Re: [HACKERS] Fix for bug in ldapServiceLookup in libpq

2011-05-12 Thread Albe Laurenz
Tom Lane wrote: > You missed one "return" where the string needed to be freed. I've > applied this patch with that fix and a couple of cosmetic changes. > Thanks for the report and patch! Thanks for the work and the keen eye! Yours, Laurenz Albe -- Sent via pgsql-hackers mailing list (pgsql-h

Re: [HACKERS] Unfriendly handling of pg_hba SSL options with SSL off

2011-05-12 Thread Magnus Hagander
On Fri, May 13, 2011 at 00:21, Tom Lane wrote: > Magnus Hagander writes: >> On Tue, May 10, 2011 at 05:39, Tom Lane wrote: >>> I wouldn't have a problem with making the Windows port throw an error >>> for "local" lines.  We'd have to fix initdb to remove that line from the >>> sample file (if it

Re: [HACKERS] Large Objects versus transactional behavior

2011-05-12 Thread YAMAMOTO Takashi
hi, > On Sat, Apr 30, 2011 at 2:58 PM, Kevin Grittner > wrote: >> This is related to the "SIREAD lock versus ACCESS EXCLUSIVE lock" >> thread, but seemed different enough to merit spinning off a new >> thread. >> >> Our shop hasn't used large objects so far because of the lack of >> security (unt

[HACKERS] windows installer (similar to old EnterpriseDB installer)

2011-05-12 Thread Martin Belleau
Hi, First, sorry - I really didn't know to which list to post this. I'm looking to either write or get access to something like the EnterpriseDB installer for windows, which doesn't seem to be kept up to date anymore. The installer needs to be configurable through command line so I can set the d

Re: [HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-12 Thread Tom Lane
Robert Haas writes: > On Thu, May 12, 2011 at 6:59 PM, Tom Lane wrote: >> I didn't say it was ;-). What I *am* saying is that if we're going to >> do anything about this sort of problem, there needs to be a >> well-considered system-wide plan. Arbitrarily changing the locking >> rules for indiv

Re: [HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-12 Thread Robert Haas
On Thu, May 12, 2011 at 6:59 PM, Tom Lane wrote: > Robert Haas writes: >> On Thu, May 12, 2011 at 6:28 PM, Tom Lane wrote: >>> We're not likely to do that, first because it's randomly different from >>> the handling of every other system catalog update, > >> We have very robust locking of this t

Re: [HACKERS] SSI-related code drift between index_getnext() and heap_hot_search_buffer()

2011-05-12 Thread Robert Haas
On Thu, May 12, 2011 at 7:02 PM, Kevin Grittner wrote: > Anyway, I could clean up all but that last issue in the old code. > I'm not sure whether that makes sense if you're refactoring it > anyway.  Would you like me to look at the refactored code to suggest > fixes?  Would you rather do it yourse

Re: [HACKERS] performance-test farm

2011-05-12 Thread Lou Picciano
Josh My Man! How are you?!! Is this the one?: http://planetdrizzle.org/ Lou Picciano - Original Message - From: "Josh Berkus" To: pgsql-hackers@postgresql.org Sent: Thursday, May 12, 2011 8:11:57 PM Subject: Re: [HACKERS] performance-test farm All, BTW, if we want a kind of

Re: [HACKERS] Large Objects versus transactional behavior

2011-05-12 Thread Kevin Grittner
YAMAMOTO Takashi wrote: > is there any chance to "just" make large objects obey the normal > semantics in future? I sure hope so, but I have no idea how hard that is. I feel the same about TRUNCATE TABLE now that I recognize the semantic difference between it and DELETE FROM with no WHERE cla

Re: [HACKERS] performance-test farm

2011-05-12 Thread Josh Berkus
All, BTW, if we want a kind of "performance unit test", Drizzle has a very nice framework for this. And it's even already PostgreSQL-compatible. I'm hunting for the link for it now ... -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-h

Re: [HACKERS] Contrib Versions

2011-05-12 Thread David E. Wheeler
On May 12, 2011, at 3:50 PM, Tom Lane wrote: >> Would changing the versions from 1.0 to 1.0.0 really break anything for >> those folks? > > It would as soon as they needed to do an ALTER EXTENSION UPDATE .. Ah-ite, screw it then. Best, David -- Sent via pgsql-hackers mailing list (pgsql-ha

Re: [HACKERS] Bug #6005

2011-05-12 Thread Andrew Dunstan
On 05/12/2011 07:34 PM, Tom Lane wrote: Andrew Dunstan writes: Speaking of pinging Windows people, have either of you noticed the reports that CREATE/ALTER USER VALID UNTIL 'infinity' is crashing on Windows? It appears to have been fixed (tested on Mingw-w64/W7). What exactly are the other t

Re: [HACKERS] Why not install pgstattuple by default?

2011-05-12 Thread Tom Lane
Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= writes: > I'm not sure that I can move it to main package in 9.0 package set, I > need to make sure that I won't break anything. But it is pretty doable > for 9.1. It should be okay to move, since the -devel subpackage requires the main one. Therefore there is

Re: [HACKERS] Bug #6005

2011-05-12 Thread Tom Lane
Andrew Dunstan writes: >> Speaking of pinging Windows people, have either of you noticed the >> reports that CREATE/ALTER USER VALID UNTIL 'infinity' is crashing on >> Windows? > It appears to have been fixed (tested on Mingw-w64/W7). > What exactly are the other tests you want run? Check to see

[HACKERS] Bug #6005

2011-05-12 Thread Andrew Dunstan
[subject changed] On 05/09/2011 09:44 AM, Tom Lane wrote: Andrew Dunstan writes: What's a bit annoying is that these tests were checked in without a vestige of MSVC support, and nobody pinged the usual suspects (i.e. Magnus and me) to ask for help in providing it, Speaking of pinging Windows

Re: [HACKERS] Why not install pgstattuple by default?

2011-05-12 Thread Devrim GÜNDÜZ
On Sat, 2011-05-07 at 21:47 -0400, Greg Smith wrote: > On 05/06/2011 04:06 PM, Tom Lane wrote: > > FWIW, I did move pg_config from -devel to the "main" (really client) > > postgresql package in Fedora, as of 9.0. That will ensure it's > present > > in either client or server installations. Eventu

Re: [HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-12 Thread Alexey Klyukin
On May 13, 2011, at 1:28 AM, Tom Lane wrote: > Alexey Klyukin writes: >> After digging in the code I've found that a RowExclusiveLock is acquired on >> a pg_db_role_setting table in AlterSetting(). While the name of the locks >> suggests that it should conflict with itself, it doesn't. After I

Re: [HACKERS] SSI-related code drift between index_getnext() and heap_hot_search_buffer()

2011-05-12 Thread Kevin Grittner
Robert Haas wrote: > It didn't take me very long to rebase the code well enough to make > the regression tests pass, but the isolation tests are failing, so > I think I've mucked up the predicate locking or something > somewhere in here. Anyhow, that led me to a careful comparison of > the logi

Re: [HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-12 Thread Tom Lane
Robert Haas writes: > On Thu, May 12, 2011 at 6:28 PM, Tom Lane wrote: >> We're not likely to do that, first because it's randomly different from >> the handling of every other system catalog update, > We have very robust locking of this type for table-related DDL > operations and just about non

Re: [HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-12 Thread Robert Haas
On Thu, May 12, 2011 at 6:28 PM, Tom Lane wrote: > Alexey Klyukin writes: >> After digging in the code I've found that a RowExclusiveLock is acquired on >> a pg_db_role_setting table in AlterSetting(). While the name of the locks >> suggests that it should conflict with itself, it doesn't. Afte

Re: [HACKERS] Contrib Versions

2011-05-12 Thread Robert Haas
On Thu, May 12, 2011 at 6:33 PM, David E. Wheeler wrote: >> Having said that, I don't really care that much, except that it seems >> a bit late in the release cycle to be changing this.  People have >> presumably already got installations that they hope to not have to >> scratch and reload for 9.1

Re: [HACKERS] Contrib Versions

2011-05-12 Thread Tom Lane
"David E. Wheeler" writes: > On May 12, 2011, at 3:09 PM, Tom Lane wrote: >> Having said that, I don't really care that much, except that it seems >> a bit late in the release cycle to be changing this. People have >> presumably already got installations that they hope to not have to >> scratch a

Re: [HACKERS] Contrib Versions

2011-05-12 Thread David E. Wheeler
On May 12, 2011, at 3:09 PM, Tom Lane wrote: > I had somewhat intentionally not numbered them in the same format as the > main release numbers, because if we did that, people would expect them > to match the main release numbers. Well, I think the fact that they're all 1.x managed to do that well

Re: [HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-12 Thread Tom Lane
Alexey Klyukin writes: > After digging in the code I've found that a RowExclusiveLock is acquired on a > pg_db_role_setting table in AlterSetting(). While the name of the locks > suggests that it should conflict with itself, it doesn't. After I've replaced > the lock in question with ShareUpdat

Re: [HACKERS] Unfriendly handling of pg_hba SSL options with SSL off

2011-05-12 Thread Tom Lane
Magnus Hagander writes: > On Tue, May 10, 2011 at 05:39, Tom Lane wrote: >> I wouldn't have a problem with making the Windows port throw an error >> for "local" lines.  We'd have to fix initdb to remove that line from the >> sample file (if it doesn't already), but that's surely not hard. > It d

[HACKERS] 'tuple concurrently updated' error for alter role ... set

2011-05-12 Thread Alexey Klyukin
Hello, We have recently observed a problem with concurrent execution of ALTER ROLE SET... in several sessions. It's similar to the one from http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=fbcf4b92aa64d4577bcf25925b055316b978744a The result is the 'tuple concurrently updated' er

Re: [HACKERS] Contrib Versions

2011-05-12 Thread Tom Lane
"David E. Wheeler" writes: > Hackers, > I don't suppose I could convince you to use dotted-decimal version numbers > for the contrib extension versions, rather than numerics, could I? At this > point, I think that would just mean changing them from 1.0 to 1.0.0. > Why? Well, PGXN uses semantic

Re: [HACKERS] plpgsql doesn't supply typmod for the Params it generates

2011-05-12 Thread Tom Lane
I wrote: > I think the appropriate fix is pretty clear: add a function similar to > exec_get_datum_type that returns the datum's typmod, and use that to set > paramtypmod properly. What is worrying me is that it's not clear how > much user-visible behavioral change will result, and therefore I'm n

[HACKERS] Contrib Versions

2011-05-12 Thread David E. Wheeler
Hackers, I don't suppose I could convince you to use dotted-decimal version numbers for the contrib extension versions, rather than numerics, could I? At this point, I think that would just mean changing them from 1.0 to 1.0.0. Why? Well, PGXN uses semantic versions, which have this format, so

[HACKERS] plpgsql doesn't supply typmod for the Params it generates

2011-05-12 Thread Tom Lane
pl_comp.c does this to set up Params representing values it supplies for expression/query execution: param = makeNode(Param); param->paramkind = PARAM_EXTERN; param->paramid = dno + 1; param->paramtype = exec_get_datum_type(estate, datum); param->paramtypmod

Re: [HACKERS] SSI-related code drift between index_getnext() and heap_hot_search_buffer()

2011-05-12 Thread Kevin Grittner
Robert Haas wrote: > [SSI questions based on breakage trying to resolve code drift] I'm looking at this and should have answers within an hour or two. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.or

Re: [HACKERS] Help required regarding patch development

2011-05-12 Thread Bruce Momjian
nil nil wrote: > Hello, > ?? Sir, i am a student. i want to develop a patch for postgresql. but > i dont know how to take the step.kindly guide me for this. Sure, look here: http://developer.postgresql.org -- Bruce Momjian http://momjian.us EnterpriseDB

[HACKERS] Help required regarding patch development

2011-05-12 Thread nil nil
Hello,    Sir, i am a student. i want to develop a patch for postgresql. but i dont know how to take the step.kindly guide me for this.        Thanks    Emman

[HACKERS] PgCon 2011 Lightning Talks - Submit yours today!

2011-05-12 Thread Selena Deckelmann
Hi! We're having Lightning Talks again at PgCon - scheduled for 5:30pm on May 19th in Ottawa! Do you have a talk or idea you'd like to share? Didn't get your original talk in? Want to compress that into 5 minutes? Lightning Talks are one of the most highly attended sessions because they are fast

[HACKERS] SSI-related code drift between index_getnext() and heap_hot_search_buffer()

2011-05-12 Thread Robert Haas
Attempting to rebase on of Heikki's index-only scan patches has led me to spend most of the day staring at the two functions named in the subject line. I assume the code in these two functions has a common origin, as a large amount of it is nearly identical; and one effect of Heikki's patch is to

Re: [HACKERS] Fw: [BUGS] BUG #6011: Some extra messages are output in the event log at PostgreSQL startup

2011-05-12 Thread Robert Haas
On Thu, May 12, 2011 at 2:57 PM, Kevin Grittner wrote: >> I wish the fix will be back-patched in 8.3, too. > > I guess the question is whether this is a bug which causes more > problems than the potential breakage which might ensue for someone > who relies on the current behavior.  How sure can yo

Re: [HACKERS] Formatting Curmudgeons WAS: MMAP Buffers

2011-05-12 Thread Kevin Grittner
Robert Haas wrote: > Unfortunately, people often come into our community with incorrect > assumptions about how it works, including: > > - someone's in charge > - there's one right answer > - it's our job to fix your problem Would it make sense to dispel such notions explicitly in the Develop

Re: [HACKERS] performance-test farm

2011-05-12 Thread Greg Smith
Tom Lane wrote: There's no such thing as a useful performance test that runs quickly enough to be sane to incorporate in our standard regression tests. To throw a hard number out: I can get a moderately useful performance test on a SELECT-only workload from pgbench in about one minute. Th

Re: [HACKERS] performance-test farm

2011-05-12 Thread Tomas Vondra
Dne 12.5.2011 08:54, Greg Smith napsal(a): > Tomas Vondra wrote: >> Actually I was not aware of how the buildfarm works, all I >> knew was there's something like that because some of the hackers mention >> a failed build on the mailing list occasionally. >> >> So I guess this is a good opportunity

Re: [HACKERS] Fix for bug in ldapServiceLookup in libpq

2011-05-12 Thread Tom Lane
"Albe Laurenz" writes: > I have attached a new version of the patch that should address all known > problems. You missed one "return" where the string needed to be freed. I've applied this patch with that fix and a couple of cosmetic changes. Thanks for the report and patch!

Re: [HACKERS] performance-test farm

2011-05-12 Thread Tomas Vondra
Dne 12.5.2011 16:36, Tom Lane napsal(a): >> * Josh Berkus (j...@agliodbs.com) wrote: >>> The first problem is plaform performance, which would be a matter of >>> expanding the buildfarm to include a small set of performance tests ... >>> probably ones based on previously known problems, plus some o

Re: [HACKERS] Fw: [BUGS] BUG #6011: Some extra messages are output in the event log at PostgreSQL startup

2011-05-12 Thread Kevin Grittner
"MauMau" wrote: > I'm sorry to interrupt you, but how should I treat this bug report > I issued? Should I submit a bug fix patch for the latest source > code (=v9.1)? Patches should always be submitted against the HEAD of the master branch. > I wish the fix will be back-patched in 8.3, too.

Re: [HACKERS] pg_upgrade and PGPORT

2011-05-12 Thread Bruce Momjian
Robert Haas wrote: > On Thu, May 12, 2011 at 1:22 AM, Peter Eisentraut wrote: > > On ons, 2011-05-11 at 18:36 -0400, Bruce Momjian wrote: > >> Robert Haas wrote: > >> > On Wed, May 11, 2011 at 2:18 PM, Tom Lane wrote: > >> > > Or you could just "unsetenv" instead of complaining. > >> > > >> > +1

Re: [HACKERS] Uninitialized SSL values? (was: Fix for bug in ldapServiceLookup in libpq)

2011-05-12 Thread Tom Lane
"Albe Laurenz" writes: > FWIW, I ran valgrind on psql establishing an SSL connection, and I found > some messages like this: > ==26437== Conditional jump or move depends on uninitialised value(s) > ==26437== Use of uninitialised value of size 4 Yeah, this has been mentioned before IIRC. It look

Re: [HACKERS] Help: regarding patch development

2011-05-12 Thread Kevin Grittner
nil nil wrote: > i want to develop a service for postgresql related to querry > processing.but i dont know how to develop it. plz guide me so that > i can take step. I think the root of all information on that is here: http://www.postgresql.org/developer/ with the linked developer FAQ bein

[HACKERS] Fw: [BUGS] BUG #6011: Some extra messages are output in the event log at PostgreSQL startup

2011-05-12 Thread MauMau
I'm sorry to interrupt you, but how should I treat this bug report I issued? Should I submit a bug fix patch for the latest source code (=v9.1)? I wish the fix will be back-patched in 8.3, too. If yes, I would like to get a concensus on the solution. As I mentioned, I think that it is enough t

Re: [HACKERS] performance-test farm

2011-05-12 Thread Tom Lane
> * Josh Berkus (j...@agliodbs.com) wrote: >> The first problem is plaform performance, which would be a matter of >> expanding the buildfarm to include a small set of performance tests ... >> probably ones based on previously known problems, plus some other simple >> common operations. The goal h

Re: [HACKERS] Infinity bsearch crash on Windows

2011-05-12 Thread Tom Lane
Greg Smith writes: > I must have missed that thread, I think I'm missing one of these lists > (pgsql-bugs maybe?). I've cc'd Mark Watson so maybe you can get better > responses without me in the middle if needed; for this one, he reports: > Show timezone gives US/Eastern > Select * from pg_tim

Re: [HACKERS] pg_upgrade and PGPORT

2011-05-12 Thread Robert Haas
On Thu, May 12, 2011 at 1:22 AM, Peter Eisentraut wrote: > On ons, 2011-05-11 at 18:36 -0400, Bruce Momjian wrote: >> Robert Haas wrote: >> > On Wed, May 11, 2011 at 2:18 PM, Tom Lane wrote: >> > > Or you could just "unsetenv" instead of complaining. >> > >> > +1 for that. >> >> OK, the attached

[HACKERS] Uninitialized SSL values? (was: Fix for bug in ldapServiceLookup in libpq)

2011-05-12 Thread Albe Laurenz
I wrote: >>> I have found a small but annoying bug in libpq where >>> connection parameters are resolved via LDAP. > > I have attached a new version of the patch that should address all known > problems. FWIW, I ran valgrind on psql establishing an SSL connection, and I found some messages like th

Re: [HACKERS] "stored procedures" - use cases?

2011-05-12 Thread Markus Wanner
Hi, On 05/10/2011 02:55 PM, Robert Haas wrote: > On Mon, May 9, 2011 at 11:58 PM, Pavel Stehule > wrote: >> no - you are little bit confused :). CALL and function execution >> shares nothing. There is significant differences between function and >> procedure. Function is called only from executo

Re: [HACKERS] FailedAssertion

2011-05-12 Thread Nicolas Barbier
[ Forgot the list. ] 2011/5/12, Yves Weißig : > I'm currently debugging my developed AM and are running into this problem: > > TRAP: FailedAssertion("!(((bool) (((void*)(tid) != ((void *)0)) && > ((tid)->ip_posid != 0", File: "indexam.c", Line: 488) > > Can anybody explain what it means? I'm

[HACKERS] FailedAssertion

2011-05-12 Thread Yves Weißig
Hi together, I'm currently debugging my developed AM and are running into this problem: TRAP: FailedAssertion("!(((bool) (((void*)(tid) != ((void *)0)) && ((tid)->ip_posid != 0", File: "indexam.c", Line: 488) Can anybody explain what it means? I'm having difficulties to understand what went

Re: [HACKERS] [v9.2] Leaky view and RLS

2011-05-12 Thread Kohei Kaigai
Oops, I overlooked a scenario that we discussed before. [4] Unexpected qualifier distributions into inside of join-loop If a qualifier being appended on outside of join-loop references only one-side of the join, the optimizer will unexpectedly distribute it into inside of the join-loop. In the re

Re: [HACKERS] Fix for bug in ldapServiceLookup in libpq

2011-05-12 Thread Albe Laurenz
Tom Lane wrote: >> I have found a small but annoying bug in libpq where >> connection parameters are resolved via LDAP. > Hmm ... that's a bug all right, but why have the null-termination > inside the loop at all? Seems like it should look like > > for (p = result, i = 0; values[i] != NULL;

Re: [HACKERS] Tables cannot have INSTEAD OF triggers

2011-05-12 Thread Dean Rasheed
On 11 May 2011 19:51, Tom Lane wrote: > Peter Eisentraut writes: >> Why not?  Is there a fundamental problem, or just that no one wanted to >> make it work? > More the latter really. I think they're very useful on views, but I couldn't think of a use-case for having them on tables. ISTM that any

Re: [HACKERS] Extension Packaging

2011-05-12 Thread Dimitri Fontaine
Robert Haas writes: >> Okay, how we add a "revision" key to the control file and extrevision to >> the pg_extension catalog. Its type can be "TEXT" and is optional for use >> by extensions. > > How would pg_extension.extrevision be kept up to date? AFAICS, the > whole point is that you might swap

Re: [HACKERS]

2011-05-12 Thread Heikki Linnakangas
On 12.05.2011 09:52, kishwar deeba wrote: I want to learn postgreSQL.. And also want to know how to develop a patch in postgreSQL.. please give some examples and tutorial.. The developer FAQ is a good place to start: http://wiki.postgresql.org/wiki/Developer_FAQ -- Heikki Linnakangas Ent