On Tue, Jan 26, 2010 at 23:14, Tom Lane wrote:
> Andrew Dunstan writes:
>> Tim Bunce wrote:
>>> - Added plperl.on_perl_init GUC for DBA use (PGC_SIGHUP)
>>> SPI functions are not available when the code is run.
>>>
>>> - Added normal interpreter destruction behaviour
>>> END blocks, if any, are r
Greg Stark wrote:
Actually before we get there could someone who demonstrated the
speedup verify that this patch still gets that same speedup?
Let's step back a second and get to the bottom of why some people are
seeing this and others aren't. The original report here suggested this
was a
Andrew Dunstan writes:
> Tim Bunce wrote:
>> - Added plperl.on_perl_init GUC for DBA use (PGC_SIGHUP)
>> SPI functions are not available when the code is run.
>>
>> - Added normal interpreter destruction behaviour
>> END blocks, if any, are run then objects are
>> destroyed, calling their DESTROY
On Wed, Jan 27, 2010 at 4:02 AM, Fujii Masao wrote:
> This is the bug of SR :( I think that walsender wrongly treats the
> WAL-boundary.
The attached patch would fix this bug.
>> pgsql.sr_slave02/logfile:ERROR: could not read xlog records: FATAL: could
>> not open file
>> "pg_xlog/000100
On 1/26/10 3:24 PM, David Christensen wrote:
> -hackers,
>
> In the spirit of small, but hopefully useful interface improvement
> patches, enclosed for your review is a patch for providing psql with a
> \whoami command (maybe a better name is \conninfo or similar). Its
> purpose is to print infor
Tatsuo Ishii wrote:
Hi,
Can please someone fix this? I can fix other errors ocuured on
plperl.sgml but I don't know how to do with this:
openjade:plperl.sgml:290:31:X: reference to non-existent ID "PLPERL.USE_STRICT"
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_e
Baron,
> Hypothetically, if I had time to help with something like that, is
> there a wiki or something where I could help draft it, without needing
> to get all elbows-deep into the documentation itself?
wiki.postgresql.org.
--Josh
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgr
Hi,
Can please someone fix this? I can fix other errors ocuured on
plperl.sgml but I don't know how to do with this:
openjade:plperl.sgml:290:31:X: reference to non-existent ID "PLPERL.USE_STRICT"
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://w
Josh,
On Mon, Jan 25, 2010 at 1:47 PM, Josh Berkus wrote:
>
>>> My problem with this whole idea is that it seems to be very MySQL-specific.
>>> Why aren't we providing help for users migrating from Oracle, Sybase,
>>> Informix, Ingres, DB2, SQLServer and Firebird, to name but a few? And if we
>>>
Tim Bunce wrote:
- Added plperl.on_perl_init GUC for DBA use (PGC_SIGHUP)
SPI functions are not available when the code is run.
- Added normal interpreter destruction behaviour
END blocks, if any, are run then objects are
destroyed, calling their DESTROY methods, if any.
SPI fu
-hackers,
In the spirit of small, but hopefully useful interface improvement
patches, enclosed for your review is a patch for providing psql with a
\whoami command (maybe a better name is \conninfo or similar). Its
purpose is to print information about the current connection, by
default
On Sat, 2010-01-23 at 13:28 -0700, James William Pye wrote:
> On Jan 14, 2010, at 7:08 PM, Greg Smith wrote:
> > So more targeted examples like you're considering now would help.
So is there any more movement on this? Peter, what do you think? I
mean... he has put in quite a bit of effort here. Ho
Tom Lane írta:
> Boszormenyi Zoltan writes:
>
>> Tom Lane írta:
>>
>>> Really? The main regression tests have several test cases for NaN,
>>> and no provision that I can see for platform dependence of the
>>> result.
>>>
>
>
>> I meant this, e.g. from "gypsy_moth":
>>
>
>
Tom Lane wrote:
Right, but the question is: is there enough use-case left in it to
justify spending community effort on polishing rough edges? It's not
like we haven't got plenty else to do to get 9.0 out the door.
The point I was trying to make is that I'm on the hook to do this
particula
Le 26/01/2010 19:43, Joe Conway a écrit :
> On 01/25/2010 03:21 PM, Guillaume Lelarge wrote:
>> I didn't put any documentation before knowing which one will be choosen.
>> So we still need to work on the manual.
>
> Please send the documentation as a separate patch. Once I have that I
> will commi
Boszormenyi Zoltan writes:
> Tom Lane írta:
>> Really? The main regression tests have several test cases for NaN,
>> and no provision that I can see for platform dependence of the
>> result.
> I meant this, e.g. from "gypsy_moth":
> *** 1,4
> id=1 t='a' d1=1.00 d2=2.00 c = 'a
Tom Lane írta:
> Boszormenyi Zoltan writes:
>
>> Also, another "bug" is fixed in one regression test,
>> it seems NaN is different across platforms, so
>> we must not test for it either.
>>
>
> Really? The main regression tests have several test cases for NaN,
> and no provision that I ca
Boszormenyi Zoltan writes:
> Also, another "bug" is fixed in one regression test,
> it seems NaN is different across platforms, so
> we must not test for it either.
Really? The main regression tests have several test cases for NaN,
and no provision that I can see for platform dependence of the
r
Boszormenyi Zoltan wrote:
> Alvaro Herrera írta:
> > I happened to notice this misleading comment:
> >
> > char temp[20]; /* this should be sufficient unless you have 8 byte
> > integers */
> >
>
> That comment was there before I touched that function, I deleted it now.
> There will b
Alvaro Herrera írta:
> Boszormenyi Zoltan wrote:
>
>
>> Thanks for analyzing it, patch is attached. I downloaded
>> and installed ICC, so I could reproduce the difference.
>>
>
> Why not have a single function that does both things in a single call?
> It doesn't look like there's any place
On Tue, Jan 26, 2010 at 2:12 PM, Tom Lane wrote:
> Robert Haas writes:
>> While reviewing Pavel's patch for variable quoting in psql, I came
>> upon the following comment in psqlscan.l:
>
>> /*
>> * The variable value is just emitted without any
>> * further examination.
On Tue, 2010-01-26 at 11:01 -0800, Josh Berkus wrote:
> Anyway, if we fix the *core* bogus error messages for standby mode, that
> will eliminate half of what's confusing and alarming people (and all of
> it for those using SR).
Just done that.
--
Simon Riggs www.2ndQuadrant.com
--
Robert Haas writes:
> While reviewing Pavel's patch for variable quoting in psql, I came
> upon the following comment in psqlscan.l:
> /*
> * The variable value is just emitted without any
> * further examination. This is consistent with the
> * pre-8.0 code be
On Wed, Jan 27, 2010 at 2:19 AM, Erik Rijkers wrote:
> Now, when restoring a 700MB dump (made with a 9.0devel pg_dump + pg_restore)
> into the primary,
> errors like the following occur, on all three instances:
>
> FATAL: could not open file "pg_xlog/0001000100FF" (log file 1,
> seg
On 1/26/10 10:58 AM, Tom Lane wrote:
> Josh Berkus writes:
>> On 1/26/10 10:48 AM, Heikki Linnakangas wrote:
>>> I didn't intend to replace pg_standby when I started this, it just kind
>>> of happened. Maybe we should provide a sample script similar to
>>> pg_standby, to be used instead of plain '
Josh Berkus writes:
> On 1/26/10 10:48 AM, Heikki Linnakangas wrote:
>> I didn't intend to replace pg_standby when I started this, it just kind
>> of happened. Maybe we should provide a sample script similar to
>> pg_standby, to be used instead of plain 'cp', that does the cleanup too.
> What I'm
Leonardo F wrote:
> why is IndexInfo.ii_Expressions a list? How can an index have more than
> one expression? Sorry if it's a stupid question, but I'm not familiar with
> index expressions.
Consider multi-column indexes, ie:
CREATE INDEX i_foo ON foo (length(a), length(b));
Maybe you're confusin
On 1/26/10 10:48 AM, Heikki Linnakangas wrote:
> Josh Berkus wrote:
>>> *That* makes pg_standby obsolete, not streaming replication per se.
>>> Setting standby_mode=on, with a valid restore_command using e.g 'cp' and
>>> no connection info for walreceiver is more or less the same as using
>>> pg_st
Josh Berkus wrote:
>> *That* makes pg_standby obsolete, not streaming replication per se.
>> Setting standby_mode=on, with a valid restore_command using e.g 'cp' and
>> no connection info for walreceiver is more or less the same as using
>> pg_standby.
>
> What about deletion of no-longer-needed W
On 01/25/2010 03:21 PM, Guillaume Lelarge wrote:
> I didn't put any documentation before knowing which one will be choosen.
> So we still need to work on the manual.
Please send the documentation as a separate patch. Once I have that I
will commit the posted patch, barring any objections in the me
Robert Haas writes:
> On Tue, Jan 26, 2010 at 12:36 PM, Tom Lane wrote:
>> But what it *produces* is a string. For comparison, the
>> SQL-standard-specified array_agg produces arrays, but what it
>> acts on isn't an array.
> This point is well-taken, but naming it string_agg() because it
> prod
While reviewing Pavel's patch for variable quoting in psql, I came
upon the following comment in psqlscan.l:
/*
* The variable value is just emitted without any
* further examination. This is consistent with the
* pre-8.0 code behavior, if not with the way that
> *That* makes pg_standby obsolete, not streaming replication per se.
> Setting standby_mode=on, with a valid restore_command using e.g 'cp' and
> no connection info for walreceiver is more or less the same as using
> pg_standby.
What about deletion of no-longer-needed WALfile copies?
--Josh Ber
Boszormenyi Zoltan wrote:
> Thanks for analyzing it, patch is attached. I downloaded
> and installed ICC, so I could reproduce the difference.
Why not have a single function that does both things in a single call?
It doesn't look like there's any place that calls the function with only
one value
On Tue, Jan 26, 2010 at 02:21:29PM +, Bruce Momjian wrote:
> Log Message:
> ---
> Remove tabs in SGML.
Can we see about making a commit hook for CVS that disallows \t in
SGML files? The process in git is pretty simple.
Cheers,
David.
--
David Fetter http://fetter.org/
Phone: +1 415
On Tue, Jan 26, 2010 at 12:36 PM, Tom Lane wrote:
> "David E. Wheeler" writes:
>> Because it's an aggregate that cocatenates values. It's not an
>> aggregate that lists things. I also like concat_agg better than
>> string_agg because it's not limited to acting on strings.
>
> But what it *produce
On Jan 25, 2010, at 6:56 AM, Pavel Stehule wrote:
> actualised patch - the name is string_agg
All looks fine except I'm getting this error during initdb:
creating template1 database in /usr/local/pgsql-devel/data/base/1 ... FATAL:
could not create unique index "pg_proc_oid_index"
DETAIL: Key
Tom Lane írta:
> Boszormenyi Zoltan writes:
>
>> Michael Meskes Ărta:
>>
>>> Zoltan, could you please look into this:
>>> http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=dugong&dt=2010-01-26%2011:05:01
>>> ?
>>> Apparently dugong creates the ECPGset_var statements in a different order
>>>
"David E. Wheeler" writes:
> Meh. This is all just bike-shedding. I'm fine with string_agg(), though in
> truth none of the names has really been great. The inclusion of "agg" in the
> name is unfortunate.
Yeah, I wouldn't be for it either if it weren't for the precedent of
array_agg. I was qu
On Jan 26, 2010, at 9:36 AM, Tom Lane wrote:
> But what it *produces* is a string. For comparison, the
> SQL-standard-specified array_agg produces arrays, but what it
> acts on isn't an array.
Meh. This is all just bike-shedding. I'm fine with string_agg(), though in
truth none of the names has
"Erik Rijkers" wrote:
> FATAL: could not open file "pg_xlog/0001000100FF"
> (log file 1, segment 255): No such file or directory
Yeah, log file segment numbers skip FF; they go from FE to 00 with
the "log file" number (the middle part) bumped by one. Whatever is
coming up with th
"David E. Wheeler" writes:
> Because it's an aggregate that cocatenates values. It's not an
> aggregate that lists things. I also like concat_agg better than
> string_agg because it's not limited to acting on strings.
But what it *produces* is a string. For comparison, the
SQL-standard-speci
Boszormenyi Zoltan writes:
> Michael Meskes Ãrta:
>> Zoltan, could you please look into this:
>> http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=dugong&dt=2010-01-26%2011:05:01
>> ?
>> Apparently dugong creates the ECPGset_var statements in a different order
>> than
>> the other archs.
> It seem
I don't know if it has anything to do with HS/SR, I haven't tried it on a
single CVS vanilla
installation (yet).
To test with HS/SR, I've setup three 9.0devel instances (cvs as of today) on a
single machine, one
as a primary, and two as slaves. I used the instructions in
http://wiki.postgres
> If we ever get another index type that supports ordered
> scans, it'll be time enough to worry about cases like this.
Ok
> BTW, I think you could use tuplesort_begin_index_btree() rather than
> touching _bt_mkscankey_nodata directly.
well I created my own tuplesort_begin_rawheap method (co
Tom Lane wrote:
> Pavel Stehule writes:
>> why is concat_agg better than listagg ?
>
> It isn't ... it's the wrong part of speech. "concat"enate is a
> verb,
Concatenation is a noun. "concat" doesn't get far enough to
distinguish.
-Kevin
--
Sent via pgsql-hackers mailing list (pgsql-ha
Zoltan, could you please look into this:
http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=dugong&dt=2010-01-26%2011:05:01 ?
Apparently dugong creates the ECPGset_var statements in a different order than
the other archs.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (D
Pavel Stehule writes:
> 2010/1/25 Robert Haas :
>> On Mon, Jan 25, 2010 at 2:27 PM, David E. Wheeler
>> wrote:
>>> concat_agg().
>>
>> I like that one...
> why is concat_agg better than listagg ?
It isn't ... it's the wrong part of speech. "concat"enate is a verb,
whereas the other functions
Dimitri Fontaine writes:
> Heikki Linnakangas writes:
>> *That* makes pg_standby obsolete, not streaming replication per se.
>> Setting standby_mode=on, with a valid restore_command using e.g 'cp' and
>> no connection info for walreceiver is more or less the same as using
>> pg_standby.
> I've y
On Jan 26, 2010, at 4:03, Peter Eisentraut wrote:
What else can it act on?
Any data type, since they all can be converted to text. Integers would
be a common choice.
David
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://w
On 2010-01-26 17:11, Alvaro Herrera wrote:
> Merlin Moncure escribió:
>
>> *) CopySnapshot was promoted from static. Is this legal/good idea?
>> Is a wrapper more appropriate?
>
> Hmm ... I wonder why isn't the patch doing RegisterSnapshot with the
> passed snapshot directly -- why is it necessa
Merlin Moncure escribió:
> *) CopySnapshot was promoted from static. Is this legal/good idea?
> Is a wrapper more appropriate?
Hmm ... I wonder why isn't the patch doing RegisterSnapshot with the
passed snapshot directly -- why is it necessary to create a new copy of
it? (I notice that only one
On 2010-01-26 16:54, Robert Haas wrote:
> On Tue, Jan 26, 2010 at 9:13 AM, Merlin Moncure wrote:
>> *) Works as advertised...'feels right'. Found only one small issue
>> which Marko was already aware of and had adjusted for.
> [...]
>> Marko was already aware of it and has a fix ready.
>
> So it
2010/1/26 Robert Haas :
> On Tue, Jan 26, 2010 at 2:14 AM, Pavel Stehule
> wrote:
>> 2010/1/25 Robert Haas :
>>> On Mon, Jan 25, 2010 at 2:27 PM, David E. Wheeler
>>> wrote:
On Jan 25, 2010, at 2:09 AM, Peter Eisentraut wrote:
> xmlagg -> concatenates values to form xml datum
> arr
On Tue, Jan 26, 2010 at 9:13 AM, Merlin Moncure wrote:
> *) Works as advertised...'feels right'. Found only one small issue
> which Marko was already aware of and had adjusted for.
[...]
> Marko was already aware of it and has a fix ready.
So it sounds like we should expect an updated patch shor
On Tue, Jan 26, 2010 at 8:54 PM, Heikki Linnakangas
wrote:
> Simon Riggs wrote:
>> Currently, we had presumed
>> that standby_mode = off would be the same as Warm Standby replication,
>> using pg_standby or other.
>
> That's still true. standby_mode=off is the same as what you have in PG
> 8.4. Yo
On Tue, Jan 26, 2010 at 6:54 AM, Heikki Linnakangas
wrote:
> From a user point-of-view, it might be simplest to provide a
> "restore_directory" option, besides restore_command, and handle the copy
> ourselves.
Well, that might not handle all possible use cases -- of course, it
could be there as a
On Tue, Jan 26, 2010 at 2:14 AM, Pavel Stehule wrote:
> 2010/1/25 Robert Haas :
>> On Mon, Jan 25, 2010 at 2:27 PM, David E. Wheeler
>> wrote:
>>> On Jan 25, 2010, at 2:09 AM, Peter Eisentraut wrote:
xmlagg -> concatenates values to form xml datum
array_agg -> concatenates values to fo
Marko,
Submission Review
-
*) patch applies clean to HEADwever
*) applied tests ran ok
*) there is some documentation adjustments in the patch. possibly a
little underweight, but sufficient.
*) A couple of very minor things aside, I think this should be
accepted and passed for 8
Tom Lane wrote:
> "Kevin Grittner" writes:
>> So add me to the list of people who think that if
>> these are going to be recurring, we should look at moving from
>> cvs to git as soon as 9.0 is released.
>
> The gating factor is not release schedule; it is the still-
> unaddressed tasks that mus
On Thu, Jan 21, 2010 at 17:11, Tom Lane wrote:
> "Kevin Grittner" writes:
>> So add me to the list of people who think that if
>> these are going to be recurring, we should look at moving from cvs
>> to git as soon as 9.0 is released.
>
> The gating factor is not release schedule; it is the still
Heikki Linnakangas writes:
> From a user point-of-view, it might be simplest to provide a
> "restore_directory" option, besides restore_command, and handle the copy
> ourselves.
Even more user-friendly would be to provide default working archive and
restore commands, maybe simple shell scripts us
Hi,
Michael Meskes írta:
> Zoltan, could you please look into this:
> http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=dugong&dt=2010-01-26%2011:05:01
> ?
> Apparently dugong creates the ECPGset_var statements in a different order than
> the other archs.
>
> Michael
>
It seems mongoose also fail
On tis, 2010-01-26 at 03:08 -0800, David E. Wheeler wrote:
> On Jan 25, 2010, at 23:14, Pavel Stehule
> wrote:
>
> > why is concat_agg better than listagg ?
>
> Because it's an aggregate that cocatenates values. It's not an
> aggregate that lists things. I also like concat_agg better than
Simon Riggs wrote:
> Currently, we had presumed
> that standby_mode = off would be the same as Warm Standby replication,
> using pg_standby or other.
That's still true. standby_mode=off is the same as what you have in PG
8.4. You can still use pg_standby etc. with that.
> pg_standby checks file s
On Tue, Jan 26, 2010 at 1:23 PM, Alastair Turner wrote:
> .
>
> Given that it potentially produces a delimited list, not a straight
> conacatenation (and that list is unacceptable since it would be
> descriptive as a noun but not as a verb) would implode_agg not be the
> most descriptive name?
On Tue, Jan 26, 2010 at 1:08 PM, David E. Wheeler wrote:
.
>
> Because it's an aggregate that cocatenates values. It's not an aggregate
> that lists things. I also like concat_agg better than string_agg because
> it's not limited to acting on strings.
>
.
Given that it potentially prod
On Jan 25, 2010, at 23:14, Pavel Stehule
wrote:
why is concat_agg better than listagg ?
Because it's an aggregate that cocatenates values. It's not an
aggregate that lists things. I also like concat_agg better than
string_agg because it's not limited to acting on strings.
Best,
David
Dimitri Fontaine wrote:
> Heikki Linnakangas writes:
>> Yes. Just like with pg_standby.
>
> Hehe, I'm using walmgr.py from skytools instead, and this discussion
> makes me think I'll continue doing so even if using SR, as they are
> complementary solutions.
>
> In SR mode, the master continues t
On Tue, 2010-01-26 at 12:12 +0200, Heikki Linnakangas wrote:
> Magnus Hagander wrote:
> > I think there are definite use-cases for pg_standby as well, even when
> > we have SR. SR requires you to have a reasonably reliable network
> > connection that lets you do an arbitrary TCP connection. There a
Heikki Linnakangas writes:
> Yes. Just like with pg_standby.
Hehe, I'm using walmgr.py from skytools instead, and this discussion
makes me think I'll continue doing so even if using SR, as they are
complementary solutions.
In SR mode, the master continues to archive as usual, and the slave will
Dimitri Fontaine wrote:
> Heikki Linnakangas writes:
>> *That* makes pg_standby obsolete, not streaming replication per se.
>> Setting standby_mode=on, with a valid restore_command using e.g 'cp' and
>> no connection info for walreceiver is more or less the same as using
>> pg_standby.
>
> I've y
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Tue, Jan 26, 2010 at 11:24:09AM +0100, Dimitri Fontaine wrote:
[...]
> I've yet to understand how the files in the archive get from the master
> to the slave in this case, or are you supposing in your example that the
> cp in the restore_command i
On Tue, Jan 26, 2010 at 10:56:52AM +0100, Boszormenyi Zoltan wrote:
> Thanks for applying it. You seem to have accidentally
> removed the outofscope.pgc test, too. The test results are there
Yup, my bad. I'm already trying to recover and testing. Apparently the files
weren't added but I didn't not
Heikki Linnakangas writes:
> *That* makes pg_standby obsolete, not streaming replication per se.
> Setting standby_mode=on, with a valid restore_command using e.g 'cp' and
> no connection info for walreceiver is more or less the same as using
> pg_standby.
I've yet to understand how the files in
2010/1/26 Heikki Linnakangas :
> Magnus Hagander wrote:
>> I think there are definite use-cases for pg_standby as well, even when
>> we have SR. SR requires you to have a reasonably reliable network
>> connection that lets you do an arbitrary TCP connection. There are a
>> lot of scenarios that cou
Magnus Hagander wrote:
> I think there are definite use-cases for pg_standby as well, even when
> we have SR. SR requires you to have a reasonably reliable network
> connection that lets you do an arbitrary TCP connection. There are a
> lot of scenarios that could still use the
> "here's-a-file-you
Michael Meskes írta:
>> Should I send you a new patch without this regression test
>> or do you delete it before applying the patch?
>>
>
> Na, I will just remove it, no need to worry.
>
> Michael
>
Thanks for applying it. You seem to have accidentally
removed the outofscope.pgc test, too.
2010/1/26 Tom Lane :
> Greg Smith writes:
>> [ Greg and Selena discuss filing some rough edges off pg_standby ]
>
> Maybe I'm missing something, but I thought pg_standby would be mostly
> dead once SR hits the streets. Is it worth spending lots of time on?
>
> The ideas all sound good, I'm just w
On Tue, 2010-01-26 at 11:08 +0900, Fujii Masao wrote:
> On Tue, Jan 26, 2010 at 9:08 AM, Simon Riggs wrote:
> > Just committed a fix: the server no longer requests 01.history
> > at start of archive recovery.
>
> Good.
>
> And I think that writeTimeLineHistory() should also skip the requ
> Should I send you a new patch without this regression test
> or do you delete it before applying the patch?
Na, I will just remove it, no need to worry.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debi
81 matches
Mail list logo