Re: Missing include in be-secure-openssl.c?

to copy-paste on this thread some of the buildfarm logs that show the compilation failure? No issues from me even if these are in Japanese. -- Michael signature.asc Description: PGP signature

Re: Teach pg_receivewal to use lz4 compression

ps? Attached is an updated patch, which includes fixes for most of the issues I am mentioning above. Please note that I have not changed FindStreamingStart(), so this part is the same as v9. Thanks, -- Michael From 51a2352d2e543795ec201ed444d4e74014c3a2d3 Mon Sep 17 00:00:00 2001 From: Michael Paq

Re: Missing include in be-secure-openssl.c?

be possible that hamerkop is reusing a directory where some code has already been compiled on. -- Michael signature.asc Description: PGP signature

Re: should we enable log_checkpoints out of the box?

nforce them. > The latter is unexpected and basically undiscoverable with default > settings. +1. -- Michael signature.asc Description: PGP signature

Re: Teach pg_receivewal to use lz4 compression

On Thu, Nov 04, 2021 at 04:31:48PM +0900, Michael Paquier wrote: > I would have expected read_size to be (readend - readp) to match with > the remaining data in the read buffer that we still need to read. > Shouldn't out_size also be LZ4_CHUNK_SZ to match with the size of the > ou

Re: inefficient loop in StandbyReleaseLockList()

kes sense. Shouldn't we be careful to do that in both pg_list.h and list.c, then? -- Michael signature.asc Description: PGP signature

Re: Teach pg_receivewal to use lz4 compression

the code, and the whole looked fine, so applied. While on it, I have tested the new TAP tests with all the possible combinations of --without-zlib and --with-lz4. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

ple of indentation issues in the list of objects after COMMENT ON. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

On Fri, Nov 05, 2021 at 10:39:36AM +0100, Daniel Gustafsson wrote: > Is there anything left on this or can we close it in the commitfest? Oops. I have missed that there was a CF entry for this patch, and missed that Fujii-san was registered as a committer for it. My apologies! -- Mich

Re: should we enable log_checkpoints out of the box?

ems to me we only distinguish between LOG and PANIC for server-facing events; maybe we need one or more additional levels here in order to make it easier for admins to see the really bad things that are happening? Michael -- Michael Banck Teamleiter PostgreSQL-Team Projektleiter Tel.: +4

Re: pg_upgrade test for binary compatibility of core data types

ment listed in this array. I guess that this had better document why those catalogs are part of the list? Good to see that adding a reg* in core would immediately be noticed though, as far as I understand this SQL. -- Michael signature.asc Description: PGP signature

Re: removing global variable ThisTimeLineID

comes to timeline switches because we don't update it while in >> recovery when replaying a end-of-recovery record. This could at least >> be documented better. > > We don't update it during recovery at all. There's exactly one > assignment statement for that variable and it's here: Indeed. It looks like my reading was sloppy here. -- Michael signature.asc Description: PGP signature

Re: XLogReadRecord() error in XlogReadTwoPhaseData()

nstead of just elog()'ing what XLogReadRecord() returns. -- Michael signature.asc Description: PGP signature

Re: Commitfest 2021-11 Patch Triage - Part 1

sonally quite excited about this > feature so I'm looking forward to (hopefully) seeing it go in. So am I. -- Michael signature.asc Description: PGP signature

Re: Unnecessary delay in streaming replication due to replay lag

ng if there should be a way to work out something with the control file, though, but things can get very fancy with HA and base backup deployments and the various cases we support thanks to the current way recovery works, as well. We could also go simpler and rework the priority order if both archiving and streaming are options wanted by the user. -- Michael signature.asc Description: PGP signature

Re: Make mesage at end-of-recovery less scary.

ll record after reading the header, so it seems to me that we should not assume that things are just ending as proposed in this patch. -- Michael signature.asc Description: PGP signature

Improve error context after some failed XLogReadRecord()

about those new error strings, but I am sure that these could be tweaked. Thoughts? -- Michael diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c index aae0ae5b8a..b7d9521576 100644 --- a/src/backend/replication/logical/logical.c +++ b/src/backend/replic

Re: XLogReadRecord() error in XlogReadTwoPhaseData()

On Mon, Nov 08, 2021 at 01:42:46PM +0900, Michael Paquier wrote: > Indeed. Looking closer, I think that we'd better improve > DecodingContextFindStartpoint(), > pg_logical_replication_slot_advance(), XLogSendLogical() as well as > pg_logical_slot_get_changes_guts() to follow a

Re: Commitfest 2021-11 Patch Triage - Part 1

On Mon, Nov 08, 2021 at 03:07:43PM +0900, Kyotaro Horiguchi wrote: > I noticed I'm one of the author^^; I'll also look into the comments > and try to address them. Cool, thanks. I'll come back to this thread from this point, then. -- Michael signature.asc Description: PGP signature

Re: removing global variable ThisTimeLineID

I; One problem with newTLI is that this conflicts with the declaration around 7663 in xlog.c, where we check after a TLI switch when replaying such a record. Perhaps this could be named newInsertTLI, for example. -- Michael signature.asc Description: PGP signature

Re: standby recovery fails (tablespace related) (tentative patch and discussion)

have subdirs in it for the rest? It seems to me that it would make debugging much easier. The uses of perl2host() seem sufficient. -- Michael signature.asc Description: PGP signature

Re: consistently use "ProcSignal" instead of "procsignal" in code comments

like 15 minutes ago.. And the patch was fine on consistency ground, so I have just applied it now. -- Michael signature.asc Description: PGP signature

Clean up build warnings of plperl with clang-12+

ck an -Werror in it as it is proving to be good in detecting incorrect placeholders. Tom has suggested that we could add -Wno-compound-token-split-by-macro to take care of the issue on our side, and attached is a patch to do so. Any objections? I'd like to get this back-patched. Thanks, -- Mi

Re: removing global variable ThisTimeLineID

at it calls, what I'd prefer to do is rename the newTLI > variable in the inner scope to newReplayTLI, as in the attached v2. WFM. Thanks. -- Michael signature.asc Description: PGP signature

Re: Removed unused import modules from tap tests

imize merge conflicts. However, everything has changed on HEAD, so there is a good argument for simplifying the tests as you are proposing here. Any thoughts from others? -- Michael signature.asc Description: PGP signature

Re: Deficient error handling in pg_dump and pg_basebackup

he sync callback in receivelog.c exit() on sight, but I am wondering if it would not be saner to just exit() from walmethods.c each time we see a failure with a fsync(). > At the very least it seems like it'd be preferable > to do the exit(1) at the caller level. You mean walmethods.c here, right? -- Michael signature.asc Description: PGP signature

Re: Improve error context after some failed XLogReadRecord()

On Tue, Nov 09, 2021 at 04:58:11PM +0900, Kyotaro Horiguchi wrote: > Otherwise it looks good to me. What you are proposing is better than what I had in those two contexts, so I have just used what you have suggested for both of them. Thanks! -- Michael signature.asc Description: PGP signature

Re: Commitfest 2021-11 Patch Triage - Part 2

icism raised > over the usefulness vs code weight tradeoff, but the response to this haven't > really been followed up on. Alvaro and Michael, do you have any changed > thoughts on Justins patch reorg or do you stil feel this isn't worth going > ahead with? My feeling on thi

Re: Add jsonlog log_destination for JSON server logs

On Tue, Oct 19, 2021 at 08:02:02PM +0900, Michael Paquier wrote: > 0001 and 0002, the refactoring bits, are in a rather committable > shape, so I'd like to apply that as the last refactoring pieces I know > of for this thread. 0003 still needs a closer lookup, and one part I > do

Re: Weird failure in explain.out with OpenBSD

garding this issue. Postgres is not wrong here. -- Michael signature.asc Description: PGP signature

Re: fix warnings in 9.6, 10, 11's contrib when compiling without openssl

oint in updating imath on the stable branches where it exists if there is an issue with it impacting pgcrypto without OpenSSL. -- Michael signature.asc Description: PGP signature

Re: Clean up build warnings of plperl with clang-12+

On Wed, Nov 10, 2021 at 07:35:21AM +0900, Michael Paquier wrote: > Tom has suggested that we could add -Wno-compound-token-split-by-macro > to take care of the issue on our side, and attached is a patch to do > so. > > Any objections? I'd like to get this back-patched. Bac

Re: Clean up build warnings of plperl with clang-12+

s in CFLAGS because it breaks configure, > # so use COPT instead. > $conf{build_env}{COPT} = "-Werror"; > } > > Guess I could drop the branch check now. Thanks. I'll switch to something like that. -- Michael signature.asc Description: PGP signature

Re: Clean up build warnings of plperl with clang-12+

its own local Makefile. > (And I wonder if the > meson system will be able to do it at all.) If you feel motivated > to make that happen, go for it, but I don't. Neither am I. 9ff47ea is the least invasive solution, at least. -- Michael signature.asc Description: PGP signature

Re: RecoveryInProgress() has critical side effects

he end of recovery based on its the state of Insert, but this could have changed while in recovery when replaying one or more XLOG_FPW_CHANGE records. > I'm personally not too worried about a ~4% regression in this > particular benchmark... This is not a hot code path, that should be fin

Re: pg_waldump stucks with options --follow or -f and --stats or -z

ke pg_waldump more responsive to the dump of the stats when interrupted, via XLogDumpDisplayStats(). -- Michael signature.asc Description: PGP signature

Re: Frontend error logging style

hat it isn't uniform today and give up. I agree with this sentiment, but this is a bit more complex than just calling exit() with pg_log_fatal(), no? pg_dump likes playing a lot with its exit_nicely(), meaning that we may want to allow frontends to plug in callbacks. -- Michael signatur

Re: add recovery, backup, archive, streaming etc. activity messages to server logs along with ps display

ogFileRead(), joining the point of Nathan's upthread. So I cannot get excited by this change. -- Michael signature.asc Description: PGP signature

Re: Unnecessary global variable declared in xlog.c

ere are no objections. -- Michael signature.asc Description: PGP signature

Re: Unnecessary global variable declared in xlog.c

On Tue, Nov 16, 2021 at 02:08:54AM -0500, Tom Lane wrote: > I think LastRec was originally referenced by multiple functions > in xlog.c. But it does look like it could be a local now. Thanks for double-checking, applied this one as of f975fc3. -- Michael signature.asc Descriptio

Re: pg_waldump stucks with options --follow or -f and --stats or -z

ch the idea of multiple stats reports emitted in a single pg_waldump call, TBH. This makes things more complicated than they should, and the gain is not obvious, at least to me. -- Michael signature.asc Description: PGP signature

Re: add recovery, backup, archive, streaming etc. activity messages to server logs along with ps display

ne in pgarch.c does not provide any additional information as the segment to-be-archived should be part of the command. -- Michael signature.asc Description: PGP signature

Re: Deficient error handling in pg_dump and pg_basebackup

On Wed, Nov 10, 2021 at 02:03:11PM +0900, Michael Paquier wrote: >> but this code seems about as fishy and ill-thought-out as anything >> else I've touched here. Why is this different from the half-dozen >> other fsync-error cases in the same file? Why, if fsyn

Re: Deficient error handling in pg_dump and pg_basebackup

ier.xyz Your proposals still look rather sane to me, after a second look. -- Michael signature.asc Description: PGP signature

Re: pg_upgrade test for binary compatibility of core data types

upthread seem to be covered with that. So I'd like to get that applied on HEAD. We could as well be less conservative and backpatch that down to 12 to follow on 7c15cef so we would be more careful with 15~ already (a backpatch down to 14 would be enough for this purpose, actually thanks to the 1

Re: CREATE tab completion

LANGUAGE", MatchAny)) + COMPLETE_WITH("HANDLER"); + else if (Matches("CREATE", "LANGUAGE", MatchAny, "HANDLER", MatchAny)) + COMPLETE_WITH("INLINE", "VALIDATOR"); It looks like you forgot the case of "OR REPLACE" here? This is done for triggers, for example. -- Michael signature.asc Description: PGP signature

Re: Deficient error handling in pg_dump and pg_basebackup

On Wed, Nov 17, 2021 at 02:19:20PM -0500, Tom Lane wrote: > Pushed then; thanks for reviewing that. We can consider the fsync > error question at leisure. Fine by me. Thanks for the commit. -- Michael signature.asc Description: PGP signature

Re: wait event and archive_command

n... Thought? FWIW, I find cleaner, and less bug-prone, the approach taken by Fujii-san's patch to have the wait event set as an argument of the function rather than trying to guess it from the command data. -- Michael signature.asc Description: PGP signature

Re: pg_upgrade test for binary compatibility of core data types

Justin, could you send a rebased version of that with all the changes from the buildfarm client included? -- Michael signature.asc Description: PGP signature

Re: pg_upgrade test for binary compatibility of core data types

e aclitem of this new table. prion uses a specific user name, "ec2-user", that caused the failure. -- Michael signature.asc Description: PGP signature

Re: pg_upgrade test for binary compatibility of core data types

oth styles to compensate with the cases where the objects are created after a drop. The list of objects and the version ranges look correct to me. -- Michael signature.asc Description: PGP signature

Re: CREATE tab completion

ATE SCHEMA was itching me a bit, until I recalled this recent thread which has a more complete logic: https://www.postgresql.org/message-id/87im0efqhp@wibble.ilmari.org The rest looks good, I'll take care of that in a bit. -- Michael signature.asc Description: PGP signature

Re: pg_waldump stucks with options --follow or -f and --stats or -z

On Thu, Nov 18, 2021 at 01:32:08PM +0530, Bharath Rupireddy wrote: > Hm. So, the pg_waldump can have handlers for SIGINT, SIGTERM, SIGQUIT > and then it should emit the computed stats in those handlers the > comobinations - "-s/-f/-z" and "-s/-e/-f/-z". I'm o

Re: Teach pg_receivewal to use lz4 compression

was symmetry, where IMO it makes sense to have a compressEnd call each time there is a successful compressBegin call done for the LZ4 state data, as there is no way to know if in the future LZ4 won't change some of its internals to do more than just an internal flush. -- Michael signature.asc Description: PGP signature

Re: CREATE tab completion

domains and transforms remained. That looked like good enough on its own, so applied those parts of the patch. -- Michael signature.asc Description: PGP signature

Re: Some RELKIND macro refactoring

e same result as the original without impacting the level of safety of the original code. -- Michael signature.asc Description: PGP signature

Re: CREATE tab completion

On Fri, Nov 19, 2021 at 04:19:01PM +0900, Ken Kato wrote: > I assume Michael has committed the modified version of the patch. > Therefore, I changed the status to"committed" in Commitfest 2022-01. > https://commitfest.postgresql.org/36/3418/ Thanks, I did not notice

Re: drop tablespace failed when location contains .. on win32

ost if reading through this code in the future. Changes in trim_directory(), for example, should explain what is returned and why. + isabs = is_absolute_path(path); + tmppath = strdup(path); If possible, it would be nice to cut any need for malloc() allocations in this code. -- Michael signature.asc Description: PGP signature

Re: wait event and archive_command

On Thu, Nov 18, 2021 at 10:04:57AM +0530, Bharath Rupireddy wrote: > Yeah let's not do that. I'm fine with the > wait_event_for_archive_command_v2.patch as is. Switched the patch as RfC, then. -- Michael signature.asc Description: PGP signature

Re: dfmgr additional ABI version fields

k? Hmm. Wouldn't that cause more harm than actual benefits? -- Michael signature.asc Description: PGP signature

Re: pg_waldump stucks with options --follow or -f and --stats or -z

e signal handler, and then check its value in the main loop of pg_waldump, dumping the stats if it is detected as turned on because of a signal. -- Michael signature.asc Description: PGP signature

Re: Pasword expiration warning

re the user is informed of the authentication result, FWIW, so that does not seem wise. -- Michael signature.asc Description: PGP signature

Re: Should rename "startup process" to something else?

and go as far as renaming walsender to "WAL sender", "walreceiver" to "WAL receiver", and "walwriter" to "WAL writer", even if that means potentially breaking scripts monitoring ps outputs. -- Michael signature.asc Description: PGP signature

Re: logical decoding/replication: new functions pg_ls_logicaldir and pg_ls_replslotdir

eplslot" could be part of the third argument here. There is no need to separate it. +ordinary file in the server's pg_logical/mappings directory. Paths had better have markups around them, no? -- Michael signature.asc Description: PGP signature

Re: VS2022: Support Visual Studio 2022 on Windows

I'll double-check your patch later, but that looks rather good to me. Will try to apply and back-patch, and it would be better to check the version numbers assigned in the patch, as well. -- Michael signature.asc Description: PGP signature

Re: logical decoding/replication: new functions pg_ls_logicaldir and pg_ls_replslotdir

the result looked fine at the end. Hence, applied. -- Michael signature.asc Description: PGP signature

Re: VS2022: Support Visual Studio 2022 on Windows

On Sun, Nov 21, 2021 at 10:41:17AM +0900, Michael Paquier wrote: > I'll double-check your patch later, but that looks rather good to me. > Will try to apply and back-patch, and it would be better to check the > version numbers assigned in the patch, as well. I have spent a couple of

Re: Some RELKIND macro refactoring

On Mon, Nov 22, 2021 at 11:21:52AM +0100, Peter Eisentraut wrote: > On 19.11.21 08:31, Michael Paquier wrote: >> Regarding 0001, I find the existing code a bit more self-documenting >> if we keep those checks flagInhAttrs() and guessConstraintInheritance(). >> So I wou

Re: Post-CVE Wishlist

s last part has never reached -hackers though :) Anyway, the closest thing I can put my finger on now is that: https://www.postgresql.org/message-id/c5cb08f4cce46ff661ad287fadaa1...@postgrespro.ru -- Michael signature.asc Description: PGP signature

Re: Teach pg_receivewal to use lz4 compression

. Hmm. I have double-checked all that, and I agree that we could just skip LZ4F_compressEnd() in this error code path. From what I can see in the upstream code, what we have now is not broken either, but the compressEnd() call does some work that's not needed here. -- Michael signature.asc Description: PGP signature

Re: [BUG]Missing REPLICA IDENTITY check when DROP NOT NULL

indexStruct->indisprimary), colName))); Using ngettext() looks incorrect to me here as it is used to get the plural form of a string, so you'd better make these completely separated instead. -- Michael signature.asc Description: PGP signature

Re: VS2022: Support Visual Studio 2022 on Windows

the compilation of all its dependencies. > - Perl, Python, TCL, MIT Kerberos, > OpenSSL, libxml2, libxslt etc. are all built with the same toolchain for > consistency. Dave, do you include LZ4 in 14? Just asking, as a matter of curiosity. -- Michael signature.asc Description: PGP signature

Re: BUFFERS enabled by default in EXPLAIN (ANALYZE)

y case, thank you all, I’m so glad that this is being discussed again. It’d be so good to start seeing buffers in more plans. — Michael

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

to repeat this step. Am I missing > something? This is a known issue with exclusive backups, which is a reason why non-exclusive backups have been implemented. pg_basebackup does that, and using "false" as the third argument of pg_start_backup() would have the same effect. So I would

Re: [BUG]Missing REPLICA IDENTITY check when DROP NOT NULL

On Thu, Nov 25, 2021 at 10:44:53AM +0530, Dilip Kumar wrote: > Good catch, your patch looks fine to me and solves the reported problem. And applied down to 10. A couple of comments in the same area did not get the call, though. -- Michael signature.asc Description: PGP signature

Re: Deduplicate code updating ControleFile's DBState.

end and the frontend. 0002 does not seem worth the trouble, though, as it is changing only two code paths. -- Michael signature.asc Description: PGP signature

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

ure if this is worth worrying about either. > If we are keeping it then why not make it better? Well, non-exclusive backups are better by design in many aspects, so I don't quite see the point in spending time on something that has more limitations than what's already in place. -- Mich

Re: pg_waldump stucks with options --follow or -f and --stats or -z

d a new paragraph in the description of --stats. -- Michael signature.asc Description: PGP signature

Re: [PATCH] ALTER tab completion

+ else if (TailMatches("ALTER", "SEQUENCE", MatchAny, "AS")) + COMPLETE_WITH("smallint", "integer", "bigint"); Re-quoting Horiguchi-san, that should be COMPLETE_WITH_CS() to keep these completions in lower case. -- Michael signature.asc Description: PGP signature

Re: Deduplicate code updating ControleFile's DBState.

On Thu, Nov 25, 2021 at 04:04:23PM +0900, Michael Paquier wrote: > I have not check the performance implication of that with a micro > benchmark or the like, but I can get behind 0001 on consistency > grounds between the backend and the frontend. /* Now create p

Re: pg_dump, pg_basebackup don't error out with wrong option for "--format"

ting use cases as it is possible to save some characters if getopt_long() is sure of the uniqueness of the option found. -- Michael signature.asc Description: PGP signature

Re: pg_waldump stucks with options --follow or -f and --stats or -z

On Fri, Nov 26, 2021 at 03:47:30PM +0530, Bharath Rupireddy wrote: > On Fri, Nov 26, 2021 at 11:50 AM Michael Paquier wrote: >> +When --follow is used with --stats and >> +the pg_waldump is terminated or interrupted >> +with signal SIGINT or >> SIGTERM >

Re: Deduplicate code updating ControleFile's DBState.

PI old enough to vote (a70e74b0). Anyway, that's a useful wrapper for the backend. -- Michael signature.asc Description: PGP signature

Re: SSL Tests for sslinfo extension

t; starts is potentially accessible by other local users, and AFAICS the > same has to be true for an sslinfo test. Ah, indeed, good point. I completely forgot that we'd better control this stuff with PG_TEST_EXTRA. -- Michael signature.asc Description: PGP signature

Re: [PATCH] ALTER tab completion

On Fri, Nov 26, 2021 at 05:00:44PM +0900, Ken Kato wrote: > I made following updates: I have made one small modification for ALTER VIEW, and applied what you have. Thanks, Kato-san. -- Michael signature.asc Description: PGP signature

Re: Deduplicate code updating ControleFile's DBState.

at [1], looks good to me. Yes, I have no problems with this part, so done. -- Michael signature.asc Description: PGP signature

Re: pg_waldump stucks with options --follow or -f and --stats or -z

, but that's worth mentioning. Any opinions? -- Michael signature.asc Description: PGP signature

Re: GUC flags

gettext_noop("Compute query identifiers."), +gettext_noop("Enables in-core computation of a query identifier."), This could just be "Computes"? I am not completely sure that all the contents of 0002 are improvements, but the suggestions done for huge_pages, ssl_passphrase_command_supports_reload, checkpoint_warning and commit_siblings seem fine to me. -- Michael signature.asc Description: PGP signature

Re: Fix typos

On Mon, Nov 29, 2021 at 01:01:55AM +, qianglj.f...@fujitsu.com wrote: > I found several typos in comments and README. See patch attached. Thanks, fixed. -- Michael signature.asc Description: PGP signature

Re: GUC flags

On Mon, Nov 29, 2021 at 05:04:01PM +0900, Michael Paquier wrote: > 0001, to adjust the units, and 0003, to make the GUC descriptions less > unit-dependent, are good ideas. Actually, after sleeping on it and doing some digging in codesearch.debian.org, changing the units of max_identifier_

Re: [PATCH] pg_statio_all_tables: several rows per table due to invalid TOAST index

egular indexes and several TOAST-indexes for > the same table. Statistics for the regular and TOAST indexes is to be > calculated the same way so I've decided to use a CTE here. Hmm. Why should we care about invalid indexes at all, including pg_statio_all_indexes? -- Michael signature.asc Description: PGP signature

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

it gets included in the backup? -- Michael signature.asc Description: PGP signature

Re: [PATCH] DROP tab completion

ete.c as of HEAD at 538724f, but I think that you have done things right as there are already sections for those commands and they have multiple keywords. So, applied. Thanks! -- Michael signature.asc Description: PGP signature

Re: pg_upgrade test for binary compatibility of core data types

On Thu, Nov 18, 2021 at 03:58:18PM +0900, Michael Paquier wrote: > + ver >= 905 AND ver <= 1300 AS oldpgversion_95_13, > + ver >= 906 AND ver <= 1300 AS oldpgversion_96_13, > + ver >= 906 AND ver <= 1000 AS oldpgversion_96_10, > So here, we have the choice bet

Re: fix a typo in slotfuncs.c

to fix it. This typo exists all the way until PG 13. Indeed, thanks. I'll fix in a bit. -- Michael signature.asc Description: PGP signature

Re: GUC flags

On Wed, Dec 01, 2021 at 01:59:05AM -0600, Justin Pryzby wrote: > On Tue, Nov 30, 2021 at 03:36:45PM +0900, Michael Paquier wrote: >> -gettext_noop("Waits N seconds on connection startup >> before authentication."), >> +g

Re: [PATCH] Verify Checksums during Basebackups

Hi Magnus, thanks a lot for looking at my patch! Am Donnerstag, den 22.03.2018, 15:07 +0100 schrieb Magnus Hagander: > On Sat, Mar 17, 2018 at 10:34 PM, Michael Banck > wrote: > > On Fri, Mar 09, 2018 at 10:35:33PM +0100, Michael Banck wrote: > > > Possibly open questi

Re: Typo with pg_multixact/offset in multixact.c

On Thu, Mar 22, 2018 at 01:36:59PM -0400, Robert Haas wrote: > Committed. Thanks. -- Michael signature.asc Description: PGP signature

Re: Using base backup exclusion filters to reduce data transferred with pg_rewind

ut I am not sure if you imply that 3) would be acceptable or not. -- Michael signature.asc Description: PGP signature

Re: [PoC PATCH] Parallel dump to /dev/null

On Thu, Mar 22, 2018 at 08:42:05AM +0100, Michael Banck wrote: > Am Donnerstag, den 22.03.2018, 10:33 +0900 schrieb Michael Paquier: >> Hence, is there any objection to mark this patch as returned with >> feedback? > > I've done so now. Thanks Michael. -- Michael

<    8   9   10   11   12   13   14   15   16   17   >