Re: New committers: Melanie Plageman, Richard Guo

2024-04-26 Thread Yasir
Congratulations to both of you Melanie and Richard. Thank you so much for stepping forward to this great cause. Regards... Yasir Hussain Bitnine Global On Fri, Apr 26, 2024 at 4:54 PM Jonathan S. Katz wrote: > The Core Team would like to extend our congratulations to Melanie > Plagem

Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-16 Thread Yasir
uru's guidance! Regards... Yasir Hussain Principal Software Engineer Bitnine Global Inc. diff --git a/.gitignore b/.gitignore index 4e911395fe..527e1d8935 100644 --- a/.gitignore +++ b/.gitignore @@ -43,3 +43,4 @@ lib*.pc /Release/ /tmp_install/ /portlock/ +/.vs/

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-16 Thread Yasir
Nice approach! Thankyou Peter for the guidance. Regards... Yasir On Fri, May 17, 2024 at 11:34 AM Peter Eisentraut wrote: > On 17.05.24 08:09, Yasir wrote: > > I have been playing with PG on the Windows platform recently. An > > annoying thing I faced is that a lot of Visua

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-17 Thread Yasir
On Fri, May 17, 2024 at 12:25 AM Maciek Sakrejda wrote: > Thanks for raising this. As someone who is only modestly familiar with > Postgres internals or even C, but would still like to contribute through > review, I find the current process of finding a suitable patch both tedious > and daunting.

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-18 Thread Yasir
On Sat, May 18, 2024 at 7:27 PM Josef Šimánek wrote: > pá 17. 5. 2024 v 8:09 odesílatel Yasir > napsal: > > > > Hi Hackers, > > > > I have been playing with PG on the Windows platform recently. An > annoying thing I faced is that a lot of Visual Studio

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-18 Thread Yasir
On Sat, May 18, 2024 at 7:27 PM Josef Šimánek wrote: > pá 17. 5. 2024 v 8:09 odesílatel Yasir > napsal: > > > > Hi Hackers, > > > > I have been playing with PG on the Windows platform recently. An > annoying thing I faced is that a lot of Visual Studio

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-18 Thread Yasir
On Sun, May 19, 2024 at 1:45 AM Andrew Dunstan wrote: > > On 2024-05-18 Sa 15:43, Yasir wrote: > > > > On Sat, May 18, 2024 at 7:27 PM Josef Šimánek > wrote: > >> pá 17. 5. 2024 v 8:09 odesílatel Yasir >> napsal: >> > >> > Hi Hackers

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-18 Thread Yasir
On Sun, May 19, 2024 at 2:16 AM Tom Lane wrote: > =?UTF-8?B?Sm9zZWYgxaBpbcOhbmVr?= writes: > > But this is different. If I understand it well, just by following > > https://www.postgresql.org/docs/16/install-windows-full.html you'll > > get those files no matter what is your specific environment

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-18 Thread Yasir
On Sun, May 19, 2024 at 2:23 AM Josef Šimánek wrote: > so 18. 5. 2024 v 23:16 odesílatel Tom Lane napsal: > > > > =?UTF-8?B?Sm9zZWYgxaBpbcOhbmVr?= writes: > > > But this is different. If I understand it well, just by following > > > https://www.postgresql.org/docs/16/install-windows-full.html y

Re: Ignore Visual Studio's Temp Files While Working with PG on Windows

2024-05-18 Thread Yasir
On Sun, May 19, 2024 at 2:35 AM Andrew Dunstan wrote: > > On 2024-05-18 Sa 16:54, Yasir wrote: > > > > On Sun, May 19, 2024 at 1:45 AM Andrew Dunstan > wrote: > >> >> On 2024-05-18 Sa 15:43, Yasir wrote: >> >> >> >> On Sat, May 18, 20

Re: date_trunc function in interval version

2024-05-18 Thread Yasir
On Sun, May 19, 2024 at 2:20 AM Przemysław Sztoch wrote: > Robert Haas wrote on 5/15/2024 9:29 PM: > > On Mon, Mar 4, 2024 at 5:03 AM Przemysław Sztoch > wrote: > > Apparently the functionality is identical to date_bin. > When I saw date_bin in the documentation, I thought it solved all my pro

Re: errors building on windows using meson

2024-07-16 Thread Yasir
On Tue, May 28, 2024 at 8:50 PM Imran Zaheer wrote: > Hi > > I was facing the same error when using active state perl for compiling > postgres with meson on windows. I used active state perl because it was > working fine for pg compilations until pg-16. > > Using choco strawberry perl solved my p

ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

2024-07-16 Thread Yasir
ated. Moreover, I had to install "strawberry's perl" in order to compile PG17 on Windows 10/11. Please check out the thread "errors building on windows using meson <https://www.postgresql.org/message-id/flat/CADK3HHLQ1MNmfXqEvQi36D_MQrheOZPcXv2H3s6otMbSmfwjzg%40mail.gmail.com>&qu

Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows

2024-07-16 Thread Yasir
On Tue, Jul 16, 2024 at 4:58 PM Yasir Shah wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, failed (meson test, passed) > Implements feature: tested, failed(tested, passed) > Sp

Re: Memory growth observed with C++ application consuming libpq.dll on Windows

2024-08-01 Thread Yasir
Hi Rajesh, Can you please attach a sample code snippet showing libpq's functions being called? It will help to identify the libpq's functions to investigate further for a potential mem leak. Regards... Yasir Hussain On Thu, Aug 1, 2024 at 4:30 PM Rajesh Kokkonda wrote: > H

Re: Memory growth observed with C++ application consuming libpq.dll on Windows

2024-08-02 Thread Yasir
On Fri, Aug 2, 2024 at 1:53 PM Rajesh Kokkonda wrote: > Hi Yasir, > > Are you looking for a fully functional sample program or only the APIs > from libpq library that our product uses? I am asking this because if the > requirement is to have a sample code, then I will have to w

Re: Alias of VALUES RTE in explain plan

2024-08-15 Thread Yasir
On Mon, Jul 1, 2024 at 3:17 PM Ashutosh Bapat wrote: > Hi All, > While reviewing Richard's patch for grouping sets, I stumbled upon > following explain output > > explain (costs off) > select distinct on (a, b) a, b > from (values (1, 1), (2, 2)) as t (a, b) where a = b > group by grouping sets((

Re: Alias of VALUES RTE in explain plan

2024-10-28 Thread Yasir
On Mon, Oct 28, 2024 at 8:16 PM Tom Lane wrote: > Ashutosh Bapat writes: > > The patch looks good to me, except the name of the new member. > > > CommonTableExpr *p_parent_cte; /* this query's containing CTE */ > > + Alias*p_parent_alias; /* parent's alias for this query */ > > > the two "

Re: Alias of VALUES RTE in explain plan

2024-10-27 Thread Yasir
On Mon, Oct 28, 2024 at 1:07 AM Tom Lane wrote: > Yasir writes: > > On Sat, Oct 26, 2024 at 12:21 AM Tom Lane wrote: > >> I forgot to mention a third problem, which is that reassigning the > >> alias during subquery pullup means it doesn't happen if sub

Re: Alias of VALUES RTE in explain plan

2024-10-27 Thread Yasir
On Fri, Oct 25, 2024 at 10:35 PM Tom Lane wrote: > Yasir writes: > > I have fixed the code to produce desired output by adding a few lines in > > pull_up_simple_subquery(). > > Attached patch is divided in 2 files: > > - 001-Fix-Alias-VALUES-RTE.patch contains the

Re: Alias of VALUES RTE in explain plan

2024-10-27 Thread Yasir
On Sat, Oct 26, 2024 at 12:21 AM Tom Lane wrote: > I wrote: > > However ... I don't like this implementation, not even a little > > bit. > > I forgot to mention a third problem, which is that reassigning the > alias during subquery pullup means it doesn't happen if subquery > pullup doesn't happe

Re: Alias of VALUES RTE in explain plan

2024-10-25 Thread Yasir
nges against the actual fix. I also have verified regression tests, all seems good. Respected hackers please have a look. Thanks and regards... Yasir On Thu, Aug 15, 2024 at 7:13 PM Yasir wrote: > > > On Mon, Jul 1, 2024 at 3:17 PM Ashutosh Bapat < > ashutosh.bapat@gmail.com&

Re: Why our Valgrind reports suck

2025-05-12 Thread Yasir
blocks ==00:00:01:50.385 90463== Rerun with --leak-check=full to see details of leaked memory ==00:00:01:50.385 90463== ==00:00:01:50.385 90463== For lists of detected and suppressed errors, rerun with: -s ==00:00:01:50.385 90463== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 34 from 3) Regards, Yasir Hussain Data Bene

Re: Valgrind - showing memory leaks

2025-05-08 Thread Yasir
On Thu, May 8, 2025 at 7:27 PM Tom Lane wrote: > Yasir writes: > > I believe that the valgrind should not report any memory leaks in such > > simple/common commands. What am I doing wrong here? > > I think you are vastly overestimating both the intelligence of > va

Re: Why our Valgrind reports suck

2025-05-09 Thread Yasir
ink there is value in having > less clutter in Valgrind reports. Thoughts? > > regards, tom lane > > [1] > https://www.postgresql.org/message-id/flat/CAA9OW9e4RbpgQd8NSzpW6BgJQNpKGEFoohWhkbEL8%3DZ5obvD0Q%40mail.gmail.com > [2] https://valgrind.org/docs/manual/mc-manual.html#mc-manual.leaks > > > Thanks for the detailed analysis, this was very informative. I agree that reducing noise in Valgrind reports would be valuable, especially for catching real leaks. Having a clearer signal from Valgrind would definitely help long term. Regards, Yasir Data Bene

Re: Valgrind - showing memory leaks

2025-05-08 Thread Yasir
On Thu, May 8, 2025 at 6:17 PM Álvaro Herrera wrote: > On 2025-05-08, Yasir wrote: > > > I believe that the valgrind should not report any memory leaks in such > > simple/common commands. What am I doing wrong here? > > Hmm, that function was modified relatively recentl

Re: Violation of principle that plan trees are read-only

2025-05-20 Thread Yasir
for further inspection. Yes, this approach introduces some memory and performance overhead. However, we can limit its impact by enabling it conditionally via a compile-time flag or #define, making it suitable for debugging or assertion-enabled builds. It might sound a bit unconventional, but it could serve as a useful sanity check especially during development or when investigating plan tree integrity issues. Pardon me if this sounds naive! Yasir Data Bene

Re: Why our Valgrind reports suck

2025-05-22 Thread Yasir
nly. Whilst, the original issue I posted [link <https://www.postgresql.org/message-id/flat/CAA9OW9e536dJanVKZRd_GKQ4wN_m5rhsMnrL6ZvaWagzLwv3%3Dg%40mail.gmail.com>] is fixed. There are no leaks. Regards, Yasir Hussain Data Bene > The rest are more or less bite-sized fixes of individual problems.

Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows

2024-07-16 Thread Yasir Shah
ed, what I observed in the PG code as a standard: Your patch: #include #include It should be like: #include #include Regards... Yasir Hussain Bitnine Global Inc.