t say "run this command line incantation of
pgindent," which in the grand scheme of things is easy compared to all
the other things you have to be aware of to contribute to Postgres.
--
Tristan Partin
Neon (https://neon.tech)
On Fri Jan 12, 2024 at 10:45 AM CST, Robert Haas wrote:
On Mon, Jan 8, 2024 at 1:03 AM Tristan Partin wrote:
> I think the way to go is to expose some variation of libpq's
> pqSocketPoll(), which I would be happy to put together a patch for.
> Making frontends, psql in this
WeoEicnK%3DPCNWEMrA%40mail.gmail.com
[1]:
https://www.postgresql.org/message-id/20220127182838.ba3434dp2pe5vcia%40alap3.anarazel.de
--
Tristan Partin
Neon (https://neon.tech)
From 5ffbc7c35bb3248501b2517d26f99afe02fb53d6 Mon Sep 17 00:00:00 2001
From: Matthias van de Meent
Date: Tue, 27 Jun 2023 15:59:23 +02
of us that
pgindent out of tree code. It would also have the added benefit of
adding the tools to $PREFIX/bin, which would make the test that I added
not need a hack to get the pg_bsd_indent executable.
--
Tristan Partin
Neon (https://neon.tech)
From 6e9ca366b6e4976ae591012150fe77729e37c503 Mo
On Tue Jan 16, 2024 at 7:27 PM CST, Bruce Momjian wrote:
On Tue, Jan 16, 2024 at 07:22:23PM -0600, Tristan Partin wrote:
> I think a good solution would be to distribute pgindent and pg_bsd_indent.
> At Neon, we are trying to format our extension code using pgindent. I am
> sure there
could
install the perltidy file and whatever else too. I keep my Perl writing
to a minimum, so I am not the best person to vouch for these usecases.
[0]:
https://www.postgresql.org/message-id/aaa59ef5-dce8-7369-5cae-487727664127%40dunslane.net
--
Tristan Partin
Neon (https://neon.tech)
"meson-ic" way is to use a machine file.
+
+alias_target('pgdist', [check_dirty_index, tar_gz, tar_bz2])
Are you intending for the check_dirty_index target to prohibit the other
two targets from running? Currently that is not the case. If it is what
you intend, use a stamp file or something to indicate a rela
mit/8b7cbe9decc205b08ec8258eb184c89a33e3084b
[1]:
https://developer.apple.com/documentation/systemconfiguration/1517088-scdynamicstorecopyproxies
--
Tristan Partin
Neon (https://neon.tech)
<>
From 0a514e7a8ea2af21d98cbcc2e4da799745786155 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date
On Tue Jan 23, 2024 at 1:47 PM CST, Andres Freund wrote:
Hi,
On 2024-01-23 13:20:15 -0600, Tristan Partin wrote:
> These checks are not effective for what they are trying to prevent. A recent
> commit[0] in libcurl when used on macOS has been tripping the
> pthread_is_threaded_np()
On Tue Jan 23, 2024 at 2:10 PM CST, Tristan Partin wrote:
On Tue Jan 23, 2024 at 1:47 PM CST, Andres Freund wrote:
> Hi,
> On 2024-01-23 13:20:15 -0600, Tristan Partin wrote:
> > These checks are not effective for what they are trying to prevent. A recent
> > commit[0] in li
On Tue Jan 23, 2024 at 4:23 PM CST, Andres Freund wrote:
Hi,
On 2024-01-23 15:50:11 -0600, Tristan Partin wrote:
> What is keeping us from using pthread_sigmask(3) instead of sigprocmask(2)?
We would need to make sure to compile with threading support everywhere. One
issue is that on s
On Tue Jan 23, 2024 at 3:30 AM CST, Peter Eisentraut wrote:
On 22.01.24 21:04, Tristan Partin wrote:
> I am not really following why we can't use the builtin Meson dist
> command. The only difference from my testing is it doesn't use a
> --prefix argument.
Here are s
ering if the issue described in this thread could be related
to the issue I ran into. Afaict the merged patch has not been released
yet.
Do you have a backtrace? Given that the version is 3.2.0, seems likely.
--
Tristan Partin
Neon (https://neon.tech)
On Wed Jan 24, 2024 at 10:18 AM CST, Tristan Partin wrote:
On Tue Jan 23, 2024 at 3:30 AM CST, Peter Eisentraut wrote:
> On 22.01.24 21:04, Tristan Partin wrote:
> > I am not really following why we can't use the builtin Meson dist
> > command. The only difference from my t
On Thu Jan 25, 2024 at 10:04 AM CST, Peter Eisentraut wrote:
On 22.01.24 21:04, Tristan Partin wrote:
>> + 'HEAD', '.'],
>> + install: false,
>> + output: distdir + '.tar.bz2',
>> +)
>
> The bz2 target should be wrapped i
On Fri Jan 26, 2024 at 12:28 AM CST, Peter Eisentraut wrote:
On 25.01.24 17:25, Tristan Partin wrote:
> For what it's worth, I run Meson 1.3, and the behavior of generating the
> tarballs even though it is a dirty tree still occurred. In the new patch
> you seem to say it was
a look for you. Not sure how hard it will be, but
I can take a crack at it this week.
--
Tristan Partin
Neon (https://neon.tech)
t the Meson build if asan support is requested. That way
others don't spend time heading down a dead end.
--
Tristan Partin
Neon (https://neon.tech)
Spend so much time writing out the email, I once again forget
attachments...UGH.
--
Tristan Partin
Neon (https://neon.tech)
From 331cec1c9db6ff60dcc6d9ba62a9c8be4e5e95ed Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Mon, 29 Jan 2024 18:03:39 -0600
Subject: [PATCH v1 1/3] Refuse to
On Fri Jan 12, 2024 at 11:13 AM CST, Tristan Partin wrote:
On Fri Jan 12, 2024 at 10:45 AM CST, Robert Haas wrote:
> On Mon, Jan 8, 2024 at 1:03 AM Tristan Partin wrote:
> > I think the way to go is to expose some variation of libpq's
> > pqSocketPoll(), which I would be hap
On Tue Jan 30, 2024 at 4:42 PM CST, Jelte Fennema-Nio wrote:
On Tue, 30 Jan 2024 at 23:20, Tristan Partin wrote:
> Not next week, but here is a respin. I've exposed pqSocketPoll as
> PQsocketPoll and am just using that. You can see the diff is so much
> smaller, which is great!
T
On Tue Jan 30, 2024 at 10:00 PM CST, Alexander Lakhin wrote:
Hello,
30.01.2024 18:57, Tristan Partin wrote:
> Patch 1:
>
> Passing NULL as a second argument to memcpy breaks ubsan, ...
Maybe you would like to fix also one more similar place, reached with:
create extension xml
On Tue Jan 30, 2024 at 3:58 PM CST, Andres Freund wrote:
Hi,
On 2024-01-30 09:59:25 -0600, Tristan Partin wrote:
> From 331cec1c9db6ff60dcc6d9ba62a9c8be4e5e95ed Mon Sep 17 00:00:00 2001
> From: Tristan Partin
> Date: Mon, 29 Jan 2024 18:03:39 -0600
> Subject: [PATCH v1 1/3] Refuse
On Fri Mar 22, 2024 at 9:59 AM CDT, Robert Haas wrote:
On Wed, Jan 31, 2024 at 1:07 PM Tristan Partin wrote:
> I was looking for documentation of PQsocket(), but didn't find any
> standalone (unless I completely missed it). So I just copied how
> PQsocket() is documented in PQco
eful even if we don't take the full CI patch (0003).
0002 looks pretty reasonable to me.
About the 0003 patch: It seems useful in principle to test these things
continuously. The dist script runs about 10 seconds in each task, and
takes a bit of disk space for the artifacts. I'm not sure to what
degree this might bother someone.
0003 works for me :).
--
Tristan Partin
Neon (https://neon.tech)
On Fri Mar 22, 2024 at 12:17 PM CDT, Robert Haas wrote:
On Fri, Mar 22, 2024 at 1:05 PM Tristan Partin wrote:
> Sorry for taking a while to get back to y'all. I have taken your
> feedback into consideration for v9. This is my first time writing
> Postgres docs, so I'm ready f
ar.bz2',
+ )
You might find Meson's string formatting syntax creates a more readable
command string:
'tar.tar.bz2.command=@0@ -c'.format(bzip2.path())
And then 'install: false' is the default if you feel like leaving it
out.
Otherwise, let's get this in!
--
Tristan Partin
Neon (https://neon.tech)
d to look at the
situation again though.
[0]: If someone wants to make a plea here:
https://github.com/mesonbuild/meson/pull/12623
--
Tristan Partin
Neon (https://neon.tech)
On Mon Mar 25, 2024 at 1:44 PM CDT, Robert Haas wrote:
On Fri, Mar 22, 2024 at 4:58 PM Tristan Partin wrote:
> I had a question about parameter naming. Right now I have a mix of
> camel-case and snake-case in the function signature since that is what
> I inherited. Should I change t
at
version exists in the base repo. Perhaps it is 0.55, which would still
get rid of the aforementioned warning.
Committer, please pick your patch :).
[0]:
https://www.postgresql.org/message-id/40e80f77-a294-4f29-a16f-e21bc7bc7...@eisentraut.org
--
Tristan Partin
Neon (https://neon.tech)
d
On Tue Apr 2, 2024 at 9:32 AM CDT, Robert Haas wrote:
On Mon, Apr 1, 2024 at 12:04 PM Tristan Partin wrote:
> > This sentence seems a bit contorted to me, like maybe Yoda wrote it.
>
> Incorporated feedback, I have :).
Committed it, I did. My thanks for working on this iss
lls.
Patches look good. Sorry about causing you to do some work.
--
Tristan Partin
Neon (https://neon.tech)
c.o
../src/bin/psql/command.c: In function ‘wait_until_connected’:
../src/bin/psql/command.c:3803:17: warning: enumeration value
‘PGRES_POLLING_ACTIVE’ not handled in switch [-Wswitch]
3803 | switch (PQconnectPoll(conn))
| ^~
--
Tristan Partin
Neon (https://neon.tech)
On Wed Apr 3, 2024 at 10:05 AM CDT, Jelte Fennema-Nio wrote:
On Wed, 3 Apr 2024 at 16:55, Tristan Partin wrote:
> Removing from the switch statement causes a warning:
>
> > [1/2] Compiling C object src/bin/psql/psql.p/command.c.o
> > ../src/bin/psql/command.c: In function ‘wa
Thanks Jelte and Robert for the extra effort to correct my mistake.
I apologize. Bad copy-paste from a previous revision of the patch at
some point.
--
Tristan Partin
Neon (https://neon.tech)
dependencies: [backend_code],
+ include_directories: include_directories('../../../include/storage'),
+ kwargs: internal_lib_args,
+ )
Move the paren to the beginning of the line.
+backend_link_with += lwlock_lib
Earlier in the thread you had said this:
IMO it would be less ugly to have the origin file lwlocknames.txt be
not a text file but a .h with a macro that can be defined by
interested parties so that they can extract what they want from the
file, like PG_CMDTAG or PG_KEYWORD. Using Perl for this seems dirty...
I really like this idea, and would definitely be more inclined to see
a solution like this.
--
Tristan Partin
Neon (https://neon.tech)
ving more automation around include patterns would be great! I think
it would be good if there a Meson run_target()/Make .PHONY target that
people could use to test too. Then, eventually the cfbot could pick this
up.
--
Tristan Partin
Neon (https://neon.tech)
.
I think with this change, it is unlikely I will be able to upstream
anything to Meson that would benefit Postgres here since setting this
option seems project dependent.
--
Tristan Partin
Neon (https://neon.tech)
On Fri Mar 1, 2024 at 8:00 AM CST, Alvaro Herrera wrote:
On 2024-Feb-23, Heikki Linnakangas wrote:
> On 12/02/2024 19:01, Tristan Partin wrote:
> > On Wed Jan 24, 2024 at 8:09 AM CST, Alvaro Herrera wrote:
> > > IMO it would be less ugly to have the origin file lwlocknames.
ame(type;
I assume you are referring to the child name here?
XXX: We now have functions called AuxiliaryProcessInit() and
InitAuxiliaryProcess(). Confusing.
Based on my analysis, the *Init() is called in the Main functions, while
Init*() is called before the Main functions. Maybe
AuxiliaryProcessInit() could be renamed to AuxiliaryProcessStartup()?
Rename the other to AuxiliaryProcessInit().
--
Tristan Partin
Neon (https://neon.tech)
e confirmed the issue exists
with a pg_config compiled with Meson. I can also confirm that this issue
exists in the autotools build.
Here is a v2 of your patch which includes the fix for autotools. I will
mark this "Ready for Committer" in the commitfest. Thanks!
[0]: https://gcc.gn
On Fri Mar 8, 2024 at 12:32 AM CST, Michael Paquier wrote:
On Thu, Mar 07, 2024 at 11:39:39PM -0600, Tristan Partin wrote:
> It sounds like a legitimate issue. I have confirmed the issue exists with a
> pg_config compiled with Meson. I can also confirm that this issue exists in
> the
On Tue Mar 12, 2024 at 6:56 PM CDT, Sutou Kouhei wrote:
Hi,
In
"Re: meson: Specify -Wformat as a common warning flag for extensions" on Fri,
08 Mar 2024 10:05:27 -0600,
"Tristan Partin" wrote:
> Ok, I figured this out. -Wall implies -Wformat=1. We set warning_le
iables into the PGXS Makefile.
--
Tristan Partin
Neon (https://neon.tech)
On Thu Mar 14, 2024 at 12:15 AM CDT, Michael Paquier wrote:
On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote:
> One of them adds version gates to two LLVM flags (-frwapv,
> -fno-strict-aliasing). I believe we moved the minimum LLVM version recently,
> so these mig
as no short version. Even typing -j8 every time
would be kind of annoying; typing --num-processes 8 every time is
ridiculously verbose.
I submitted a patch[0] to Meson to add -j.
[0]: https://github.com/mesonbuild/meson/pull/12403
--
Tristan Partin
Neon (https://neon.tech)
On Fri Oct 20, 2023 at 11:22 AM CDT, Tristan Partin wrote:
On Thu Oct 19, 2023 at 12:44 PM CDT, Robert Haas wrote:
> The obvious fix to this is to just tell 'meson test' how many
> processes I'd like it to run. I thought maybe I could just do 'meson
> -j8 test
Meson
maintainers understand the use case better.
Thanks!
[0]: https://github.com/mesonbuild/meson/pull/12362
--
Tristan Partin
Neon (https://neon.tech)
7946-3e84cb577e9551c3%40postgresql.org
--
Tristan Partin
Neon (https://neon.tech)
From d336d84cf60b22147e1234260b3199a52e9863e3 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Fri, 30 Jun 2023 09:31:04 -0500
Subject: [PATCH v1 1/3] Skip checking for uselocale on Windows
Windows doesn't have
Please discard this second thread. My mail client seems to have done
something very wrong.
--
Tristan Partin
Neon (https://neon.tech)
are aware of the issue.
Hi Shlok!
Thanks for taking a look. I will check these failures out to see if
I can reproduce.
--
Tristan Partin
Neon (https://neon.tech)
Found this issue during my Fedora 39 upgrade. Tested that uninstalling
openssl still allows the various ssl tests to run and succeed.
--
Tristan Partin
Neon (https://neon.tech)
From d684d6fc1546335804d2ed82ff909991965a61a8 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Tue, 7 Nov 2023 15
On Tue Nov 7, 2023 at 11:53 PM CST, Michael Paquier wrote:
On Tue, Nov 07, 2023 at 04:06:56PM -0600, Tristan Partin wrote:
> Found this issue during my Fedora 39 upgrade. Tested that uninstalling
> openssl still allows the various ssl tests to run and succeed.
Good catch. You are righ
Looks good to me. Thanks for finding this.
--
Tristan Partin
Neon (https://neon.tech)
On Wed Nov 8, 2023 at 2:31 AM CST, Michael Paquier wrote:
On Wed, Nov 08, 2023 at 12:07:49AM -0600, Tristan Partin wrote:
>'with_ssl': ssl_library,
> - 'OPENSSL': openssl.path(),
> + 'OPENSSL': openssl.found() ? openssl.path : '&#x
ry to read flex/bison code. Here are two memory leak
fixes in any case.
--
Tristan Partin
Neon (https://neon.tech)
From af69e1711e87ae96d75814fc83a8588a4bdf7cac Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Wed, 8 Nov 2023 10:53:02 -0600
Subject: [PATCH v1] Patch two memory leaks in ecpg.a
On Wed Nov 8, 2023 at 11:18 AM CST, Michael Meskes wrote:
Am Mittwoch, dem 08.11.2023 um 12:07 -0500 schrieb Tom Lane:
> "Tristan Partin" writes:
> > clang and gcc both now support -fsanitize=address,undefined. These
> > are
> > really useful to me persona
Can you try with Meson v1.2.3?
--
Tristan Partin
Neon (https://neon.tech)
On Thu Nov 9, 2023 at 9:31 AM CST, Nazir Bilal Yavuz wrote:
Hi,
On Thu, 9 Nov 2023 at 18:27, Tristan Partin wrote:
>
> Can you try with Meson v1.2.3?
I tried with Meson v1.2.3 and upstream, both failed with the same error.
Please open a bug in the Meson repository which also mentio
On Thu Nov 9, 2023 at 9:31 AM CST, Nazir Bilal Yavuz wrote:
Hi,
On Thu, 9 Nov 2023 at 18:27, Tristan Partin wrote:
>
> Can you try with Meson v1.2.3?
I tried with Meson v1.2.3 and upstream, both failed with the same error.
An employee at Collabora produced a fix[0]. It might st
On Wed Nov 8, 2023 at 11:52 AM CST, Tom Lane wrote:
"Tristan Partin" writes:
> On Wed Nov 8, 2023 at 11:18 AM CST, Michael Meskes wrote:
>> Agreed, it's not exactly uncommon for tools like ecpg to not worry
>> about memory. After all it gets freed when the p
conditional compilation based on
HAVE_USELOCALE and WIN32.
I would like to propose removing HAVE_USELOCALE, and just have WIN32,
which means that Postgres would require uselocale(3) on anything that
isn't WIN32.
[0]: https://www.postgresql.org/message-id/cwmw5ozbwj10.1yflqwsue5...@neon.tech
--
Tristan Partin
Neon (https://neon.tech)
On Thu Nov 16, 2023 at 8:33 AM CST, Heikki Linnakangas wrote:
On 06/11/2023 19:16, Tristan Partin wrote:
>>> That sounds like a much better solution. Attached you will find a v4
>>> that implements your suggestion. Please let me know if there is
>>> something that I
On Wed Nov 22, 2023 at 3:00 PM CST, Heikki Linnakangas wrote:
On 22/11/2023 19:29, Tristan Partin wrote:
> On Thu Nov 16, 2023 at 8:33 AM CST, Heikki Linnakangas wrote:
>> On 06/11/2023 19:16, Tristan Partin wrote:
>>>>> That sounds like a much better solution. Att
ery supported Postgres version most likely.
[0]: https://github.com/Homebrew/homebrew-core/issues/155651
--
Tristan Partin
Neon (https://neon.tech)
From 672103a67aaf0dae5be6c5adcc5ce19e5b6d7676 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Mon, 27 Nov 2023 11:49:52 -0600
Subject: [PATCH
Here is a v2 which adds back a comment that was not meant to be removed.
--
Tristan Partin
Neon (https://neon.tech)
From 4bcb73eab9ceba950581a890c52820a81134f7e4 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Mon, 27 Nov 2023 11:49:52 -0600
Subject: [PATCH v2] Use BIO_{get,set}_app_data
On Mon Nov 27, 2023 at 5:53 PM CST, Michael Paquier wrote:
On Mon, Nov 27, 2023 at 12:33:49PM -0600, Tristan Partin wrote:
> -#ifndef HAVE_BIO_GET_DATA
> -#define BIO_get_data(bio) (bio->ptr)
> -#define BIO_set_data(bio, data) (bio->ptr = data)
> -#endif
Shouldn't thi
y reason to keep compatibility with what only
worked by accident.
[0]:
https://github.com/openssl/openssl/commit/a3e53d56831adb60d6875297b3339a4251f735d2
--
Tristan Partin
Neon (https://neon.tech)
On Mon Nov 27, 2023 at 7:14 PM CST, Tom Lane wrote:
"Tristan Partin" writes:
> On Mon Nov 27, 2023 at 6:21 PM CST, Tom Lane wrote:
>> What about LibreSSL? In general, I'm not too pleased with just assuming
>> that BIO_get_app_data exists.
> Falling back
patch I sent or adding
support for BoringSSL?
--
Tristan Partin
Neon (https://neon.tech)
How are you guys running the tests? I have PG_TEST_EXTRA=ssl and
everything passes for me. Granted, I am using the Meson build.
--
Tristan Partin
Neon (https://neon.tech)
On Tue Nov 28, 2023 at 9:31 AM CST, Tom Lane wrote:
"Tristan Partin" writes:
> How are you guys running the tests? I have PG_TEST_EXTRA=ssl and
> everything passes for me. Granted, I am using the Meson build.
I'm doing what it says in test/ssl/README:
make check
On Tue Nov 28, 2023 at 9:42 AM CST, Tom Lane wrote:
"Tristan Partin" writes:
> When you say "this" are you referring to the patch I sent or adding
> support for BoringSSL?
I have no interest in supporting BoringSSL. I just replied to
Daniel's comment becaus
On Tue Nov 28, 2023 at 10:06 AM CST, Tom Lane wrote:
"Tristan Partin" writes:
> On Tue Nov 28, 2023 at 9:42 AM CST, Tom Lane wrote:
>> I have no interest in supporting BoringSSL. I just replied to
>> Daniel's comment because it seemed to resolve the last concern
On Tue Nov 28, 2023 at 9:42 AM CST, Tom Lane wrote:
"Tristan Partin" writes:
> When you say "this" are you referring to the patch I sent or adding
> support for BoringSSL?
I have no interest in supporting BoringSSL.
Funnily enough, here[0] is BoringSSL adding
On Wed Nov 29, 2023 at 10:32 AM CST, Tom Lane wrote:
Daniel Gustafsson writes:
> On 29 Nov 2023, at 16:21, Tristan Partin wrote:
>> Funnily enough, here[0] is BoringSSL adding the BIO_{get,set}_app_data()
APIs.
> Still doesn't seem like a good candidate for a postgres TLS l
https://cirrus-ci.com/build/6235510532734976
--
Tristan Partin
Neon (https://neon.tech)
On Thu Nov 23, 2023 at 3:19 AM CST, Heikki Linnakangas wrote:
On 22/11/2023 23:29, Tristan Partin wrote:
> Ha, you're right. I had this working yesterday, but convinced myself it
> didn't. I had a do while loop wrapping the blocking call. Here is a v4,
> which seems to pass
).
[0]: https://www.postgresql.org/message-id/CWTM35CAUKRT.1733OSMXUZW7%40neon.tech
--
Tristan Partin
Neon (https://neon.tech)
who knows Windows will have something to say, but it also might've just
been copy-paste that I didn't realize.
There were a few more XXXs that probably should be figured out before
committing. Though perhaps some of them were already there.
Patches 1-3 seem committable as-is. I only had minor comments on
everything but 7, so after taking a look at those, they could be
committed.
Overall, this seems liked a marked improvement :).
--
Tristan Partin
Neon (https://neon.tech)
On Wed Nov 29, 2023 at 1:42 PM CST, Andres Freund wrote:
Hi,
On 2023-11-29 13:11:23 -0600, Tristan Partin wrote:
> What is our limiting factor on bumping the minimum Meson version?
Old distro versions, particularly ones where the distro just has an older
python. It's one thing to
on the January commitfest if
no one else comes along to review/commit it. This first set of changes
looks good to me.
--
Tristan Partin
Neon (https://neon.tech)
On Thu Nov 30, 2023 at 3:46 PM CST, Andrew Dunstan wrote:
On 2023-11-30 Th 16:00, Tristan Partin wrote:
> On Wed Nov 29, 2023 at 1:42 PM CST, Andres Freund wrote:
>> Hi,
>>
>> On 2023-11-29 13:11:23 -0600, Tristan Partin wrote:
>> > What is our limiting facto
On Fri Dec 1, 2023 at 6:10 AM CST, Heikki Linnakangas wrote:
On 30/11/2023 20:44, Tristan Partin wrote:
> Patches 1-3 seem committable as-is.
Thanks for the review! I'm focusing on patches 1-3 now, and will come
back to the rest after committing 1-3.
There was one test fail
On Fri Dec 1, 2023 at 12:07 PM CST, Tom Lane wrote:
"Tristan Partin" writes:
> On the buildfarm page[0], it would be nice if more than just the
> compiler versions were stated. It would be nice to have all
> build/runtime dependencies listed.
By and large, we've a
rted
versions, but given the lack of complaints, I chose to not backpatch.
Seems like a harmless think to backpatch. It is conceivable that someone
might want to run Valgrind on something other than HEAD.
--
Tristan Partin
Neon (https://neon.tech)
github.com/postgres/postgres/commit/faeedbcefd40bfdf314e048c425b6d9208896d90
[2]: https://github.com/google/sanitizers/wiki/AddressSanitizerFlags
[3]: https://github.com/google/sanitizers/wiki/SanitizerCommonFlags
--
Tristan Partin
Neon (https://neon.tech)
yourself an
indentation.
- if len(targets_info_byname[name]) > 1:
+ if len(targets_info_byname[name]) <= 1:
+ continue
But whatever you want.
--
Tristan Partin
Neon (https://neon.tech)
On Fri Aug 4, 2023 at 5:47 AM CDT, Dmitry Dolgov wrote:
> On Thu, Aug 03, 2023 at 12:23:52PM -0500, Tristan Partin wrote:
>
> This is the first I am learning about clang plugins. Interesting concept.
> Did you give any thought to using libclang instead of a compiler plugin? I
> a
On Wed Jul 12, 2023 at 9:35 AM CDT, Tristan Partin wrote:
On Wed Jul 12, 2023 at 9:31 AM CDT, Peter Eisentraut wrote:
> On 12.07.23 16:23, Tristan Partin wrote:
> > It has come to my attention that STDOUT_FILENO might not be portable and
> > fileno(3) isn't marked as signal-
e it with a pair of ShmemSize
and ShmemInit functions, like all other shared memory structs.
+if (!IsUnderPostmaster)
+{
+Assert(!found);
+memset(ShmemVariableCache, 0, sizeof(VariableCacheData));
+}
+else
+Assert(f
On Mon Dec 4, 2023 at 9:22 AM CST, Peter Eisentraut wrote:
On 01.12.23 23:10, Tristan Partin wrote:
> On Wed Jul 12, 2023 at 9:35 AM CDT, Tristan Partin wrote:
>> On Wed Jul 12, 2023 at 9:31 AM CDT, Peter Eisentraut wrote:
>> > On 12.07.23 16:23, Tristan Partin wrote:
>&g
On Fri Dec 1, 2023 at 12:16 PM CST, Tristan Partin wrote:
On Fri Dec 1, 2023 at 12:07 PM CST, Tom Lane wrote:
> "Tristan Partin" writes:
> > On the buildfarm page[0], it would be nice if more than just the
> > compiler versions were stated. It would be nice to ha
On Mon Dec 4, 2023 at 2:10 PM CST, Tom Lane wrote:
"Tristan Partin" writes:
> On Fri Dec 1, 2023 at 12:16 PM CST, Tristan Partin wrote:
>>> Ok, so what I found is that we still have build farm animals using
>>> Python 3.4, specifically the AIX machines. There wa
On Wed Nov 29, 2023 at 11:48 AM CST, Tristan Partin wrote:
I am not completely in love with the code I have written. Lots of
conditional compilation which makes it hard to read. Looking forward to
another round of review to see what y'all think.
Ok. Here is a patch which just uses sel
The file is only referenced in Meson and MSVC scripts from what I can
tell, and the Meson reference is protected by a Windows check.
--
Tristan Partin
Neon (https://neon.tech)
From bc9ffc7b0b141959a4c2a3f8b731f457ff5825c1 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Tue, 5 Dec 2023 10
not all builds. According to the OpenSSF[0], level
2 is only supposed to impact runtime performance by 0.1%.
[0]:
https://best.openssf.org/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.html#performance-implications
--
Tristan Partin
Neon (https://neon.tech)
f and exit 2 if the output isn't empty by yourself.
--
Tristan Partin
Neon (https://neon.tech)
From 1001252d49a47e660045cee3d2ba5abd87e925d9 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Mon, 11 Dec 2023 17:34:17 -0600
Subject: [PATCH v1] Add --check option to pgindent
The option is a c
On Tue Dec 12, 2023 at 5:47 AM CST, Euler Taveira wrote:
On Tue, Dec 12, 2023, at 7:28 AM, Michael Banck wrote:
> On Tue, Dec 12, 2023 at 11:18:59AM +0100, Daniel Gustafsson wrote:
> > > On 12 Dec 2023, at 01:09, Tristan Partin wrote:
> > >
> > > Not sold
id you mean '-C'?
This confuses run_build.pl into taking the "Linux and sometimes windows"
code path instead of the $using_osx one. I think simplest fix is to
move the $using_osx branch ahead of the heuristic ones, as attached.
Hey Tom,
Was this patch ever committed?
--
Tristan Partin
Neon (https://neon.tech)
1 - 100 of 285 matches
Mail list logo
