On Wed Apr 3, 2024 at 8:32 AM CDT, Jelte Fennema-Nio wrote:
On Tue, 2 Apr 2024 at 16:33, Robert Haas <robertmh...@gmail.com> wrote:
> Committed it, I did. My thanks for working on this issue, I extend.
Looking at the committed version of this patch, the pg_unreachable
calls seemed weird to me. 1 is actually incorrect, thus possibly
resulting in undefined behaviour. And for the other call an imho
better fix would be to remove the now 21 year unused enum variant,
instead of introducing its only reference in the whole codebase.
Attached are two trivial patches, feel free to remove both of the
pg_unreachable calls.
Patches look good. Sorry about causing you to do some work.
--
Tristan Partin
Neon (https://neon.tech)
