Add tablespace tap test to pg_rewind

2019-03-08 Thread Shaoqi Bai
Hi hackers, There is already a databases tap tests in pg_rewind, wonder if there is a need for tablespace tap tests in pg_rewind. Attached is a initial patch from me. Here is a patch for runing pg_rewind, it is very similar to src/bin/pg_rewind/t/002_databases.pl, but there is no master_psql("CR

Fwd: Add tablespace tap test to pg_rewind

2019-03-08 Thread Shaoqi Bai
ffc0dece8dfd.ca...@cybertec.at Backpatch-through: 9.6 From 4280335c4b81aa04b967d93348ccc6874bc9c287 Mon Sep 17 00:00:00 2001 From: Shaoqi Bai Date: Fri, 8 Mar 2019 18:04:20 +0800 Subject: [PATCH] Add tablespace tap test for pg_rewind --- src/bin/pg_rewind/t/006_tablespace.pl | 51 +

Re: Fwd: Add tablespace tap test to pg_rewind

2019-03-11 Thread Shaoqi Bai
Thanks, will work on it as you suggested Add pg_basebackup --T olddir=newdir to support check the consistency of a tablespace created before promotion Add run_test('remote'); On Mon, Mar 11, 2019 at 6:50 AM Michael Paquier wrote: > On Sat, Mar 09, 2019 at 09:09:24AM +0900, Michael Paquier wrote:

Re: Fwd: Add tablespace tap test to pg_rewind

2019-03-19 Thread Shaoqi Bai
On Tue, Mar 12, 2019 at 10:27 AM Michael Paquier wrote: > On Mon, Mar 11, 2019 at 07:49:11PM +0800, Shaoqi Bai wrote: > > Thanks, will work on it as you suggested > > Add pg_basebackup --T olddir=newdir to support check the consistency of a > > tablespace created bef

Re: Fwd: Add tablespace tap test to pg_rewind

2019-03-21 Thread Shaoqi Bai
On Tue, Mar 12, 2019 at 10:27 AM Michael Paquier wrote: > It could be an idea to split the patch in two pieces: > - One patch which refactors the code for the new option in > PostgresNode.pm > - Second patch for the new test with integration in RewindTest.pm. > This should touch different parts o

Re: Fwd: Add tablespace tap test to pg_rewind

2019-03-22 Thread Shaoqi Bai
On Fri, Mar 22, 2019 at 1:34 PM Michael Paquier wrote: > On Thu, Mar 21, 2019 at 11:41:01PM +0800, Shaoqi Bai wrote: > > Have updated the patch doing as you suggested > > + RewindTest::setup_cluster($test_mode, ['-g']); > + RewindTest::start_master(); > >

Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6

2019-04-25 Thread Shaoqi Bai
On Wed, Apr 24, 2019 at 7:55 AM Tom Lane wrote: > Michael Paquier writes: > > On Tue, Apr 23, 2019 at 04:47:19PM -0400, Tom Lane wrote: > >> Is there some precondition you're not mentioning? > > > Hm. In my own init scripts, I create a new database just after > > starting the instance. > > Ah,