stake and did not notice it as it have not
been properly tested. So I decided it would be goo to add test to it before
adding and big patches.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
В письме от 10 апреля 2018 08:55:52 пользователь David Steele написал:
> On 1/25/18 12:27 PM, Nikolay Shaplov wrote:
> > В письме от 25 января 2018 11:29:34 пользователь Tom Lane написал:
> >> Alvaro Herrera writes:
> >>> Tom Lane wrote:
> >>>> We
В письме от четверг, 5 сентября 2019 г. 11:42:27 MSK пользователь Alvaro
Herrera from 2ndQuadrant написал:
> After looking closer once again, I don't like this patch.
>
> I think the FOOBAR_ENUM_DEF defines serve no purpose, other than
> source-code placement next to the enum value definitions.
В Fri, 2 Aug 2019 11:12:35 +1200
Thomas Munro пишет:
> While moving this to the September CF, I noticed this failure:
>
> test reloptions ... FAILED 32 ms
Do you have any idea, how to reproduce this? I tried this patch on
current master, and did not get result you are t
В письме от четверг, 19 сентября 2019 г. 17:32:03 MSK пользователь Michael
Paquier написал:
> > src/test/modules/dummy_index_am directory check" I see a similar
> > failure with "ERROR: unrecognized lock mode: 2139062143". I changed
>
> > that to a PANIC and got a core file containing this sta
В Fri, 20 Sep 2019 20:58:27 +0900
Michael Paquier пишет:
Sorry I am really slow to answer... I hope it is not too late.
> The GUCs are also basically not necessary, as you can just replace the
> various WARNING calls (please don't call elog on anything which can be
> reached by the user!) by lo
В письме от вторник, 24 сентября 2019 г. 9:25:54 MSK пользователь Alvaro
Herrera написал:
> 0003 looks useful, thanks for completing it. I think it would be a good
> idea to test invalid values for each type of reloption too (passing
> floating point to integers, strings to floating point, and s
В Fri, 27 Sep 2019 17:24:49 +0900
Michael Paquier пишет:
> > Looks like some good actionable feedback. I've moved this patch to
> > September, and set it to "Waiting on Author".
>
> The patch is in this state for two months now, so I have switched it
> to "returned with feedback". The latest pa
This thread is a follow up to the thread
https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I've been
trying to remove StdRdOptions
structure and replace it with unique structure for each relation kind.
I've decided to split that patch into smaller parts.
This part adds some
Hi!
This message is follow up to the "Get rid of the StdRdOptions" patch thread:
https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m
I've split patch into even smaller parts and commitfest want each patch in
separate thread. So it is new thread.
The idea of this patch is following: I
Hi! I am starting a new thread as commitfest wants new thread for new patch.
This new thread is a follow up to an https://www.postgresql.org/message-id/
2620882.s52SJui4ql%40x200m thread, where I've been trying to get rid of
StdRdOpions structure, and now I've splitted the patch into smaller part
В письме от пятница, 27 сентября 2019 г. 17:24:49 MSK пользователь Michael
Paquier написал:
> The patch is in this state for two months now, so I have switched it
> to "returned with feedback".
So I've split this patch into even smaller parts, so it would be more easy to
review.
Do not use St
В письме от понедельник, 7 октября 2019 г. 14:57:14 MSK пользователь Michael
Paquier написал:
> On Sun, Oct 06, 2019 at 03:47:46PM +0300, Nikolay Shaplov wrote:
> > This message is follow up to the "Get rid of the StdRdOptions" patch
> > thread: https://www.postgres
В письме от понедельник, 7 октября 2019 г. 18:55:20 MSK пользователь Dent John
написал:
> I like the new approach. And I agree with the ambition — to split out the
> representation from StdRdOptions.
Thanks.
> However, with that change, in the AM’s *options() function, it looks as if
> you coul
В письме от понедельник, 7 октября 2019 г. 12:59:27 MSK пользователь Robert
Haas написал:
> > This thread is a follow up to the thread
> > https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I've
> > been trying to remove StdRdOptions structure and replace it with unique
> > stru
В письме от вторник, 8 октября 2019 г. 16:00:49 MSK пользователь Amit Langote
написал:
> > > > The idea of this patch is following: If you read the code, partitioned
> > > > tables do not have any options (you will not find
> > > > RELOPT_KIND_PARTITIONED
> > > > in boolRelOpts, intRelOpts, realR
В письме от среда, 9 октября 2019 г. 20:26:14 MSK пользователь Dent John
написал:
> I didn’t spot it was an existing pattern.
Sorry, this might be my mistake I should explicitly mention it in the first
place.
> And I agree — making the code uniform will make it easier to evolve in
> future.
>
В Thu, 10 Oct 2019 15:50:05 +0900
Amit Langote пишет:
> > I think it is bad idea to suggest option adder to ad it to
> > StdRdOption, we already have a big mess there. Better if he add it
> > to an new empty structure.
>
> I tend to agree that this improves readability of the reloptions code
> a
В письме от четверг, 10 октября 2019 г. 17:17:30 MSK пользователь Amit Langote
написал:
> I read comments that Tomas left at:
> https://www.postgresql.org/message-id/20190727173841.7ypzo4xuzizvijge%40deve
> lopment
>
> I'd like to join Michael in reiterating one point from Tomas' review.
> I thi
> > I think it is bad idea to suggest option adder to ad it to
> > StdRdOption, we already have a big mess there. Better if he add it
> > to an new empty structure.
>
> I tend to agree that this improves readability of the reloptions code
> a bit.
>
> Some comments on the patch:
>
> How about nam
Hi!
This patch introduce a dummy_index access method module, that does not do any
indexing at all, but allow to test reloptions from inside of access method
extension.
This patch is part of my bigger work on reloptions refactoring.
It came from
https://www.postgresql.org/message-id/2019022006
В письме от среда, 20 февраля 2019 г. 15:08:32 MSK пользователь Michael
Paquier написал:
> > 2.5 May be this src/test/modules dummy index is subject to another patch.
> > So I will start working on it right now, but we will do this work not
> > dependent to any other patches. And just add there
Hi!
In caf626b2 type of vacuum_cost_delay have been switched from int to real,
everywhere, but not in *RelOpts[] arrays.
For some reason it continued to build and work. But I think it is better to
move vacuum_cost_delay from int to real there too...
Patch attached.
PS. As you can see current
В письме от понедельник, 18 марта 2019 г. 3:03:04 MSK пользователь Iwata, Aya
написал:
> Hi Nikolay,
Hi!
Sorry for long delay. Postgres is not my primary work, so sometimes it takes a
while to get to it.
> This patch does not apply.
Oh... Sorry... here goes new version
> Please refer to http://
В письме от понедельник, 18 марта 2019 г. 17:00:24 MSK пользователь Kyotaro
HORIGUCHI написал:
> > So I change status to "Waiting for Author".
> That seems to be a good oppotunity. I have some comments.
>
> rel.h:
> -#define RelationGetToastTupleTarget(relation, defaulttarg) \
> -((relation)
В письме от среда, 20 марта 2019 г. 6:15:38 MSK пользователь Iwata, Aya
написал:
> You told us "big picture" about opclass around the beginning of this thread.
> In my understanding, the purpose of this refactoring is to make reloptions
> more flexible to add opclass. I understand this change may
В письме от четверг, 7 марта 2019 г. 13:09:49 MSK пользователь Chris Travers
написал:
> We maintain an extension (https://github.com/adjust/wltree)
> which has a fixed separator (::) and allows any utf-8 character in the tree.
>
> In our case we currently use our extended tree to store user-def
Hi!
This patch is part of a bigger patch I've offered before
https://www.postgresql.org/message-id/flat/2146419.veIEZdk4E4@x200m#2146419.veIEZdk4E4@x200m
as we agreed I am trying to commit it by smaller bits
This patch raises error if user tries o set or change toast.* option for a
table that doe
В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera написал:
> The new checks around toast table creation look like they belong to a
> completely independent patch also ... the error message there goes
> against message style guidelines also.
Offered toast relation checks as a separa
В письме от 18 января 2018 18:42:01 пользователь Tom Lane написал:
> >> This patch raises error if user tries o set or change toast.* option for
> >> a
> >> table that does not have a TOST relation.
> >
> > I think there is a problem with this idea, which is that the rules for
> > whether or not a
Hi!
While working with my big reloption patch,
https://www.postgresql.org/message-id/flat/2146419.veIEZdk4E4@x200m#2146419.veIEZdk4E4@x200m
I found out, that all relation options of string type in current postgres, are
actually behaving as "enum" type. But each time this behavior is implemented
as
В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera написал:
> I think we should split this in at least two commits,
Added another part for commit:
https://www.postgresql.org/message-id/43332102.S2V5pIjXRx@x200m
This one adds an enum relation option type.
--
Do code for fun.
signat
I have a small fixes for already committed reloption test patch
(https://www.postgresql.org/message-id/2615372.orqtEn8VGB@x200m)
First one is missing tab symbol where it should be.
The second is a comment. "The OIDS option is not stored" is not quite correct.
They are stored, but not as reloptio
В письме от 29 октября 2017 17:08:29 пользователь Nikolay Shaplov написал:
> While merging this commit to my branch, I found two issues that as I think
> needs fixing. Hope this does not require creating new commit request...
To draw more attention to this issue, I've filed it as a
В письме от 23 января 2018 12:03:50 пользователь Peter Eisentraut написал:
> >>> This patch raises error if user tries o set or change toast.* option for
> >>> a table that does not have a TOST relation.
> >
> > There might be a case for raising a warning in this situation,
> > but I would disagr
В письме от 25 января 2018 11:29:34 пользователь Tom Lane написал:
> Alvaro Herrera writes:
> > Tom Lane wrote:
> >> Well, maybe the right answer is to address that. It's clear to me
> >> why that would happen if we store these things as reloptions on the
> >> toast table, but can't they be store
В письме от 9 февраля 2018 18:45:29 пользователь Alvaro Herrera написал:
> If this patch gets in, I wonder if there are any external modules that
> use actual strings. An hypothetical example would be something like a
> SSL cipher list; it needs to be somewhat free-form that an enum would
> not c
В письме от 9 февраля 2018 18:45:29 пользователь Alvaro Herrera написал:
> > 1. I've changed error message from 'Valid values are "XXX", "YYY" and
> > "ZZZ".' to 'Valid values are "XXX", "YYY", "ZZZ".' to make a code a bit
> > simpler. If it is not acceptable, please let me know, I will add "and"
В письме от 9 февраля 2018 18:45:29 пользователь Alvaro Herrera написал:
> Maybe we need some in-core user to verify the string case still works.
> A new module in src/test/modules perhaps?
I've looked attentively in src/test/modules... To properly test all reloptions
hooks for modules wee need
В письме от 15 февраля 2018 12:53:27 пользователь Alvaro Herrera написал:
> > > Maybe we need some in-core user to verify the string case still works.
> > > A new module in src/test/modules perhaps?
> >
> > I've looked attentively in src/test/modules... To properly test all
> > reloptions hooks f
В письме от пятница, 1 ноября 2019 г. 13:29:58 MSK пользователь Peter
Eisentraut написал:
> Committed.
>
> I simplified the parentheses by one level from your patch.
Thank you!
--
Software Developer: https://www.upwork.com/freelancers/~014a87e140ff02c0da
Body-oriented Therapist: https://vk.co
В письме от среда, 23 октября 2019 г. 11:59:45 MSK пользователь Amit Langote
написал:
> Sorry for the late reply.
Same apologies from my side. Get decent time-slot for postgres dev only now.
> I looked atthe v2 patch and noticed a typo:
>
> + * Binary representation of relation options fo
В письме от среда, 13 ноября 2019 г. 16:05:20 MSK пользователь Michael Paquier
написал:
Guys! Sorry for being away for so long. I did not have much opportunities to
pay my attention to postgres recently.
Thank you for introducing build_reloptions function. It is approximately the
direction I w
В письме от среда, 13 ноября 2019 г. 16:30:29 MSK пользователь Michael Paquier
написал:
> On Tue, Nov 12, 2019 at 01:50:03PM +0900, Michael Paquier wrote:
> > We have been through great length to have build_reloptions, so
> > wouldn't it be better to also have this code path do so? Sure you
> > n
В письме от четверг, 14 ноября 2019 г. 16:50:18 MSK пользователь Michael
Paquier написал:
> > I've changed the patch to use build_reloptions function and again propose
> > it to the commitfest.
>
> Thanks for the new patch. I have not reviewed the patch in details,
> but I have a small comment.
В письме от среда, 20 ноября 2019 г. 16:44:18 MSK пользователь Michael Paquier
написал:
> > It seems to me that if the plan is to have one option structure for
> > each index AM, which has actually the advantage to reduce the bloat of
> > each relcache entry currently relying on StdRdOptions, the
In the thread
https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m
I've suggested to split one big StdRdOption that is used for options storage
into into Options structures individual for each relkind and each relam
That patch have been split into smaller parts, most of them were alrea
real, boolean and string options.
+do_test_reloption_string2 enables test output for another string option. We need
+second string option, because a) string reloption implementation is a bit
+tricky, and it is better to check that second value works as well; b) better to
+check both cases: string opti
В письме от воскресенье, 24 февраля 2019 г. 14:31:55 MSK пользователь Dmitry
Belyavsky написал:
Hi! Am back here again.
I've been thinking about this patch a while... Come to some conclusions and
wrote some examples...
First I came to idea that the best way to simplify the code is change the
В письме от 16 октября 2018 19:17:20 пользователь Andres Freund написал:
> Hi,
>
> On 2018-10-16 22:05:28 -0400, James Coleman wrote:
> > > I don't think it's entirely safe to do so for invisible rows. The toast
> > > references could be reused, constraints be violated, etc. So while I
> > > cou
В письме от 17 октября 2018 12:36:54 пользователь James Coleman написал:
> > I did compleatly got the question... The question is it safe to split
> > tuple
> > record into array of raw bytea? It is quite safe from my point of view.
> > We
> > use only data that is inside the tuple, and info from p
В письме от 12 сентября 2018 21:40:49 пользователь Nikolay Shaplov написал:
> > As you mentioned in previous mail, you prefer to keep enum and
> > relopt_enum_element_definition array in the same .h file. I'm not sure,
> > but I think it is done to keep everything relat
В письме от 1 ноября 2018 11:10:14 пользователь Tom Lane написал:
> >>> I see you lost the Oxford comma:
> >>>
> >>> -DETAIL: Valid values are "on", "off", and "auto".
> >>> +DETAIL: Valid values are "auto", "on" and "off".
> >>>
> >>> Please put these back.
> >>
> >> Actually that's me who h
В письме от 1 ноября 2018 18:26:20 пользователь Nikolay Shaplov написал:
> In this case the only solution I can see is
>
> DETAIL: Valid values are: "value1", "value2", "value3".
>
> Where list '"value1", "value2", &qu
В письме от 15 ноября 2018 18:26:43 пользователь Nikita Glukhov написал:
> >> But since it is now "Rejected with feedback", let's wait till autumn.
> >
> > We don't want to wait that long. But now we only need to сome to an
> > agreement
> > about CREATE INDEX syntax and where to store the opcla
В письме от 2 октября 2018 13:46:13 пользователь Michael Paquier написал:
> On Fri, Sep 14, 2018 at 09:30:25PM +0300, Nikolay Shaplov wrote:
> > BTW this commit shows why do this patch is important: 857f9c36 adds new
> > option for b-tree indexes. But thanks to the StdRdOpti
В письме от 15 ноября 2018 18:26:43 пользователь Nikita Glukhov написал:
> Attached 2nd version of the patches. Nothing has changed since March,
> this is just a rebased version.
>
> CREATE INDEX syntax and parameters storage method still need discussion.
I've played around a bit with you patch a
В письме от 10 ноября 2018 09:14:19 пользователь Michael Paquier написал:
> > Nice cleanup. Also, I like the ability to enable/control more types of
> > tests easily from the Makefile. What are the next steps for this
> > patch?
>
> Thanks. It seems to me that a complete review is still in order
В письме от 21 ноября 2018 09:39:53 пользователь Michael Paquier написал:
> > For me name "output_iso" means nothing. iso is something about CD/DVD or
> > about standards. I would not guess that iso stands for isolation if I did
> > not know it already. isolation_output is more sensible: I have he
В письме от 23 ноября 2018 09:43:45 пользователь Michael Paquier написал:
> > So, I continued exploring your patch. First I carefully read changes in
> > pgxs.mk. The only part of it I did not understand is
> >
> > .PHONY: submake
> >
> > -submake:
> > ifndef PGXS
> >
> > +submake:
> > +ifdef
В письме от 26 ноября 2018 08:53:20 Вы написали:
> > I've carefully read this documentation. And did not get clear explanation
> > of what is the true purpose of PGXS environment variable. Only
> >
> > "The last three lines should always be the same. Earlier in the file, you
> > assign variables
This is part or my bigger patch
https://www.postgresql.org/message-id/flat/2146419.veIEZdk4E4@x200m#2146419.veIEZdk4E4@x200m
we've decided to
commit by smaller parts.
Now in postgres an StdRdOptions structure is used as binary represenations of
reloptions for heap, toast, and some indexes. It h
В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera написал:
> I think we should split this in at least two commits,
I've added a third part of this patch to commitfest:
https://www.postgresql.org/message-id/flat/2083183.Rn7qOxG4Ov@x200m#2083183.Rn7qOxG4Ov@x200m
To finally commit the
analogous work was already done by Nikolay Shaplov two years ago:
> https://www.postgresql.org/message-id/5213596.TqFRiqmCTe%40nataraj-amd64
> But this patches are not based on it, although they are very similar.
Hi!
You know, I am still working on this issue.
When I started to work on it,
В письме от 1 марта 2018 23:02:20 пользователь Oleg Bartunov написал:
> > 2. Your patch does not provide any example of your new tool usage. In my
> > prototype patch I've shown the implementation of opclass options for
> > intarray. May be you should do the same. (Use my example it will be more
>
В письме от 1 марта 2018 16:15:32 пользователь Andres Freund написал:
> > This is part or my bigger patch
> > https://www.postgresql.org/message-id/flat/2146419.veIEZdk4E4@x200m#21464
> > 19.veIEZdk4E4@x200m we've decided to commit by smaller parts.
>
> I've not read that thread. Is this supposed
В письме от 1 марта 2018 19:11:05 пользователь Nikita Glukhov написал:
> Hi.
>
> I have refactored patch by introducing new struct relop_enum_element to make
> it possible to use existing C-enum values in option's definition. So,
> additional enum GIST_OPTION_BUFFERING_XXX was removed.
Hi! I've i
В письме от 1 марта 2018 14:47:35 пользователь Alvaro Herrera написал:
> I see you lost the Oxford comma:
>
> -DETAIL: Valid values are "on", "off", and "auto".
> +DETAIL: Valid values are "auto", "on" and "off".
>
> Please put these back.
Actually that's me who have lost it. The code with ox
В письме от 2 марта 2018 11:27:49 пользователь Andres Freund написал:
> > Since I get a really big patch as a result, it was decided to commit it in
> > parts.
>
> I get that, but I strongly suggest not creating 10 loosely related
> threads, but keeping it as a patch series in one thread. It's re
ns to run conversion, and run the,
in fuzzer.
My colleagues (they will come here shortly) have narrowed down this query to
SELECT E'\n"\\u0"'::jsonb;
and says that is crashes even in utf8 locale.
They also have a preliminary version of patch to fix it. They will tell
no "[]" in the path to the source, everything is OK.
It would be OK for me, if it still does not work. But I would appreciate at
least proper error message there (or at configure step), this would save time,
for figuring out, why it suddenly stopped working.
--
Nikolay Shaplov aka Nata
will be total mess with two different options mechanisms working in the
same time, but this might be much more easy to review. When we are done with
the first step, we can change the rest.
If this will help to finally include patch into postgres, I can do it. Will
that help you to review?
-
nconsistency.
> I'm not seeing any reasonable way to split this patch in smaller ones.
Actually me neither. Not a good one anyway.
But if somebody really need it to be split, it can be done that way.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
signature.asc
Description: This is a digitally signed message part.
A new version of the patch.
Autovacuum options were extended in b07642db
So I added that options to the current patch.diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c
index e136116..55bd1ec 100644
--- a/src/backend/access/common/reloptions.c
+++ b/src/ba
do now.
2. This behaviour is reasonable. DB User can fix problem without updating
pg_class, having rights to change his own table.
3. Better to get test alarm, if this behavior is accidentally changed.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:na
of thinking is acceptable,
please let me know, I will set myself as a reviewer and will dig further into
the code.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
signature.asc
Description: This is a digitally signed message part.
better
somehow narrow it to one ugly print... Print "ok %-5i"|"not ok %-5i" to
buffer first, and then have one "%s%-*s %8.0f ms%s\n" print or something like
that...
I am not strongly insisting on that, but I feel strong urge to remove code
duplication h
um_parallel and fast_default)
I guess the intention was to align them too...
As for the rest: I see no other problems in the code, and consider it should
be passed to commiter (or may be more experienced reviewer)
> > On 24 Nov 2022, at 20:32, Andres Freund wrote:
> >
>
88 ms
ok 13 types.float8 139 ms
ok 14 types.bit165 ms
ok 15 types.numeric 1065 ms
but this does not seems very realistic in the current code bas
В письме от понедельник, 28 ноября 2022 г. 21:28:48 MSK пользователь Andres
Freund написал:
> On 2022-11-28 14:13:16 +0100, Daniel Gustafsson wrote:
> > > On 27 Nov 2022, at 11:22, Nikolay Shaplov wrote:
> > > В письме от суббота, 26 ноября 2022 г. 23:35:45 MS
it.
Guys sorry, I am totally unable to do just anything this month... Do not have
spare resources to switch my attention to anything even this simple...
Hope, next month will be better... And I will try to do some more reviewing of
other patches...
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
signature.asc
Description: This is a digitally signed message part.
r. Testing and coauthoring will also be
apriciated.
My original big patch, I gave you link to, have been split into several parts.
The last minor part, that should be commit in advance, and have not been
commit yet is https://commitfest.postgresql.org/33/2370/
If you join as a reviewer this would be splendid! :-)
--
Nikolay Shaplov
dh...@nataraj.su (e-mail, jabber)
@dhyan:nataraj.su (matrix)
sion method chosen by user, and may be later
extend it with another byte of compression method bits, if it is needed.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
signature.asc
Description: This is a digitally signed message part.
became
useful for other solutions. Encryption was just first example that came in my
mind. Robert Haas has another example for compression method optimized for
certain data type. So it is good if you can have method of your own.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres P
s refactoring,
I am also was strongly advised to commit things chopped into smaller parts,
when possible. This test can be commit separately so I am doing it.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
signature.asc
Description: This i
В письме от четверг, 30 июня 2022 г. 06:47:48 MSK пользователь Nikolay Shaplov
написал:
> Hi! I am surely feel this patch is important. I have bigger patch
> https://commitfest.postgresql.org/38/3536/ and this test makes sense as a
> part of big work of options refactoring,
>
>
table
AM options is one of my next goals, as soon as this patch is commit.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
signature.asc
Description: This is a digitally signed message part.
ster` branch as well and
> doesn't depend on the platform.
>
> Although the bug is easy to fix for this particular case (see the
> patch) I'm not sure if this solution is general enough. E.g. is there
> something that generally prevents pg_mblen() from doing out of bound
>
any cases that are not
> problematic already.
>
> * Continue to allow non-ASCII values, but change charin/charout,
> char_text, etc so that the external representation is encoding-safe
> (perhaps make it an octal or decimal number).
This will give us steady #1 for ascii_char, and deprecation and removal of
"char" later on.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
signature.asc
Description: This is a digitally signed message part.
eanup", RELOPT_TYPE_ENUM,
in src/backend/access/common/reloptions.c
This change should be done in 3499df0d
But current implementation of reloptions is very error prone , and it is very
easy to miss this part.
--
Nikolay Shaplov
dh...@nataraj.su (e-mail, jabber)
@dhyan:nataraj.su (matrix)
Hi!
Let me join the review process.
I am no expert in execution plans, so there would not be much help in doing
even better optimization. But I can read the code, as a person who is not
familiar
with this area and help making it clear even to a person like me.
So, I am reading v25-0001-Transf
Hi!
Let me join the review process.
I am no expert in execution plans, so there would not be much help in doing
even better optimization. But I can read the code, as a person who is not
familiar
with this area and help making it clear even to a person like me.
So, I am reading v25-0001-Transf
В письме от понедельник, 24 июня 2024 г. 23:51:56 MSK пользователь Nikolay
Shaplov написал:
So, I continue reading the patch.
I see there is `entries` variable in the code, that is the list of
`RestrictInfo` objects and `entry` that is `OrClauseGroup` object.
This naming is quite misguiding
these checks into parts (compiler optimizer should
take care about overhead) and give each part a sane explanation.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
signature.asc
Description: This is a digitally signed message part.
В письме от четверг, 2 июля 2020 г. 17:15:13 MSK пользователь Daniel
Gustafsson написал:
> > A new version of the patch.
> > Autovacuum options were extended in b07642db
> >
> > So I added that options to the current patch.
>
> The heapam.c hunk in this version fails to apply to HEAD, can you p
В письме от четверг, 17 января 2019 г. 20:33:06 MSK пользователь Alvaro
Herrera написал:
> You introduced new macros IsHeapRelation and IsViewRelation, but I don't
> want to introduce such API. Such things have been heavily contested and
> I don't to have one more thing to worry about for this p
В письме от вторник, 29 января 2019 г. 20:43:07 MSK пользователь Dmitry
Belyavsky написал:
> Please find attached the patch extending the sets of symbols allowed in
> ltree labels. The patch introduces 2 variants of escaping symbols, via
> backslashing separate symbols and via quoting the labels
В письме от среда, 20 февраля 2019 г. 15:08:32 MSK пользователь Michael
Paquier написал:
> On Sun, Jan 06, 2019 at 06:28:11PM +0300, Nikolay Shaplov wrote:
> > Actually I am not satisfied with it too... That is why I started that
> > bigger reloptions refactoring work. So for now I
В письме от вторник, 29 января 2019 г. 20:43:07 MSK пользователь Dmitry
Belyavsky написал:
> Dear all,
>
> Please find attached the patch extending the sets of symbols allowed in
> ltree labels. The patch introduces 2 variants of escaping symbols, via
> backslashing separate symbols and via quoti
Hi!
I'd like to propose a small patch for make_ctags script. It checks if ctags
utility is intalled or not. If not it reports an error and advises to install
ctags.
This will make life of a person that uses ctags first time in his life a bit
easier.
I use command -v to detect if ctags command
1 - 100 of 149 matches
Mail list logo
