Re: Let's make PostgreSQL multi-threaded

the prospect of fairly modest advantages. The risk to reward doesn't look great. That's my initial reaction. I could be convinced otherwise. I read through the thread thus far, and Andrew's response is the one that best aligns with my reaction. -- Joe Conway PostgreSQL Co

Re: Inconsistent results with libc sorting on Windows

is disabled. This is a wild shot in the dark, but I wonder if somehow the locale is being initialized (i.e. setlocale) differently in the parallel workers than the backend due to some Windows specific behavior differences? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases

Re: Order changes in PG16 since ICU introduction

lation, even though pg_collation.collprovider='i' To me it's neither desirable nor necessary that a collation that has collprovider='i' is diverted to non-ICU semantics. This discussion makes me wonder (though probably too late for the v16 cycle) if we shouldn't treat

Re: Order changes in PG16 since ICU introduction

On 6/6/23 15:15, Jeff Davis wrote: On Tue, 2023-06-06 at 14:11 -0400, Joe Conway wrote: This discussion makes me wonder (though probably too late for the v16 cycle) if we shouldn't treat "C" and "POSIX" locales to be a third provider, something like "internal&qu

Re: Order changes in PG16 since ICU introduction

hen it does not behave like an ICU collation, even though pg_collation.collprovider='i' To me it's neither desirable nor necessary that a collation that has collprovider='i' is diverted to non-ICU semantics. It's not very principled, but it matches what libc do

Re: pg_collation.collversion for C.UTF-8

nk this should be (a). However we should also clearly document that the semantics of such is provider/OS dependent and therefore may not be what is expected/desired. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Order changes in PG16 since ICU introduction

"internal" made more sense. Or perhaps "builtin" or "postgresql". Either OK by me Same here -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Inconsistent results with libc sorting on Windows

created libc collations that can be used with UTF-8 are affected, plus the default collation (French_France.1252 in my case). Wow, that sounds pretty horrid -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Let's make PostgreSQL multi-threaded

from where we are will be enormous. I seriously doubt that the net benefits could justify that work, no matter how long you want to look forward. It's not really significantly different from "let's rewrite the server in C++/Rust/$latest_hotness". Agreed. -- Joe Conway Postgre

Re: Order changes in PG16 since ICU introduction

UTF-8" explicitly as some distributions do, then use it. If the provider has no such thing, throw an error. Somewhere we should document that "C.UTF-8" from the provider might not be as stable or working as they expect. -- Joe Conway PostgreSQL Contributors Team RDS Open Source

Re: Order changes in PG16 since ICU introduction

On 6/8/23 17:15, Jeff Davis wrote: On Wed, 2023-06-07 at 20:52 -0400, Joe Conway wrote: If the provider has no such thing, throw an error. Just to be clear, that implies that users (and buildfarm members) with LANG=C.UTF-8 in their environment would not be able to run a plain "initdb -D

Re: git.postgresql.org seems to be down

On 6/8/23 20:02, Jaime Casanova wrote: Hi, Someone made https://git.postgresql.org/ depressed After not being able to pull, I dropped and tried to clone again: Try now -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Cleaning up threading code

uctor that I missed? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

(moving to hackers) On 6/12/23 05:13, Heikki Linnakangas wrote: On 10/06/2023 22:28, Joe Conway wrote: On 6/10/23 15:07, Joe Conway wrote: On 6/10/23 14:42, Tom Lane wrote: Joe Conway writes: 5/ The attached fixes the issue for me on pg10 and passes check-world. Comments? The call in

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

On 6/12/23 10:44, Joe Conway wrote: 1/ how do we fix the misbehavior reported due to libperl in existing stable branches I was mostly trying to concentrate on #1, but 2 & 3 are worthy of discussion. Hmm, browsing through the perl source I came across a reference to this (from h

Re: [17] collation provider "builtin"

semantics; therefore they need no version and indexes are not at risk of corruption. See previous discussion[1]. I haven't studied the details yet but +1 for this idea. It models what we are actually doing. +1 agreed -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

On 6/12/23 17:28, Joe Conway wrote: On 6/12/23 10:44, Joe Conway wrote: 1/ how do we fix the misbehavior reported due to libperl in existing stable branches I was mostly trying to concentrate on #1, but 2 & 3 are worthy of discussion. Hmm, browsing through the perl source I came acro

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

On 6/19/23 19:30, Heikki Linnakangas wrote: On 18/06/2023 21:27, Joe Conway wrote: I have proposed a targeted fix that I believe is safe to backpatch -- attached. IIUC, Tom was +1, but Heikki was looking for a more general solution. My issue with the more general solution is that it will

Re: EBCDIC sorting as a use case for ICU rules

oking over-quoted contents. I'm open to suggestions on whether this EBCDIC example is worth being in the doc in some form or putting this in the wiki would be good enough. I would definitely favor adding to the docs, but no idea how to deal with the length issue. -- Joe Conway PostgreSQL Co

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

On 6/22/23 03:26, Heikki Linnakangas wrote: On 21/06/2023 01:02, Joe Conway wrote: On 6/19/23 19:30, Heikki Linnakangas wrote: I think we should call "uselocale(LC_GLOBAL_LOCALE)" immediately after returning from the perl interpreter, instead of before setlocale() calls, if w

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

d to the CF is still needed. 3/ I believe it is probably the right way to go for pg17+, but I would love to hear opinions from Jeff Davis, Peter Eisentraut, and/or Thomas Munroe (the locale code "usual suspects" ;-)), and others, about that. -- Joe Conway PostgreSQL Contributors Team

RFC: pg_stat_logmsg

| 2 ... 8<-- Part of the thinking is that people with fleets of postgres instances can use this to scan for various errors that they care about. Additionally it would be useful to look for "should not happen" errors. I will register this in the July CF and will a

Re: RFC: pg_stat_logmsg

On 6/30/23 23:20, Pavel Stehule wrote: so 1. 7. 2023 v 1:57 odesílatel Joe Conway <mailto:m...@joeconway.com>> napsal: Part of the thinking is that people with fleets of postgres instances can use this to scan for various errors that they care about. Additionally it would

Re: Optionally using a better backtrace library?

straightforward to add support for other object file and debugging formats. The state I currently have is very hacky, but if there's interest in upstreaming something like this, I could clean it up. +1 Seems useful! -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Ser

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

On 7/3/23 12:17, Tristan Partin wrote: The Reply-To header in your email is pointing at joe@cd, fyi. Pretty strange. I noticed that -- it happened only the one time, and I am not sure why. Seems fine now though. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

On 7/3/23 12:25, Tristan Partin wrote: On Sat Jun 24, 2023 at 8:09 AM CDT, Joe Conway wrote: Although I have not looked yet, presumably we could have similar problems with plpython. I would like to get agreement on this approach against plperl before diving into that though. Thoughts? I

Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?

On 8/21/24 09:01, Peter Eisentraut wrote: On 07.08.24 15:49, Daniel Gustafsson wrote: On 5 Aug 2024, at 15:36, Joe Conway wrote: It would not shock me to see complaints from others after we rip out support for 1.0.2, but maybe not ¯\_(ツ)_/¯ I think it's highly likely that we wil

Re: how to log into commitfest.postgresql.org and begin review patch

off period expedited. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: allowing extensions to control planner behavior

exes by initial vowels is definitely silly. On the other, I can see how it might be useful for an extension to exclude indexes based on a regex match of the index name or something similar, at least for testing. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: CI, macports, darwin version problems

On 9/8/24 16:55, Thomas Munro wrote: On Sat, Aug 3, 2024 at 12:07 AM Joe Conway wrote: I tried making this run like a service using launchctl, but that was giving the permissions errors. I finally gave up trying to figure it out and just accepted that I need to manually start the script

Re: CI, macports, darwin version problems

On 9/12/24 02:05, Thomas Munro wrote: On Tue, Sep 10, 2024 at 3:04 PM Thomas Munro wrote: On Mon, Sep 9, 2024 at 1:37 PM Joe Conway wrote: Seems the mounted drive got unmounted somehow ¯\_(ツ)_/¯ Please check it out and let me know if it is working properly now. Looks good, thanks

Re: CI, macports, darwin version problems

that image. I could try this experiment again if Joe could see a way to free up some disk space. Hmmm, sorry, will take a look now -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: CI, macports, darwin version problems

On 7/16/24 08:28, Joe Conway wrote: On 7/16/24 00:34, Thomas Munro wrote: temporarily disabled that machine from the pool and click the re-run button, and it failed[2] on jc-m2-1: "Error: The operation couldn’t be completed. No space left on device" after a long period during wh

Re: CI, macports, darwin version problems

On 7/16/24 11:44, Andres Freund wrote: hi, On 2024-07-16 09:38:21 -0400, Joe Conway wrote: On 7/16/24 08:28, Joe Conway wrote: > On 7/16/24 00:34, Thomas Munro wrote: > > temporarily disabled that machine from the pool and click the re-run > > button, and it failed[2] on jc-m2

Re: [18] Policy on IMMUTABLE functions and Unicode updates

, and allow those to be used like we do IMMUTABLE except with appropriate warning labels. E.g. something ("STABLE_VERSION"?) to mean "forever within a major version lifetime" and something ("STABLE_SYSTEM?") to mean "as long as you don't upgrade your OS". -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: [18] Policy on IMMUTABLE functions and Unicode updates

On 7/16/24 15:33, David G. Johnston wrote: On Tue, Jul 16, 2024 at 11:57 AM Joe Conway <mailto:m...@joeconway.com>> wrote: > There are two alternative philosophies: > > A. By choosing to use a Unicode-based function, the user has opted in > to

Re: [18] Policy on IMMUTABLE functions and Unicode updates

On 7/16/24 16:16, Tom Lane wrote: Joe Conway writes: So you are proposing we add STATIC to VOLATILE/STABLE/IMMUTABLE (in the third position before IMMUTABLE), give it IMMUTABLE semantics, mark builtin functions that deserve it, and document with suitable caution statements? What is the

Re: RFC: pg_stat_logmsg

. And it'll be confusing to have a mix of old/new line numbers. Agreed. I am going to try hard to get back to this sooner rather than later, but realistically that might be in time for the September commitfest rather than during this one. -- Joe Conway PostgreSQL Contributors Team RD

Re: RFC: pg_stat_logmsg

lecmds.c. I think including version in the key makes most sense. Also do we even have a mechanism to grab the commit sha in running code? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: CI, macports, darwin version problems

On 7/17/24 13:01, Andres Freund wrote: On 2024-07-16 12:12:37 -0400, Joe Conway wrote: > It's possible you have some old images stored as your user, check > "tart list" for both users. Hmm, this is not the easiest ever to parse for me... Unfortunately due to the wrap

Re: CI, macports, darwin version problems

On 7/17/24 16:41, Andres Freund wrote: Hi, On 2024-07-17 13:20:06 -0400, Joe Conway wrote: > > Or maybe simpler -- how do people typically add storage to a mac mini? I > > don't mind buying an external disk or whatever. > > That I do not know, not a mac person at all..

Re: CI, macports, darwin version problems

On 7/18/24 04:12, Nazir Bilal Yavuz wrote: Hi, On Thu, 18 Jul 2024 at 07:40, Thomas Munro wrote: On Thu, Jul 18, 2024 at 9:58 AM Joe Conway wrote: > On 7/17/24 16:41, Andres Freund wrote: > > Does "tart pull ghcr.io/cirruslabs/macos-runner:sonoma" as the CI user > &g

Re: CI, macports, darwin version problems

On 7/18/24 07:55, Joe Conway wrote: On 7/18/24 04:12, Nazir Bilal Yavuz wrote: Could it be pulling the ''macos-runner:sonoma' image on every run? Or perhaps since this was the first run it simply needed to pull the image for the first time? The scheduling timing (21:24) looks

Re: CI, macports, darwin version problems

On 7/18/24 08:55, Nazir Bilal Yavuz wrote: Hi, On Thu, 18 Jul 2024 at 15:00, Joe Conway wrote: On 7/18/24 07:55, Joe Conway wrote: > On 7/18/24 04:12, Nazir Bilal Yavuz wrote: >> Could it be pulling the ''macos-runner:sonoma' image on every run? > > Or perhaps s

Re: CI, macports, darwin version problems

On 7/18/24 10:23, Nazir Bilal Yavuz wrote: On Thu, 18 Jul 2024 at 17:01, Joe Conway wrote: So perhaps I am back to needing more storage... You might not need more storage. Thomas knows better, but AFAIU, CFBot will pull only sonoma images after the patch in this thread gets merged. And your

Re: CI, macports, darwin version problems

On 7/18/24 10:33, Joe Conway wrote: On 7/18/24 10:23, Nazir Bilal Yavuz wrote: On Thu, 18 Jul 2024 at 17:01, Joe Conway wrote: So perhaps I am back to needing more storage... You might not need more storage. Thomas knows better, but AFAIU, CFBot will pull only sonoma images after the patch

Re: CI, macports, darwin version problems

On 7/21/24 16:15, Joe Conway wrote: On 7/18/24 10:33, Joe Conway wrote: On 7/18/24 10:23, Nazir Bilal Yavuz wrote: On Thu, 18 Jul 2024 at 17:01, Joe Conway wrote: So perhaps I am back to needing more storage... You might not need more storage. Thomas knows better, but AFAIU, CFBot will

Re: CI, macports, darwin version problems

On 7/21/24 17:26, Thomas Munro wrote: On Mon, Jul 22, 2024 at 8:34 AM Joe Conway wrote: Hmmm, maybe nevermind? I rebooted the mac mini and now it seems to be working. Maybe someone can confirm. There ought to be plenty of space available for sonoma and ventura at the same time now. Thanks

Re: CI, macports, darwin version problems

e stuff removed the there is enough space? I guess if all else fails I will have to get the mac mini with more built in storage in order to accommodate sonoma. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: [18] Policy on IMMUTABLE functions and Unicode updates

I don't know to what extent doing so would satisfy Noah's concern; but if it would do so I'd be happy with that answer. I came to the same conclusion. I think someone mentioned somewhere on this thread that other databases support multiple Unicode versions. I think we need to figu

Re: Built-in CTYPE provider

rent state is ok", and +1 on "current state is ok with agreement on what to do in 18" -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Convert sepgsql tests to TAP

ly good tool on RHEL variants, but I don't think many people use it on anything else. As Tom says, perhaps there are a few wizards out there though... -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: CI, macports, darwin version problems

On 7/23/24 10:44, Joe Conway wrote: I guess if all else fails I will have to get the mac mini with more built in storage in order to accommodate sonoma. I *think* I finally have it in a good place. I replaced the nvme enclosure that I bought the other day (which had a 10G interface speed

Re: can we mark upper/lower/textlike functions leakproof?

ful, but I know of users that would accept that tradeoff in order to get better performance and security on their production workloads. Or in some cases (e.g. PASSWORD) just better security. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: can we mark upper/lower/textlike functions leakproof?

ime someone drops a bunch of new code in here. I still maintain that there is a whole host of users that would accept the risk of side channel attacks via existence of an error or not, if they could only be sure nothing sensitive leaks directly into the logs or to the clients. We should give

Re: can we mark upper/lower/textlike functions leakproof?

On 7/31/24 16:10, Robert Haas wrote: On Wed, Jul 31, 2024 at 2:43 PM Joe Conway wrote: I still maintain that there is a whole host of users that would accept the risk of side channel attacks via existence of an error or not, if they could only be sure nothing sensitive leaks directly into the

Re: can we mark upper/lower/textlike functions leakproof?

On 8/1/24 07:17, Laurenz Albe wrote: On Wed, 2024-07-31 at 14:43 -0400, Joe Conway wrote: I still maintain that there is a whole host of users that would accept the risk of side channel attacks via existence of an error or not, if they could only be sure nothing sensitive leaks directly into

Re: can we mark upper/lower/textlike functions leakproof?

On 8/1/24 07:57, Robert Haas wrote: On Wed, Jul 31, 2024 at 4:42 PM Joe Conway wrote: You are assuming that everyone allows direct logins with the ability to create procedures. Plenty don't. Well, if you can send queries, then you can do the same thing, driven by client-side logic.

Re: can we mark upper/lower/textlike functions leakproof?

of attribute entirely and pushes down anything that merits being pushed? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: can we mark upper/lower/textlike functions leakproof?

On 8/2/24 11:07, Tom Lane wrote: Joe Conway writes: Hmmm, and then have "leakproof_mode" = strict/lax/off where 'strict' is current behavior, 'lax' allows the 'maybe's to get pushed down, and 'off' ignores the leakproof attribute entirely

Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?

able until July 2028[1] which means many people will continue to use it. Joe [1] https://www.redhat.com/en/blog/announcing-4-years-extended-life-cycle-support-els-red-hat-enterprise-linux-7 -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?

On 8/5/24 09:14, Tom Lane wrote: Joe Conway writes: I know I am way late to this thread, and I have only tried a cursory skim of it given the length, but have we made any kind of announcement (packagers at least?) that we intend to not support Postgres 18 with ssl on RHEL 7.9 and derivatives

Re: Remaining dependency on setlocale()

but maybe it matters for some? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Remaining dependency on setlocale()

um_l, isalpha_l, isascii_l, isblank_l, iscntrl_l, isdigit_l, isgraph_l, islower_l, isprint_l, ispunct_l, isspace_l, isupper_l, isxdigit_l -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: gitmaster server problem?

oblem found and fixed about an hour ago. Sorry for the interruption. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: gitmaster server problem?

On 8/19/24 05:04, Jelte Fennema-Nio wrote: On Sat, 17 Aug 2024 at 22:05, Joe Conway wrote: Just to close this out -- problem found and fixed about an hour ago. Sorry for the interruption. Whatever the problem was it seems to have returned What specifically? I am not seeing anything at the

Re: gitmaster server problem?

or is helpful (although I doubt it): Error 503 Backend fetch failed Backend fetch failed Guru Meditation: XID: 1030914118 I am not seeing any errors here. nagios monitoring is showing an ipv6 error though. Not the same issue as yesterday. -- Joe Conway PostgreSQL Contributors Team RDS Open Sou

Re: repeat() function, CHECK_FOR_INTERRUPTS(), and unlikely()

On 5/28/20 1:23 PM, Joe Conway wrote: > On 5/27/20 3:29 AM, Michael Paquier wrote: >>> I think that each of those tests should have a separate unlikely() marker, >>> since the whole point here is that we don't expect either of those tests >>> to

Re: repeat() function, CHECK_FOR_INTERRUPTS(), and unlikely()

On 6/4/20 5:20 PM, Alvaro Herrera wrote: > On 2020-May-28, Joe Conway wrote: > >> I backpatched and pushed the changes to the repeat() function. Any other >> opinions regarding backpatch of the unlikely() addition to >> CHECK_FOR_INTERRUPTS()? > > We don't

Re: Recording test runtimes with the buildfarm

On 6/10/20 6:00 PM, Andres Freund wrote: > On June 10, 2020 2:13:51 PM PDT, David Rowley wrote: >>On Thu, 11 Jun 2020 at 02:13, Tom Lane wrote: >>> I have in the past scraped the latter results and tried to make sense >>of >>> them. They are *mighty* noisy, even when considering just one animal

Re: Building PostgreSQL extensions on Windows

On 6/11/20 6:42 PM, David Rowley wrote: > I've heard from a few people that building PostgreSQL extensions on > Windows is a bit of a pain. I've heard from these people that their > solution was to temporarily add their extension as a contrib module > and have the extension building code take care

Re: language cleanups in code and docs

On 6/16/20 3:26 AM, Magnus Hagander wrote: > On Tue, Jun 16, 2020 at 2:23 AM Andres Freund wrote: > postmaster is just a symlink, which we very well could just leave in > place... I was really just thinking of the code level stuff. And I think > there's some clarity reasons to rename it

pg_read_file() with virtual files returns empty string

Since pg11 pg_read_file() and friends can be used with absolute paths as long as the user is superuser or explicitly granted the role pg_read_server_files. I noticed that when trying to read a virtual file, e.g.: SELECT pg_read_file('/proc/self/status'); the returned result is a zero length st

Re: pg_read_file() with virtual files returns empty string

On 6/27/20 3:43 PM, Tom Lane wrote: > Joe Conway writes: >> The attached patch fixes this for me. I think it ought to be backpatched >> through >> pg11. > >> Comments? > > 1. Doesn't seem to be accounting for the possibility of an error in fread().

Re: pg_read_file() with virtual files returns empty string

On 6/28/20 6:00 PM, Tom Lane wrote: > Joe Conway writes: >> All good stuff -- I believe the attached checks all the boxes. > > Looks okay to me, except I think you want > > ! if (bytes_to_read > 0) > > to be > > ! if (bytes_to_read >= 0) Yep --

Re: pg_read_file() with virtual files returns empty string

On 7/1/20 4:12 PM, Tom Lane wrote: > Joe Conway writes: >> I did some performance testing of the worst case/largest possible file and >> found >> that skipping the stat and bulk read does cause a significant regression. > > Yeah, I was wondering a little bit if that&

Re: pg_read_file() with virtual files returns empty string

On 7/1/20 5:17 PM, Joe Conway wrote: > On 7/1/20 4:12 PM, Tom Lane wrote: >> Joe Conway writes: >>> I did some performance testing of the worst case/largest possible file and >>> found >>> that skipping the stat and bulk read does cause a significant regres

Re: pg_read_file() with virtual files returns empty string

On 7/1/20 6:22 PM, Tom Lane wrote: > Joe Conway writes: >> The only downside is that the max filesize is reduced to (MaxAllocSize - >> MIN_READ_SIZE - 1) compared to MaxAllocSize with the old method. > > Hm, I was expecting that the last successful iteration of > enlargeS

Re: pg_read_file() with virtual files returns empty string

On 7/2/20 3:36 PM, Tom Lane wrote: > Joe Conway writes: >> On 7/1/20 6:22 PM, Tom Lane wrote: >>> Hm, I was expecting that the last successful iteration of >>> enlargeStringInfo would increase the buffer size to MaxAllocSize, >>> so that we'd really only

Re: pg_read_file() with virtual files returns empty string

On 7/2/20 4:27 PM, Tom Lane wrote: > Joe Conway writes: >> When I saw originally MaxAllocSize - 5 fail I skipped to something smaller by >> 4096 and it worked. But here I see that the actual max size is MaxAllocSize >> - 6. > > Huh, I wonder why it's not max -

Re: pg_read_file() with virtual files returns empty string

On 7/2/20 5:37 PM, Tom Lane wrote: > Joe Conway writes: >> In fact, in principle there is no reason we can't get to max - 4 with this >> code >> except that when the filesize is exactly 1073741819, we need to try to read >> one >> more byte to find t

Re: pg_read_file() with virtual files returns empty string

On 7/2/20 6:29 PM, Tom Lane wrote: > Joe Conway writes: >> On 7/2/20 5:37 PM, Tom Lane wrote: >>> I still can't get excited about contorting the code to remove that >>> issue. > >> It doesn't seem much worse than the oom test that was there before --

Re: pg_read_file() with virtual files returns empty string

On 7/4/20 12:52 PM, Tom Lane wrote: > Justin Pryzby writes: >> But I noticed that cfbot is now populating with failures like: > >> genfile.c: In function ‘read_binary_file’: >> genfile.c:192:5: error: ignoring return value of ‘fread’, declared with >> attribute warn_unused_result [-Werror=unused

Re: pg_read_file() with virtual files returns empty string

On 7/4/20 1:10 PM, Joe Conway wrote: > On 7/4/20 12:52 PM, Tom Lane wrote: >> Justin Pryzby writes: >>> But I noticed that cfbot is now populating with failures like: >> >>> genfile.c: In function ‘read_binary_file’: >>> genfile.c:192:5: error: ignor

repeat() function, CHECK_FOR_INTERRUPTS(), and unlikely()

I was doing some memory testing under fractional CPU allocations and it became painfully obvious that the repeat() function needs CHECK_FOR_INTERRUPTS(). I exchanged a few emails offlist with Tom about it, and (at the risk of putting words in his mouth) he agreed and felt it was a candidate for ba

Re: repeat() function, CHECK_FOR_INTERRUPTS(), and unlikely()

On 5/12/20 8:06 AM, Joe Conway wrote: > I was doing some memory testing under fractional CPU allocations and it became > painfully obvious that the repeat() function needs CHECK_FOR_INTERRUPTS(). > > I exchanged a few emails offlist with Tom about it, and (at the risk of > putting

Re: repeat() function, CHECK_FOR_INTERRUPTS(), and unlikely()

On 5/25/20 9:52 AM, Tom Lane wrote: > Joe Conway writes: >>> Comments or objections? > >> Seeing none ... I intend to backpatch and push these two patches in the next >> day >> or so. > > There was some question as to what (if anything) to do with the Wi

Re: repeat() function, CHECK_FOR_INTERRUPTS(), and unlikely()

On 5/27/20 3:29 AM, Michael Paquier wrote: >> I think that each of those tests should have a separate unlikely() marker, >> since the whole point here is that we don't expect either of those tests >> to yield true in the huge majority of CHECK_FOR_INTERRUPTS executions. > > +1. I am not sure that

Re: pg_config wrongly marked as not parallel safe?

On 11/30/18 10:32 AM, Tom Lane wrote: > Joe Conway writes: >> On 11/30/18 3:30 AM, Kyotaro HORIGUCHI wrote: >>> # And returning to the topic, I vote for pg_config should be "stable". > >> And on that note, Does this change does warrant backpatching, or should

Re: Some thoughts on NFS

On 2/19/19 10:59 AM, Magnus Hagander wrote: > On Tue, Feb 19, 2019 at 4:46 PM Robert Haas > wrote: > > On Tue, Feb 19, 2019 at 2:03 AM Thomas Munro > wrote: > > How can we achieve that, without writing our > > own NFS c

Re: Row Level Security − leakproof-ness and performance implications

On 2/19/19 6:43 PM, Laurenz Albe wrote: > Pierre Ducroquet wrote: >> if we had a 'RLS-enabled' context on functions, a way to make a lot of built- >> in functions leakproof would simply be to prevent them from logging errors >> containing values. >> >> For others, like arraycontains, it's much tr

Re: list append syntax for postgresql.conf

On 2/20/19 10:15 AM, Peter Eisentraut wrote: > Nowadays there are a number of methods for composing multiple > postgresql.conf files for modularity. But if you have a bunch of things > you want to load via shared_preload_libraries, you have to put them all > in one setting. How about some kind of

Re: BUG #15646: Inconsistent behavior for current_setting/set_config

On 2/20/19 12:11 PM, Tom Lane wrote: > Joe Conway writes: >> On 2/20/19 11:10 AM, PG Bug reporting form wrote: >>> But current behavior returns empty string instead of NULL (the initial >>> value) after transaction is rolled back. When I restart session, NULL is

oddity with ALTER ROLE/USER

I noticed that ALTER ROLE/USER succeeds even when called without any options: postgres=# alter user foo; ALTER ROLE postgres=# alter role foo; ALTER ROLE postgres=# alter group foo; ERROR: syntax error at or near ";" LINE 1: alter group foo; That seems odd, does nothing useful, and is inconsiste

Re: oddity with ALTER ROLE/USER

On 2/22/19 4:19 PM, Tom Lane wrote: > Joe Conway writes: >> I noticed that ALTER ROLE/USER succeeds even when called without any >> options: > >> postgres=# alter user foo; >> ALTER ROLE >> postgres=# alter role foo; >> ALTER ROLE >> postgres=# alt

Re: Should we increase the default vacuum_cost_limit?

On 2/25/19 1:17 AM, Peter Geoghegan wrote: > On Sun, Feb 24, 2019 at 9:42 PM David Rowley > wrote: >> The current default vacuum_cost_limit of 200 seems to be 15 years old >> and was added in f425b605f4e. >> >> Any supporters for raising the default? > > I also think that the current default limi

Re: crosstab/repivot...any interest?

extension or live the life of an > Orphan in pgxn.  If there's some interest here, we can consider a new > contrib extension (which I personally rate very unlikely) or recasting > as an extra routine to tablefunc.  Any way we slice it, huge thanks to > Joe Conway&co for g

Re: get_controlfile() can leak fds in the backend

On 2/27/19 2:47 AM, Michael Paquier wrote: > Hi all, > (CC-ing Joe as of dc7d70e) > > I was just looking at the offline checksum patch, and noticed some > sloppy coding in controldata_utils.c. The control file gets opened in > get_controlfile(), and if it generates an error then the file > descri

Re: Row Level Security − leakproof-ness and performance implications

On 2/20/19 11:24 AM, Tom Lane wrote: > Pierre Ducroquet writes: >> For simple functions like enum_eq/enum_ne, marking them leakproof is an >> obvious fix (patch attached to this email, including also textin/textout). > > This is not nearly as "obvious" as you think. See prior discussions, > not

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

On 6/13/19 11:07 AM, Bruce Momjian wrote: > On Thu, Jun 13, 2019 at 04:26:47PM +0900, Masahiko Sawada wrote: >> Yeah, in principle since data key of 2 tier key architecture should >> not go outside database I think we should not tell data keys to >> utility commands. So the rearranging WAL format s

<    1   2   3   4   5   6   >