Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-02-08 Thread Joe Conway
On 2/7/22 12:09, Robert Haas wrote: On Mon, Feb 7, 2022 at 11:13 AM Joe Conway wrote: It is confusing and IMHO dangerous that the predefined roles currently work differently than regular roles eith respect to privilege inheritance. I feel like that's kind of a conclusory statemen

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-02-08 Thread Joe Conway
On 2/8/22 10:07, Robert Haas wrote: On Tue, Feb 8, 2022 at 10:00 AM Joshua Brindle wrote: 4 predefined roles currently use has_privs_of_role in master. Further, pg_monitor, as an SQL-only predefined role, also behaves consistently with the INHERIT rules that other roles do. In order for SQL-o

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-02-09 Thread Joe Conway
On 2/9/22 13:13, Nathan Bossart wrote: On Tue, Feb 08, 2022 at 10:54:50PM -0500, Robert Haas wrote: On Tue, Feb 8, 2022 at 7:38 PM Joe Conway wrote: If we were to start all over again with this feature my vote would be to do things differently than we have done. I would not have called them

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-02-10 Thread Joe Conway
On 2/10/22 14:28, Nathan Bossart wrote: On Wed, Feb 09, 2022 at 04:39:11PM -0500, Joe Conway wrote: On 2/9/22 13:13, Nathan Bossart wrote: I do wonder if users find the differences between predefined roles and role attributes confusing. INHERIT doesn't govern role attributes, but it

Re: List of all* PostgreSQL EXTENSIONs in the world

2022-02-10 Thread Joe Conway
On 2/10/22 15:35, Robert Haas wrote: On Thu, Feb 10, 2022 at 3:19 PM Joel Jacobson wrote: I've compiled a list of all* PostgreSQL EXTENSIONs in the world: https://gist.github.com/joelonsql/e5aa27f8cc9bd22b8999b7de8aee9d47 *) It's not all, but 1041, compared to the 338 found on PGXN. Maybe it

Re: Observability in Postgres

2022-02-15 Thread Joe Conway
On 2/15/22 07:30, Dave Page wrote: On Mon, 14 Feb 2022 at 20:16, Greg Stark > wrote: So I've been dealing a lot with building and maintaining dashboards for (fleets of) Postgres servers. And it's a pain. I have a few strongly held ideas about where the pain poin

Re: pgsql: Move scanint8() to numutils.c

2022-02-15 Thread Joe Conway
On 2/14/22 16:18, Peter Eisentraut wrote: Move scanint8() to numutils.c Move scanint8() to numutils.c and rename to pg_strtoint64(). We already have a "16" and "32" version of that, and the code inside the functions was aligned, so this move makes all three versions consistent. The API is also

Re: pgsql: Move scanint8() to numutils.c

2022-02-15 Thread Joe Conway
On 2/15/22 13:47, Robert Haas wrote: On Tue, Feb 15, 2022 at 10:39 AM Joe Conway wrote: (moving to hackers) I guess shame on me for not noticing the thread, but I don't see any discussion about the potential for breakage to external projects. scanint8() is exported, and this change brea

Re: Time to drop plpython2?

2022-02-18 Thread Joe Conway
On 2/17/22 13:08, Andres Freund wrote: On 2022-02-16 23:14:46 -0800, Andres Freund wrote: > Done. Curious how red the BF will turn out to be. Let's hope it's not > too bad. - rhinoceros Joe replied that he is afk, looking into it tomorrow. I installed python3 packages (initially forgettin

Re: Time to drop plpython2?

2022-02-18 Thread Joe Conway
On 2/18/22 14:37, Andres Freund wrote: Hi, On 2022-02-18 14:19:49 -0500, Joe Conway wrote: On 2/17/22 13:08, Andres Freund wrote: > On 2022-02-16 23:14:46 -0800, Andres Freund wrote: > > > Done. Curious how red the BF will turn out to be. Let's hope it's not > >

Re: Time to drop plpython2?

2022-02-18 Thread Joe Conway
On 2/18/22 15:25, Andres Freund wrote: On 2022-02-18 14:46:39 -0500, Joe Conway wrote: $ ll /usr/bin/python lrwxrwxrwx. 1 root root 7 Mar 13 2021 /usr/bin/python -> python2 8<--- Yea, that all looks fine. What's the problem if you don't specify the PYTHON

Re: Time to drop plpython2?

2022-02-18 Thread Joe Conway
On 2/18/22 15:53, Andres Freund wrote: the next run succeeded, with 'PYTHON' => 'python3' in build env. But presumably this just was because you installed the python3-devel package? Ok, I guess I got confused when it failed due to the missing devel package, because I removed the PYTHON => 'py

Re: out of memory in crosstab()

2022-11-16 Thread Joe Conway
houghts on whether this should be fixed and the fix be back-patched? -1 on backpatching -- this is not a bug, and the changes are non-trivial Joe -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: pgsql: Fix typos and bump catversion.

2022-11-19 Thread Joe Conway
*/ -#define CATALOG_VERSION_NO 202211121 +#define CATALOG_VERSION_NO 202211821 #endif I think that should be 202211181, no? I am not clear on the desirable way to fix though :-/ Joe -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: pgsql: Fix typos and bump catversion.

2022-11-19 Thread Joe Conway
On 11/19/22 17:24, Tom Lane wrote: Andres Freund writes: On 2022-11-19 17:10:57 -0500, Joe Conway wrote: Rishu Bagga pointed out to me offlist that this catversion bump seems flawed: /* mmddN */ -#define CATALOG_VERSION_NO 202211121 +#define CATALOG_VERSION_NO

Re: [PATCH] Add <> support to sepgsql_restorecon

2022-11-21 Thread Joe Conway
restorecon to relabel them to the wrong security level. +1 Please add to the next commitfest here: https://commitfest.postgresql.org/41/ Thanks, -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: fixing CREATEROLE

2022-11-22 Thread Joe Conway
ltiple competing concepts (privs on objects, attributes of roles, membership, when things are inherited versus not, settings bound to roles, etc). I don't know what to do about it, but yeah, fixing the documentation would be a noble goal. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: drop postmaster symlink

2022-11-23 Thread Joe Conway
worth pointing out that the PGDG RPMs still use the symlink in the included systemd service file: 8<-- ExecStart=/usr/pgsql-15/bin/postmaster -D ${PGDATA} 8<------ -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: drop postmaster symlink

2022-11-23 Thread Joe Conway
ither. FWIW, the reason I took note of the postmaster symlink in the first place a few years ago was because selinux treats execution of programs from symlinks differently than from actual files. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Collation version tracking for macOS

2022-11-29 Thread Joe Conway
u want to happen, you can always repair the situation somehow, because the library to be used for each collation is explicitly specified in some way, and you just have to get it to match what you want to have happen. My vote is for something like #5. The collversion should indicate a specific immut

Re: Collation version tracking for macOS

2022-11-29 Thread Joe Conway
On 11/29/22 13:59, Jeff Davis wrote: On Tue, 2022-11-29 at 11:27 -0500, Joe Conway wrote: My vote is for something like #5. The collversion should indicate a specific immutable ordering behavior. Easier said than done: https://www.postgresql.org/message-id

Re: Error-safe user functions

2022-12-05 Thread Joe Conway
if we like the 'feedback' idea 'efeedbk'. Maybe eretort? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Error-safe user functions

2022-12-05 Thread Joe Conway
se. prolixity -- nice word! I won't comment on its applicability to you in particular ;-P -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Collation version tracking for macOS

2022-12-05 Thread Joe Conway
ry unambiguously defines a specific collation behavior (I think, ignoring bugs?) -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: [PATCH] random_normal function

2022-12-09 Thread Joe Conway
only one. Thanks for the patch. What do you think about these results? Angels on pins time! :) I just noticed this thread -- what is lacking in the normal_rand() function in the tablefunc contrib? https://www.postgresql.org/docs/current/tablefunc.html#id-1.11.7.52.5 -- Joe Conway PostgreSQL

Re: function for testing that causes the backend to terminate

2021-04-29 Thread Joe Conway
On 4/29/21 6:56 AM, Dave Cramer wrote: For testing unusual situations I'd like to be able to cause a backend to terminate due to something like a segfault. Do we currently have this in testing ? If you can run SQL as a superuser from that backend, try: COPY (SELECT pg_backend_pid()) TO PROGR

Re: PG in container w/ pid namespace is init, process exits cause restart

2021-05-04 Thread Joe Conway
e that somebody (Joe Conway if memory serves) reported years ago. Guilty as charged ;-) Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development

Re: PG 14 release notes, first draft

2021-05-10 Thread Joe Conway
On 5/10/21 2:03 AM, Bruce Momjian wrote: I have committed the first draft of the PG 14 release notes. You can see the most current build of them here: https://momjian.us/pgsql_docs/release-14.html I need clarification on many items, and the document still needs its items properly orde

Re: PG 14 release notes, first draft

2021-05-11 Thread Joe Conway
On 5/10/21 9:56 PM, Bruce Momjian wrote: On Mon, May 10, 2021 at 07:50:14AM -0400, Joe Conway wrote: On 5/10/21 2:03 AM, Bruce Momjian wrote: > I have committed the first draft of the PG 14 release notes. You can > see the most current build of them here: > > https://momjian.u

Re: PG 14 release notes, first draft

2021-05-11 Thread Joe Conway
On 5/11/21 11:11 AM, Bruce Momjian wrote: On Tue, May 11, 2021 at 06:57:19AM -0400, Joe Conway wrote: On 5/10/21 9:56 PM, Bruce Momjian wrote: > On Mon, May 10, 2021 at 07:50:14AM -0400, Joe Conway wrote: > > On 5/10/21 2:03 AM, Bruce Momjian wrote: > > > I have committed the

Re: PG 14 release notes, first draft

2021-05-11 Thread Joe Conway
On 5/11/21 11:37 AM, Bruce Momjian wrote: On Tue, May 11, 2021 at 11:26:48AM -0400, Joe Conway wrote: On 5/11/21 11:11 AM, Bruce Momjian wrote: > > Previously existence of such columns were ignored when caller had table > > level privileges. > > I can't reproduce the

Re: PG 14 release notes, first draft

2021-05-11 Thread Joe Conway
On 5/11/21 1:30 PM, Bruce Momjian wrote: On Tue, May 11, 2021 at 12:31:01PM -0400, Joe Conway wrote: On 5/11/21 11:37 AM, Bruce Momjian wrote: > On Tue, May 11, 2021 at 11:26:48AM -0400, Joe Conway wrote: > > On 5/11/21 11:11 AM, Bruce Momjian wrote: > > > > Previously exis

Re: View invoker privileges

2021-05-14 Thread Joe Conway
On 5/14/21 4:11 AM, Noah Misch wrote: On Wed, Apr 14, 2021 at 10:25:08AM +0300, Ivan Ivanov wrote: In Postgres we can create view with view owner privileges only. What’s the reason that there is no option to create view with invoker privileges? Is there any technical or security subtleties relat

Re: Freenode woes

2021-05-20 Thread Joe Conway
On 5/19/21 4:27 PM, Robert Treat wrote: On Wed, May 19, 2021 at 10:19 AM Christoph Berg wrote: Fwiw, if the PostgreSQL projects is considering moving the #postgresql IRC channel(s) elsewhere given [1,2], I'm a member of OFTC.net's network operations committee and would be happy to help. [1] h

Re: use has_privs_of_role() for pg_hba.conf

2022-10-06 Thread Joe Conway
over the next week. Joe -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: use has_privs_of_role() for pg_hba.conf

2022-10-08 Thread Joe Conway
other comments or concerns, I will commit/push by the end of the weekend. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: RLS + XPATH

2022-10-31 Thread Joe Conway
e from RLS. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Support for CREATE MODULE?

2021-06-02 Thread Joe Conway
On 6/2/21 10:43 AM, Jim Mlodgenski wrote: On Wed, Jun 2, 2021 at 9:58 AM Tom Lane wrote: I wonder whether it'd be better to consider modules as a kind of extension, or at least things with the same sort of ownership relations as extensions have. That would solve the problem of associating obj

Re: Cosmic ray hits integerset

2021-07-07 Thread Joe Conway
On 7/7/21 2:53 AM, Jakub Wartak wrote: Hi, Asking out of pure technical curiosity about "the rhinoceros" - what kind of animal is it ? Physical box or VM? How one could get dmidecode(1) / dmesg(1) / mcelog (1) from what's out there (e.g. does it run ECC or not ?) Rhinoceros is just a VM on a

Re: Limiting memory allocation

2022-05-18 Thread Joe Conway
ps if you are running in a container. And in fact most non-container installations these days are also running in a cgroup under systemd. The only difference is that you are more likely to see a memory limit set in a container than under systemd. [1] https://github.com/torvalds/linux/blob/

Re: Limiting memory allocation

2022-05-18 Thread Joe Conway
On 5/18/22 16:20, Alvaro Herrera wrote: On 2022-May-18, Joe Conway wrote: On 5/18/22 11:11, Alvaro Herrera wrote: > Apparently, if the cgroup goes over the "high" limit, the processes are > *throttled*. Then if the group goes over the "max" limit, OOM-killer i

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
57.htm#i1120532 "SYSTEM_USER Returns the name of the current data store user as identified by the operating system." Seems equivalent. -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
identifiers? On the contrary, I would argue that not having the identifier for the external "user" available is a security concern. Ideally you want to be able to trace actions inside Postgres to the actual user that invoked them. -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
On 6/22/22 11:52, Tom Lane wrote: Jacob Champion writes: On Wed, Jun 22, 2022 at 8:10 AM Joe Conway wrote: In case port->authn_id is NULL then the patch is returning the SESSION_USER for the SYSTEM_USER. Perhaps it should return NULL instead. If the spec says that SYSTEM_USER "re

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
On 6/22/22 11:35, Jacob Champion wrote: On Wed, Jun 22, 2022 at 8:10 AM Joe Conway wrote: --- a/src/backend/utils/init/miscinit.c +++ b/src/backend/utils/init/miscinit.c @@ -473,6 +473,7 @@ static OidAuthenticatedUserId = InvalidOid; static OidSessionUserId = InvalidOid; static Oid

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
On 6/22/22 12:28, Tom Lane wrote: Joe Conway writes: On 6/22/22 11:52, Tom Lane wrote: I think a case could be made for ONLY returning non-null when authn_id represents some externally-verified identifier (OS user ID gotten via peer identification, Kerberos principal, etc). But -1 on that

Re: replacing role-level NOINHERIT with a grant-level option

2022-07-01 Thread Joe Conway
i.e., the grant-level option always takes precedence over the role-level option). Also, AFAICT this strategy still provides the full set of behavior that would be possible if only the grant-level option existed. Would this allow for an explicit REVOKE to override a default INHERIT along a specific

Re: replacing role-level NOINHERIT with a grant-level option

2022-07-01 Thread Joe Conway
On 7/1/22 07:48, Robert Haas wrote: On Fri, Jul 1, 2022 at 6:17 AM Joe Conway wrote: Would this allow for an explicit REVOKE to override a default INHERIT along a specific path? Can you give an example? If you mean that A is granted to B which is granted to C which is granted to D and you

Re: Hardening PostgreSQL via (optional) ban on local file system access

2022-07-01 Thread Joe Conway
e production database is to have a non-privileged NOINHERIT user for logging in and then do SET ROLE=; when needed, similar to using su/sudo in shell. This practice both reduces the attack surface and also provides auditability by knowing who logged in for superuser work. +many -- Joe

Re: Patch proposal: New hooks in the connection path

2022-07-05 Thread Joe Conway
and probably should be: 8<-- + if (status != STATUS_OK) + { + if (FailedConnection_hook) 8<-- -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-07-07 Thread Joe Conway
I guess another good question is why the email address no longer confirmed... -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: pg_parameter_aclcheck() and trusted extensions

2022-07-07 Thread Joe Conway
eone wants to argue it's too late for API breaks in v15? Well there are other API breaks that affect me in v15, and to be honest I have done little except keep an eye out for the ones likely to affect extensions I maintain so far, so may as well inflict the pain now as later ¯\_(ツ)_/¯ Joe -- J

Re: Patch proposal: New hooks in the connection path

2022-07-07 Thread Joe Conway
On 7/6/22 04:13, Drouvot, Bertrand wrote: On 7/6/22 12:11 AM, Joe Conway wrote: On 7/5/22 03:37, Bharath Rupireddy wrote: 2. Timeout Handler is a signal handler, called as part of SIGALRM signal handler, most of the times, signal handlers ought to be doing small things, now that we are handing

Re: [Commitfest 2022-07] Begins Now

2022-07-19 Thread Joe Conway
reviewing a patch. So we definitely expect an email "soon" from someone in the second column, but not from somebody who is only in the first column. +1 -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: [PATCH] Introduce array_shuffle() and array_sample()

2022-07-22 Thread Joe Conway
rving subarrays. Or else be lazy and reject more-than-one-D arrays; but it's probably not that hard to handle them. +1 Joe [1] https://www.postgresql.org/message-id/flat/Pine.LNX.4.44.0306281418020.2178-10%40peter.localdomain#a064d6dd8593993d799db453a3ee04d1 -- Joe Conway RDS Open Source

Re: let's disallow ALTER ROLE bootstrap_superuser NOSUPERUSER

2022-07-22 Thread Joe Conway
com/pgaudit/set_user/blob/1335cd34ca91b6bd19d5e910cc93c831d1ed0db0/README.md?plain=1#L612 https://github.com/pgaudit/set_user/blob/1335cd34ca91b6bd19d5e910cc93c831d1ed0db0/README.md?plain=1#L618 -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Support logical replication of DDLs

2022-07-23 Thread Joe Conway
especially handy when there is a large number of databases to configure for logical replication. I would strongly favor #2, although I admittedly have no idea what complexities it adds. -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Proposal to provide the facility to set binary format output for specific OID's per session

2022-07-25 Thread Joe Conway
of the session. +1 makes a lot of sense to me. Dave please add this to the open commitfest (202209) -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: [PATCH] Expose port->authn_id to extensions and triggers

2022-08-06 Thread Joe Conway
identification name" Oracle: "SYSTEM_USER Returns the name of the current data store user as identified by the operating system." I am not sure how else we should interpret SYSTEM_USER -- if it isn't port->authn_id what else would you propose it should be? -- Joe

Re: Pg stuck at 100% cpu, for multiple days

2021-08-30 Thread Joe Conway
On 8/30/21 3:34 PM, Justin Pryzby wrote: On Mon, Aug 30, 2021 at 09:09:20PM +0200, Laurenz Albe wrote: On Mon, 2021-08-30 at 17:18 +0200, hubert depesz lubaczewski wrote: > The thing is - I can't close it with pg_terminate_backend(), and I'd > rather not kill -9, as it will, I think, close all o

Re: Pg stuck at 100% cpu, for multiple days

2021-08-30 Thread Joe Conway
On 8/30/21 8:22 PM, Tom Lane wrote: Joe Conway writes: It would be interesting to step through a few times to see if it is really stuck in that loop. Yeah, this single data point is not enough justification to blame dynahash.c (which is *extremely* battle-tested code, you'll recall)

Re: Returning to Postgres community work

2021-08-31 Thread Joe Conway
On 8/31/21 1:53 AM, Gurjeet Singh wrote: I'm very happy to announce that I now work for Supabase [1]. They have hired me so that I can participate in, and contribute to the Postgres community. Welcome back! :-) Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure E

question regarding policy for patches to out-of-support branches

2024-06-05 Thread Joe Conway
he policy written down somewhere, or is it only project lore? In either case, what is the actual policy? Thanks, -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: question regarding policy for patches to out-of-support branches

2024-06-06 Thread Joe Conway
ughts on how to improve I am happy to make more changes. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: CI, macports, darwin version problems

2024-07-03 Thread Joe Conway
difficulty fetching the image? CCing our Mac Mini pool attendants. How can I help? Do you need to know versions of some of the stuff on my mac mini? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Commitfest manager for July 2024

2024-07-08 Thread Joe Conway
that, although given that Corey and I are colleagues, it might be better if someone else on pginfra did. Or at least if a few other hackers tell me to "just do it"... -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Commitfest manager for July 2024

2024-07-09 Thread Joe Conway
On 7/8/24 11:38, Joe Conway wrote: On 7/3/24 12:51, Andrey M. Borodin wrote: On 3 Jul 2024, at 01:08, Corey Huinker wrote: I'll give it a shot. Great, thank you! Do you have extended access to CF? Like activity log and mass-mail functions? If no I think someone from PG_INFRA can gran

Re: RFC: pg_stat_logmsg

2023-07-09 Thread Joe Conway
On 7/7/23 01:38, Gurjeet Singh wrote: On Thu, Jul 6, 2023 at 12:37 AM Masahiko Sawada wrote: On Sat, Jul 1, 2023 at 8:57 AM Joe Conway wrote: > > The basic idea is to mirror how pg_stat_statements works, except the > logged messages keyed by filename, lineno, and elevel are sav

Re: COPY table FROM STDIN via SPI

2023-07-12 Thread Joe Conway
g/docs/current/libpq-copy.html -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: COPY table FROM STDIN via SPI

2023-07-12 Thread Joe Conway
On 7/12/23 14:43, c...@anastigmatix.net wrote: On 2023-07-12 14:18, Joe Conway wrote: On 7/11/23 22:52, James Sewell wrote: What about running a COPY directly from C - is that possible? https://www.postgresql.org/docs/current/libpq-copy.html Or is the question about a COPY kicked off from

Re: pgsql: Fix search_path to a safe value during maintenance operations.

2023-07-31 Thread Joe Conway
the issue needs to go one step further. Even if the search_path does not change from the originally intended one, a newly created function can shadow the intended one based on argument coercion rules. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-08-01 Thread Joe Conway
On 7/3/23 12:25, Tristan Partin wrote: On Sat Jun 24, 2023 at 8:09 AM CDT, Joe Conway wrote: Although I have not looked yet, presumably we could have similar problems with plpython. I would like to get agreement on this approach against plperl before diving into that though. Thoughts? I

Re: CREATE FUNCTION ... SEARCH { DEFAULT | SYSTEM | SESSION }

2023-08-12 Thread Joe Conway
hat the user just wants "SEARCH SYSTEM" allows us some freedom to do that. Personally I think having pg_temp in the SYSTEM search path makes sense for temp tables, but I find it easy to forget that functions can be created by unprivileged users in pg_temp, and therefore having pg_temp in

Re: CREATE FUNCTION ... SEARCH { DEFAULT | SYSTEM | SESSION }

2023-08-12 Thread Joe Conway
On 8/12/23 09:15, Joe Conway wrote: On 8/11/23 22:35, Jeff Davis wrote: 2. We can more accurately serve the user's intent. For instance, the safe search_path of "pg_catalog, pg_temp" is arcane and seems to be there just because we don't have a way to specify that pg_temp

Re: Would it be possible to backpatch Close support in libpq (28b5726) to PG16?

2023-08-16 Thread Joe Conway
y out, would we add libpq support for Close to 16.2? Seems pretty clearly a "no" to me. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: C function to return double precision[][]

2023-08-21 Thread Joe Conway
generic to the element type (i.e. not specifically float8), but the needed type conversion stuff happens in here: https://github.com/postgres-plr/plr/blob/20a1f133bcf2bc8f37ac23da191aea590d612619/plr.c#L1109 HTH, -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web

Re: list of acknowledgments for PG16

2023-08-22 Thread Joe Conway
ct the HTML docs and put them on the website. These days the docs update is part of a scripted process for doing an entire release. I'm sure we could figure out how to just release the updated docs, but with RC1 a week away, is it really worthwhile? -- Joe Conway PostgreSQL Contributors

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-08-27 Thread Joe Conway
On 8/15/23 10:40, Heikki Linnakangas wrote: On 01/08/2023 16:48, Joe Conway wrote: Any further comments on the posted patch[1]? I would like to apply/push this prior to the beta and minor releases next week. I'm not sure about the placement of the uselocale() calls. In plperl_spi_exec()

Re: New GUC autovacuum_max_threshold ?

2024-04-26 Thread Joe Conway
view, having autovac run very quickly, even if more frequently, provides an overall better user experience. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: New GUC autovacuum_max_threshold ?

2024-04-26 Thread Joe Conway
On 4/26/24 09:31, Robert Haas wrote: On Fri, Apr 26, 2024 at 9:22 AM Joe Conway wrote: Although I don't think 50 is necessarily too small. In my view, having autovac run very quickly, even if more frequently, provides an overall better user experience. Can you elaborate on why you

Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation

2024-05-03 Thread Joe Conway
heard similar anecdotes, and the reported experience goes even further -- many such upgrade/migration uses, with exceedingly rare reported failures. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: 'trusted'/'untrusted' PL in DoD/DISA PostgreSQL STIGs

2024-05-05 Thread Joe Conway
have better connections. Those docs were developed by the respective companies (Crunchy and EDB) in cooperation with DISA. The community has nothing to do with them. I suggest you contact the two companies with corrections and suggestions. -- Joe Conway PostgreSQL Contributors Team RDS Open

Re: First draft of PG 17 release notes

2024-05-11 Thread Joe Conway
improves mostly is COPY of large rows and streaming a base backup. That sounds user-visible enough to me to warrant an entry imho. +1 -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: PostgreSQL 17 Beta 1 release announcement draft

2024-05-16 Thread Joe Conway
ation provider that provides similar sorting semantics to the `C` collation except with UTF-8 encoding rather than SQL_ASCII." -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: First draft of PG 17 release notes

2024-05-16 Thread Joe Conway
performance. The reticence to note their work, while noting other, far smaller, things in the release notes, pretty much tells us that our work isn't valued. agreed -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: PostgreSQL 17 Beta 1 release announcement draft

2024-05-16 Thread Joe Conway
On 5/16/24 08:05, Joe Conway wrote: On 5/15/24 21:45, Jonathan S. Katz wrote: Please provide feedback no later than Wed 2024-05-22 18:00 UTC. As the beta release takes some extra effort, I want to ensure all changes are in with time to spare before release day. "`EXPLAIN` can now sho

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-16 Thread Joe Conway
commitfest and therefore the author needs to care enough to register for the next one? I spent a good deal of time going through the CommitFest this week And you deserve a big Thank You for that. + many +1 agreed -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-16 Thread Joe Conway
On 5/16/24 16:57, Jacob Champion wrote: On Thu, May 16, 2024 at 1:31 PM Joe Conway wrote: Maybe we should just make it a policy that *nothing* gets moved forward from commitfest-to-commitfest and therefore the author needs to care enough to register for the next one? I think that's goi

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-16 Thread Joe Conway
to basically have a CF called "parking lot", where you can park patches that aren't active in a commitfest  but you also don't want to be dead. It would probably also be doable to have the cf bot run patches in that commitfest as well as the current one, if that's wh

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-16 Thread Joe Conway
On 5/16/24 17:24, Jacob Champion wrote: On Thu, May 16, 2024 at 2:06 PM Joe Conway wrote: Maybe the word "care" was a poor choice, but forcing authors to think about and decide if they have the "time to shepherd a patch" for the *next CF* is exactly the point. If they don&#

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-16 Thread Joe Conway
On 5/16/24 17:36, Jacob Champion wrote: On Thu, May 16, 2024 at 2:29 PM Joe Conway wrote: If no one, including the author (new or otherwise) is interested in shepherding a particular patch, what chance does it have of ever getting committed? That's a very different thing from what I

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-17 Thread Joe Conway
clear" - but I think that's missing the point. What we really want is to not see that stuff in the first place. It's a CommitFest, not once-upon-a-time-I-wrote-a-patch-Fest. +1 -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-17 Thread Joe Conway
On 5/17/24 08:31, Jelte Fennema-Nio wrote: On Fri, 17 May 2024 at 14:19, Joe Conway wrote: On 5/16/24 22:26, Robert Haas wrote: > For example, imagine that the CommitFest is FORCIBLY empty > until a week before it starts. You can still register patches in the > system generally, but

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-17 Thread Joe Conway
On 5/17/24 09:08, Peter Eisentraut wrote: On 17.05.24 14:42, Joe Conway wrote: Namely, the week before commitfest I don't actually know if I will have the time during that month, but I will make sure my patch is in the commitfest just in case I get a few clear days to work on it. Becau

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-17 Thread Joe Conway
yeah, I'm still here, please review my patch," we've already lost the game. That person isn't sad because we asked them to click a link. They're sad it's already been N * 2 months and nothing has happened. +many -- Joe Conway PostgreSQL Contributors Team RD

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-19 Thread Joe Conway
best sub-linearly (limited by the velocity of knowledge sharing). I agree with Andrey on this, the only way I see to handle this is to scale CF management efforts. The number of items tracked are surely growing, but I am not sure I would call it exponential -- see attached -- Joe Conway

Re: commitfest.postgresql.org is no longer fit for purpose

2024-05-24 Thread Joe Conway
e likely to be taken seriously. Maybe do a FOSDEM-style dev meeting with triage review at PG.EU would at least move us forward? Granted it is less early and perhaps less often than the thread seems to indicate, but has been tossed around before and seems doable. -- Joe Conway PostgreSQL Contri

Re: Optimizing COPY with SIMD

2024-06-03 Thread Joe Conway
On 6/2/24 15:17, Neil Conway wrote: Inspired by David Rowley's work [1] Welcome back! -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: has_privs_of_role vs. is_member_of_role, redux

2022-08-25 Thread Joe Conway
ut membership in the target role, and leave everything else unchanged. Thoughts? I'm not sure about these last two. Does it matter that object creation is being logged, maybe for auditing purposes, under a different user than the owner of the object? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Order changes in PG16 since ICU introduction

2023-05-24 Thread Joe Conway
IMHO the experience should be unified to the degree possible. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

<    1   2   3   4   5   6   >