tion is
> going to try to recreate OpenSSL's custom format.
>
> --Jacob
>
> [1]
> https://lists.apache.org/thread.html/2055b56985c69e7a6977151bf9817a0f982a4ad3b78a6a1984977fd0%401289507617%40%3Cusers.httpd.apache.org%3E
>
This patch set no longer applies
http://cfbot.cputube.org/patch_32_2835.log
Can we get a rebase?
I marked the patch "Waiting on Author".
--
Ibrar Ahmed
or its second
> argument, which in turn makes PQgetResult() return non-COMMAND_OK.
>
>
> Regards
> Takayuki Tsunakawa
>
>
This patch set no longer applies
http://cfbot.cputube.org/patch_32_2601.log
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
empty range is neither left nor right any element */
>
> I these comments should all say ".. left nor right OF any ..."
>
> --
> Justin
>
>
>
This patch set no longer applies.
http://cfbot.cputube.org/patch_32_2747.log
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
ns to worry about more.
>
> regards, tom lane
>
>
>
This patch set no longer applies
http://cfbot.cputube.org/patch_32_2569.log
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
> + fprintf(stderr, "simple batch... ");
> > + fflush(stderr);
>
> Why do we need fflush()? IMO that shouldn't be needed in a use like
> this? Especially not on stderr, which ought to be unbuffered?
>
>
> > + /*
> > + * Enter batch mode and dispatch a set of operations, which we'll
> then
> > + * process the results of as they come in.
> > + *
> > + * For a simple case we should be able to do this without interim
> > + * processing of results since our out buffer will give us enough
> slush to
> > + * work with and we won't block on sending. So blocking mode is
> fine.
> > + */
> > + if (PQisnonblocking(conn))
> > + {
> > + fprintf(stderr, "Expected blocking connection mode\n");
> > + goto fail;
> > + }
>
> Perhaps worth adding a helper for this?
>
> #define EXPECT(condition, explanation) \
> ...
> or such?
>
> Greetings,
>
> Andres Freund
>
>
>
The build is failing for this patch, can you please take a look at this?
https://cirrus-ci.com/task/4568547922804736
https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.129221
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
.
> >
> >>
> >> +/*
> >> + * Send WAL statistics only if WalWriterDelay has elapsed
> to
> >> minimize
> >> + * the overhead in WAL-writing.
> >> + */
> >> +if (rc & WL_TIMEOUT)
> >> +pgstat_send_wal();
> >>
> >> On second thought, this change means that it always takes
> >> wal_writer_delay
> >> before walwriter's WAL stats is sent after XLogBackgroundFlush() is
> >> called.
> >> For example, if wal_writer_delay is set to several seconds, some
> >> values in
> >> pg_stat_wal would be not up-to-date meaninglessly for those seconds.
> >> So I'm thinking to withdraw my previous comment and it's ok to send
> >> the stats every after XLogBackgroundFlush() is called. Thought?
> >
> > Thanks, I didn't notice that.
> >
> > Although PGSTAT_STAT_INTERVAL is 500msec, wal_writer_delay's
> > default value is 200msec and it may be set shorter time.
> >
> > Why don't to make another way to check the timestamp?
> >
> > + /*
> > +* Don't send a message unless it's been at least
> > PGSTAT_STAT_INTERVAL
> > +* msec since we last sent one
> > +*/
> > + now = GetCurrentTimestamp();
> > + if (TimestampDifferenceExceeds(last_report, now,
> > PGSTAT_STAT_INTERVAL))
> > + {
> > + pgstat_send_wal();
> > + last_report = now;
> > + }
> > +
> >
> > Although I worried that it's better to add the check code in
> > pgstat_send_wal(),
> > I didn't do so because to avoid to double check PGSTAT_STAT_INTERVAL.
> > pgstat_send_wal() is invoked pg_report_stat() and it already checks the
> > PGSTAT_STAT_INTERVAL.
>
> I forgot to remove an unused variable.
> The attached v13 patch is fixed.
>
> Regards
> --
> Masahiro Ikeda
> NTT DATA CORPORATION
This patch set no longer applies
http://cfbot.cputube.org/patch_32_2859.log
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
; - add both:
> + `ALTER CONSTRAINT constraint_name [ALTER] FOREIGN KEY ON UPDATE
> referential_action`
> + `ALTER CONSTRAINT constraint_name [ALTER] FOREIGN KEY ON DELETE
> referential_action`
>
> This does not imply any changes, that are not in the command - very much
> ana
still has the previous thread. The old thread
has the v18 as the latest patch which is failing. The new thread which (
https://www.postgresql.org/message-id/CAJkzx4T5E-2cQe3dtv2R78dYFvz%2Bin8PY7A8MArvLhs_pg75gg%40mail.gmail.com
)
has the new patch.
--
Ibrar Ahmed
ready changed by
another patch
-/* Define to build with OpenSSL support. (--with-ssl=openssl) */
+/* Define to 1 if you have OpenSSL support. */
Do you mind sending an updated patch?
http://cfbot.cputube.org/patch_32_2980.log.
I am changing the status to "Waiting for Author"
In my
sync_rep.pl ok
Bailout called. Further testing stopped: system pg_ctl failed
FAILED--Further testing stopped: system pg_ctl failed
make[2]: *** [Makefile:19: check] Error 255
make[1]: *** [Makefile:49: check-recovery-recurse] Error 2
make: *** [GNUmakefile:71: check-world-src/test-recurse] Error 2
...
--
Ibrar Ahmed
iling because you forgot to drop the table
created in a test
case (aggregates), It's a bit minor change so the attached patch fixes
that issue.
https://cirrus-ci.com/task/6704792446697472
--
Ibrar Ahmed
v12-0001-GROUP-BY-optimization-made-compatible-with-chang.patch
Description: Binary data
hanges any successful behavior and it just saves
> > the failure case so +1 for back-patching.
>
> Thanks for the review! New patch version attached.
>
> - Heikki
>
The patch does not apply successfully
http://cfbot.cputube.org/patch_32_2864.log
1 out of 10 hunks FAILED -- saving rejects to file
src/bin/pg_rewind/pg_rewind.c.rej
There is a minor issue therefore I rebase the patch. Please take a look at
that.
--
Ibrar Ahmed
v3-0001-pg_rewind-Fix-determining-TLI-when-server-was-jus.patch
Description: Binary data
iled.
http://cfbot.cputube.org/patch_32_2824.log
patching file contrib/pageinspect/gistfuncs.c
Hunk #1 FAILED at 151.
Hunk #2 FAILED at 175.
Hunk #3 FAILED at 245.
Hunk #4 FAILED at 271.
...
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
he wrong "-p"
I have regenerated the patch, can you please take a look.
http://cfbot.cputube.org/patch_32_2917.log
=== applying patch ./v4-0001-popcount.patch
can't find file to patch at input line 21
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--
--
Ibrar Ahmed
v5-0001-popcount.patch
Description: Binary data
-and-pg_change_role_.patch)
does
not apply successfully and has some hunks failed.
http://cfbot.cputube.org/patch_32_2918.log
1 out of 23 hunks FAILED -- saving rejects to file
src/backend/utils/misc/guc.c.rej
patching file src/include/catalog/catversion.h
Hunk #1 FAILED at 53.
1 out of 1 hunk FAILED -- saving rejects to file
src/include/catalog/catversion.h.rej
patching file src/include/catalog/pg_authid.dat
Can we get a rebase?
I am marking the patch "Waiting on Author".
--
Ibrar Ahmed
efore I rebased the patch, please take a look.
--
Ibrar Ahmed
null_check_on_pkey_optimization_v3.patch
Description: Binary data
On Mon, Mar 8, 2021 at 8:59 PM Peter Geoghegan wrote:
> On Mon, Mar 8, 2021 at 6:41 AM Ibrar Ahmed wrote:
> > The patch
> (0001-Add-bool-column-for-LP_DEAF-flag-to-GiST-pageinspect.patch)
> > does not apply successfully and has multiple hanks failed.
>
> That&#x
base?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
r/resowner.c.rej
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
: use of undeclared identifier 'pgstat_temp_directory';
did you mean 'pgstat_stat_directory'?
&pgstat_temp_directory,
^
pgstat_stat_directory
../../../../src/include/pgstat.h:922:14: note: 'pgstat_stat_directory'
declared here
extern char *pgstat_stat_directory;
^
guc.c:4373:3: error: use of undeclared identifier 'PG_STAT_TMP_DIR'
PG_STAT_TMP_DIR,
^
guc.c:4374:25: error: use of undeclared identifier
'assign_pgstat_temp_directory'
check_canonical_path, assign_pgstat_temp_directory, NULL
---
Can we get an updated patch?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
patch_32_2972.log
patching file contrib/postgres_fdw/expected/postgres_fdw.out
Hunk #2 FAILED at 9179.
1 out of 2 hunks FAILED -- saving rejects to file
contrib/postgres_fdw/expected/postgres_fdw.out.rej
As this is a minor change therefore I have updated the patch. Please take a
look.
--
Ibrar Ahmed
pgsql14-truncate-on-foreign-table.v3.patch
Description: Binary data
1
step c1: COMMIT;
Can you please take a look at that?
--
Ibrar Ahmed
;
The patch (func.sgml.20210123.diff) does not apply successfully.
http://cfbot.cputube.org/patch_32_2901.log
=== Applying patches on top of PostgreSQL commit ID
0ce4cd04da558178b0186057b721c50a00b7a945 ===
=== applying patch ./func.sgml.20210123.diff
patching file doc/src/sgml/func.sgml
Hunk #1 FAILED at 16968.
Hunk #2 FAILED at 17034.
...
Hunk #19 FAILED at 18743.
19 out of 19 hunks FAILED -- saving rejects to file doc/src/sgml/func.sgml.rej
Can we get a rebase?
I am marking the patch "Waiting on Author".
--
Ibrar Ahmed
ight improvement.
>
> Regards,
>
> --
> Masahiko Sawada
> EDB: https://www.enterprisedb.com/
>
>
>
Regression is failing, can you please take a look.
https://cirrus-ci.com/task/5522445932167168
t/080_pg_isready.pl ... ok
# Failed test 'parallel reindexdb for system with --concurrently skips
catalogs status (got 1 vs expected 0)'
# at t/090_reindexdb.pl line 191.
Bailout called. Further testing stopped: system pg_ctl failed
FAILED--Further testing stopped: system pg_ctl failed
make[2]: *** [Makefile:57: check] Error 255
make[1]: *** [Makefile:43: check-scripts-recurse] Error 2
make: *** [GNUmakefile:71: check-world-src/bin-recurse] Error 2
=== ./contrib/hstore_plperl/log/initdb.log ===
Running in no-clean mode. Mistakes will not be cleaned up.
The files belonging to this database system will be owned by user
"postgres".
This user must also own the server process.
--
--
Ibrar Ahmed
As Commitfest 2021-01 is now closed. I am volunteering to manage next
commitfest.
--
Ibrar Ahmed
Hi,
Anyone else already volunteers that? It is my first time so need some
access, if all agree.
On Mon, Feb 1, 2021 at 10:17 PM Ibrar Ahmed wrote:
> As Commitfest 2021-01 is now closed. I am volunteering to manage next
> commitfest.
>
>
> --
> Ibrar Ahmed
>
--
Ibrar Ahmed
On Thu, Feb 4, 2021 at 2:00 AM David Steele wrote:
> On 2/3/21 3:13 PM, Stephen Frost wrote:
> > Greetings,
> >
> > * Ibrar Ahmed (ibrar.ah...@gmail.com) wrote:
> >> Anyone else already volunteers that? It is my first time so need some
> >> access, if all
>
> Best regards,
> houzj
>
>
> One of the patch
(v10-0001-INSERT-SELECT-to-use-BulkInsertState-and-multi_i.patch) from the
patchset does not apply.
http://cfbot.cputube.org/patch_32_2553.log
1 out of 13 hunks FAILED -- saving rejects to file
src/backend/commands/copyfrom.c.rej
1
make[4]: *** Waiting for unfinished jobs
make[3]: *** [../../../src/backend/common.mk:39: transam-recursive] Error 2
make[2]: *** [common.mk:39: access-recursive] Error 2
make[1]: *** [Makefile:42: all-backend-recurse] Error 2
make: *** [GNUmakefile:11: all-src-recurse] Error 2
I am changing the status to "Waiting on Author"
--
Ibrar Ahmed
ains three columns (integer, text,
varchar).
The total number of rows is 1000 in total.
Unpatched (Master: 92c12e46d5f1e25fc85608a6d6a19b8f5ea02600)
COPY: 9069.432 ms vacuum; 2567.961ms
COPY: 9004.533 ms vacuum: 2553.075ms
COPY: 8832.422 ms vacuum: 2540.742ms
Patched (Master: 92c12e46d5f1e25fc85608a6d6a19b8f5ea02600)
COPY: 10031.723 ms vacuum: 127.524 ms
COPY: 9985.109 ms vacuum: 39.953 ms
COPY: 9283.373 ms vacuum: 37.137 ms
Time to take the copy slightly increased but the vacuum time significantly
decrease.
--
Ibrar Ahmed
On Mon, Aug 17, 2020 at 2:19 PM Hamid Akhtar wrote:
> Unfortunately the latest patch doesn't apply cleanly on the master branch.
> Can you please share an updated one.
Please see the attached patch rebased with master (
a28d731a1187e8d9d8c2b6319375fcbf0a8debd5)
--
Ibrar Ahmed
On Wed, Aug 19, 2020 at 6:15 PM Anastasia Lubennikova <
a.lubennik...@postgrespro.ru> wrote:
> On 18.08.2020 02:54, Alvaro Herrera wrote:
> > On 2020-Aug-14, Ibrar Ahmed wrote:
> >
> >> The table used for the test contains three columns (integer, text,
> >>
On Thu, Aug 27, 2020 at 2:14 AM Anastasia Lubennikova <
a.lubennik...@postgrespro.ru> wrote:
> On 21.08.2020 19:43, Ibrar Ahmed wrote:
>
>
>
> On Wed, Aug 19, 2020 at 6:15 PM Anastasia Lubennikova <
> a.lubennik...@postgrespro.ru> wrote:
>
>> On 18.08.20
n │ 1
>
> Thanks,
>
> I think it is a lot of work if you want I can help with that. (Just start
getting your messages on threads)
> --
> Álvaro Herrerahttps://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
>
>
--
Ibrar Ahmed
Please create separate commitfest entry.
:ltree;
> ltree
> ---
> a
> (1 row)
>
>
> 2. '*{a}.*{b}.*{c}' is not equivalent to '*{a+b+c}' (as I expect):
>
> SELECT ltree '1.2' ~ '*{2}';
> ?column?
> --
> t
> (1 row)
>
> -- expected true
> SELECT ltree '1.2' ~ '*{1}.*{1}';
> ?column?
> --
> f
> (1 row)
>
>
> Maybe these two bugs need a separate thread?
>
>
> Please create separate commitfest entry.
> --
> Nikita Glukhov
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
>
>
>
--
Ibrar Ahmed
le command.
>
What about have an API to get the single file or list of files? We will use
a single file in
our application and other tools can get the benefit of list of files.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
--
Ibrar Ahmed
les or one
TAR file per thread. I really want to have a single tar file because the
main purpose of the TAR file is to
reduce the management of multiple files, but in case of one file per
thread, we end up with many tar
files. Therefore we need to have one master thread which is responsible for
writing on tar file and all
the other threads will receive the data from the network and stream to the
master thread. This also
supports the idea of using a thread-based model rather than a process-based
approach because it
requires too much data sharing between processes. If we cannot achieve
this, then we can disable the
TAR option for parallel backup in the first version.
- In the case of data sharing, we need to try to avoid unnecessary locking
and more suitable algorithm to
solve the reader-writer problem is required.
--
Ibrar Ahmed
success = listCasts(pattern, show_verbose
This can be achieved with the list/array/hash table, so I have changed that
code in the attached patch just for a sample if you want I can do that for
whole code.
--
Ibrar Ahmed
The new status of this patch is: Waiting on Author
Hi Corey,
Here is the modified patch (sample).
On Mon, Mar 4, 2019 at 7:02 PM Ibrar Ahmed wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: not tested
> Spec compliant:
Hi
Patch work fine to me, but I have one test case where default partition still
scanned.
postgres=# explain select * from test1 where (id < 10) and true;
QUERY PLAN
---
Ap
Hi Yuzuko Hosoya,
Ignore my last message, I think this is also a legitimate scan on default
partition.
On Mon, Mar 4, 2019 at 10:29 PM Ibrar Ahmed wrote:
> Hi
>
> Patch work fine to me, but I have one test case where default partition
> still scanned.
>
> postgres=# exp
The patch requires to rebase on the master branch.
The new status of this patch is: Waiting on Author
Hi Paul,
I have rebased the patch to master (1e2fddfa33d3c7cc93ca3ee0f32852699bd3e012)
and fixed some compilation warning. Now I am reviewing the actual code.
On Fri, Jul 26, 2019 at 6:35 PM Ibrar Ahmed wrote:
> The patch requires to rebase on the master branch.
>
> The new statu
mat.
> > I implemented the simplest one, while there are more ideas:
>
> I think we should start simple.
>
> I haven't had a chance to look at Jeevan's patch at all, or yours in
> any detail, as yet, so these are just some very preliminary comments.
> It will be good, however, if we can agree on who is going to do what
> part of this as we try to drive this forward together. I'm sorry that
> I didn't communicate EDB's plans to work on this more clearly;
> duplicated effort serves nobody well.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
--
Ibrar Ahmed
The patch does not work.
postgres=# CREATE TABLE foo (id int,r int4range, valid_at tsrange, CONSTRAINT
bar_pk PRIMARY KEY (r, valid_at WITHOUT OVERLAPS));
CREATE TABLE
postgres=# CREATE TABLE bar (id int,r int4range, valid_at tsrange, CONSTRAINT
bar_fk FOREIGN KEY (r, PERIOD valid_at) REFERENCES
Hi,
I have rebased the patch and currently reviewing the patch
on master (1e2fddfa33d3c7cc93ca3ee0f32852699bd3e012).
On Mon, Jul 1, 2019 at 4:45 PM Thomas Munro wrote:
> On Wed, Apr 3, 2019 at 2:12 AM Ibrar Ahmed wrote:
> > I start looking at the patch, there is a couple of prob
Hi Paul,
On Mon, Aug 5, 2019 at 3:11 AM Paul A Jungwirth
wrote:
> On Fri, Aug 2, 2019 at 1:49 PM Ibrar Ahmed wrote:
> > I did some clean-up on this patch. I have also refactored a small
> portion of the code
> > to reduce the footprint of the patch. For simplicity, I have d
On Tue, Aug 6, 2019 at 8:28 PM Paul Jungwirth
wrote:
> Hi Ibrar,
>
> On 8/6/19 3:26 AM, Ibrar Ahmed wrote:
> > - Why we are not allowing any other datatype other than ranges in the
> > primary key. Without that there is no purpose of a primary key.
>
> A temporal prim
s opinion on this.
>
> 9)
> + printf(_(" -i, --incr-backup=DIRECTORY incremental backup directory
> (maximum %d)\n"), MAX_INCR_BK_COUNT);
> + printf(_(" -o, --output-dir=DIRECTORY combine backup into
> directory\n"));
> + printf(_("\nGeneral options:\n"));
> + printf(_(" -n, --no-clean do not clean up after
> errors\n"));
>
> Combine backup into directory can be combine backup directory
>
> 10)
> +/* Max number of incremental backups to be combined. */
> +#define MAX_INCR_BK_COUNT 10
> +
> +/* magic number in incremental backup's .partial file */
>
> MAX_INCR_BK_COUNT can be increased little, some applications use 1
> full backup at the beginning of the month and use 30 incremental
> backups rest of the days in the month
>
> Regards,
> Vignesh
> EnterpriseDB: http://www.enterprisedb.com
>
>
>
--
Ibrar Ahmed
On Tue, Aug 6, 2019 at 11:31 PM Ibrar Ahmed wrote:
>
> I have not looked at the patch in detail, but just some nits from my side.
>
> On Fri, Aug 2, 2019 at 6:13 PM vignesh C wrote:
>
>> On Thu, Aug 1, 2019 at 5:06 PM Jeevan Chalke
>> wrote:
>> >
>>
ead the whole 1GB into Ram.
>
>> --
>> Robert Haas
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Jeevan Chalke
> Technical Architect, Product Development
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
--
Ibrar Ahmed
macros.
>
> +1
>
> regards, tom lane
>
>
>
--
Ibrar Ahmed
initdb-print_v2.patch
Description: Binary data
+1
Patch successfully applied to the master (
43211c2a02f39d6568496168413dc00e0399dc2e)
On Thu, Aug 8, 2019 at 12:30 PM Mark G wrote:
> Hello all,
>
> Please find attached a trivial patch making a few arrays const (in
> addition to the data they point to).
>
>
>
--
Ibrar Ahmed
On Fri, Aug 9, 2019 at 1:25 AM Mark G wrote:
>
>
> On Thu, Aug 8, 2019 at 8:25 PM Ibrar Ahmed wrote:
>
>> +1
>>
>> Patch successfully applied to the master (
>> 43211c2a02f39d6568496168413dc00e0399dc2e)
>>
>
> That change looks like an unrelated p
;
+1 for using fopen(), fread(), fwrite(), and fclose()
> Let me know if we still want to go with native OS calls.
>
>
-1 for OS call
>
>> --
>> Robert Haas
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Jeevan Chalke
> Technical Architect, Product Development
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
--
Ibrar Ahmed
NSERT INTO test VALUES(:two,0,0);
> > [...]
> > client 0 script 0 aborted in command 1 query 0: ERROR: syntax error at
> or near ":"
>
> Indeed, the user should test whether the variable was assigned before
> using it if the result is not warranted to return one row.
>
> > The new status of this patch is: Waiting on Author
>
> The attached patch implements the altered behavior described above.
>
> --
> Fabien.
--
Ibrar Ahmed
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
The patch passed my review, I have not reviewed the documentation
Patch conflict with this assertion
Assert(pstate->p_expr_kind == EXPR_KIND_UPDATE_SOURCE);
src/backend/parser/parse_expr.c line 1570
The new status of this patch is: Waiting on Author
ould greatly increase IO cost which could attribute to the problem.
> However, I am really not sure what UNION ALL actually does to append both
> result sets so I was wondering if someone would be able to help me out with
> this.
>
>
>
>
> Mark
>
>
> 066ce...@free.fr: Please, avoid top-posting. It makes harder to follow
the
discussion.
--
Ibrar Ahmed
p://www.enterprisedb.com
>>
>
>
> Attached new sets of patches with refactoring done separately.
> Incremental backup patch became small now and hopefully more
> readable than the first version.
>
> --
> Jeevan Chalke
> Technical Architect, Product Development
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
+ buf = (char *) malloc(statbuf->st_size);
+ if (buf == NULL)
+ ereport(ERROR,
+ (errcode(ERRCODE_OUT_OF_MEMORY),
+errmsg("out of memory")));
Why are you using malloc, you can use palloc here.
--
Ibrar Ahmed
bles/indexes key and a WAL key, plus keys for
> rotation. I explained why per-tablespace keys don't add much value.
>
> --
> Bruce Momjian http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + As you are, so once was I. As I am, so you will be. +
> + Ancient Roman grave inscription +
>
--
Ibrar Ahmed
need a consensus on that. Do we really need
that
feature or not. In the previous discussion, there was no resistance to have
that
in PostgreSQL, but some problem with the patch. Current patch is very simple
and not invasive, but still, we need a consensus on that.
Along with users, I request some senior hackers/committers to also
> weigh in about the desirability of this feature.
>
> --
> With Regards,
> Amit Kapila.
> EnterpriseDB: http://www.enterprisedb.com
>
>
>
--
Ibrar Ahmed
On Fri, Aug 16, 2019 at 4:12 PM Ibrar Ahmed wrote:
>
>
>
>
> On Fri, Aug 16, 2019 at 3:24 PM Jeevan Chalke <
> jeevan.cha...@enterprisedb.com> wrote:
>
>>
>>
>> On Fri, Aug 2, 2019 at 6:43 PM vignesh C wrote:
>>
>>> Some comments:
>
t group are
moon_insung...@lab.ntt.co.jp,
sawada.m...@gmail.com,
shawn.w...@highgo.ca,
ahsan.h...@highgo.ca,
ibrar.ah...@gmail.com
I am able to do that for others as well.
>
> --
> Bruce Momjian http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + As you are, so once was I. As I am, so you will be. +
> + Ancient Roman grave inscription +
>
--
Ibrar Ahmed
nCacheRelCallback and
> PlanCacheObjectCallback a bit so when a CachedPlanSource is invalidated
> the query_list is not only marked as invalid but it is also fully
> released to free memory here.
>
> Regards,
> Daniel Migowski
>
> PS@Konstantin: This patch also includes the CachedPlanMemoryUsage
> function you like, maybe you like the review the patch for me?
>
>
--
Ibrar Ahmed
ows=0 loops=1)
Workers Planned: 2
Workers Launched: 2
-> Parallel Seq Scan on test (cost=0.00..97294.74 rows=1 width=8)
(actual time=1616.000..1616.000 rows=0 loops=3)
Filter: (b > 1)
Rows Removed by Filter: 337
Planning Time: 0.699 ms
Execution Time: 1622.325 ms
(8 rows)
--
Ibrar Ahmed
u can have some
worker threads.
But before doing that need to see the pg_basebackup bottleneck, after that,
we
can see what is the best way to solve that. Some numbers may help to
understand the
actual benefit.
--
Ibrar Ahmed
nd possibly
> encryption, and so it'd likely make sense to just have independent
> processes and connections through which to do that.
>
> +1 for compression and encryption, but I think parallelism will give us
the benefit with and without the compression.
Thanks,
>
> Stephen
>
--
Ibrar Ahmed
coverage can be seen in the before and after
> pictures of GCOV test coverage analysis summary.
>
> The attached patch contain the test cases added in regression for
> increasing the coverage.
>
>
> --
> Movead Li
>
Hi Movead,
Please add that to commitfest.
--
Ibrar Ahmed
es it match the behavior of other
> > > PostgreSQL programs.
> >
> > +1 ... are we missing this anywhere else?
>
> I did some searching, and oid2name.c is also missing this.
>
> Yes, "oid2name" missing that check too.
--
Ibrar Ahmed
0001-oid2name-Error-out-on-too-many-command-line-argume.patch
Description: Binary data
On Mon, Aug 26, 2019 at 9:46 AM Michael Paquier wrote:
> On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote:
> > I did some searching, and oid2name.c is also missing this.
>
> And pgbench, no?
>
Yes, the patch is slightly different.
> --
> Michael
&g
egards, Sergei
Please add that to commitfest.
--
Ibrar Ahmed
m just curious why we need that "pg_get_databasebyid"
function. Is there a need for this function for the user?
--
Ibrar Ahmed
gt;
Hi,
I think its a user request and don't require to be in the core of
PostgreSQL.
A simple SQL function can fulfill the requirement of the user.
CREATE OR REPLACE FUNCTION pg_get_databasebyid(dboid integer) RETURNS name
AS $$
SELECT datname from pg_database WHERE oid = dboid;
$$ LANGUAGE SQL;
--
Ibrar Ahmed
the
capability
in pg_basebackup to do that.
> I don't
> think it's worth doing that at this point; I definitely don't think it
> needs to be part of the first patch.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
--
Ibrar Ahmed
On Tue, Sep 3, 2019 at 6:00 PM Robert Haas wrote:
> On Sat, Aug 31, 2019 at 3:41 PM Ibrar Ahmed wrote:
> > Are we using any tar library in pg_basebackup.c? We already have the
> capability
> > in pg_basebackup to do that.
>
> I think pg_basebackup is using homebrew co
On Tue, Sep 3, 2019 at 8:00 PM Tom Lane wrote:
> Ibrar Ahmed writes:
> > +1 using the library to tar.
>
> Uh, *what* library?
>
I was just replying the Robert that he said
"But I think there must be a reason why tar libraries exist,
and I don't want to write a new
On Tue, Sep 3, 2019 at 7:39 PM Robert Haas wrote:
> On Tue, Sep 3, 2019 at 10:05 AM Ibrar Ahmed wrote:
> > +1 using the library to tar. But I think reason not using tar library is
> TAR is
> > one of the most simple file format. What is the best/newest format of
> TAR?
&
already a pretty high barrier at a lot
of organizations,it requires a shared_preload_libraries setting,
which is pretty close to untenable in a lot of use cases.
We are thinking to move a module in core just because of
"barrier for turning it on is quite high" which is not a very compelling
reason. I am just thinking
why not have a system which makes that easy instead of adding to core.
--
Ibrar Ahmed
?
>
> Yes, it is related to that, but we don't have that on our agenda in a
weekly meeting. It has
many conflicting points about what we are doing. Swada / Bruce can comment
on that.
> --
> Álvaro Herrerahttps://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
>
>
--
Ibrar Ahmed
, Hamid Akhtar is
also working with me on this
work.
--
Ibrar Ahmed
P COLUMN might be
> necessary to alleviate that situation.
>
>
- Is this intentional not implemented the "RENAME COLUMN" statement for
VIEW because it is implemented for Materialized View? I have made just a
similar
change to view and it works.
ALTER
On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao wrote:
> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed wrote:
> >
> >
> >
> > On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao
> wrote:
> >>
> >> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote:
> >>
On Thu, Oct 31, 2019 at 5:11 PM Ibrar Ahmed wrote:
>
>
> On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao wrote:
>
>> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed
>> wrote:
>> >
>> >
>> >
>> > On Thu, Oct 31, 2019 at 12:32 PM Fujii Masa
On Thu, Oct 31, 2019 at 5:28 PM Ibrar Ahmed wrote:
>
>
> On Thu, Oct 31, 2019 at 5:11 PM Ibrar Ahmed wrote:
>
>>
>>
>> On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao
>> wrote:
>>
>>> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed
>>> wro
once this bug
> is fixed. I have also checked other calls of this API and the
> handling is done correctly.
>
> The patch works for me on master and on 12. I have rebased the patch for
Version 11.
> Wyatt, what do you think?
> --
> Michael
>
--
Ibrar Ahmed
diff --git a/src/backe
7 Support, Remote DBA, Training & Services
>
>
>
I have updated the patch using OIDs > 8000
--
Ibrar Ahmed
v4-0001-Add-RESUME-option-to-VACUUM-and-autovacuum.patch
Description: Binary data
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Patch looks to me and works on my machine
73025140885c889410b9bf
of windows.
Hmm, need to remove the assert in the function
"setup_cancel_handler"
-- Ibrar Ahmed
IZED VIEW mv RENAME COLUMN a to r;
ALTER TABLE
Attached patch fixes that for ALTER VIEW , ALTER MATERIALIZED VIEW and
ALTER FOREIGN TABLE
# ALTER MATERIALIZED VIEW mv RENAME COLUMN a to r;
ALTER MATERIALIZED VIEW
# ALTER FOREIGN TABLE ft RENAME COLUMN a to t;
ALTER FOREIGN TABLE
--
Ibrar Ahmed
001_alter_tag_ibrar_v1.patch
Description: Binary data
On Fri, Nov 1, 2019 at 8:00 AM Fujii Masao wrote:
> On Fri, Nov 1, 2019 at 6:34 AM Ibrar Ahmed wrote:
> >
> >
> >
> > On Thu, Oct 31, 2019 at 6:56 PM Tom Lane wrote:
> >>
> >> Fujii Masao writes:
> >> > ... I found that the command tag
was on the 1st of November of course.
> --
> Michael
>
--
Ibrar Ahmed
creates an array of ItemPointers and allocates
memory in chunks by dividing the maintenance_work_mem into multiple chunks.
Comments?
--
Ibrar Ahmed
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c
index a3c4a1df3b..73922a2e34 100644
--- a/src/backend/access
On Mon, Dec 9, 2019 at 11:54 PM Alvaro Herrera
wrote:
> On 2019-Dec-09, Ibrar Ahmed wrote:
>
> > Hi,
> >
> > The memory consumption of VACUUM has some issues and could be improved.
> > Some of its limitations are recorded in the comments of the
> “vacuumlazy.c
You are checking file->dirty twice, first before calling the function and
within the function too. Same for the Assert. For example.
size_t
BufFileRead(BufFile *file, void *ptr, size_t size)
{
size_t nread = 0;
size_t nthistime;
if (file->dirty)
{
BufFi
On Wed, Dec 11, 2019 at 7:29 PM Robert Haas wrote:
> On Mon, Dec 9, 2019 at 2:02 PM Ibrar Ahmed wrote:
> >> Did you see this thread?
> >>
> https://postgr.es/m/CAGTBQpbDCaR6vv9=scXzuT8fSbckf=a3ngzdwfwzbdvugvh...@mail.gmail.com
> >>
> > Yes, and somehow di
On Wed, Dec 11, 2019 at 9:29 PM Ibrar Ahmed wrote:
>
>
> On Wed, Dec 11, 2019 at 7:29 PM Robert Haas wrote:
>
>> On Mon, Dec 9, 2019 at 2:02 PM Ibrar Ahmed wrote:
>> >> Did you see this thread?
>> >>
>> https://postgr.es/m/CAGTBQpbDCaR6vv9=s
user of the KMS and pgcrypto can be more
> powerful with the KMS. I'll register this KMS patch to the next Commit
> Fest.
>
> It is already there "KMS - Internal key management system" (
https://commitfest.postgresql.org/26/2196/).
I really appreciate peoples (CC-ing) who participated in off-list
> discussion/meeting for many inputs, suggestions and reviewing codes.
>
> Regards,
>
>
> --
> Masahiko Sawada http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
--
Ibrar Ahmed
her hand yet, but let's see. If you take care
> of it, that would be great. Thanks!
> --
> Michael
> I want to be this time. This is my first time doing this.
--
Ibrar Ahmed
1 - 100 of 214 matches
Mail list logo
