On Wed, Aug 7, 2019 at 2:47 PM Jeevan Chalke <jeevan.cha...@enterprisedb.com> wrote:
> > > On Mon, Aug 5, 2019 at 7:13 PM Robert Haas <robertmh...@gmail.com> wrote: > >> On Fri, Aug 2, 2019 at 9:13 AM vignesh C <vignes...@gmail.com> wrote: >> > + rc = system(copycmd); >> >> I don't think this patch should be calling system() in the first place. >> > > So, do you mean we should just do fread() and fwrite() for the whole file? > > I thought it is better if it was done by the OS itself instead of reading > 1GB > into the memory and writing the same to the file. > > It is not necessary to read the whole 1GB into Ram. > >> -- >> Robert Haas >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Jeevan Chalke > Technical Architect, Product Development > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > > -- Ibrar Ahmed
