Hi Michael,
Thank you so much for your help. I am new to PG development, I'll keep
learning. :)
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
Michael Paquier 于2025年8月2日周六 18:55写道：
> On Fri, Aug 01, 2025 at 03:16:18PM +0800, Chao Li wrote
I just noticed that my IDE auto formatted guc_tables.c, which generated a
lot of unnecessary diffs. Recreated the patch, and attach the v2 version.
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
Chao Li 于2025年8月4日周一 15:57写道：
> Oh, I forget
I tested this patch locally and it works for me.
However I doubt if it really improve performance. The original code
"contain_volatile_functions((Node *) rte->values_lists)" recursively work
through rte-values_list, and this patch move contain_volatile_functions() into
the for loop, and checks
ease note may recommend the tools.
Regards,
Chao Li (Evan)
--
HighGo Infra. Software Inc.
https://www.highgo.com/
CommitFests patch created: https://commitfest.postgresql.org/patch/5946/
> 2025年8月4日 16:17，Chao Li 写道：
>
> I just noticed that my IDE auto formatted guc_tables.c, which generated a lot
> of unnecessary diffs. Recreated the patch, and attach the v2 version.
>
Hi,I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to correct it.I ran a basic test of “make check” and the test passed.
v1-0001-Fix-a-minor-typo-in-code-comment.patch
Description: Binary data
Chao Li (Evan
Updated the patch to v3 version.
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
Chao Li 于2025年8月5日周二 14:25写道：
> CommitFests patch created: https://commitfest.postgresql.org/patch/5946/
>
> 2025年8月4日 16:17，Chao Li 写道：
>
> I just noti
It looks weird. From https://www.postgresql.org/message-id/1CA8625F-AA41-4ED2-B60F-E28AC71F37DC%40highgo.com, I don’t see the attachment of the patch file. However, the email in my Inbox has the attachment.Try to resend the attachment.
Chao Li (Evan)HighGo Infra. Software
again without map file change# nothing re-compiled
Chao Li (Evan)HighGo Infra. Software Inc.https://www.highgo.com/
v1-0001-Enhance-Makefiles-to-rebuild-objects-on-map-file-.patch
Description: Binary data
I am fine with that, and thanks for the v2 patch.
Chao Li (Evan)
HighGo Infra. Software Inc.
https://www.highgo.com/
> On Aug 6, 2025, at 12:11, Fujii Masao wrote:
>
> On Wed, Aug 6, 2025 at 8:11 AM Chao Li wrote:
>>
>> Hi,
>>
>> I d
ansactions and in-progress transactions
won't see the newly created index. So, it should be ok for the index to
point to the newest version of tuple version that is visible to the index.
Can anyone please explain me about that?
Thanks and regards,
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
raw
parse tree, turning on a flag once is much more convenient than typing a
command in the debugger for every trace.
I will wait to see if Tom still objects to adding that. I will not make the
code change unless I see a hint of "go".
Chao Li (Evan)
--
H
This explanation sounds reasonable to me. I didn't mean to "optimize" the
logic, I was just trying to understand the behavior.
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
David G. Johnston 于2025年8月1日周五 15:50写道：
> On Friday, Au
try.
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
Tender Wang 于2025年8月1日周五 14:37写道：
>
>
> Chao Li 于2025年8月1日周五 14:16写道：
>
>> Hi Community,
>>
>> Let me use a small example to demonstrate my observation.
>>
>>
Hi Committers,
I happened to catch this typo while reading the regression test code, so
submitting a fix.
As the typo is in the code comment, no test needs to run.
Best regards,
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
v1-0001-Fixed-a-typo-in
Thanks a lot for the comment, then please discard this patch.
David G. Johnston 于2025年8月1日周五 10:12写道：
> On Thu, Jul 31, 2025 at 6:57 PM Chao Li wrote:
>
>>
>> I'm using VS Code to work on PostgreSQL, and the .vscode folder
>> constantly shows up in "git sta
mode, don't use -O
if test "$enable_debug" != yes; then
CFLAGS="-O"
fi
fi
For GCC, we need to use "-O0" for best debugging experience. Why here
always uses "-O2" for GCC regardless debugging?
If confirmed a bug, I'd like a submit a patch to fix that.
Thanks,
Chao Li (Evan)
HighGo Inc.
logging in.
You have not passed the cool off period yet.
```
How long is the cool off period? I am going to submit a patch, so I need to
log in to CommitFests.
My account is li.evan.c...@gmail.com
Thanks will be greatly appreciated.
Chao Li (Evan)
HighGo Inc.
for a while, it should be no harm.
Attached is the patch file.
Thanks a lot.
Chao Li (Evan)
=
HighGo Inc.
v1-0001-Trivial-ignore-IDE-specific-files-.vscode.patch
Description: Binary data
Hi David,
I see. That was my first submission. I have a few more patches to submit,
your suggestion really helps.
Chao Li (Evan)
David G. Johnston 于2025年8月1日周五 10:25写道：
> On Thu, Jul 31, 2025 at 7:15 PM Chao Li wrote:
>
>> Thanks a lot for the comment, then please discar
No worries. I am in now.
Chao Li 于2025年8月1日周五 08:19写道：
> Hi CommitFests maintainers,
>
> I logged in to the PostgreSQL site via my Google account a couple of
> days ago, and I still cannot log in to CommitFests. The error I got is:
>
> ```
>
> The site you
Hi Tom,
Thanks for the explanation. W.R.T the PROFILE variable, I tried:
# ./configure --enable-debug
# PROFILE="-O0" make
As a result, both "-O2" and "-O0" presented to gcc. In that case, I believe
"-O0" will be ignored by gcc.
Did yo
My bad. You are right, the last -O will work. Then I think I get a solution
to my original problem. Thanks again for your help.
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
Tom Lane 于2025年8月1日周五 12:07写道：
> Chao Li writes:
> > Thank
irm with the
community if it's intentional to not dump raw parse tree? If we really
don't want to dump raw parse tree again "debug_print_parse", are you ok to
add a new option "debug_print_raw_parse"?
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
> But what if the table already has an index?
I have tested that, if I create the index first, then update the tuple, the
index entry will only point to the new version of data. That's why my
question was specifically about creating the index after updating the tuple.
Chao
Ah ... Good to learn. Attached v2 updated the out file as well, now the
test passed:
$ make check
...
# All 229 tests passed.
Thanks a lot.
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
Michael Paquier 于2025年8月1日周五 15:04写道：
> On Fri, Aug 01, 2
ion is that, if start "postgres -d 3", it
originally only turn on debug_print_parse, now it will turn on
debug_print_raw_parse as well, which potentially make people who don't want
raw parse tree unhappy. Maybe use "-d 5" or not turning on
debug_print_raw_parse at all by "-d&quo
Oh, I forget to attached the patch file, here comes it.
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
Chao Li 于2025年8月4日周一 15:53写道：
> I was reviewing some patches today, and during debugging the patches, I
> wanted to view raw parse tree, so
minimum changes to map files.
I would prefer option 2 or 3, and slightly more keen on 3. What do you think?
Best regards,
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
ING FROM LOSS OF USE, DATA OR PROFITS,
WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING
OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THE DATA FILES OR
SOFTWARE.
Unicode and the Unicode logo are trademarks of Unicode, Inc. in the United
States and other countries. A
I tested the patch. Basically all of my test cases passed. Just a few small
comments:
+ if (subkey->sk_attno > firstchangingattnum) /*
>, not >= */
+ break;
Can we enhance the comment to something like ">, not >= because
first
> On Aug 15, 2025, at 14:37, Chao Li wrote:
>
> When subkey->sk_attno <= firstchangingattnum, if first is not satisfied, then
> last should not be satisfied either, so we can skip check last.
Sorry for a typo, "subkey->sk_attno <= firstchangingattnum”
I downloaded the patch and tested all join types: inner, left, right, full,
semi and anti. Basically my tests all passed. However, I didn't test any case
of parallel query.
I have two nit comments:
1. In hashjoin.h, line 76-78, the added comment says "(In the unlikely but
supported case of a n
is “plain/text” now in “Archives”.
Regards,
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
2022) but we can consider that later. For now let's leave the
> XML file alone.
>
Sounds good. Let me recreate the patch.
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
> On Aug 13, 2025, at 17:16, Chao Li wrote:
>
> I downloaded the patch and tested all join types: inner, left, right, full,
> semi and anti. Basically my tests all passed. However, I didn't test any case
> of parallel query.
>
> I have two nit comments:
>
&
I applied the batch and built the html docs. I tested that all hyperlinks
worked for me.
There are a few nit comments about wording:
diff --git a/doc/src/sgml/logicaldecoding.sgml
b/doc/src/sgml/logicaldecoding.sgml
index 593f784b69d..4516650983d 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+
tested
again. Now this patch looks good to me.
BTW, in the pushed commit, when you add me as a reviewer, would you please use
my company email address: "Chao Li ". Thanks a lot.
The new status of this patch is: Ready for Committer
Hi Hackers,
While reviewing the code, I found the original comment difficult to
follow, so I am trying to rephrase it for clarity.
Regards,
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/From d4bfb58e2904c919f0891643142fc87069a2c69d Mon Sep 17 00:00:00
e implied to me that the patch added something not in the
> upstream file.
>
I will update the commit message in the new patch.
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
are no longer required by the new standard, but are
> retained in this patch for compatibility"
>
> How is that done?
The 9 mappings are not changed between 2000.ucm and 2022.ucm. For example,
GB18030 code 0xFD9C is one of the 9 not-required code, but the mapping:
\xFD\x9C
I can use a separate
commit to add "unlikely".
Best regards,
--
Chao Li (Evan)
--
HighGo Software Inc.
https://www.highgo.com/
From bef138c16e78c815bb653db37a01c28cd024abd5 Mon Sep 17 00:00:00 2001
From: "Chao Li (HighGo Inc.)"
Date: Thu, 31 Ju
> On Aug 16, 2025, at 00:52, Tom Lane wrote:
>
> Chao Li writes:
>> With this patch, “isnull” now becomes true because of the change of strict
>> op. Then the outer null join key tuple must be stored in a tuplestore. When
>> an outer table contains a lot of nul
and the receiving variable “page”
is of “Page” type as well, so the cast is not needed.
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
From 5b5462398117acd0203e760b7bf18c4ff616cf81 Mon Sep 17 00:00:00 2001
From: "Chao Li (Evan)"
Date: Thu, 21 Aug 2025 11:35:18 +0800
Subject: [PATCH v1] Remove redundant assignemnt in CreateWorkExprC
Hi Zhijie,
> On Aug 21, 2025, at 11:41, Zhijie Hou (Fujitsu)
> wrote:
>
>
>
Thanks for working on the patch. I tested it locally, and it worked for me
properly.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
On 2025/8/13 15:20, Chao Li wrote:
Sounds good. Let me recreate the patch.
Attached is the new patch. It downloads the UCM file in make:
```
Unicode % make gb18030_to_utf8.map
wget -O gb-18030-2000.ucm --no-use-server-timestamps
https://raw.githubusercontent.com/unicode-org/icu-data
"debug_print_raw_parse" is "on".
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
From a2501a6cb70a9bb198163acbdef043290fd85b53 Mon Sep 17 00:00:00 2001
From: "Chao Li (HighGo Inc.)"
Date: Thu, 31 Jul 2025 17:02:32 +0800
Subject: [PATCH v5] Add
ore details.
I traced this problem today, and I agree that making FuncnameGetCandidates to
pass out some information should be right direction to go.
When there are multiple matches, I think we can find the best match by
considering argument names/types, default values. If there are still multiple
b
Nothing to be done for `generated-headers'.
/Library/Developer/CommandLineTools/usr/bin/make -C nodes
generated-header-symlinks
make[2]: Nothing to be done for `generated-header-symlinks'.
/Library/Developer/CommandLineTools/usr/bin/make -C utils
generated-header-symlinks
/Library/Developer/CommandLineTools/usr/bin/make -C adt jsonpath_gram.h
make[3]: `jsonpath_gram.h' is up to date.
```
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
t; tuples that (probably) don't have null join keys. The fact that you
> could cram it in with not very many lines of code does not mean that
> the result will be understandable or maintainable --- and certainly,
> hash join is on the hairy edge of being too complicated already.
>
&
worry about registering hash_seq_search scans,
Looks like a bad auto replacement: “no longer”, here “long" should be kept.
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
any email
link or attachment link.
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
> On Sep 5, 2025, at 16:29, Chao Li wrote:
>
>
>
>> On Sep 5, 2025, at 14:24, Kirill Reshke wrote:
>> --
>> Best regards,
>> Kirill Reshke
>>
>
>
> LGTM. SlruRecentlyUsed() is now an inline function.
>
After pulling master, I ju
LKIND_PARTITIONED_TABLE” is clearer and more
reliable. Consider if some other kind is added, then “kind != RELKIND_SEQUENCE”
might be broken, and hard to find the root cause.
4 -0006
```
- appendStringInfo(&cmd, "SELECT DISTINCT n.nspname, c.relname,
gpt.attrs\n"
+ appendStringInfo(&cmd, "SELECT DISTINCT n.nspname, c.relname,
gpt.attrs, c.relkind\n"
```
There is an extra whitespace before “c.relkind”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
> On Sep 5, 2025, at 14:24, Kirill Reshke wrote:
> --
> Best regards,
> Kirill Reshke
>
LGTM. SlruRecentlyUsed() is now an inline function.
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
> On Sep 5, 2025, at 18:06, Tatsuo Ishii wrote:
>
> Hi,
>
> v7 patch looks good to me. BTW, how do you want to be credited in the
> commit message?
>
> Author: Chao Li mailto:l...@highgo.com>>
> Author: Chao Li mailto:li.evan.c...@gmail.com>>
>
&g
Hi Tatsuo san,
I just rebased the commit for the GUC change.
On Sep 3, 2025, at 09:57, Tatsuo Ishii wrote:
That's 0.3% difference, definitely noise-level. Ok, I withdraw my
claim and commit the patch without unlikely().
I also removed unlikely() in v7.
Best regards,
--
Chao Li (Evan)
H
be only used in dev environment, and we can clearly
state the limitation in doc.
The attached patch is unpolished. You may download and test it. Please
mainly focus on the design for now. Once the design is agreed by the
community, I will polish the change, add tests and update the doc.
[1]
https:
> On Aug 27, 2025, at 15:26, Chao Li wrote:
>
> diff --git a/src/include/parser/parse_node.h b/src/include/parser/parse_node.h
> index f7d07c84542..58a4b9df157 100644
> --- a/src/include/parser/parse_node.h
> +++ b/src/include/parser/parse_node.h
> @@ -361,7 +361,7 @@ e
> On Aug 18, 2025, at 16:50, Chao Li wrote:
>
>
>
Hi John,
Any follow up on this patch?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
same way as HeapTuple like “typedef
structure ParamListInfoData *ParamListInfo”. I tried that in my local and build
still passed.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
ew other comments. Let me raise
them in a separate email.
Regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
hj_JoinState is already int, so the cast seems unnecessary.
> So I remove it in the attached patch.
>
> --
> Thanks,
> Tender Wang
> <0001-Fix-an-unnecessary-cast-calling-elog-in-ExecHashJoin.patch>
Yes, hj_JoinState is of type int, so the type cast to int is not needed.
Hi Tatsuo san,
Rebased v6 is attached.
Chao Li (Evan)
-
HighGo Software Co., Ltd.
https://www.highgo.com/
Tatsuo Ishii 于2025年9月1日周一 10:13写道：
> Hi Chao Li,
>
> >> v5 patch looks good to me. If there's no objection, I plan to push the
> >
refstate->upperindexnull[i] = true;
+ }
+ else {
+ sbsrefstate->upperprovided[i] = true;
```
This is also a nit comment about code format. “{" should be put to the next
line of “else” according to other existing code.
Best regards,
--
C
> On Sep 2, 2025, at 10:59, Chao Li wrote:
>
> jsonbsubs doesn’t need to check is_slice flag as well, I will explain that in
> my next email tougher with my new comments.
Now jsonb_check_json_needed() loops over all indirections:
static bool
jsonb_check_jsonpath_needed(List
he error message is kinda misleading and unnecessary. So I created a fix.
>From the code comment in pg_waldump.c, the same change should be applied to
pg_walinspect. If this patch is accepted, I will then work on pg_walinspect
as well.
Best regards,
Chao Li (Evan)
-
HighG
> On Aug 29, 2025, at 15:22, Chao Li wrote:
>
> +static bool
> +jsonb_check_jsonpath_needed(List *indirection)
> +{
> + ListCell *lc;
> +
> + foreach(lc, indirection)
> + {
> + Node *accessor = lfirst(lc);
> +
> +
bscriptTransform(). That’s why I ended up suggesting removing “is_slice” from
SubscriptTransform().
Does that sound reasonable?
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
ndex [0] directly following
the data column, regardless what indirections are followed, it’s by default lax
mode.
So, I think this is a design decision. Maybe I missed something from your
previous design, but I don’t find anything about that from the commit comments.
I feel this would be better aligned with 1) and 2).
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
le = ExecCopySlotHeapTuple(slot);
visible = HeapTupleSatisfiesVisibility(tuple, GetActiveSnapshot(),
slot->tts_tableOid);
return visible;
}
```
This seems also work for me. WDYT?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
was 32, then I
thought log_cnt might get decreased if I ran nextval() again, but it didn’t.
Only after I ran 10 (cache size) more nextval(), log_cnt got decreased by 10 to
22. The test code is a place for people to look for expected behavior. So I
think adding more nextval() to verify and show the change of log_cnt is helpful.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
to find other errors. So, we usually only turn it on when
needed, and turn it off once debugging is done.
But v2 code looks good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
scussion thread that mentioned a workaround, so I did further search and
eventually figured out the workaround.
I think it’s worth resolving this issue, because it avoids confusion from
people who want to try or test logical replication logically, and allows the
same script to run in both an pure local e
ecide length of “targets”. So that avoids hard
code “2” in “for”. If we need to add more elements to “targets”, we can just
add it without updating “for”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
> On Sep 10, 2025, at 12:20, Chao Li wrote:
>
> v2 tries to fix the CI failure.
>
> Chao Li (Evan)
> -
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>
>
Here is the CF patch https://commitfest.postgresql.org/patch/6046/, and the C
> On Sep 10, 2025, at 02:20, Sophie Alpert wrote:
>
> Hi Chao,
>
> Thanks for taking a look.
>
> On Tue, Sep 9, 2025 at 12:52 AM, Chao Li wrote:
>> However, I noticed that, when “TidRecheck()” is called, it is actually
>> passed with “epqstate->re
> On Sep 10, 2025, at 13:18, Chao Li wrote:
>
> With my proposal, my theory is that, TidNext() fetches a tuple by ctid, if
> other concurrent transaction update/delete the tuple, the tuple's visibility
> changes.
>
I did some more debugging on this issue today, and
Hi Hackers,
Just fixed an one-word error in comment. Please take a look.
Best regards,
Chao Li (Evan)
-
HighGo Software Co., Ltd.
https://www.highgo.com/
v1-0001-Fix-parameter-name-in-table_tuple_lock-comment.patch
Description: Binary data
mix use both, which sounds reasonable.
I don’t see you have updated any documentation yet. I don’t want to block you
because of this issue. As long as you state the behavior clearly in the
document, I am happy to let it go.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
o ts values (2, 3);
ERROR: new row for relation "ts" violates check constraint "cc"
DETAIL: Failing row contains (2, 3).
evantest=# insert into ts values (1, 1);
ERROR: cannot compare record types with different numbers of columns
```
But v2 needs a rebase, I cannot apply it to
ind check in
> RangeVarCallbackForPolicy.
>
LGTM. I built the patch on MacOS M4, and build passed without warning.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
is two examples, always returning FALSE seems to also work. But I am
still not 100% sure if there are other use case that returning FALSE may not
work. So, feels like checking visibility is a safe solution.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
c, there may have slight performance
difference. The current version stores dereferenced “allProcs” in a local
static variable, which is faster than using the macro because the macro need to
dereference “allProcs” from the “ProcGlobal” every time when it is called.
In other files, they are just simple d
colName,
+
format_type_with_typemod(targettype, targettypmod),
+ constr_name,
+
RelationGetRelationName(rel)),
```
I thi
.track_counts” up to be with the other boolean
flags? Whey define together to share the same byte, feels better to initialize
them together as well.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Hi Hacker,
This is a follow up 991295f. I searched over the src/ and make all
ItemPointer arguments as const as much as possible.
I made clean build and no waring found. And "make check" also passes. I
will create a patch on CF to see if CI passes.
Best regards,
Cha
> On Sep 2, 2025, at 11:53, David G. Johnston
> wrote:
>
> On Monday, September 1, 2025, Chao Li <mailto:li.evan.c...@gmail.com>> wrote:
>>
>> The last comment is about error message:
>>
>> ```
>> evantest=# select data.a from test_js
T [52426] LOG: redo done at 0/017AF398 system usage:
CPU: user: 0.00 s, system: 0.00 s, elapsed: 0.00 s
2025-09-03 10:46:48.496 CST [52426] LOG: last completed transaction was at log
time 2025-09-03 10:42:02.901807+08
```
So, I guess xlogreader may return a different log message when xl_tot_le
> On Sep 10, 2025, at 14:28, Peter Eisentraut wrote:
>
> Thanks. New patch set attached.
>
v5 looks good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
> On Sep 12, 2025, at 07:11, Melanie Plageman wrote:
>
> On Wed, Sep 10, 2025 at 4:24 AM Chao Li wrote:
>>
>
> Thanks for the review!
>
> For any of your feedback that I simply implemented, I omitted an
> inline comment about it. Those changes are included i
> On Aug 22, 2025, at 22:10, Tom Lane wrote:
>
> Chao Li writes:
>> When reading dumped parse/query/plan trees, sometime we want to know
>> what exact type/operator/function an OID stands for. I just added a new
>> feature that will add some OID descripti
reference, then every
* column is implicitly part of the expression. Set used_in_expr to true
* unconditionally.
*/
Best reagards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
d normalization of such values.
>
Are you suggesting add a test case to this patch? Can you please be more
specific?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
t(&it, &val, true);
Assert(tok == WJB_VALUE);
- memset(&ps, 0, sizeof(ps));
+ //memset(&ps, 0, sizeof(ps));
pushJsonbValue(&ps, WJB_BEGIN_OBJECT, NULL);
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
ve ALTER TABLE ALTER COLUMN SET EXPRESSION,
> so I added a test on it.
>
I confirm “make check” passed with this patch.
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
ormat similar to that used for Lists, that is "<>"
for a NULL pointer or "(item item item)" otherwise. Also retool
the code to not have so many copies of the identical logic.
It mentioned “(item item item)”, not a whitespace in front of the first item.
Best regard
regards,
--Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/
v1-0001-Fixes-a-trivial-bug-in-dumped-parse-query-plan-tr.patch
Description: Binary data
uot;procedure" : "function";
/*
if (proc_call)
return errdetail("There is no procedure of that name.");
else
return errdetail("There is no function of that name.");
*/
return errdetail("There is no %s of that name.", func_kind);
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
1 - 100 of 161 matches
Mail list logo
