> On Aug 19, 2025, at 14:24, Michael Paquier <mich...@paquier.xyz> wrote: > > > -- > Michael > <0001-Replace-uses-of-long-by-uint64-in-dynahash.c-and-hse.patch>
-static long next_pow2_long(long num); -static int next_pow2_int(long num); +static uint64 next_pow2_uint64(uint64 num); +static int next_pow2_int(uint64 num); There are already pg_nextpower2_64() and pg_nextpower2_32() in pg_bitutils.h, feels like the new replacement functions are duplicate to the existing ones. - * we no longer need to worry about registering hash_seq_search scans, + * we no uint64er need to worry about registering hash_seq_search scans, Looks like a bad auto replacement: “no longer”, here “long" should be kept. -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
