On 22.01.2019 22:17, Tomas Vondra wrote:
On 1/22/19 7:36 PM, Arthur Zakirov wrote:
max_shared_dictionaries_size can be renamed to
shared_dictionaries_cleanup_threshold.
That really depends on what exactly the threshold does. If it only
triggers cleanup but does not enforce maximum amount of
On 01.02.2019 12:09, Arthur Zakirov wrote:
Thanks for sharing your ideas, Tomas. Unfortunately I won't manage to
develop new version of the patch till the end of the commitfest due to
lack of time. I'll think about the second approach. Tracking timestamp
of the last time a dict was u
#x27;s buffer.
What do you think?
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c
index 69b6226f8f..cbc7e4e7ea 100644
--- a/src/backend/access/transam/xlogreade
On 12.02.2019 07:23, Michael Paquier wrote:
On 02/11/2019 07:25 PM, Arthur Zakirov wrote:
Grigory noticed that one of our utilities has very slow performance when
xlogreader reads zlib archives. We found out that xlogreader sometimes
reads a WAL file block twice.
What do you think?
I think
's why `reqLen` is equal to XLOG_BLCKSZ).
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
s://github.com/postgrespro/pg_probackup/blob/c052651b8c8864733bcabbc2660c387b792229d8/src/parsexlog.c#L1046
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
On 18.02.2019 04:09, Michael Paquier wrote:
And done, after doing and extra pass, doing more testing using by own
plugins, pg_waldump and more fancy stuff with a primary/standby and
pgbench.
Thank you Michael.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian
structure. There no such ready structure within PostgreSQL sources
except binaryheap.c, but it isn't for concurrent algorithms.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
>From 3e220e259eebc6b9730c9500176015b04e588cae Mon Sep 17 00:00:00 2
On 21.02.2019 15:45, Robert Haas wrote:
On Wed, Feb 20, 2019 at 9:33 AM Arthur Zakirov wrote:
I'm working on the (b) approach. I thought about a priority queue
structure. There no such ready structure within PostgreSQL sources
except binaryheap.c, but it isn't for concurrent algor
27;dbentry' becomes invalid after calling pgstat_vacuum_stat().
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
se pg_stat_tmp dir was
removed from the `foreach my $dirname` loop.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
.c about
mappings created via mmap() so that you don't leak mappings on an
abort, but that's probably not a crazy difficult problem.
It seems to me Tom and Andres also vote for the mmap() approach. I think
I need to look closely at the mmap().
I've labeled the patch as
On 01.10.2018 12:22, Arthur Zakirov wrote:
On Thu, Jun 14, 2018 at 11:40:17AM +0300, Arthur Zakirov wrote:
I attached new version of the patch.
The patch still applies to HEAD. I moved it to the next commitfest.
Here is the rebased patch. I also updated copyright in ts_shared.h and
by Alvaro.
Please see the changes in the patch.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 90d67f1acf..06f3f69073 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@
g */
I think we don't need DictPointerData struct anymore, because only
ts_dict_shmem_release function needs it (see comments above) and we only
need it to hash search. I'll move all fields of DictPointerData to
TsearchDictKey struct.
> XXX "supported" is not the same as &
erData to
> TsearchDictKey struct.
I was wrong, DictInitData also needs DictPointerData. I didn't remove
DictPointerData, I renamed it to DictEntryData. Hope that it is a more
appropriate name.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
&
Hello Alexander,
On Friday, June 7, 2019, Alexander Korotkov
wrote:
> BTW, does this patch checks that temporary table is really orphan?
> AFAICS, user may define some temporary tables in single-user mode
> before running VACUUM.
As far as I remember, the patch checks it.
--
Arthu
%40mail.gmail.com
Initially the patch proposed to use quote_all_identifiers of
_dumpOptions. But then everyone came to a decision to use global
quote_all_identifiers from string_utils.c, because fmtId() uses it.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres
;
int use_setsessauth;
Wow, good catch. I thought C compilers would have reported this issue,
but obviously not. Patch applied to head. Thanks.
Thank you, Bruce!
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
about toast tables and I'm not aware about
policy of completion toast tables.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index e913b83091..1d235a3987 100644
--- a
ome current tests to use default configuration
or to add specific tests for locale testing?
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
e removing a mention to an
> already-committed patch.
>
> - (and rebased)
Just a little note. In parallel.sgml it is still mentioned that
dynamic_shared_memory_type accepts 'none' value:
> must be set to a
> value other than none.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
d day from the string. But patched
to_timestamp() raises an error. Someone could rely on such behaviour.
The patch divides separator characters from letters and digits. And
'年' or 'y' are letters here. And so the format string doesn't match the
input string.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
On Mon, Jul 23, 2018 at 04:30:43PM +0300, Arthur Zakirov wrote:
> I looked for some tradeoffs of the patch. I think it could be parsing
> strings like the following input strings:
>
> SELECT TO_TIMESTAMP('2011年5月1日', '-MM-DD');
> SELECT TO_TIMESTAMP(&#
; Actually..another thought: since toast tables may be VACUUM-ed, should I
> > > introduce Query_for_list_of_tpmt ?
>
> I didn't include this one yet though.
>
> Feel free to bump to next CF.
I think it could be done by a separate patch.
--
Arthur Zakirov
Postgres Prof
s now changes in the code and tests.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index edc9be92a6..db1da7bee7 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -6264
that
> it's only worth to follow Oracle when it does reasonable things.
I agree with you. I think it isn't worth to copy this behaviour.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
and output functions respectively of the aclitem
data type. I think they don't need to be documented and shouldn't have
"pg_" prefix as they was created to maintenance aclitem data type.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
DEBUG... / LOG / INFO?
+1 from me to keep initial name "pgbench_error". "pgbench_log" for new
function looks nice to me. I think it is better than just "log",
because "log" may conflict with natural logarithmic function (see "man 3
log").
> &g
error()
> > could be dangerous. I think "fmt" checking could be removed, or we may
> > use Assert()
>
> I would like not to use Assert in this case because IIUC they are mostly
> used for testing.
I'd vote to remove this check at all. I don't see any
Hello,
On Tue, May 15, 2018 at 05:02:43PM -0400, Robert Haas wrote:
> On Tue, Mar 27, 2018 at 8:19 AM, Arthur Zakirov
> wrote:
> > Yes, there is dsm_pin_mapping() for this. But it is necessary to keep a
> > segment even if there are no attached processes. From 0003:
> &g
lies some kernel calls, which could
> fail. We can't afford to inject steps that might fail into post-commit
> cleanup (because it's too late to recover by failing the transaction).
> It'd be better to do cleanup while searching for a dictionary to use.
But it is possib
e
occured in various events. So I think I should check the current approach
too using CLOBBER_CACHE_ALWAYS. It could show some problems in the
current patch.
Then if everything is OK I think I'll check another approach (unmapping
in TS syscache callback) using CLOBBER_CACHE_ALWAYS.
--
Arthur
d more
connections. Maybe it would be useful to make such tests. I did it
manually but it is better to have a script.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
pinned segments won't be unpinned.
But I'm not sure is this real case. Text search configuration changes
should be very infrequent (as it is written on in the
InvalidateTSCacheCallBack commentary).
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
UM (ANALYZE) measurement (,".
The following with whitespace after column works well:
VACUUM (ANALYZE) measurement (city_id
and gives: "VACUUM (ANALYZE) measurement (city_id ,".
Also I think it could be good to list column names after parentheses,
but I'm not sure if it easy to
;))
It looks better to me. Such condition is used for other commands and
works the same way.
The last point I've noticed, there is no VERBOSE entry after VACUUM FULL
ANALYZE command anymore.
I'm not sure how this patch should be commited. Can it be commited
outside the commitfest? Otherwise add it to the next commitfest please
in order not to forget it.
Thoughts?
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
just reject VACUUM VERBOSE ANALYZE
> VERBOSE, but I tentatively assume it's intentional).
Right. Understood.
> > I'm not sure how this patch should be commited. Can it be commited
> > outside the commitfest? Otherwise add it to the next commitfest please
> > in order not to forget it.
>
> I've done https://commitfest.postgresql.org/18/1661/
Thank you!
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
On Wed, May 16, 2018 at 02:36:33PM +0300, Arthur Zakirov wrote:
> ... I attached the rebased patch.
I attached new version of the patch.
I found a bug when CompoundAffix,
SuffixNodes, PrefixNodes, DictNodes of IspellDictData structure are
empty. Now they have terminating entry and therefore t
n of service \"%s\" not found" will be raised, because
group_found is false. It may confuse as it hides a real error. For
example, if permission is denied to open the directory.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
the heap
- recheck all got items and exclude those of them which don't satisfy
the phrase query
Last two point is additional work.
We have our index as an extension. It is changed GIN index and can store
lexemes and their positions. And therefore phrase queries are faster.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
Hello all,
On Wed, Feb 28, 2018 at 11:16:24AM +0300, Arthur Zakirov wrote:
> I've sent a pull request with nepali snowball algorithm into
> https://github.com/snowballstem [1]. They aren't againts the patch.
>
> They haven't merged it yet, though. There are some
type. AT_PASS_ADD_COL subcommands are executed
before AT_PASS_ADD_INDEX, AT_PASS_ADD_CONSTR and AT_PASS_MISC.
I'm not sure how important it is. But I think it could break backward
compatibility.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
false);
It is not critical, but it may be good to change them in one place.
>
> In this version of the patch I also improved NULL handling, you can see it
> in
> the tests.
New tests passed.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
_basebackup -D data_repl -X stream -R --progress --verbose > backup 2>&1
If you redirect stderr too then isatty() will know that message output is not
tty.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
. I thought that
the current approach may confuse programmers, who will implement subscribting.
Also you can see extractValue() function of GIN [1]. It returns if values is
null in same way.
1 - https://www.postgresql.org/docs/current/static/gin-extensibility.html
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
d character "/", expected ":"
>From Oracle's documentation [1]:
> FX - Requires exact matching between the character data and the format model.
I agree that compatibility breaking is not good and a fu
ure patch may only try to fix wrong output date and time as in Amul's first
email.
1 -
https://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements004.htm#i34924
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
Datum source, SubscriptingRefState *state, bool *isNull
I think it is time to mark the patch as "Ready for Commiter". I've
marked it.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
fprintf(stderr, "\n");
> + else
> + fprintf(stderr, "\r");
Here the condition should be inverted I think. The next condition should be
used:
> if (!isatty(fileno(stderr)))
> ...
Otherwise pg_basebackup will insert &#
On Tue, Nov 21, 2017 at 07:16:46AM -0300, Martín Marqués wrote:
>
> Ups! Attached the corrected version.:)
>
Thank you for the new version.
The patch applies via 'patch' command without warnings and errors, tests
passed. Marked the patch as "Ready for Commiter".
6', 'FXYY:Mon:DD');
ERROR: unexpected character "/", expected ":"
HINT: In FX mode, punctuation in the input string must exactly match the
format string.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
diff --git a/
ror messages.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
ew syntax.
The result of ts_debug() function was changed. Is it possible to keep the old
ts_debug() result? To be specific, 'dictionaries' column is text now, not
array, as I understood. It will be good to keep the result for the sake of
backward compatibility.
--
Arthur Zakirov
Po
d'?
>
> Additionally, I added some examples to documentation regarding
> multilingual search and combination of exact and linguistic-aware
> search and fixed typos.
Great!
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
hub.com/tvondra/shared_ispell or github.com/postgrespro/shared_ispell
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
ll be a large patch not submitted to 2018-01? Depending on
> size/complexity I'm not sure it's OK to submit 2018-03 only -- it may be
> too late.
>
Oh, I see. I try to prepare the patch while 2018-01 is open.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
On Tue, Dec 26, 2017 at 07:03:48PM +0100, Pavel Stehule wrote:
>
> Tomas had some workable patches related to this topic
>
Tomas, have you planned to propose it?
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
Hello, hackers,
On Tue, Dec 26, 2017 at 07:48:27PM +0300, Arthur Zakirov wrote:
> The patch will be ready and added into the 2018-03 commitfest.
>
I attached the patch itself.
0001-Fix-ispell-memory-handling.patch:
Some strings are allocated via compact_palloc0(). But they are not
pers
e passed.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
ached.
+1. Attached patch works nicely. It applies using "patch".
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
h a separate patch anyway.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
e is good and regression tests passed. There is no need to update
the documentation.
Marked as Ready for Commiter.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
mit/efc280b89b181657afe5412f398681b2c393a35c#diff-efde70a147d16a83b9b132b7f396ab6d
2 -
https://github.com/postgresql-cfbot/postgresql/tree/commitfest/19/1697/src/backend/snowball/libstemmer
3 -
https://github.com/postgresql-cfbot/postgresql/tree/commitfest/19/1697/src/include/snowball/libstemmer
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
The patch seems reasonable. It fixes the lack of tab completion for
ALTER DATABASE ... SET TABLESPACE ... .
There is no need to patch the documentation and regression tests.
Marked as Ready for Commiter.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
P */
> } OnCommitAction;
There is the extra comma here after ONCOMMIT_DROP.
1 - https://www.postgresql.org/docs/current/static/sql-createtable.html
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
you mean, thank you. I thought that
{ ON COMMIT DROP | ON TRANSACTION END RESET } parameters are used only
for transactional variables in the first place. But is there any sense
in using this parameters with non-transactional variables? That is when
we create non-transactional variable we don
is better to leave the
syntax as is without changes for now.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
an be run periodically. Is it suitable?
Also it would be good to move missing stopwords from Stopwords ISO to
snowball-website...
1 - https://github.com/snowballstem/snowball-website/tree/master/algorithms
2 -
https://github.com/snowballstem/snowball-website/blob/master/algorithms/english/stop.
es are only accepted if the
> corresponding host is a name. The user must use the "host=ip" syntax
> to connect to an ip.
Patch gives me an error if I specified only hostaddr:
psql -d "hostaddr=127.0.0.1"
psql: host "/tmp" cannot have an hostaddr "127.0.0.1"
It is wrong, because I didn't specified host=/tmp.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
On Thu, Jun 14, 2018 at 11:40:17AM +0300, Arthur Zakirov wrote:
> I attached new version of the patch.
The patch still applies to HEAD. I moved it to the next commitfest.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
ve an hostaddr "127.0.0.1"
This is the expected modified behavior: hostaddr can only be specified
on a host when it is a name, which is not the case here.
See the comment above about backward compatibility. psql without the
patch can connect to an instance if I specify only hostaddr.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
101 - 171 of 171 matches
Mail list logo
