e or directory: 'replication/basebackup.o'
Apparently this should be checked carefully with different configure
flags combinations if we are going to continue maintaining this.
--
Best regards,
Aleksander Alekseev
ution is general enough. E.g. is there
something that generally prevents pg_mblen() from doing out of bound
reading in cases similar to this one? Should we prevent such an INSERT
from happening instead?
--
Best regards,
Aleksander Alekseev
v1-0001-Fix-out-of-bounds-memory-reads-in-text_substring.patch
Description: Binary data
the development from the repository and be sure they
are not going to be deleted by accident (by `git clean`, for
instance).
Very convenient.
--
Best regards,
Aleksander Alekseev
I suggest we use "git link" for the larger patchset in the other
thread since I'm not contributing to it right now and all in all that
thread is waiting for this one. For this thread we continue using
patches since several people contribute to them.
[1]: https://commitfest.postgresql.org/38/3608/
--
Best regards,
Aleksander Alekseev
ept that we will receive at least two emails instead
of one.
--
Best regards,
Aleksander Alekseev
the discussions in -v8, -v9, -v9 ets
threads get lost.
May I suggest using a single thread?
--
Best regards,
Aleksander Alekseev
med it was lost.
Sorry for the confusion. However, the part about various email clients
is accurate.
--
Best regards,
Aleksander Alekseev
fore that they use
Reviewers field in the CF application when writing the commit message.
I would argue that this is the reason.
--
Best regards,
Aleksander Alekseev
ents it from using Pluggable TOAST if this
will produce a cleaner code (I believe it will) and will allow
delivering partial decompression (this is yet to be figured out).
--
Best regards,
Aleksander Alekseev
verrides
this behavior. For instance:
```
array_shuffle([ [1,2], [3,4], [5,6] ], depth => 2)
```
BTW, while on it, shouldn't we add similar functions for JSON and/or
JSONB? Or is this going to be too much for a single discussion?
[1]: http://cfbot.cputube.org/
--
Best regards,
Aleksander Alekseev
the proposed check.
--
Best regards,
Aleksander Alekseev
offlist.
If no one sees any other defects I'm going to change the status of the
patch to "Ready to Committer" in a short time.
--
Best regards,
Aleksander Alekseev
v14-0001-Add-option-for-amcheck-and-pg_amcheck-to-check-u.patch
Description: Binary data
hers have
> something to say.
LGTM
--
Best regards,
Aleksander Alekseev
v2-0001-Eliminate-duplicate-code-in-table.c.patch
Description: Binary data
Hi Amit,
> I don't think this change should be part of this patch. Do you see a
> reason for doing this?
My bad. I thought this was done by pgindent.
--
Best regards,
Aleksander Alekseev
v3-0001-Eliminate-duplicate-code-in-table.c.patch
Description: Binary data
Hi Alvaro,
> Hmm, but see commit 2ed532ee8c47 about this kind of check. Perhaps we
> should change these error messages to conform to the same message style.
Good point! Done.
--
Best regards,
Aleksander Alekseev
v4-0001-Eliminate-duplicate-code-in-table.c.patch
Description: Binary data
Hi Amit,
> Yeah, that's better. On again thinking about the function name, I
> wonder if validate_relation_type() suits here as there is no generic
> object being passed?
Yep, validate_relation_type() sounds better.
--
Best regards,
Aleksander Alekseev
v5-0001-Eliminate-dup
Hi Amit,
> Yep, validate_relation_type() sounds better.
Or maybe validate_relation_kind() after all?
--
Best regards,
Aleksander Alekseev
Hi Junwang,
> btw, there are some typos in Patch v5, %s/ralation/relation/g
D'oh!
> yeah, IMHO validate_relation_kind() is better ;)
Cool. Here is the corrected patch. Thanks!
--
Best regards,
Aleksander Alekseev
v6-0001-Eliminate-duplicate-code-in-table.c.patch
Description: Binary data
Hi Sergey,
> @Aleksander Alekseev thanks for reporting the issue. I have altered
> the patch to respect the behavior of pg_stat_activity, specifically
> [1]
>
> > Another important point is that when a server process is asked to
display any of these statistics,
> > i
tch and this particular discussion. In any case, having some stats
is better than none.
I'm going to change the status of the patch to "Ready for Committer"
in a short time unless anyone has a second opinion.
--
Best regards,
Aleksander Alekseev
Hi Nikita,
> I've reworked the patch set according to recommendations of Aleksander
> Alekseev, Robert Haas
> and Matthias van de Meent, and decided, as it was recommended earlier,
> include only the most
> important part in the first set. Also, I've added a large REA
othing exotic. Please let me know if there are any
other details of interest.
I'll continue looking for the source of the problem and will post an
update as soon as I have one.
--
Best regards,
Aleksander Alekseev
uspect
> there is something odd about your environment settings.
Thanks for sharing this.
I repeated the experiment in a clean environment (Raspbian installed
from scratch on a brand new SD-card) and can confirm that the problem
is gone.
Sorry for the disturbance.
--
Best regards,
Aleksander Alekseev
the list of the authors, the reviewers and a link to
the discussion. Please use [3] as a template.
[1]: http://cfbot.cputube.org/
[2]: https://github.com/afiskon/pgscripts/
[3]:
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=784cedda0604ee4ac731fd0b00cd8b27e78c02d3
--
Best regards,
Aleksander Alekseev
h added commit message. Please
note that patches created with `git format-patch` are generally
preferable than patches created with `git diff`.
I'm going to change the status of this patch to "Ready for Committer"
in a short time unless anyone has a second opinion.
--
Best regards,
urn to the idea of dictionary versions.
Since no one objected so far and/or proposed a better idea I assume
this can be added to the list of TODOs as well.
--
Best regards,
Aleksander Alekseev
v6-0001-Compression-dictionaries-for-JSONB.patch
Description: Binary data
c-volatility.html
--
Best regards,
Aleksander Alekseev
v1-0001-timezone_volatility.patch
Description: Binary data
v2-0001-timezone_volatility.patch
Description: Binary data
TABLE as
well?
I can see pros and cons to be IMMUTABLE _or_ STABLE when dealing with time
zones, but at least PostgreSQL should be consistent in this, right?
--
Best regards,
Aleksander Alekseev
ch.
Here is the patch.
--
Best regards,
Aleksander Alekseev
v3-0001-timezone_volatility.patch
Description: Binary data
timestamptz_bin().
Am I missing something?
--
Best regards,
Aleksander Alekseev
o_This#Don.27t_use_timetz
--
Best regards,
Aleksander Alekseev
2021-09-07 12:34:56+03
```
PostgreSQL was built on MacOS Catalina without the `--with-system-tzdata=` flag.
Is it a bug or this behavior is intentional (something to do with SQL
standard, perhaps)?
--
Best regards,
Aleksander Alekseev
David, Tom,
> Well, given that the limitation is documented I’d have to say it is
> intentional:
> [...]
> That's intentional, per the fine manual:
> [...]
My bad, I missed this. Many thanks!
--
Best regards,
Aleksander Alekseev
hould be moved on the known distance. In other words,
it's possible to copy `oldhash` to `newhash` and then move only half
of the items. I don't claim that this code necessarily should be
faster, or that this should be checked in the scope of this work.
--
Best regards,
Aleksander Aleksee
It looks like this patch rotted a little and needs to be rebased. Please see
http://cfbot.cputube.org/
The new status of this patch is: Waiting on Author
It looks like this patch needs to be updated. According to
http://cfbot.cputube.org/ it applies but doesn't pass any tests. Changing the
status to save time for reviewers.
The new status of this patch is: Waiting on Author
sses installcheck-world. After some
searching through the code, I was unable to identify any places where
the logic will break. Although this only proves my inattention, the
easiest way to make any further progress seems to apply the patch.
--
Best regards,
Aleksander Alekseev
sed http://cfbot.cputube.org/ I notified
several authors and changed the status to "Waiting for Author", but
somehow I don't feel comfortable doing it for 40+ patches at once...
Also, I recall that in the past the fact that the patch doesn't pass
CI was not considered enough not to review it.
--
Best regards,
Aleksander Alekseev
Hi Andrey,
> only performance issues
That's interesting. Any chance you could share the hardware
description, the configuration file, and steps to reproduce with us?
--
Best regards,
Aleksander Alekseev
d a hack, and if
something will go wrong, you are on your own.
Of course, there is a possibility that something has changed in the past
four years. I'm sure somebody on the mailing list will correct me in this
case.
[1] https://wiki.postgresql.org/wiki/PgCon_2017_Developer_Meeting
--
Best r
estigate reasons for such poor
> performance.
Let's say, any information regarding bottlenecks that affect real users
with real queries is of interest. Artificially created queries that are
unlikely to be ever executed by anyone are not.
--
Best regards,
Aleksander Alekseev
implementation of date_bin() for TZ
case.
[1]: https://docs.timescale.com/api/latest/hyperfunctions/time_bucket_ng/
[2]: https://github.com/timescale/timescaledb/blob/master/src/time_bucket.c#L470
--
Best regards,
Aleksander Alekseev
ebruary, not October. Sorry for the confusion.
--
Best regards,
Aleksander Alekseev
--
Best regards,
Aleksander Alekseev
v5-0001-psql-Fix-tab-completion-for-ALTER-TABLE.patch
Description: Binary data
t, I didn't
invest too much time into investigating this. Hopefully, it's not a big
deal.
[1]: http://cfbot.cputube.org/
--
Best regards,
Aleksander Alekseev
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
The cfbot seems to be happy with the updated patch.
The new
for the fact that comments seem to be
inaccurate in light of the discussion. The corrected patch is attached.
I'm going to mark it as "Ready for Committer" unless anyone objects.
--
Best regards,
Aleksander Alekseev
v2-0001-Add-callback-to-reset-filenode-to-table-access-metho.patch
Description: Binary data
ostgrespro/zson/blob/master/docs/benchmark.md
[6]:
https://www.postgresql.org/message-id/CAEze2WheMusc73UZ5TpfiAGQ%3DrRwSSgr0y3j9DEVAQgQFwneRA%40mail.gmail.com
[7]: https://github.com/postgrespro/zson#usage
[8]:
https://www.postgresql.org/message-id/77356556-0634-5cde-f55e-cce739dc09b9%40enterprisedb
Hi hackers,
Many thanks for all the great feedback!
Please see the follow-up thread `RFC: compression dictionaries for JSONB`:
https://www.postgresql.org/message-id/CAJ7c6TPx7N-bVw0dZ1ASCDQKZJHhBYkT6w4HV1LzfS%2BUUTUfmA%40mail.gmail.com
--
Best regards,
Aleksander Alekseev
Open-Source
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
The patch was marked as the one that needs review and doesn't
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
The v3 patch LGTM. I wonder if we should explicitly say in pg
x = myoff; index < numProcs; index++)
... are of any value, but other changes may be. I choose to keep the patch
as-is except for the named defects and let the committer decide which
changes, if any, are worth committing.
I'm updating the status to "Ready for Committe
ize_t and another that addresses shadowing. Refactorings
only, nothing else.
Regarding the code formatting, please see src/tools/pgindent.
--
Best regards,
Aleksander Alekseev
procarray.c:780:31: warning: passing 'const pg_atomic_uint32 *' (aka 'const
struct pg_atomic_uint32 *')
se see
http://commitfest.cputube.org/
--
Best regards,
Aleksander Alekseev
e to write a test on it?
--
Best regards,
Aleksander Alekseev
ually if needed?
--
Best regards,
Aleksander Alekseev
tps://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.141500
--
Best regards,
Aleksander Alekseev
v7-0001-enhancing-plpgsql-dbgapi.patch
Description: Binary data
Hi Pavel,
> I know it. Attached patch try to fix this issue
>
> I merged you patch (thank you)
Thanks! I did some more minor changes, mostly in the comments. See the
attached patch. Other than that it looks OK. I think it's Ready for
Committer now.
--
Best regards,
Aleks
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
The patch was tested on MacOS against master `80ba4bb3`.
The
as tested on MacOS against master `80ba4bb3`.
>
> The new status of this patch is: Ready for Committer
>
The second patch seems fine too. I'm attaching both patches to trigger
cfbot and to double-check them.
--
Best regards,
Aleksander Alekseev
0001-Reduce-Wsign-compare-warnings-from-cla
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
v2-0001 and v2-0002 look fine, but I don't like much the idea
ll attract
more contributors and thus would be a good step for the project in the
long run.
* including PyTest integration
** citation needed
--
Best regards,
Aleksander Alekseev
, we can't
lock it".
```
elog(ERROR, "cannot lock virtual tuple");
```
For some reason I thought that ereport() is the preferred way of
throwing errors, but I see elog() used many times in ExecLockRows() so
this is probably fine.
--
Best regards,
Aleksander Alekseev
Thanks Rovert and to everyone involved.
--
Best regards,
Aleksander Alekseev
;Command Line Tools for Xcode" package
(/Library/Developer/CommandLineTools/SDKs/). Or alternatively finding
the official way of installing the beta version of this package.
[1]:
https://www.postgresql.org/docs/current/installation-platform-notes.html#INSTALLATION-NOTES-MACOS
--
Best regards,
Aleksander Alekseev
ased.
Thoughts?
I added the patch to the nearest commitfest so that it wouldn't be lost [1].
[1]: https://commitfest.postgresql.org/48/5073/
--
Best regards,
Aleksander Alekseev
v1-0001-Dirty-fix.patch
Description: Binary data
() makes 15-character (60-bit) file names. Where does the 48-bit
> limit arise? How does the SlruFileName() comment about a 24-bit limit for
> short names relate this comment's 16-bit limit?
Yes, this comment is wrong. Here is a fix.
[1]:
https://www.postgresql.org/message-id/CAJ7c6TNM
le in the following grep match?
>
> src/backend/commands/async.c:1274: int headPage =
> QUEUE_POS_PAGE(QUEUE_HEAD);
Good catch. We better use int64s here.
Here is the corrected patchset.
--
Best regards,
Aleksander Alekseev
v2-0001-Fix-the-comment-for-SlruCtl
themself.
As I recall, previously it was argued that changes like this should
have some use within the core [1].
Can you think of any such use?
[1]: https://commitfest.postgresql.org/42/4180/
--
Best regards,
Aleksander Alekseev
here.
The referred patch was rejected at first because it didn't modify
nodeSeqScan.c to make use of the change within the core.
I'm not saying this is necessarily applicable to this particular patch
or that this is a general rule though.
--
Best regards,
Aleksander Alekseev
mit that this information may be incorrect
and/or outdated.
--
Best regards,
Aleksander Alekseev
r the patch - 127 ms. I realize this could be just something
specific to my hardware and/or amount of data.
Do you think this is something that was expected or something worth
investigating further?
I haven't looked at the code yet.
[1]: https://github.com/afiskon/pgscripts/blob/master/single-install-meson.sh
--
Best regards,
Aleksander Alekseev
that we use
> microseconds, I’m not sure it’s ok to use 10 more bits for nanoseconds…
A counter is mandatory since someone can for instance change the
system's time while the process is generating UUIDs. You can't
generally assume that local time of the system is monotonic.
--
Best regards,
Aleksander Alekseev
bles.
>
> Not sure this works even reasonably well for UUIDv7.
UUIDv7 is not guaranteed to be unique. It just does it best to reduce
the number of possible conflicts. So I don't think we should worry
about it.
--
Best regards,
Aleksander Alekseev
y none of the compilers complained about this.
Here is the patch.
--
Best regards,
Aleksander Alekseev
From 7361a4b12262317e10c2203fed018be258beb16f Mon Sep 17 00:00:00 2001
From: Aleksander Alekseev
Date: Wed, 3 Jul 2024 16:22:14 +0300
Subject: [PATCH v1] IndexScanOK: remove unused parameter
chine unfortunately.
--
Best regards,
Aleksander Alekseev
uot; by Aho, Ullman et al
[2] are good reads.
I'm not entirely sure if it answers your question but I hope that it's helpful.
[1]: https://www.amazon.com/Flex-Bison-John-R-Levine/dp/0596155972/
[2]:
https://www.amazon.com/Compilers-Principles-Techniques-Tools-2nd/dp/0321486811/
--
Best regards,
Aleksander Alekseev
he title it's written from the DBAs perspective
[1]: https://www.postgresql.org/docs/current/runtime-config-replication.html
--
Best regards,
Aleksander Alekseev
ompiled by post
> hackers and maintainers?
I believe you wanted to reply to the mailing list, not to me directly.
Please use the "Reply to All" button.
Do the postfix operators you mention exist in the SQL standard?
--
Best regards,
Aleksander Alekseev
.4
You need something like flex 2.6.4 and bison >= 2.3. That's what I use.
--
Best regards,
Aleksander Alekseev
However IMO your learning curve will be less steep with a Linux
virtual machine.
[1]: https://wiki.postgresql.org/wiki/Mailing_Lists
[2]: https://github.com/afiskon/pgscripts/
--
Best regards,
Aleksander Alekseev
x27;t recommend this path for
someone who wants to contribute.
--
Best regards,
Aleksander Alekseev
t and `git format-path`. And in my humble experience this is
something done often.
--
Best regards,
Aleksander Alekseev
;
> > ...
>
> I believe that was just an oversight. Trivial patch attached.
I tested your patch. LGTM.
PGPROC is exposed to third-party code, but since we don't change the
structure this time, the extensions will not be affected.
--
Best regards,
Aleksander Alekseev
+(1 row)
```
If I understand correctly, all the v's are of the same size. If this
is the case you should add more test cases.
[1]: https://commitfest.postgresql.org/
--
Best regards,
Aleksander Alekseev
rate_series(0, 1_000_000);
EXPLAIN ANALYZE SELECT COUNT(*) FROM test5 WHERE n > 950_000_000;
```
It runs fast and choses Index Only Scan. But then I discovered that
without the patch Postgres also uses Index Only Scan for this query. I
didn't know it could do this - what is the name of this technique? The
query takes 17.6 ms with the patch, 21 ms without the patch. Not a
huge win but still.
That's all I have for now.
--
Best regards,
Aleksander Alekseev
olutely no idea :)
--
Best regards,
Aleksander Alekseev
sure if this was the best choice.
[1]: https://commitfest.postgresql.org/48/4905/
--
Best regards,
Aleksander Alekseev
Hi,
> Many thanks. Here is the corrected patch. Now it also includes MIN()
> support and tests.
Michael Paquier (cc:'ed) commented offlist that I forgot to change the
documentation.
Here is the corrected patch.
--
Best regards,
Aleksander Alekseev
v3-0001-Support-min-record-and
Hi,
> Here is the corrected patchset.
TWIMC this is currently listed as an open item for PG17 [1].
Sorry if everyone interested is already aware.
[1]: https://wiki.postgresql.org/wiki/PostgreSQL_17_Open_Items
--
Best regards,
Aleksander Alekseev
nc.c. Alexander K., as the owner of the open
> item, are you planning to look at that?
Thanks, Michael. I prepared a corrected patchset.
--
Best regards,
Aleksander Alekseev
v3-0001-Fix-the-comment-for-SlruCtlData.long_segment_name.patch
Description: Binary data
v3-0002-Use-int64-for-page-numbers-in-clog.c-async.c.patch
Description: Binary data
> 04X to know that short file names include 4 characters. I'm OK to
> mention SlruFileName() rather than duplicate the knowledge here, but
> SlruFileName() should also be updated to mention the same level of
> details with some examples of file names.
Fair enough. Here is th
e start ignoring them and will skip
something important one day. So I think we should do this.
--
Best regards,
Aleksander Alekseev
Hi,
> > Thanks, pushed after correcting a couple typos.
>
> Thanks!
I noticed that ec99d6e9c87a introduced a slight typo:
s/if there is not room/if there is no room
--
Best regards,
Aleksander Alekseev
n
necessary.
--
Best regards,
Aleksander Alekseev
ewed in the scope of
July commitfest?
--
Best regards,
Aleksander Alekseev
s patch, fixed
> here.
Unfortunately the patchset rotted quite a bit since February and needs a rebase.
--
Best regards,
Aleksander Alekseev
east, one should prove
that this particular place is a bottleneck under given loads. I doubt
it is. Most of the time it's a network, disk I/O or locks.
So unless the author can provide benchmarks that show measurable
benefits of the change I suggest rejecting it.
--
Best regards,
Aleksander Alekseev
this
particular implementation was chosen.
I added corresponding comments to SetLatchV() and SetLatches(). Also
the patchset needed a rebase. PFA v4.
It passes `make installcheck-world` on 3 machines of mine: MacOS x64,
Linux x64 and Linux RISC-V.
--
Best reg
e
2020... If there is anything that may help merging it into PG17 please
let me know.
--
Best regards,
Aleksander Alekseev
v26-0001-Make-End-Of-Recovery-error-less-scary.patch
Description: Binary data
501 - 600 of 974 matches
Mail list logo