On Wed, 1 Nov 2023 at 19:28, Ashutosh Bapat
wrote:
>
> At this stage the standby would have various replication objects like
> publications, subscriptions, origins inherited from the upstream
> server and possibly very much active. With failover slots, it might
> inherit replication slots. Is it i
On Wed, 3 Jan 2024 at 14:49, Amit Kapila wrote:
>
> On Wed, Jan 3, 2024 at 12:09 PM vignesh C wrote:
> >
> > On Wed, 1 Nov 2023 at 19:28, Ashutosh Bapat
> > wrote:
> > >
> > > At this stage the standby would have various replication objects like
logical replication cluster b)
Upgrade cascaded logical replication cluster c) Upgrade 2 node
circular logical replication cluster.
Thoughts?
[1] - https://www.postgresql.org/docs/devel/pgupgrade.html
Regards,
Vignesh
From 9458a2c62a0702316d9ab339cd01dac0e088c52e Mon Sep 17 00:00:00 2001
From:
On Wed, 3 Jan 2024 at 11:25, Amit Kapila wrote:
>
> On Wed, Jan 3, 2024 at 6:21 AM Michael Paquier wrote:
> >
> > On Tue, Jan 02, 2024 at 03:58:25PM +0530, Amit Kapila wrote:
> > > On Fri, Dec 29, 2023 at 2:26 PM vignesh C wrote:
> > >> Thanks, th
On Tue, 2 Jan 2024 at 15:58, Amit Kapila wrote:
>
> On Fri, Dec 29, 2023 at 2:26 PM vignesh C wrote:
> >
> > On Thu, 28 Dec 2023 at 15:59, Amit Kapila wrote:
> > >
> > > On Wed, Dec 13, 2023 at 12:09 PM vignesh C wrote:
> > > >
> > >
On Thu, 28 Dec 2023 at 09:27, jian he wrote:
>
> On Wed, Dec 20, 2023 at 8:27 PM Masahiko Sawada wrote:
> >
> >
> > Why do we need to use SPI? I think we can form heap tuples and insert
> > them to the error table. Creating the error table also doesn't need to
> > use SPI.
> >
> Thanks for pointi
On Sun, 29 Oct 2023 at 11:14, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Andres,
>
> While tracking BF failures related with pg_ugprade, I found the same failure
> has still happened [1] - [4].
> According to the log, the output directory was remained even after the
> successful upgrade [5].
> I an
On Wed, 22 Nov 2023 at 13:01, Kyotaro Horiguchi wrote:
>
> Anyway, this requires rebsaing, and done.
Few tests are failing at [1], kindly post an updated patch:
/tmp/cirrus-ci-build/src/test/recovery --testgroup recovery --testname
039_end_of_wal -- /usr/local/bin/perl -I
/tmp/cirrus-ci-build/src
On Tue, 21 Nov 2023 at 01:47, Schoemans Maxime wrote:
>
> On 14/11/2023 20:46, Tom Lane wrote:
> > I took a brief look through this very interesting work. I concur
> > with Tomas that it feels a little odd that range join selectivity
> > would become smarter than scalar inequality join selectivit
On Mon, 20 Nov 2023 at 10:00, Amit Langote wrote:
>
> On Thu, Sep 28, 2023 at 5:26 PM Amit Langote wrote:
> > On Tue, Sep 26, 2023 at 10:06 PM Amit Langote
> > wrote:
> > > After sleeping on this, I think we do need the checks after all the
> > > ExecInitNode() calls too, because we have many i
On Mon, 1 Jan 2024 at 19:26, Andy Fan wrote:
>
>
> Andy Fan writes:
>
> >
> > Some Known issues:
> > --
> >
> > 1. Currently only Scan & Join nodes are considered for this feature.
> > 2. JIT is not adapted for this purpose yet.
>
> JIT is adapted for this feature in v2. Any feedb
On Tue, 21 Nov 2023 at 09:52, Adam Hendel wrote:
>
> Hello,
>
> On Mon, Nov 13, 2023 at 6:01 PM Andres Freund wrote:
>>
>> Hi,
>>
>> On 2023-11-13 11:55:07 -0600, Adam Hendel wrote:
>> > Currently, pgbench will log individual transactions to a logfile when the
>> > `--log` parameter flag is provi
On Thu, 7 Dec 2023 at 20:06, Anthonin Bonnefoy
wrote:
>
> Hi,
>
> Thanks for the review!
>
> > ```
> > +-- Worker can take some additional time to end and report their spans
> > +SELECT pg_sleep(0.2);
> > + pg_sleep
> > +--
> > +
> > +(1 row)
> > ```
> >
> > Pretty sure this will fail on b
On Tue, 31 Oct 2023 at 14:36, Dmitry Dolgov <9erthali...@gmail.com> wrote:
>
> > On Fri, Oct 27, 2023 at 05:02:44PM +0200, Dmitry Dolgov wrote:
> > > On Thu, Oct 26, 2023 at 09:08:42AM +0900, Michael Paquier wrote:
> > > typedef struct ArrayExpr
> > > {
> > > + pg_node_attr(custom_query_jumble)
On Wed, 1 Nov 2023 at 03:38, Matthias van de Meent
wrote:
>
> (now really to -hackers)
> Hi,
>
> Over at [0] I'd implemented an optimization that allows us to skip
> calling _bt_compare in _bt_moveright in many common cases. This patch,
> when stacked on top of the prefix truncation patch, improve
On Fri, 21 Jul 2023 at 02:59, Ivan Panchenko wrote:
>
> Friday, 14 July 2023, 23:27 +03:00 от Tom Lane :
>
> =?UTF-8?B?SXZhbiBQYW5jaGVua28=?= writes:
> > Четверг, 6 июля 2023, 14:48 +03:00 от Peter Eisentraut <
> > pe...@eisentraut.org >:
> >> If the transform deals with a built-in type, then th
On Wed, 1 Nov 2023 at 16:43, Peter Eisentraut wrote:
>
> Here is an updated version of this patch. It doesn't have any new
> functionality, just a rebase and some minor adjustments.
>
> I have split up the one patch into several ones, which could be
> considered incrementally, namely:
>
> v3-0001
On Thu, 29 Jun 2023 at 13:20, John Morris wrote:
>
> Background
>
> ==
>
> PostgreSQL has an amazing variety of routines for accessing files. Consider
> just the “open file” routines.
>PathNameOpenFile, OpenTemporaryFile, BasicOpenFile, open, fopen,
> BufFileCreateFileSet,
>
>Buf
On Mon, 18 Sept 2023 at 18:01, Jelte Fennema-Nio wrote:
>
> @Euler thanks for the review. I addressed the feedback.
>
> On Fri, 15 Sept 2023 at 01:41, Andy Fan wrote:
> > What if a client has *cached* an old version of RowDescription
> > and the server changed it to something new and sent resultd
On Wed, 1 Nov 2023 at 11:25, Richard Guo wrote:
>
>
> On Thu, Aug 10, 2023 at 3:24 PM Richard Guo wrote:
>>
>> The cfbot reminds that this patch does not apply any more, so rebase it
>> to v2.
>
>
> Attached is another rebase over the latest master. Any feedback is
> appreciated.
One of the tes
On Mon, 7 Aug 2023 at 19:25, Sandro Santilli wrote:
>
> On Tue, Aug 01, 2023 at 08:24:15PM +0200, Daniel Gustafsson wrote:
> > > On 28 Jun 2023, at 10:29, Daniel Gustafsson wrote:
> > >
> > >> On 31 May 2023, at 21:07, Sandro Santilli wrote:
> > >> On Thu, Apr 27, 2023 at 12:49:57PM +0200, Sandr
On Fri, 8 Dec 2023 at 19:15, Ashutosh Bapat
wrote:
>
> > > > pg_replication_slot could be set back to null.
> > >
> > > In this case, since the basebackup was taken after the slot was
> > > invalidated, it
> > > does not require the WAL that was removed. But it seems that once the
> > > streaming
On Tue, 12 Sept 2023 at 14:39, Peter Eisentraut wrote:
>
> On 11.09.23 13:59, Jelte Fennema wrote:
> > @Tom and @Robert, since you originally suggested extending the
> > protocol for this, I think some input from you on the protocol design
> > would be quite helpful. BTW, this protocol extension i
On Tue, 24 Oct 2023 at 22:00, Nathan Bossart wrote:
>
> On Tue, Sep 12, 2023 at 03:53:28PM +0100, Dagfinn Ilmari Mannsåker wrote:
> > Tom Lane writes:
> >> It's possible that we could get away with just summarily changing
> >> the argument type from text to regclass. ISTR that we did exactly
> >
in
all databases | Nathan Bossart
Add additional extended protocol commands to psql: \parse and \bindx |
Anthonin Bonnefoy
Function to log backtrace of postgres processes | Vignesh C/Bharath Rupireddy
Check consistency of GUC defaults between .sample.conf and
pg_settings.boot_val | Nathan Bossart
a
On Mon, 8 Jan 2024 at 22:50, Jelte Fennema-Nio wrote:
>
> On Mon, 8 Jan 2024 at 07:22, vignesh C wrote:
> > Here is a list of "Needs review" entries for which there has not been
> > much communication on the thread and needs help in proceeding further.
>
>
On Thu, 9 Nov 2023 at 21:48, Heikki Linnakangas wrote:
>
> On 18/09/2023 07:08, David Rowley wrote:
> > On Fri, 15 Sept 2023 at 22:37, Heikki Linnakangas wrote:
> >>> I've added a call to LockAssertNoneHeld(false) in there.
> >>
> >> I don't see it in the patch?
> >
> > hmm. I must've git format-
On Fri, 20 Jan 2023 at 15:30, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 15:35, vignesh C wrote:
> >
> > On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick
> > wrote:
> > >
> > > 2022年11月7日(月) 22:39 vignesh C :
> > > >
> > > >
On Sat, 6 Jan 2024 at 05:50, Paul Jungwirth
wrote:
>
> Getting caught up on reviews from November and December:
>
> On 11/19/23 22:57, jian he wrote:
> >
> > I believe the following part should fail. Similar tests on
> > src/test/regress/sql/generated.sql. line begin 347.
> >
> > drop table
On Sat, 25 Nov 2023 at 06:49, Heikki Linnakangas wrote:
>
> On 19/11/2023 02:04, Andres Freund wrote:
> > On 2023-11-17 11:37:21 +0100, Heikki Linnakangas wrote:
> >> The new facility makes it easier to optimize bulk loading, as the
> >> logic for buffering, WAL-logging, and syncing the relation o
On Tue, 4 Jul 2023 at 06:56, James Coleman wrote:
>
> On Sun, Jun 11, 2023 at 10:23 PM James Coleman wrote:
> >
> > ...
> > > And while trying the v9 patch I came across a crash with the query
> > > below.
> > >
> > > set min_parallel_table_scan_size to 0;
> > > set parallel_setup_cost to 0;
> >
On Sat, 21 Oct 2023 at 18:34, Konstantin Knizhnik wrote:
>
> Hi hackers,
>
> EXPLAIN statement has a list of options (i.e. ANALYZE, BUFFERS, COST,...)
> which help to provide useful details of query execution.
> In Neon we have added PREFETCH option which shows information about page
> prefetchi
On Fri, 8 Dec 2023 at 15:17, Kartyshov Ivan wrote:
>
> Should rise disscusion on separate utility statement or find
> case where procedure version is failed.
>
> 1) Classic (wait_classic_v3.patch)
> https://www.postgresql.org/message-id/3cc883048264c2e9af022033925ff8db%40postgrespro.ru
> =
On Mon, 4 Sept 2023 at 16:59, Kyotaro Horiguchi wrote:
>
> At Thu, 24 Aug 2023 11:22:32 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > I could turn this into something like undo longs in a simple form, but
> > I'd rather not craft a general-purpose undo log system for this unelss
> > it's absolut
On Tue, 9 Jan 2024 at 14:31, Andrei Lepikhov wrote:
>
> Here is a new version of GROUP-BY optimization without sort model.
>
> On 21/12/2023 17:53, Alexander Korotkov wrote:
> > I'd like to make some notes.
> >
> > 1) As already mentioned, there is clearly a repetitive pattern for the
> > code fol
On Thu, 16 Nov 2023 at 05:30, jian he wrote:
>
> On Fri, Nov 3, 2023 at 12:34 AM Marko Tiikkaja wrote:
> >
> > I am now. Thanks! :-) Will try to keep an eye on the builds in the future.
> >
> > Attached v4 of the patch which should fix the issue.
> >
>
> doc seems to still have an issue.
> http
On Wed, 10 Jan 2024 at 03:48, Robert Haas wrote:
>
> Hi,
>
> I think we need to be more aggressive about marking things returned
> with feedback when they don't get updated. If a patch is waiting for
> reviews for a long time, well, that's one thing. Maybe we eventually
> close it due to lack of i
On Wed, 3 Jan 2024 at 08:54, Amit Kapila wrote:
>
> On Wed, Jan 3, 2024 at 7:10 AM Michael Paquier wrote:
> >
> > On Tue, Jan 02, 2024 at 02:07:58PM +, Bertrand Drouvot wrote:
> > > + wal_level_insufficient means that the
> > > +is insufficient on the primary
> > > +
On Wed, 6 Dec 2023 at 12:53, Euler Taveira wrote:
>
> On Thu, Nov 9, 2023, at 8:12 PM, Michael Paquier wrote:
>
> On Thu, Nov 09, 2023 at 03:41:53PM +0100, Peter Eisentraut wrote:
> > On 08.11.23 00:12, Michael Paquier wrote:
> >> - Should the subdirectory pg_basebackup be renamed into something m
On Mon, 28 Aug 2023 at 18:56, Amit Kapila wrote:
>
> On Thu, Aug 24, 2023 at 11:44 AM vignesh C wrote:
> >
>
> The patch looks mostly good to me. I have made minor changes which are
> as follows: (a) removed the autovacuum =off and
> wal_receiver_status_interval = 0 setti
confirm_flush LSN is updated due to
keepalives. As we don't flush the latest value of confirm_flush LSN,
it may lead to processing the same changes again.
Author: Julien Rouhaud, Vignesh C, Kuroda Hayato based on suggestions by
Ashutosh Bapat
Reviewed-by: Amit Kap
Hi,
Recently urocryon has been failing with the following errors at [1]:
checking for icu-uc icu-i18n... no
configure: error: ICU library not found
If you have ICU already installed, see config.log for details on the
failure. It is possible the compiler isn't looking in the proper directory.
Use
On Fri, 1 Sept 2023 at 20:20, Mark Wong wrote:
>
> Hi,
>
> On Fri, Sep 01, 2023 at 11:27:47AM +0530, vignesh C wrote:
> > Hi,
> >
> > Recently urocryon has been failing with the following errors at [1]:
> > checking for icu-uc icu-i18n... no
> > configur
On Mon, 4 Sept 2023 at 15:20, Amit Kapila wrote:
>
> On Fri, Sep 1, 2023 at 10:50 AM vignesh C wrote:
> >
> > On Fri, 1 Sept 2023 at 10:06, Amit Kapila wrote:
> > >
> > > On Thu, Aug 31, 2023 at 6:12 PM Ashutosh Bapat
> > > wrote:
> > >
On Tue, 5 Sept 2023 at 09:10, Dilip Kumar wrote:
>
> On Fri, Sep 1, 2023 at 12:16 PM vignesh C wrote:
> >
> > On Fri, 1 Sept 2023 at 10:06, Amit Kapila wrote:
> > >
> > > On Thu, Aug 31, 2023 at 6:12 PM Ashutosh Bapat
> > > wrote:
> > >
scription name or OID.
> - The relation OID.
> - Its LSN.
> - Its sync state.
Added a SQL function to handle the insertion and removed the "ALTER
SUBSCRIPTION ... ADD TABLE" command that was added.
Attached patch has the changes for the same.
Regards,
Vignesh
From ce0e041bf1
ot
filtered) but the confirm_flush LSN is updated due to keepalives. As we
don't flush the latest value of confirm_flush LSN, it may lead to
processing the same changes again without this patch.
Author: Vignesh C, Julien Rouhaud, Kuroda Hayato based on suggestions by
Ashutosh Bapat
Reviewed-b
'-s', $new_sub->host,
> '-p', $old_sub->port, '-P', $new_sub->port,
> $mode,
> '--preserve-subscription-state',
> '--check',
> ],
> &#
On Wed, 10 May 2023 at 13:29, Peter Smith wrote:
>
> Here are some review comments for the v5-0001 patch code.
>
> ==
> General
>
> 1. ALTER SUBSCRIPTION name ADD TABLE (relid = XYZ, state = 'x' [, lsn =
> 'X/Y'])
>
> I was a bit confused by this relation 'state' mentioned in multiple
> place
On Mon, 4 Sept 2023 at 13:26, Amit Kapila wrote:
>
> On Mon, Sep 4, 2023 at 11:51 AM Amit Kapila wrote:
> >
> > On Wed, Jul 19, 2023 at 12:47 PM Michael Paquier
> > wrote:
> > >
> > > On Wed, May 10, 2023 at 05:59:24PM +1000, Peter Smith wrote:
> > > > 1. ALTER SUBSCRIPTION name ADD TABLE (reli
On Wed, 10 May 2023 at 13:39, Peter Smith wrote:
>
> On Mon, Apr 24, 2023 at 4:19 PM Julien Rouhaud wrote:
> >
> > Hi,
> >
> > On Thu, Apr 13, 2023 at 03:26:56PM +1000, Peter Smith wrote:
> > >
> > > 1.
> > > All the comments look alike, so it is hard to know what is going on.
> > > If each of th
On Thu, 7 Sept 2023 at 17:26, Himanshu Upadhyaya
wrote:
>
> Attached is v2 of the patch, rebased against the latest HEAD.
Thanks for working on this, few comments:
1) "CREATE TABLE check_constr_tbl (i int CHECK(i<>0) DEFERRABLE, t
text)" is crashing in windows, the same was noticed in CFBot too:
On Thu, 7 Sept 2023 at 17:26, Himanshu Upadhyaya
wrote:
>
> Attached is v2 of the patch, rebased against the latest HEAD.
Few issues:
1) Create domain fails but alter domain is successful, I feel we
should support create domain too:
postgres=# create domain d1 as int check(value<>0) deferrable;
E
On Thu, 14 Sept 2023 at 15:33, Himanshu Upadhyaya
wrote:
>
>
>
> On Thu, Sep 14, 2023 at 9:57 AM vignesh C wrote:
>>
>> 3) Insert check is not deferred to commit:
>> This insert check here is deferred to commit:
>> postgres=# CREATE TABLE tbl (i int ) par
llow to skip arguments, we must define wrappers like
> pg_copy_logical_replication_slot_*.
> Another approach is that pg_dump always dumps srsublsn even if it is NULL.
Modified
The attached v8 version patch has the changes for the same.
Regards,
Vignesh
From 84dff766b98381dafd7382b7521107a9f76608dd
On Tue, 12 Sept 2023 at 18:52, Zhijie Hou (Fujitsu)
wrote:
>
> On Monday, September 11, 2023 6:32 PM vignesh C wrote:
> >
> >
> > The attached v7 patch has the changes for the same.
>
> Thanks for updating the patch,
On Fri, 15 Sept 2023 at 15:08, vignesh C wrote:
>
> On Tue, 12 Sept 2023 at 14:25, Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Vignesh,
> >
> > Thank you for updating the patch! Here are some comments.
> >
> > Sorry if there are duplicate comments
On Tue, 19 Sept 2023 at 11:49, Michael Paquier wrote:
>
> On Fri, Sep 15, 2023 at 04:51:57PM +0530, vignesh C wrote:
> > Another approach to solve this as suggested by one of my colleague
> > Hou-san would be to set max_logical_replication_workers = 0 while
> > upgrading.
/www.postgresql.org/message-id/5dff4caf26f45ce224a33a5e18e110b93a351b2f.camel%40j-davis.com
Regards,
Vignesh
From 9347e863cc78d328f7556db0e357787d14feae75 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 22 Sep 2023 15:12:23 +0530
Subject: [PATCH v1] Restart the apply worker if the subscription owner has
changed f
On Sat, 23 Sept 2023 at 11:28, Amit Kapila wrote:
>
> On Sat, Sep 23, 2023 at 1:27 AM vignesh C wrote:
> >
> >
> > Fixed this issue by checking if the subscription owner has changed
> > from superuser to non-superuser in case the pg_authid rows changes.
> > Th
On Mon, 25 Sept 2023 at 00:32, vignesh C wrote:
>
> On Sat, 23 Sept 2023 at 11:28, Amit Kapila wrote:
> >
> > On Sat, Sep 23, 2023 at 1:27 AM vignesh C wrote:
> > >
> > >
> > > Fixed this issue by checking if the subscription owner has changed
>
On Sun, 2 Jul 2023 at 20:42, vignesh C wrote:
>
> Hi,
>
> Improved tab completion for "ALTER DEFAULT PRIVILEGE" and "ALTER TABLE":
> 1) GRANT, REVOKE and FOR USER keyword was not displayed in tab
> completion of alter default privileges like the below state
On Wed, 20 Sept 2023 at 16:54, Amit Kapila wrote:
>
> On Fri, Sep 15, 2023 at 3:08 PM vignesh C wrote:
> >
> > The attached v8 version patch has the changes for the same.
> >
>
> Is the check to ensure remote_lsn is valid correct in function
> check_for_subscri
On Tue, 26 Sept 2023 at 13:03, Peter Smith wrote:
>
> Here are some comments for patch v2-0001.
>
> ==
> src/backend/replication/logical/worker.c
>
> 1. maybe_reread_subscription
>
> ereport(LOG,
> (errmsg("logical replication worker for subscription \"%s\"
> will restart because of a
ing.
>
> /as password option/because the password option/
Modified
The attached v3 version patch has the changes for the same.
Regards,
Vignesh
From f2828562ad7619a6d1fb1844c6afba546df840b5 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 22 Sep 2023 15:12:23 +0530
Subject: [PATCH
On Wed, 27 Sept 2023 at 06:58, Peter Smith wrote:
>
> On Tue, Sep 26, 2023 at 11:57 PM vignesh C wrote:
> >
> > On Tue, 26 Sept 2023 at 13:03, Peter Smith wrote:
> > >
> > > Here are some comments for patch v2-0001.
> > >
> > > ==
> &
On Tue, 26 Sept 2023 at 10:58, vignesh C wrote:
>
> On Wed, 20 Sept 2023 at 16:54, Amit Kapila wrote:
> >
> > On Fri, Sep 15, 2023 at 3:08 PM vignesh C wrote:
> > >
> > > The attached v8 version patch has the changes for the same.
> > >
> >
>
On Mon, 25 Sept 2023 at 10:05, Amit Kapila wrote:
>
> On Fri, Sep 22, 2023 at 4:36 AM Michael Paquier wrote:
> >
> > On Thu, Sep 21, 2023 at 02:35:55PM +0530, Amit Kapila wrote:
> > > It is because after upgrade of both publisher and subscriber, the
> > > subscriptions won't work. Both publisher
On Wed, 27 Sept 2023 at 12:28, Amit Kapila wrote:
>
> On Wed, Sep 27, 2023 at 6:58 AM Peter Smith wrote:
> >
> > On Tue, Sep 26, 2023 at 11:57 PM vignesh C wrote:
> > >
> > > On Tue, 26 Sept 2023 at 13:03, Peter Smith wrote:
> > > >
belong together?
Modified
> ~
>
> 2b.
> None of the other bool fields here has an 'is' prefix, so you could
> consider a shorter field name, like 'ownersuperuser' or
> 'superuserowner', etc.
Modified
The attached v5 version patch has the changes for th
On Thu, 28 Sept 2023 at 03:55, Masahiko Sawada wrote:
>
> Sorry for the late reply.
>
> On Sun, Sep 3, 2023 at 2:48 PM Noah Misch wrote:
> >
> > On Wed, Jul 12, 2023 at 01:47:51PM +0200, Daniel Gustafsson wrote:
> > > > On 12 Jul 2023, at 09:52, Masahiko Sawada wrote:
> > > > Agreed. The timeout
af720b4c50a122647182f4a030bb0ea8f750fe2f.
Attached a patch for fixing the same.
Regards,
Vignesh
From 8f5b1514cbbbddbd3cd42ba0d847c9cc3d619f6c Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sat, 30 Sep 2023 20:11:08 +0530
Subject: [PATCH] Remove ParallelReadyList and worker_spi_state from
typedefs.list
Remove ParallelReadyList and
On Sat, 30 Sept 2023 at 21:44, Tom Lane wrote:
>
> vignesh C writes:
> > Remove ParallelReadyList and worker_spi_state from typedefs.list,
> > these structures have been removed as part of an earlier commits,
> > ParallelReadyLis
t;passwordrequired;
>
> SUGGESTION
> must_use_password = sub->passwordrequired && !sub->ownersuperuser;
Modified
Thanks for the comments, the attached v6 version patch has the changes
for the same.
Regards,
Vignesh
From 228c1439c722d74d1bc8746541e0fb0fcf127b57 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date:
On Tue, 19 Sept 2023 at 15:46, Pierre Ducroquet wrote:
>
> On Monday, September 18, 2023 11:54:42 PM CEST Nathan Bossart wrote:
> > On Mon, Sep 18, 2023 at 02:52:47PM -0700, Nathan Bossart wrote:
> > > On Thu, Jul 27, 2023 at 10:51:11AM +0200, Pierre Ducroquet wrote:
> > >> I ended up writing seve
On Mon, 3 Jul 2023 at 07:16, Masahiko Sawada wrote:
>
> On Fri, Jun 23, 2023 at 12:39 PM Dilip Kumar wrote:
> >
> > On Fri, Jun 9, 2023 at 10:47 AM Masahiko Sawada
> > wrote:
> > >
> > > Hi,
> > >
> > > In logical decoding, we don't need to collect decoded changes of
> > > aborted transactions.
On Fri, 17 Mar 2023 at 18:01, Jim Jones wrote:
>
> After some more testing I realized that v5 was leaking the xmlDocPtr.
>
> Now fixed in v6.
Few comments:
1) Why the default option was chosen without comments shouldn't it be
the other way round?
+opt_xml_serialize_format:
+
On Fri, 30 Apr 2021 at 11:53, Dilip Kumar wrote:
>
> On Thu, Apr 29, 2021 at 9:45 PM vignesh C wrote:
> >
> > Hi,
> >
> > While debugging one of the logical decoding issues, I found that xid was
> > not included in restoring reorder buffer changes from disk
Hi,
I noticed a couple of typos in code. "the the" should have been "the",
attached patch has the changes for the same.
Regards,
Vignesh
From 83d3ccf7e0bb7732c70da825bfcfb8d0e453c207 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 6 Oct 2023 15:24:12 +0530
Subject:
On Wed, 4 Oct 2023 at 17:01, Shlok Kyal wrote:
>
> On Wed, 4 Oct 2023 at 16:56, Peter Smith wrote:
> >
> > On Tue, Oct 3, 2023 at 5:42 PM vignesh C wrote:
> > >
> > > Thanks for the comments, the attached v6 version patch has the changes
> > > for
On Fri, 6 Oct 2023 at 20:50, Dagfinn Ilmari Mannsåker wrote:
>
> vignesh C writes:
>
> > Hi,
> >
> > I noticed a couple of typos in code. "the the" should have been "the",
> > attached patch has the changes for the same.
>
> This made m
On Sat, 7 Oct 2023 at 08:12, Amit Kapila wrote:
>
> On Tue, Oct 3, 2023 at 12:12 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v6 version patch has the changes
> > for the same.
> >
>
> Few comments:
> =
>
On Fri, 6 Oct 2023 at 18:30, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> Based on comments, I revised my patch. PSA the file.
>
> >
> > > Today, I discussed this problem with Andres at PGConf NYC and he
> > > suggested as following. To verify, if there is any pending unexpected
> > > WAL
On Mon, 9 Oct 2023 at 16:17, Amit Kapila wrote:
>
> On Sat, Oct 7, 2023 at 8:28 AM vignesh C wrote:
> >
> > On Fri, 6 Oct 2023 at 20:50, Dagfinn Ilmari Mannsåker
> > wrote:
> > >
> > > vignesh C writes:
> > >
> > > > Hi,
> &
On Mon, 9 Oct 2023 at 12:18, Peter Smith wrote:
>
> On Mon, Oct 9, 2023 at 3:32 PM Amit Kapila wrote:
> >
> > On Fri, Oct 6, 2023 at 12:15 PM Peter Smith wrote:
> > >
> > > Here is a patch to add the 2 missing references:
> > >
> > > ref/alter_subscription.sgml ==> added more ids
> > > ref/alter
On Tue, 10 Oct 2023 at 08:47, Peter Smith wrote:
>
> On Tue, Oct 10, 2023 at 11:46 AM vignesh C wrote:
> >
> > I noticed a couple of other places where a link to "ALTER SUBSCRIPTION
> > ... DISABLE" and "ALTER SUBSCRIPTION ... SET" can be specified
On Mon, 9 Oct 2023 at 16:20, David Rowley wrote:
>
> On Mon, 9 Oct 2023 at 21:17, David Rowley wrote:
> > Here are some more thoughts on how we could improve this:
> >
> > 1. Adjust the definition of StringInfoData.maxlen to define that -1
> > means the StringInfoData's buffer is externally manag
On Thu, 12 Oct 2023 at 11:10, Amit Kapila wrote:
>
> On Sun, Oct 8, 2023 at 8:22 AM vignesh C wrote:
> >
>
> --- a/src/include/catalog/pg_subscription.h
> +++ b/src/include/catalog/pg_subscription.h
> @@ -127,6 +127,7 @@ typedef struct Subscription
> * skipped */
&g
On Tue, 10 Oct 2023 at 06:59, Kyotaro Horiguchi wrote:
>
> At Fri, 6 Oct 2023 14:58:13 +0530, vignesh C wrote in
> > On Fri, 30 Apr 2021 at 11:53, Dilip Kumar wrote:
> > > It makes sense to include xid in the debug message, earlier I thought
> > > that will it be
e significant improvement in many
scenarios.
Attached patch for reference which was used to capture the execution time
breakup.
Thoughts?
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
On Tue, Mar 3, 2020 at 11:44 AM vignesh C wrote:
> On Wed, Feb 26, 2020 at 8:47 PM Ants Aasma
On Sat, Jan 15, 2022 at 3:58 PM Amit Kapila wrote:
>
> On Fri, Jan 14, 2022 at 5:35 PM vignesh C wrote:
> >
> > Thanks for the updated patch, few minor comments:
> > 1) Should "SKIP" be "SKIP (" here:
> > @@ -1675,7 +1675,7 @@ ps
On Mon, Jan 24, 2022 at 10:06 PM Fujii Masao
wrote:
>
>
>
> On 2022/01/24 16:35, torikoshia wrote:
> > On 2022-01-14 19:48, Bharath Rupireddy wrote:
> >> On Sat, Nov 20, 2021 at 11:50 AM Bharath Rupireddy
> >> wrote:
> >>>
> >>> O
On Mon, Jan 24, 2022 at 1:05 PM torikoshia wrote:
>
> On 2022-01-14 19:48, Bharath Rupireddy wrote:
> > On Sat, Nov 20, 2021 at 11:50 AM Bharath Rupireddy
> > wrote:
> >>
> >> On Fri, Nov 19, 2021 at 4:07 PM vignesh C wrote:
> >> > T
On Wed, Jan 26, 2022 at 11:07 AM Bharath Rupireddy
wrote:
>
> On Tue, Jan 25, 2022 at 12:00 PM vignesh C wrote:
> > Thanks for the comments, attached v17 patch has the fix for the same.
>
> Have a minor comment on v17:
>
> can we modify the elog(LOG, to new style
On Fri, Jan 28, 2022 at 1:54 PM Bharath Rupireddy
wrote:
>
> On Thu, Jan 27, 2022 at 10:45 AM vignesh C wrote:
> >
> > On Wed, Jan 26, 2022 at 11:07 AM Bharath Rupireddy
> > wrote:
> > >
> > > On Tue, Jan 25, 2022 at 12:00 PM vignesh C wrote:
> >
On Sat, Jan 29, 2022 at 8:06 AM vignesh C wrote:
>
> On Fri, Jan 28, 2022 at 1:54 PM Bharath Rupireddy
> wrote:
> >
> > On Thu, Jan 27, 2022 at 10:45 AM vignesh C wrote:
> > >
> > > On Wed, Jan 26, 2022 at 11:07 AM Bharath Rupireddy
> > > wrote:
On Thu, Feb 10, 2022 at 3:15 PM Ashutosh Sharma wrote:
>
> On Wed, Feb 9, 2022 at 11:53 PM Euler Taveira wrote:
> >
> > On Wed, Feb 9, 2022, at 12:06 PM, Ashutosh Sharma wrote:
> >
> > Just wondering if we should also be detecting the incorrect conninfo
> > set with ALTER SUBSCRIPTION command as
On Fri, Feb 11, 2022 at 7:14 PM Ashutosh Sharma wrote:
>
> I have spent little time looking at the latest patch. The patch looks
> to be in good shape as it has already been reviewed by many people
> here, although I did get some comments. Please take a look and let me
> know your thoughts.
>
>
>
n updated patch which is rebased on top of HEAD.
Regards,
Vignesh
From 22d17bd8eeb2c35870b80cbc41c23e89e2c8f981 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sun, 6 Nov 2022 06:34:44 +0530
Subject: [PATCH v9 1/2] Add RESET clause to Alter Publication which will reset
the publication with defaul
On Thu, 11 Aug 2022 at 02:03, Euler Taveira wrote:
>
> On Wed, Aug 10, 2022, at 9:39 AM, osumi.takami...@fujitsu.com wrote:
>
> Minor review comments for v6.
>
> Thanks for your review. I'm attaching v7.
>
> "If the subscriber sets min_apply_delay parameter, ..."
>
> I suggest we use subscription
801 - 900 of 1883 matches
Mail list logo
