On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera wrote:
>
> On 2021-May-14, vignesh C wrote:
>
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab completion for the
> > alter subscription set opt
On Thu, May 20, 2021 at 9:40 PM Tom Lane wrote:
>
> vignesh C writes:
> > On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera
> > wrote:
> >> I wish we didn't have to keep knowledge in the psql source on which
> >> option names are to be used for each comm
On Wed, May 19, 2021 at 2:03 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Tue, May 18, 2021 at 9:21 PM Alvaro Herrera
wrote:
> >
> > On 2021-May-14, vignesh C wrote:
> >
> > > While I was reviewing one of the logical decodin
On Mon, May 24, 2021 at 9:38 AM Amit Kapila wrote:
>
> On Thu, May 13, 2021 at 11:30 AM vignesh C wrote:
> >
>
> Do we want to update the information about pg_stat_replication_slots
> at the following place in docs
> https://www.postgresql.org/docs/devel/logicaldecoding-
On Tue, May 25, 2021 at 8:54 AM Ajin Cherian wrote:
>
> On Fri, May 21, 2021 at 6:43 PM Peter Smith wrote:
>
> > Fixed in v77-0001, v77-0002
>
> Attaching a new patch-set that rebases the patch, addresses review
> comments from Peter as well as a test failure reported by Tang. I've
> also added s
On Tue, May 25, 2021 at 12:40 PM Michael Paquier wrote:
>
> On Mon, May 24, 2021 at 10:03:01AM +0530, Amit Kapila wrote:
> > So, this appears to be an existing caveat of synchronous replication.
> > If that is the case, I am not sure if it is a good idea to just block
> > such ops for the prepared
On Tue, Apr 27, 2021 at 3:21 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> While reviewing [1], I found that the CREATE COLLATION doesn't throw an error
> if duplicate options are specified, see [2] for testing a few cases on HEAD.
> This may end up accepting some of the weird cases, see [2]. It's aga
On Mon, Apr 5, 2021 at 7:19 PM Bharath Rupireddy
wrote:
>
> On Mon, Apr 5, 2021 at 6:41 PM Euler Taveira wrote:
> > Here's the v4 patch reabsed on the latest master, please review it further.
> >
> > /* UNLOGGED and TEMP relations cannot be part of publication. */
> > if (!RelationIsPermanent(tar
On Tue, May 25, 2021 at 6:36 PM Ajin Cherian wrote:
>
> On Tue, Apr 27, 2021 at 1:49 PM Ajin Cherian wrote:
>
> Rebased the patch as it was no longer applying.
Thanks for the updated patch, few comments:
1) I'm not sure if we could add some tests for skip empty
transactions, if possible add a fe
On Wed, May 26, 2021 at 7:44 PM Bharath Rupireddy
wrote:
>
> On Wed, May 26, 2021 at 7:18 PM vignesh C wrote:
> > +1 for fixing this issue, we have handled this error in other places.
> > The patch does not apply on head, could you rebase the patch on head
> > and post a
On Wed, May 26, 2021 at 7:55 PM Bharath Rupireddy
wrote:
>
> On Wed, May 26, 2021 at 7:38 PM vignesh C wrote:
> > > Attaching v5 patch, please have a look.
> >
> > We get the following error while adding an index:
> > create publication mypub for table idx_t1;
On Fri, May 28, 2021 at 9:14 AM Ajin Cherian wrote:
>
> On Wed, May 26, 2021 at 6:53 PM vignesh C wrote:
> >
> > On Tue, May 25, 2021 at 8:54 AM Ajin Cherian wrote:
> > >
> > > On Fri, May 21, 2021 at 6:43 PM Peter Smith wrote:
> > >
> > >
Hi,
I felt inclusion of alias types regpublication and regsubscription will
help the logical replication users. This will also help in [1].
The alias types allow simplified lookup of publication oid values for
objects. For example, to examine the pg_publication_rel rows, one could
write:
SELECT pr
On Wed, May 26, 2021 at 7:44 PM Bharath Rupireddy
wrote:
>
> On Wed, May 26, 2021 at 7:18 PM vignesh C wrote:
> > +1 for fixing this issue, we have handled this error in other places.
> > The patch does not apply on head, could you rebase the patch on head
> > and post a
On Sat, May 29, 2021 at 9:10 PM Tom Lane wrote:
>
> vignesh C writes:
> > I felt inclusion of alias types regpublication and regsubscription will
> > help the logical replication users.
>
> This doesn't really seem worth the trouble --- how often would you
> use
On Sat, May 29, 2021 at 9:20 PM Bharath Rupireddy
wrote:
>
> On Sat, May 29, 2021 at 9:08 PM vignesh C wrote:
> > One minor comment:
> > You can remove the brackets around errcode, You could change:
> > + if (localeEl)
> > + ereport(ERROR,
> > + (errcode
On Wed, 16 Nov 2022 at 15:35, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick wrote:
> >
> > 2022年11月7日(月) 22:39 vignesh C :
> > >
> > > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick
> > > wrote:
> > > >
>
On Sun, 15 Jan 2023 at 23:02, vignesh C wrote:
>
> On Sun, 8 Jan 2023 at 21:00, vignesh C wrote:
> >
> > On Tue, 3 Jan 2023 at 13:13, vignesh C wrote:
> > >
> > > Hi All,
> > >
> > > Just a reminder that Commitfest 2023-01 has started.
>
Regards,
Vignesh
From 83aa8b6a0c7b4de42c1bf7aa6cfd863830a86c76 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 27 Jan 2023 15:17:09 +0530
Subject: [PATCH] Lock the replication origin record instead of locking the
pg_replication_origin relation.
Lock the replication origin record instead of locking the
pg_replication_orig
On Thu, 26 Jan 2023 at 19:53, Melih Mutlu wrote:
>
> Hi Shveta,
>
> Thanks for reviewing.
>
> shveta malik , 25 Oca 2023 Çar, 16:02 tarihinde şunu
> yazdı:
>>
>> On Mon, Jan 23, 2023 at 6:30 PM Melih Mutlu wrote:
>> --I see initial data copied, but new catalog columns srrelslotname
>> and srrelo
On Tue, 17 Jan 2023 at 19:01, Amit Langote wrote:
>
> On Wed, Dec 28, 2022 at 4:28 PM Amit Langote wrote:
> >
> > Hi,
> >
> > Rebased the SQL/JSON patches over the latest HEAD. I've decided to
> > keep the same division of code into individual commits as that
> > mentioned in the revert commit 2
On Tue, 1 Nov 2022 at 16:40, Thomas Munro wrote:
>
> On Fri, Oct 28, 2022 at 4:56 PM Thomas Munro wrote:
> > See attached sketch patches. I guess the main thing that may not be
> > good enough is the use of a fixed sized latch buffer. Memory
> > allocation in don't-throw-here environments like
On Mon, 16 Jan 2023 at 04:49, Tomas Vondra
wrote:
>
> cfbot didn't like the rebased / split patch, and after looking at it I
> believe it's a bug in parallel apply of large transactions (216a784829),
> which seems to have changed interpretation of in_remote_transaction and
> in_streamed_transactio
On Sun, 25 Sept 2022 at 05:29, Dmitry Dolgov <9erthali...@gmail.com> wrote:
>
> > On Sat, Sep 24, 2022 at 04:07:14PM +0200, Dmitry Dolgov wrote:
> > > On Fri, Sep 16, 2022 at 09:25:13PM +0300, Sergei Kornilov wrote:
> > > Hello!
> > >
> > > Unfortunately the patch needs another rebase due to the re
On Sun, 22 Jan 2023 at 22:00, vignesh C wrote:
>
> On Sun, 15 Jan 2023 at 23:02, vignesh C wrote:
> >
> > On Sun, 8 Jan 2023 at 21:00, vignesh C wrote:
> > >
> > > On Tue, 3 Jan 2023 at 13:13, vignesh C wrote:
> > > >
> > > > Hi All,
On Sat, 28 Jan 2023 at 11:26, Amit Kapila wrote:
>
> On Sat, Jan 28, 2023 at 9:36 AM houzj.f...@fujitsu.com
> wrote:
> >
> > On Friday, January 27, 2023 8:16 PM Amit Kapila
> > >
> > > On Fri, Jan 27, 2023 at 3:45 PM vignesh C wrote:
> > > >
On Fri, 27 Jan 2023 at 17:46, Amit Kapila wrote:
>
> On Fri, Jan 27, 2023 at 3:45 PM vignesh C wrote:
> >
> > On Mon, 23 Jan 2023 at 10:52, Amit Kapila wrote:
> > >
> > > IIRC, this is done to prevent concurrent drops of origin drop say by
> > > expo
On Mon, 30 Jan 2023 at 13:00, houzj.f...@fujitsu.com
wrote:
>
> On Monday, January 30, 2023 2:32 PM Amit Kapila
> wrote:
> >
> > On Mon, Jan 30, 2023 at 9:20 AM vignesh C wrote:
> > >
> > > On Sat, 28 Jan 2023 at 11:26, Amit Kapila wrote:
> > >
On Mon, 30 Jan 2023 at 13:00, houzj.f...@fujitsu.com
wrote:
>
> On Monday, January 30, 2023 2:32 PM Amit Kapila
> wrote:
> >
> > On Mon, Jan 30, 2023 at 9:20 AM vignesh C wrote:
> > >
> > > On Sat, 28 Jan 2023 at 11:26, Amit Kapila wrote:
> > >
On Mon, 30 Jan 2023 at 13:00, houzj.f...@fujitsu.com
wrote:
>
> On Monday, January 30, 2023 2:32 PM Amit Kapila
> wrote:
> >
> > On Mon, Jan 30, 2023 at 9:20 AM vignesh C wrote:
> > >
> > > On Sat, 28 Jan 2023 at 11:26, Amit Kapila wrote:
> > >
On Mon, 30 Jan 2023 at 17:30, vignesh C wrote:
>
> On Mon, 30 Jan 2023 at 13:00, houzj.f...@fujitsu.com
> wrote:
> >
> > On Monday, January 30, 2023 2:32 PM Amit Kapila
> > wrote:
> > >
> > > On Mon, Jan 30, 2023 at 9:20 AM vignesh C wrote:
>
On Wed, 11 Jan 2023 at 22:17, vignesh C wrote:
>
> On Tue, 8 Nov 2022 at 02:16, Fabien COELHO wrote:
> >
> >
> > Hello Ian,
> >
> > > cfbot reports the patch no longer applies. As CommitFest 2022-11 is
> > > currently underway, thi
On Mon, 16 Jan 2023 at 20:07, vignesh C wrote:
>
> On Fri, 4 Nov 2022 at 04:59, Ian Lawrence Barwick wrote:
> >
> > 2022年7月13日(水) 19:13 Przemysław Sztoch :
> > >
> > > Dear Michael P.,
> > >
> > > 3. The matter is not that simple. When
On Wed, 18 Jan 2023 at 23:57, Joe Conway wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: not tested
> Spec compliant: not tested
> Documentation:not tested
>
> This needs re
On Thu, 8 Dec 2022 at 00:33, Andres Freund wrote:
>
> Hi,
>
> On 2022-11-04 09:25:52 +0100, Drouvot, Bertrand wrote:
> > Please find attached a rebase in v7.
>
> cfbot complains that the docs don't build:
> https://cirrus-ci.com/task/6694349031866368?logs=docs_build#L296
>
> [03:24:27.317] ref/che
On Fri, 6 Jan 2023 at 11:46, vignesh C wrote:
>
> On Sun, 13 Nov 2022 at 04:15, Tom Lane wrote:
> >
> > Andy Fan writes:
> > > In the past we pull-up the ANY-sublink with 2 steps, the first step is to
> > > pull up the sublink as a subquery, and the next step
On Tue, 3 Jan 2023 at 18:38, vignesh C wrote:
>
> On Sun, 20 Nov 2022 at 11:42, Nikolay Shaplov wrote:
> >
> > В письме от воскресенье, 6 ноября 2022 г. 19:22:09 MSK пользователь Nikolay
> > Shaplov написал:
> >
> > > > > > cfbot reports the pa
On Mon, 16 Jan 2023 at 19:56, vignesh C wrote:
>
> On Thu, 3 Nov 2022 at 15:06, Ian Lawrence Barwick wrote:
> >
> > 2022年9月30日(金) 1:04 Matthias van de Meent :
> > >
> > > On Wed, 28 Sept 2022 at 19:40, Bruce Momjian wrote:
> > > >
> > >
On Fri, 4 Nov 2022 at 07:02, Ian Lawrence Barwick wrote:
>
> 2022年7月27日(水) 2:47 chenhj :
> >
> > Hi hackers,
> >
> > I have rebase this patch and made some improvements.
> >
> >
> > 1. A header is added to each chunk in the pcd file, which records the chunk
> > of which block the chunk belongs to
On Tue, 17 Jan 2023 at 17:06, vignesh C wrote:
>
> On Fri, 25 Nov 2022 at 18:08, Peter Eisentraut
> wrote:
> >
> > On 23.08.22 03:38, Dong Wook Lee wrote:
> > > I made a small patch for xml2 to improve test coverage.
> > > However, there
On Tue, 17 Jan 2023 at 17:10, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 10:18, Ian Lawrence Barwick wrote:
> >
> > 2022年9月3日(土) 17:28 Dong Wook Lee :
> > >
> > > Hi hackers,
> > > I write a tiny patch about vacuumlo to improve test coverage.
&
On Tue, 17 Jan 2023 at 17:17, vignesh C wrote:
>
> On Tue, 29 Nov 2022 at 20:24, Nazir Bilal Yavuz wrote:
> >
> > Hi,
> >
> > Thanks for the patch!
> >
> >
> > On 10/29/22 12:54, Marina Polyakova wrote:
> > >
> > > 1) The ECPG
On Sun, 29 Jan 2023 at 22:05, vignesh C wrote:
>
> On Sun, 22 Jan 2023 at 22:00, vignesh C wrote:
> >
> > On Sun, 15 Jan 2023 at 23:02, vignesh C wrote:
> > >
> > > On Sun, 8 Jan 2023 at 21:00, vignesh C wrote:
> > > >
>
On Wed, 1 Feb 2023 at 11:25, Julien Rouhaud wrote:
>
> On Wed, Feb 1, 2023 at 10:44 AM vignesh C wrote:
> >
> > I don't have permissions to close the commitfest, could one of them
> > help in closing the commitfest.
>
> It's technically 17:53 at Anywher
On Wed, 1 Feb 2023 at 14:49, Alvaro Herrera wrote:
>
> On 2023-Jan-31, vignesh C wrote:
>
> > On Tue, 3 Jan 2023 at 18:38, vignesh C wrote:
>
> > > The patch does not apply on top of HEAD as in [1], please post a rebased
> > > patch:
> > > === Ap
On Mon, 6 Feb 2023 at 17:02, vignesh C wrote:
>
> On Mon, 6 Feb 2023 at 06:47, Peter Smith wrote:
> >
> > Here are some comments for patch v63-0002.
> >
> > This is a WIP because I have not yet looked at the large file -
> > ddl_deparse.c.
> >
> &g
On Tue, 7 Feb 2023 at 17:35, vignesh C wrote:
>
> On Mon, 6 Feb 2023 at 17:02, vignesh C wrote:
> >
> > On Mon, 6 Feb 2023 at 06:47, Peter Smith wrote:
> > >
> > > Here are some comments for patch v63-0002.
> > >
> > > This is
On Fri, 10 Feb 2023 at 21:50, vignesh C wrote:
> The attached v68 version patch has the changes for the same.
I was not sure if we should support ddl replication of
create/alter/drop subscription commands as there might be some data
inconsistency issues in the following cases:
#node1 who
Hi,
The output sql generated by pg_dump for the below function refers to a
modified table name:
create table t1 (c1 int);
create table t2 (c1 int);
CREATE OR REPLACE FUNCTION test_fun(c1 int)
RETURNS void
LANGUAGE SQL
BEGIN ATOMIC
WITH delete_t1 AS (
DELETE FROM t1 WHERE c1 = $1
On Fri, 17 Feb 2023 at 02:38, Jonathan S. Katz wrote:
>
> On 2/16/23 2:43 PM, Jonathan S. Katz wrote:
> > On 2/16/23 2:38 PM, Alvaro Herrera wrote:
> >> On 2023-Feb-16, Jonathan S. Katz wrote:
> >>
> >>> On 2/16/23 12:53 PM, Alvaro Herrera wrote:
> >>
> I don't think this is the fault of logi
he changes to handle the same.
Regards,
Vignesh
From 1d454be7e89828bdacb191681e469c9581b615d5 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sun, 2 Oct 2022 10:45:04 +0530
Subject: [PATCH v1 1/2] Display publications and subscriptions for tab
completion of \dRp and \dRs.
Display public
On Tue, 4 Oct 2022 at 09:13, Michael Paquier wrote:
>
> On Mon, Oct 03, 2022 at 06:29:32PM +0100, Dagfinn Ilmari Mannsåker wrote:
> > vignesh C writes:
> >> +else if (TailMatchesCS("\\dRp*"))
> >> +COMPLETE_WITH_QUERY(Query_for_list_of_p
On Wed, 5 Oct 2022 at 08:17, Michael Paquier wrote:
>
> On Tue, Oct 04, 2022 at 10:35:25AM +0100, Dagfinn Ilmari Mannsåker wrote:
> > LGTM, +1 to commit.
>
> Fine by me, so done.
Thanks for pushing this.
Regards,
Vignesh
On Thu, 6 Oct 2022 at 12:44, Amit Kapila wrote:
>
> On Sat, Oct 1, 2022 at 12:35 AM Andres Freund wrote:
> >
> > This issue does occasionally happen in CI, as e.g. noted in this thread:
> > https://www.postgresql.org/message-id/20220930185345.GD6256%40telsasoft.com
> >
> > On 2022-08-18 15:17:47
On Wed, 12 Oct 2022 at 16:16, vignesh C wrote:
>
> On Thu, 6 Oct 2022 at 12:44, Amit Kapila wrote:
> >
> > On Sat, Oct 1, 2022 at 12:35 AM Andres Freund wrote:
> > >
> > > This issue does occasionally happen in CI, as e.g. noted in this thread:
> &g
HI,
I noticed that the tab completion for ALTER STATISTICS .. SET was not
handled. The attached patch displays SCHEMA and STATISTICS for tab
completion of ALTER STATISTICS name SET.
Regards,
Vignesh
From 2177167ee74ab3748e23aac15c65b8391e73528f Mon Sep 17 00:00:00 2001
From: "vignesh.c"
Date: Tu
On Mon, 24 Oct 2022 at 12:30, Michael Paquier wrote:
>
> On Wed, Oct 19, 2022 at 04:06:51PM +0530, vignesh C wrote:
> > I noticed that the tab completion for ALTER STATISTICS .. SET was not
> > handled. The attached patch displays SCHEMA and STATISTICS for tab
> > comple
Hi,
Tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE action was
missing, this patch adds the tab completion for the same.
Regards,
Vignesh
From 4b0473799a0d6af126ccd3d7802e5d0cbb83b944 Mon Sep 17 00:00:00 2001
From: "vignesh.c"
Date: Thu, 27 Oct 2022 14:00:46 +0530
Subject: [PATCH v1] Tab com
On Fri, 28 Oct 2022 at 08:02, Dong Wook Lee wrote:
>
> On Fri, Oct 28, 2022 at 12:08 AM vignesh C wrote:
> >
> > Hi,
> >
> > Tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE action was
> > missing, this patch adds the tab completion for the same.
>
On Thu, 27 Oct 2022 at 16:02, vignesh C wrote:
>
> On Thu, 27 Oct 2022 at 02:09, Zheng Li wrote:
> >
> > > Adding support for deparsing of CREATE/ALTER/DROP LANGUAGE for ddl
> > > replication.
> >
> > Adding support for deparsing of:
> > COMM
On Mon, 31 Oct 2022 at 16:17, vignesh C wrote:
>
> On Thu, 27 Oct 2022 at 16:02, vignesh C wrote:
> >
> > On Thu, 27 Oct 2022 at 02:09, Zheng Li wrote:
> > >
> > > > Adding support for deparsing of CREATE/ALTER/DROP LANGUAGE for ddl
> > > > re
On Wed, 2 Nov 2022 at 05:13, vignesh C wrote:
>
> On Mon, 31 Oct 2022 at 16:17, vignesh C wrote:
> >
> > On Thu, 27 Oct 2022 at 16:02, vignesh C wrote:
> > >
> > > On Thu, 27 Oct 2022 at 02:09, Zheng Li wrote:
> > > >
> > > > > Add
On Thu, Jun 3, 2021 at 9:18 AM osumi.takami...@fujitsu.com
wrote:
>
> On Tuesday, June 1, 2021 4:33 PM Peter Smith
> > To: Andres Freund
> > Cc: PostgreSQL-development ; Amit Kapila
> > ; Markus Wanner
> >
> > Subject: Re: locking [user] catalog tables vs 2pc vs logical rep
> >
> > Hi.
> >
> >
On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
>
> On Fri, May 7, 2021 at 5:44 PM Dilip Kumar wrote:
> >
> > On Fri, May 7, 2021 at 5:38 PM Bharath Rupireddy
> > wrote:
> > >
> > > On Fri, May 7, 2021 at 11:50 AM Dilip Kumar wrote:
> > >
On Mon, Jun 7, 2021 at 4:18 AM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, June 3, 2021 7:07 PM Amit Kapila wrote:
> > On Thu, Jun 3, 2021 at 9:18 AM osumi.takami...@fujitsu.com
> > wrote:
> > > Thank you for providing the patch.
> > > I have updated your patch to include some other view
On Tue, Jun 8, 2021 at 1:34 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, June 7, 2021 6:22 PM Amit Kapila wrote:
> > On Mon, Jun 7, 2021 at 10:44 AM Amit Kapila
> > wrote:
> > >
> > > One more comment is that for HEAD, first just create a patch with
> > > synchronous replication-related
On Wed, Jun 9, 2021 at 12:03 PM osumi.takami...@fujitsu.com
wrote:
>
> On Wednesday, June 9, 2021 12:06 PM Amit Kapila
> wrote:
> > On Tue, Jun 8, 2021 at 6:24 PM vignesh C wrote:
> > >
> > > Thanks for the updated patch.
> > >
> > > I ha
On Fri, Jun 11, 2021 at 6:57 AM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, June 10, 2021 1:30 PM I wrote:
> > On Thursday, June 10, 2021 1:14 PM vignesh C
> > > On Wed, Jun 9, 2021 at 12:03 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > >
&
On Fri, Jun 11, 2021 at 12:27 PM Michael Paquier wrote:
>
> On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote:
> > /* Complete "CREATE SUBSCRIPTION ... WITH ( " */
> > else if (HeadMatches("CREATE"
On Mon, Jun 14, 2021 at 5:33 PM osumi.takami...@fujitsu.com
wrote:
>
> On Friday, June 11, 2021 2:13 PM vignesh C wrote:
> > Thanks for the updated patch:
> > Few comments:
> > 1) We have used Reordering and Clustering for the same command, we could
> > rep
On Wed, Jun 16, 2021 at 4:59 PM Amit Kapila wrote:
>
> On Sat, Jan 9, 2021 at 8:08 PM Bharath Rupireddy
> wrote:
> >
> > And, with this feature, since there can be many huge tables inside a
> > schema, the initial table sync phase of the replication can take a
> > while.
> >
> > Say a user has cr
On Wed, Jun 16, 2021 at 3:51 PM Amit Kapila wrote:
>
> On Mon, Jun 14, 2021 at 5:33 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Friday, June 11, 2021 2:13 PM vignesh C wrote:
> >
> > Attached the patch-set that addressed those two comments
On Wed, Jan 20, 2021 at 6:27 PM Rahila Syed wrote:
>
> Hi Vignesh,
>
>>
>> I have handled the above scenario(drop schema should automatically
>> remove the schema entry from publication schema relation) & addition
>> of tests in the new v2 patch attached.
>> Thoughts?
>
>
> Please see some initial
On Thu, Jun 17, 2021 at 7:40 PM Ajin Cherian wrote:
>
> On Wed, Jun 16, 2021 at 9:08 AM Peter Smith wrote:
> >
> > On Fri, Jun 11, 2021 at 6:34 PM Peter Smith wrote:
> >
> > > KNOWN ISSUES: This v85 patch was built and tested using yesterday's
> > > master, but due to lots of recent activity in
Thanks for the comments.
On Fri, Jun 18, 2021 at 5:25 PM Ajin Cherian wrote:
>
> On Thu, Jun 17, 2021 at 12:41 AM vignesh C wrote:
>
> > Thanks for reporting it, the attached patch is a rebased version of
> > the patch with few review comment fixes, I will reply with the
On Wed, Jun 23, 2021 at 9:10 AM Ajin Cherian wrote:
>
> On Tue, Jun 22, 2021 at 3:36 PM Greg Nancarrow wrote:
>
> > Some minor comments:
> >
> > (1)
> > v88-0002
> >
> > doc/src/sgml/logicaldecoding.sgml
> >
> > "examples shows" is not correct.
> > I think there is only ONE example being referred
On Thu, Jun 24, 2021 at 2:12 PM Greg Nancarrow wrote:
>
> On Thu, Jun 24, 2021 at 4:41 PM tanghy.f...@fujitsu.com
> wrote:
> >
> > I applied your V7* patch and complied it. The following warnings came
out, please take a look.
> >
>
> I encountered the following warnings when building with the v7
On Thu, Jun 24, 2021 at 12:10 PM tanghy.f...@fujitsu.com
wrote:
>
> Hi
>
> I applied your V7* patch and complied it. The following warnings came out,
> please take a look.
>
> >pg_publication.c:688:22: warning: ‘tables’ may be used uninitialized in this
> >function [-Wmaybe-uninitialized]
> >
On Fri, Jun 25, 2021 at 1:30 PM Peter Eisentraut
wrote:
>
> On 15.05.21 15:15, vignesh C wrote:
> > Thanks Bharath, that looks good. I have added a commitfest entry at [1]
> > and marked it to Ready For Committer.
> > [1] - https://commitfest.postgresql
On Mon, Jun 7, 2021 at 2:38 PM Amit Kapila wrote:
>
> On Thu, Jun 3, 2021 at 10:39 PM Tom Lane wrote:
> >
> > "Euler Taveira" writes:
> > > I was checking the GRANT on pg_subscription and noticed that the command
> > > is not
> > > correct. There is a comment that says "All columns of pg_subscr
On Tue, Jun 29, 2021 at 12:26 PM Amit Kapila wrote:
>
> On Wed, Jun 23, 2021 at 4:10 PM Ajin Cherian wrote:
> >
>
> The first two patches look mostly good to me. I have combined them
> into one and made some minor changes. (a) Removed opt_two_phase and
> related code from repl_gram.y as that is n
Hi all,
The next commit fest is going to begin soon.
I would like to volunteer as commit fest manager for 2021-07 if the
role is not filled and there are no objections.
Regards,
Vignesh
On Thu, May 13, 2021 at 8:09 PM vignesh C wrote:
>
> On Thu, May 13, 2021 at 4:58 AM Alvaro Herrera
> wrote:
> >
>
> Thanks for the comments, Attached patch has the changes for the same.
>
The Patch was not applying on Head, the attached patch is rebased on
top of Head
On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
>
> On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached patch has the fix for the same.
>
> The patch was not applying on the head, attached patch which is rebased on
> HEAD.
On Thu, Jul 1, 2021 at 1:06 AM Rahila Syed wrote:
>
> Hi,
>
> Filtering of columns at the publisher node will allow for selective
> replication of data between publisher and subscriber. In case the updates on
> the publisher are targeted only towards specific columns, the user will have
> an o
On Thu, Jul 1, 2021 at 5:43 PM Bharath Rupireddy
wrote:
>
> On Tue, Jun 22, 2021 at 10:11 AM Bharath Rupireddy
> wrote:
> >
> > On Tue, Jun 22, 2021 at 9:45 AM vignesh C wrote:
> > > I have removed the skip table patches to keep the focus on the main
> >
On Fri, Jul 2, 2021 at 7:08 AM Michael Paquier wrote:
>
> On Thu, Jul 01, 2021 at 09:29:01PM -0400, Bruce Momjian wrote:
> > Should we reserve the next commit fest for vignesh C?
>
> If Vignesh is willing to help here, I'd say yes to that.
I'm interested in ass
Hi,
I found a strange behavior when there is an insert after renaming the
schema. The test steps for the same are given below, Here after the
schema is renamed, the renamed schema table data should not be sent,
but the data was being sent. I felt the schema invalidation was not
called, attached a
On Fri, Jul 2, 2021 at 10:18 AM tanghy.f...@fujitsu.com
wrote:
>
> On Wednesday, June 30, 2021 7:43 PM vignesh C wrote:
> >
> > Thanks for reporting this issue, the attached v9 patch fixes this issue.
> > This also fixes the other issue you reported at [1].
>
> A c
On Fri, Jul 2, 2021 at 6:05 PM Ibrar Ahmed wrote:
>
>
>
> On Fri, 2 Jul 2021 at 1:47 PM, David Rowley wrote:
>>
>> On Fri, 2 Jul 2021 at 15:04, vignesh C wrote:
>> > I'm interested in assisting Ibrar Ahmed.
>>
>> It might be worth talking to Ibr
On Wed, Apr 7, 2021 at 12:13 PM osumi.takami...@fujitsu.com
wrote:
>
> Hi
>
>
> Mainly affected by a commit 9de9294,
> I've fixed minor things to rebase the patch.
> All modifications I did are cosmetic changes and
> a little bit of documentation updates.
> Please have a look at attached v09.
>
P
On Thu, Jun 3, 2021 at 8:36 AM Greg Nancarrow wrote:
>
> On Fri, May 21, 2021 at 2:46 PM Greg Nancarrow wrote:
> >
> > On Thu, May 20, 2021 at 2:45 PM Ivan Panchenko wrote:
> > >
> > > I have upgraded the patch for the 14th version.
> > >
> >
> > I have some feedback on the patch:
> >
>
> I've a
On Wed, Jun 23, 2021 at 7:32 PM Álvaro Herrera wrote:
>
> On 2021-Jun-20, Tom Lane wrote:
>
> > Actually ... isn't there a second race, in the opposite direction?
> > IIUC, the point of this is that once we force some WAL to be sent
> > to the frozen sender/receiver, they'll be killed for failure
On Mon, Jun 7, 2021 at 8:48 PM Bossart, Nathan wrote:
>
> On 12/25/20, 12:09 PM, "Andres Freund" wrote:
> > When running write heavy transactional workloads I've many times
> > observed that one needs to run the benchmarks for quite a while till
> > they get to their steady state performance. The
On Sun, Apr 4, 2021 at 1:51 PM Amit Langote wrote:
>
> On Fri, Apr 2, 2021 at 11:55 PM Zhihong Yu wrote:
> >
> > Hi,
> >
> > + skip = !ExecLockTableTuple(erm->relation, &tid, markSlot,
> > + estate->es_snapshot,
> > estate->es_output_cid,
> > +
On Mon, Jul 5, 2021 at 10:30 PM Álvaro Herrera wrote:
>
> On 2021-Jul-05, vignesh C wrote:
>
> > On Wed, Jun 23, 2021 at 7:32 PM Álvaro Herrera
> > wrote:
> > >
> > > On 2021-Jun-20, Tom Lane wrote:
> > >
> > > > Actually ... isn&#x
On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote:
>
> On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
> >
> > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
> > >
> > > Thanks for the comments, the attached patch has the fix for the same.
> >
On Wed, Jun 30, 2021 at 7:48 PM vignesh C wrote:
>
> On Thu, May 13, 2021 at 8:09 PM vignesh C wrote:
> >
> > On Thu, May 13, 2021 at 4:58 AM Alvaro Herrera
> > wrote:
> > >
> >
> > Thanks for the comments, Attached patch has the changes for the sam
On Thu, Jul 8, 2021 at 11:37 AM Amit Kapila wrote:
>
> On Tue, Jul 6, 2021 at 9:58 AM Peter Smith wrote:
> >
> > Please find attached the latest patch set v93*
> >
>
> Thanks, I have gone through the 0001 patch and made a number of
> changes. (a) Removed some of the code which was leftover from p
On Thu, Jul 8, 2021 at 1:52 AM Daniel Gustafsson wrote:
>
> > On 6 Jul 2021, at 17:08, vignesh C wrote:
>
> > The patch was not applying on the head because of the recent commit
> > "8aafb02616753f5c6c90bbc567636b73c0cbb9d4", attached patch which is
> >
1001 - 1100 of 1883 matches
Mail list logo
