On Sun, 25 Sept 2022 at 05:29, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Sat, Sep 24, 2022 at 04:07:14PM +0200, Dmitry Dolgov wrote: > > > On Fri, Sep 16, 2022 at 09:25:13PM +0300, Sergei Kornilov wrote: > > > Hello! > > > > > > Unfortunately the patch needs another rebase due to the recent split of > > > guc.c (0a20ff54f5e66158930d5328f89f087d4e9ab400) > > > > > > I'm reviewing a patch on top of a previous commit and noticed a failed > > > test: > > > > > > # Failed test 'no parameters missing from postgresql.conf.sample' > > > # at t/003_check_guc.pl line 82. > > > # got: '1' > > > # expected: '0' > > > # Looks like you failed 1 test of 3. > > > t/003_check_guc.pl .............. > > > > > > The new option has not been added to the postgresql.conf.sample > > > > > > PS: I would also like to have such a feature. It's hard to increase > > > pg_stat_statements.max or lose some entries just because some ORM sends > > > requests with a different number of parameters. > > > > Thanks! I'll post the rebased version soon.
The patch does not apply on top of HEAD as in [1], please post a rebased patch: === Applying patches on top of PostgreSQL commit ID 456fa635a909ee36f73ca84d340521bd730f265f === === applying patch ./v9-0001-Prevent-jumbling-of-every-element-in-ArrayExpr.patch .... can't find file to patch at input line 746 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/src/backend/utils/misc/queryjumble.c b/src/backend/utils/misc/queryjumble.c |index a67487e5fe..063b4be725 100644 |--- a/src/backend/utils/misc/queryjumble.c |+++ b/src/backend/utils/misc/queryjumble.c -------------------------- No file to patch. Skipping patch. 8 out of 8 hunks ignored can't find file to patch at input line 913 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/src/include/utils/queryjumble.h b/src/include/utils/queryjumble.h |index 3c2d9beab2..b50cc42d4e 100644 |--- a/src/include/utils/queryjumble.h |+++ b/src/include/utils/queryjumble.h -------------------------- No file to patch. Skipping patch. [1] - http://cfbot.cputube.org/patch_41_2837.log Regards, Vignesh
