Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

hi. the following are review of v40-0001-Implement-ALTER-TABLE-.-MERGE-PARTITIONS-.-comma.patch ALTER TABLE sales_range MERGE PARTITIONS (sales_feb2022, sales_mar2022) INTO sales_feb_mar_apr2022; There are no tests when sales_feb2022 or sales_mar2022 have any constraints. a partition can have its

Re: Partitioned tables and [un]loggedness

On Thu, Jun 05, 2025 at 10:04:23AM +0900, Shinya Kato wrote: > Thank you. It looks good to me. How does the RMT feel about this change? Nathan, would you be OK with that? It's not a big problem, as well, if the code is kept as-is, but as it's a simple change.. -- Michael signature.asc Descript

Re: Wrong security context for deferred triggers?

On Tue, Apr 15, 2025 at 08:58:50AM -0700, Noah Misch wrote: > commit 01463e1 wrote: >> +NOTICE: I am regress_groot Ahah. Excellent. > Let's not incur trivially-avoidable trademark risks > (https://google.com/search?q=%22i+am+groot%22) in the source tree. But you may be right that it could be a

Potential issue in listExtensions()

Hi, Upstream commit d696406a9b255546bc1716d07199103abd8bb785 [1] added the support for default extension version in \dx output and changed the query that fetches the extension list. The changed query seems problematic and might display duplicate entries of extension if the same object oid exists i

Re: Question Regarding Merge Append and Parallel Execution of Index Scans on Partitioned Table

On Thu, 5 Jun 2025 at 07:31, Ayush Vatsa wrote: > Are these Index Scans executed sequentially (one after the other as the Merge > Append requests tuples)? It's a fairly simple answer: Merge Append does not support parallelism. > Or are they possibly executed in parallel, in advance, or concurre

pg_probackup build issue with PostgreSQL 18beta1 due to pg_detoast_datum_packed()

Hi, hackers I've run into a build issue when trying to use pg_probackup with PostgreSQL 18beta1. After some adjustments to pg_probackup, I encountered the following linker errors: /usr/bin/ld: src/pg_crc.o: in function `crc32_bytea': /home/japin/Codes/extensions/pg_probackup/src/pg_crc.c:109:(.

Re: encode/decode support for base64url

Thanks for the review Aleksander; On Mon, Mar 31, 2025 at 5:37 PM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi Florents, > > > Here's a v3 with some (hopefully) better test cases. > > Thanks for the new version of the patch. > > ``` > +encoded_len = pg_base64_encode(src, len, d

Re: like pg_shmem_allocations, but fine-grained for DSM registry ?

On Tue, Jun 3, 2025 at 11:23 PM Nathan Bossart wrote: > This latest patch set looks pretty good to me. > Thanks; let's wait a bit to see if there're any objections. If not, I've taken note of > created_at might be interesting. For a separate patch .

Re: Custom Glibc collation version strings under LOCPATH

On 04.06.25 06:03, Thomas Munro wrote: One way to move to a newer glibc-based Linux distribution but keep the locales working the same* without keeping the associated zombie C code alive is to find the source system's collation definition source files, compile them with the localedef on the targe

Re: Partitioned tables and [un]loggedness

On Wed, Jun 4, 2025 at 6:42 PM Michael Paquier wrote: > > On Thu, Sep 19, 2024 at 01:08:33PM +0900, Michael Paquier wrote: > > I have applied 0001 for now to add ATT_PARTITIONED_TABLE. Attached is > > the remaining piece. > > And the second piece is now applied as of e2bab2d79204. > -- > Michael

Re: Enhance pg_createsubscriber to create required standby.

On Wed, Jun 4, 2025 at 2:39 PM Peter Eisentraut wrote: > > On 04.06.25 05:56, Shubham Khanna wrote: > > Currently, pg_createsubscriber is designed to convert an existing > > physical replica into a logical subscriber. To use it, the user must > > manually set up a standby node beforehand, ensure t

Re: Partitioned tables and [un]loggedness

On Wed, Jun 4, 2025 at 6:55 PM Shinya Kato wrote: > > On Wed, Jun 4, 2025 at 6:42 PM Michael Paquier wrote: > > > > On Thu, Sep 19, 2024 at 01:08:33PM +0900, Michael Paquier wrote: > > > I have applied 0001 for now to add ATT_PARTITIONED_TABLE. Attached is > > > the remaining piece. > > > > And

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

On Wed, Jun 4, 2025 at 6:41 AM Masahiko Sawada wrote: > > On Tue, May 20, 2025 at 9:54 PM Amit Kapila wrote: > > > > Yeah, I find the idea that the presence of a logical slot will allow > > the user to enable logical decoding/replication more appealing than > > this new alternative, leaving aside

Re: Enable data checksums by default

On 23.05.25 11:43, Tomas Vondra wrote: We don't currently have anything in the release notes that calls this out as a potential upgrading issue, so I propose the attached patch. Seems reasonable, although maybe it should say ... so if the old cluster does not have checksums enabled ... ins

Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding

On Tue, Jun 3, 2025 at 4:25 PM Ajin Cherian wrote: > > On Tue, Jun 3, 2025 at 3:55 PM Amit Kapila wrote: > > > > > > You haven't shared the exact test scenario, but I am assuming the > > above tests are for very large transactions, as you are comparing > > streaming and non-streaming modes. Can w

Re: Enhance pg_createsubscriber to create required standby.

On 04.06.25 05:56, Shubham Khanna wrote: Currently, pg_createsubscriber is designed to convert an existing physical replica into a logical subscriber. To use it, the user must manually set up a standby node beforehand, ensure that physical replication is active, and only then run pg_createsubscri

Re: Conflict detection for update_deleted in logical replication

On Mon, Jun 2, 2025 at 12:09 PM Amit Kapila wrote: > > On Mon, May 26, 2025 at 12:46 PM Zhijie Hou (Fujitsu) > wrote: > > > > Attaching the V32 patch set which addressed comments in [1]~[5]. > > > > Review comments: > === > * > +advance_conflict_slot_xmin(FullTransactionId new_xmin) >

synchronized_standby_slots used in logical replication

Hi, I'm working with *logical replication* in a PostgreSQL 17 setup, and I'm exploring the new synchronized_standby_slots parameter to make replication slots failover safe in a highly available environment using physical standby nodes managed by Patroni. While testing this feature, I encountered

Re: pull-up subquery if JOIN-ON contains refs to upper-query

Hi, all! I updated the patch and it looks nice. All the problems have been solved. On 03.04.2025 16:56, Ilia Evdokimov wrote: On 02.04.2025 19:39, Alena Rybakina wrote: I see that I need to add a walker that, when traversing the tree, determines whether there are conditions under which pull

Re: Restrict publishing of partitioned table with a foreign table as partition

On Tue, May 20, 2025 at 2:33 AM Shlok Kyal wrote: > > This approach seems better to me. I have created a patch with the > above approach. > > Thanks and Regards, > Shlok Kyal Some quick comments on the patch: 1. In doc/src/sgml/ref/create_subscription.sgml: +has partitioned table with foreign

Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

On Wed, Jun 4, 2025 at 4:53 AM Dmitry Koval wrote: > Added some changes to documentation. > Patches are attached to the email. > hi. I haven't touched v39-0002 yet. The following are reviews of v39-0001. +CREATE INDEX sales_range_sales_date_idx ON sales_range USING btree (sales_date); +INSERT IN

Re: Custom Glibc collation version strings under LOCPATH

On Wed, Jun 4, 2025 at 9:17 PM Peter Eisentraut wrote: > I wonder why you want to capture LOCPATH early in main.c. It seems > sufficient to look it up when needed? Right, it is setenv() that we're trying to avoid. Updated. From 5482ccf5a61061411f9a996da84f14471b791d83 Mon Sep 17 00:00:00 2001 F

Re: Suggestions for improving \conninfo output in v18

On 2025/06/03 20:22, Robert Treat wrote: +1 on the idea to put it there; if someone gets confused about the behavior, that seems like the place they'd go to look it up. Though I would wordsmith the patch a little: + Note that the Client User field shows the user at the time +

Re: strange perf regression with data checksums

Hi, We had a RMT meeting yesterday, and we briefly discussed whether the v2 patch should go into PG18. And we concluded we probably should try to do that. On the one hand, it's not a PG18-specific bug, in the sense that older releases are affected the same way. But it requires data checksums to b

Re: Add log_autovacuum_{vacuum|analyze}_min_duration

Thank you all for the comments! On Wed, Jun 4, 2025 at 10:30 AM wenhui qiu wrote: > > HI > I vote log_autovacuum_{vacuum|analyze}_min_duration. Then don't remove > log_autovacuum_min_duration so easily! > > On Wed, Jun 4, 2025 at 7:16 AM Fujii Masao > wrote: >> >> >> >> On 2025/06/04 4:32, Sam

Some questions about gin index

Hi, When reading the code for Gin Index, there are lots of confusion about some concepts, so here are some questions in my mind. 1. search mode. /* * searchMode settings for extractQueryFn. */ #define GIN_SEARCH_MODE_DEFAULT 0 #define GIN_SEARCH_MODE_INCLUDE_EMPTY 1 #defin

Re: postgres_fdw could deparse ArrayCoerceExpr

Hi Maxim, On Wed, Jan 29, 2025 at 11:59 AM Maxim Orlov wrote: > > One important note here. This patch will change cast behaviour in case of > local and foreign types are mismatched. > The problem is if we cannot convert types locally, this does not mean that it > is also true for a foreign wrap

Re: Proposal: Limitations of palloc inside checkpointer

Hi, Thanks for the feedback! > I think it would be good start point to use the same batch size of > CompactCheckpointerRequestQueue() and AbsorbSyncRequests() > So we’ll keep both batch processing and the request cap in place for now. > > > Right, but another point is to avoid lengthy holding o

RE: Suggestion to add --continue-client-on-abort option to pgbench

Dear Ikeda-san, Thanks for starting the new thread! I have never known the issue before I heard at PGConf.dev. Few comments: 1. This parameter seems a type of benchmark option. So should we set benchmarking_option_set as well? 2. Not sure, but exit-on-abort seems a similar option. What if both

Re: MergeAppend could consider sorting cheapest child path

On 4/6/2025 00:41, Alexander Korotkov wrote: On Tue, Jun 3, 2025 at 5:35 PM Andrei Lepikhov wrote: On 3/6/2025 16:05, Alexander Korotkov wrote: On Tue, Jun 3, 2025 at 4:53 PM Andrei Lepikhov wrote: Additionally, as I mentioned earlier, the primary reason for choosing MergeAppend in the regre

Request to Expedite Account Activation Cool-Off Period

Hi, all I created a new PostgreSQL.org account today, as changing usernames is not possible. Could an administrator please assist in expediting my account activation. Thanks! Best regards, Xuneng new username: alterego

Re: ABI Compliance Checker GSoC Project

On Tue, 3 Jun 2025 at 23:50, David E. Wheeler wrote: > >> Ummm, are you saying that it complains about changes to unexported > >> symbols also? > > This is a good question. No, it doesn’t complain about unexported symbols. But it does complain about some exported symbols that, in my understanding,

Re: Speedup truncations of temporary relation forks

On 2025/06/02 18:06, Yura Sokolov wrote: 31.05.2025 17:23, Daniil Davydov пишет: Hi, On Sat, May 31, 2025 at 7:41 PM Fujii Masao wrote: Here are a few review comments on the patch: + for (j = 0; j < nforks; j++) { - InvalidateLocalBuff

Re: doc pg_constraint.convalidated column description need update

On 03.05.25 17:42, Robert Treat wrote: I actually think this mix of VALID / ENFORCED is a little convoluted for end users, but I don't think the system catalog documentation is the best place to work that out, and I see we've also not added this type of extra information to other columns in the t

Re: ABI Compliance Checker GSoC Project

On 2025-Jun-04, Mankirat Singh wrote: > On Tue, 3 Jun 2025 at 23:50, David E. Wheeler wrote: > > >> Ummm, are you saying that it complains about changes to unexported > > >> symbols also? > > > > This is a good question. > No, it doesn’t complain about unexported symbols. You mentioned ReadStrea

Re: [PATCH] Hex-coding optimizations using SVE on ARM.

I have marked the commitfest entry for this [0] as waiting-on-author because the patch needs to be rebased. [0] https://commitfest.postgresql.org/patch/5538/ -- nathan

Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

Hello Peter, I've tried running VCI, the idea looks great to me. Thank you and Iwata-san for working on this feature. Looked at the source code of VCI module, the patch is huge but here are some ideas I hope could be useful for community. Made some patches on top of v4 that can be squashed into fu

Re: Please update your contact list: It must be pgsql-hackers@lists.postgresql.org

RECALL: A lot of e-mail on bad ML addresses yet. Dear all users of the pgsql-hackers @ lists.postgresql.org mailing list, A lot of people always send e-mails to the bad mailing list address. Can you ONLY send to pgsql-hackers @ lists.postgresql.org? It is same for other lists from lists.postgres

Re: Custom Glibc collation version strings under LOCPATH

On 6/4/25 00:03, Thomas Munro wrote: One way to move to a newer glibc-based Linux distribution but keep the locales working the same* without keeping the associated zombie C code alive is to find the source system's collation definition source files, compile them with the localedef on the target

Cluster.pm psql() undefined $$stderr

Greetings, everyone! If you call node->psql in not-array context, with on_error_die => 1, but without passing stderr, you will get the following error and the test will die, but not the way we expect: Use of uninitialized value in concatenation (.) or string at /path/to/source_co

Re: strange perf regression with data checksums

On Wed, Jun 4, 2025 at 7:33 AM Tomas Vondra wrote: > So better to get this in now, otherwise we may have to wait until PG19, > because of ABI (the patch adds a field into BTScanPosData, but maybe > it'd be possible to add it into padding, not sure). I agree. I can get this into shape for commit t

Add tab-completion for ALTER TABLE ADD NOT NULL

Hi, psql already supports tab-completion for ALTER TABLE ADD with constraints like CHECK and UNIQUE. However, after commit 14e87ffa5c5 introduced support for adding NOT NULL constraints using ALTER TABLE ADD, tab-completion for that case was missing. The attached patch adds tab-completion suppor

Re: Add tab-completion for ALTER TABLE ADD NOT NULL

On 2025-Jun-04, Fujii Masao wrote: > Hi, > > psql already supports tab-completion for ALTER TABLE ADD with constraints > like CHECK and UNIQUE. However, after commit 14e87ffa5c5 introduced > support for adding NOT NULL constraints using ALTER TABLE ADD, > tab-completion for that case was missing.

Re: Speedup truncations of temporary relation forks

On Wed, 4 Jun 2025 at 16:18, Fujii Masao wrote: > > Regardless, I think we should go ahead and apply the current patch. > Yeah, it is definitely improving things. It turns out that I made almost the same patch for our fork of Postgres, commissioned by one of the clients dealing with truncation o

Re: ABI Compliance Checker GSoC Project

On Jun 4, 2025, at 09:43, Álvaro Herrera wrote: > You mentioned ReadStream, but that's not exported. I this not an export at line 67? ``` ❯ rg ReadStream src/include/storage/read_stream.h 50: * the ReadStreamBlockNumberCB callback to abide by the restrictions of AIO 66:struct ReadStream; 67:ty

Re: postgres_fdw could deparse ArrayCoerceExpr

Hi. Alexander Korotkov писал(а) 2025-06-04 14:29: On Wed, Jan 29, 2025 at 11:59 AM Maxim Orlov wrote: One important note here. This patch will change cast behaviour in case of local and foreign types are mismatched. The problem is if we cannot convert types locally, this does not mean that

Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

On Jun 3, 2025, at 15:10, David E. Wheeler wrote: >> https://github.com/theory/postgres/pull/12 > > Found a little more unnecessary code to remove. Updated patches attached. And these should fix the CI failure. I also ran pgindent. Best, David v8-0001-Rename-jsonpath-method-arg-tokens.patc

Re: [19] Proposal: function markers to indicate collation/ctype sensitivity

Hi Jeff, On Jun 3, 2025, at 23:22, Jeff Davis wrote: > If we didn't have separate markers, we'd need to assume that all of > those objects could be affected by a provider update. I understand the need to trace these dependencies, but as a function developer with relatively modest understanding

Re: Add tab-completion for ALTER TABLE ADD NOT NULL

On 2025/06/04 23:38, Álvaro Herrera wrote: On 2025-Jun-04, Fujii Masao wrote: Hi, psql already supports tab-completion for ALTER TABLE ADD with constraints like CHECK and UNIQUE. However, after commit 14e87ffa5c5 introduced support for adding NOT NULL constraints using ALTER TABLE ADD, tab-

Re: Custom Glibc collation version strings under LOCPATH

On 6/4/25 09:52, Joe Conway wrote: On 6/4/25 00:03, Thomas Munro wrote: One way to move to a newer glibc-based Linux distribution but keep the locales working the same* without keeping the associated zombie C code alive is to find the source system's collation definition source files, compile th

Re: ABI Compliance Checker GSoC Project

On Wed, 4 Jun 2025 at 19:13, Álvaro Herrera wrote: > > On Tue, 3 Jun 2025 at 23:50, David E. Wheeler wrote: > > > What’s the error? Maybe we can fix it. > > > > As per my knowledge Postgres internal code lacks visibility annotations on > > its symbols, which causes compilation errors when fvisibi

Re: [19] Proposal: function markers to indicate collation/ctype sensitivity

On Wed, Jun 4, 2025 at 8:34 AM David E. Wheeler wrote: > On Jun 3, 2025, at 23:22, Jeff Davis wrote: > > > If we didn't have separate markers, we'd need to assume that all of > > those objects could be affected by a provider update. > > I understand the need to trace these dependencies, but as a

Re: [19] Proposal: function markers to indicate collation/ctype sensitivity

On Wed, 2025-06-04 at 11:33 -0400, David E. Wheeler wrote: > I understand the need to trace these dependencies, but as a function > developer with relatively modest understanding of collation nuances, > I’m wondering how I’d know I needed these markers. It seems > complicated. Which leads me to thi

Re: ABI Compliance Checker GSoC Project

Hi, On 2025-06-04 11:15:10 -0400, David E. Wheeler wrote: > On Jun 4, 2025, at 09:43, Álvaro Herrera wrote: > > > You mentioned ReadStream, but that's not exported. > > I this not an export at line 67? > > ``` > ❯ rg ReadStream src/include/storage/read_stream.h > > 50: * the ReadStreamBlockNu

Re: Partitioned tables and [un]loggedness

On Wed, Jun 04, 2025 at 07:05:20PM +0900, Shinya Kato wrote: > On Wed, Jun 4, 2025 at 6:55 PM Shinya Kato wrote: >> Should we consider preventing tab completion for PARTITION BY >> immediately after CREATE TABLE name (...)? Or is it fine to leave it >> as is, given that it's syntactically correct?

Re: like pg_shmem_allocations, but fine-grained for DSM registry ?

On Wed, Jun 04, 2025 at 11:17:42AM +0300, Florents Tselai wrote: > Thanks; let's wait a bit to see if there're any objections. Would you mind combining the patches into just one patch? That's how I reviewed it, and that's how it would be committed. -- nathan

Re: fix notes about password encryption in pg_authid docs

On Wed, Jun 04, 2025 at 02:11:55PM +0900, Michael Paquier wrote: > Looks fine to me. Committed, thanks. -- nathan

Re: Improve explicit cursor handling in pg_stat_statements

> Hmm. I was not sure if we'd really need to get down to that, as most > of the grammar keywords have the same parsed meaning, but there's a > good point with LAST for example that uses a negative value for > howMany. If we silence the number, LAST would map with everything > else that has FETCH_

Re: strange perf regression with data checksums

On Wed, Jun 4, 2025 at 10:21 AM Peter Geoghegan wrote: > On Wed, Jun 4, 2025 at 7:33 AM Tomas Vondra wrote: > > So better to get this in now, otherwise we may have to wait until PG19, > > because of ABI (the patch adds a field into BTScanPosData, but maybe > > it'd be possible to add it into padd

Re: Fix slot synchronization with two_phase decoding enabled

On Sun, Jun 1, 2025 at 10:25 PM Amit Kapila wrote: > > > Yet another idea is to dump the subscription with two_phase = on and > failover = false. We should do this when both options are 'true' > during the dump. As we are documenting that we always dump > createsubscription with connect as false

Re: Allow CI to only run the compiler warnings task

On Wed, May 21, 2025 at 10:32 AM Rustam ALLAKOV wrote: > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: tested, failed > Documentation:tested, failed > >

Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

On 6/4/25 19:59, Jim Nasby wrote: > > > On Fri, May 23, 2025 at 4:29 PM Tomas Vondra > wrote: > > Also, Alvaro seemed to think TAM is the way to go, and in order to keep > the OLTP performance he suggested to use both heap and VCI at the same > time, in diffe

Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

On Fri, May 23, 2025 at 4:29 PM Tomas Vondra wrote: > Also, Alvaro seemed to think TAM is the way to go, and in order to keep > the OLTP performance he suggested to use both heap and VCI at the same > time, in different "forks". I'm not sure how would that work, or if we > can already do that - A

Re: like pg_shmem_allocations, but fine-grained for DSM registry ?

> On 4 Jun 2025, at 7:19 PM, Nathan Bossart wrote: > > On Wed, Jun 04, 2025 at 11:17:42AM +0300, Florents Tselai wrote: >> Thanks; let's wait a bit to see if there're any objections. > > Would you mind combining the patches into just one patch? That's how I > reviewed it, and that's how it wo

Re: pgsql: postgres_fdw: Inherit the local transaction's access/deferrable

On Tue, Jun 3, 2025 at 6:45 AM Etsuro Fujita wrote: > No, this is a fix, not a feature, as discussed in the thread; as > mentioned in the commit message, the previous version of postgres_fdw > could cause surprising behaviors that would never happen in normal > cases where a read-only and/or defer

Re: Add --system-identifier / -s option to pg_resetwal

Thank you, Peter and Michael, for the reviews Attached is v2, simplified as suggested: - Removed short option -s - Removed interactive confirmation and --force - Simplified tests leaving only essential ones Additionally, there was an off-list review done by Andrey Borodin, so his comments also ad

Re: Add log_autovacuum_{vacuum|analyze}_min_duration

> Approach 2: > - log_autovacuum_min_duration: Changed behavior, which controls only > autovacuum logging. > - log_autoanalyze_min_duration: New parameter, which controls > autoanalyze logging. My vote is for this approach. It is probably OK to change the behavior of log_autovacuum_min_duration, a

Re: gcc 15 "array subscript 0" warning at level -O3

Hi, On 2025-04-25 15:58:29 -0400, Andres Freund wrote: > On 2025-04-25 13:37:15 -0400, Tom Lane wrote: > > Buildfarm member serinus has been producing the identical warning for > > some time. I'd been ignoring that because it runs "experimental gcc", > > but I guess the experiment has leaked out

Question Regarding Merge Append and Parallel Execution of Index Scans on Partitioned Table

Hello Hackers, I had a question regarding the execution of the following query plan on a partitioned table with vector similarity search: QUERY PLAN --

a couple of small cleanup patches for DSM-related code

0001 changes test_dsm_registry.c to use PG_GETARG_INT32 and PG_RETURN_INT32. The installation script and the C code both used signed integers, so I'm not sure why I used PG_GETARG/RETURN_UINT32 in commit 8b2bcf3. I'm planning to back-patch this one to v17, where the DSM registry was first introdu

Re: ABI Compliance Checker GSoC Project

On Jun 4, 2025, at 12:10, Andres Freund wrote: > No. It just makes the *name* of the struct visible. The type's definition is > in the .c file and therefore not visible outside of read_stream.c. Right, got it, thanks. David signature.asc Description: Message signed with OpenPGP

Re: Non-reproducible AIO failure

Hi, Thanks for working on investigating this. On 2025-06-03 08:00:01 +0300, Alexander Lakhin wrote: > 02.06.2025 09:00, Alexander Lakhin wrote: > > With additional logging (the patch is attached), I can see the following: > > ... > > !!!pgaio_io_reclaim [63817]| ioh: 0x1046b5660, ioh->op: 1, ioh

Re: pg_upgrade: warn about roles with md5 passwords

On 02.06.25 17:32, Nathan Bossart wrote: Since MD5 passwords are slated to be marked as deprecated in v18, I figured it might be a good idea to add a check for roles with MD5 passwords to pg_upgrade. I'm tempted to suggest that we apply this to v18, but I'm content to leave it for v19 if nobody

Re: Enhance pg_createsubscriber to create required standby.

On 04.06.25 11:56, Amit Kapila wrote: It's not clear to me how this change now would substantially improve the user experience. The number of characters you type is approximately the same. You still need to support the old mode because the backup might not come from pg_basebackup. In the curr

Re: Add --system-identifier / -s option to pg_resetwal

On 04.06.25 20:46, Nikolay Samokhvalov wrote: - Simplified logic, getting rid of '-' check (negative numbers) -- decided to accept negative input values (they wrap to valid positive uint64) That doesn't seem like a good idea to me.

Re: Non-reproducible AIO failure

On Thu, Jun 5, 2025 at 8:02 AM Andres Freund wrote: > On 2025-06-03 08:00:01 +0300, Alexander Lakhin wrote: > > 2025-06-03 00:19:09.282 EDT [25175:1] LOG: !!!pgaio_io_before_start| ioh: > > 0x104c3e1a0, ioh->op: 1, ioh->state: 1, ioh->result: 0, ioh->num_callbacks: > > 2, ioh->generation: 21694 >

Re: PG 18 release notes draft committed

On Tue, Jun 3, 2025 at 10:21:23AM -0700, Noah Misch wrote: > On Thu, May 01, 2025 at 10:44:50PM -0400, Bruce Momjian wrote: > > I have committd the first draft of the PG 18 release notes. > > When a commit changes the user that runs a function in existing queries, I > think that almost always nee

Re: pg_upgrade: warn about roles with md5 passwords

On Wed, Jun 4, 2025 at 10:15:49PM +0200, Peter Eisentraut wrote: > On 02.06.25 17:32, Nathan Bossart wrote: > > Since MD5 passwords are slated to be marked as deprecated in v18, I figured > > it might be a good idea to add a check for roles with MD5 passwords to > > pg_upgrade. I'm tempted to sug

Re: doc pg_constraint.convalidated column description need update

On Wed, Jun 4, 2025 at 9:37 AM Peter Eisentraut wrote: > On 03.05.25 17:42, Robert Treat wrote: > > I actually think this mix of VALID / ENFORCED is a little convoluted > > for end users, but I don't think the system catalog documentation is > > the best place to work that out, and I see we've als

Re: postgres_fdw could deparse ArrayCoerceExpr

On Wed, Jun 4, 2025 at 6:15 PM Alexander Pyhalov wrote: > Alexander Korotkov писал(а) 2025-06-04 14:29: > > On Wed, Jan 29, 2025 at 11:59 AM Maxim Orlov wrote: > >> > >> One important note here. This patch will change cast behaviour in case > >> of local and foreign types are mismatched. > >> The

Re: a couple of small cleanup patches for DSM-related code

On Wed, Jun 4, 2025 at 12:48 PM Nathan Bossart wrote: > > 0001 changes test_dsm_registry.c to use PG_GETARG_INT32 and > PG_RETURN_INT32. The installation script and the C code both used signed > integers, so I'm not sure why I used PG_GETARG/RETURN_UINT32 in commit > 8b2bcf3. I'm planning to bac

Re: pg_upgrade: warn about roles with md5 passwords

On Wed, Jun 04, 2025 at 04:46:52PM -0400, Bruce Momjian wrote: > On Wed, Jun 4, 2025 at 10:15:49PM +0200, Peter Eisentraut wrote: >> I tend think pg_upgrade should stick to checking things that are necessary >> for the upgrade to succeed. It shouldn't start being an interactive portal >> to the r

Re: pg_upgrade: warn about roles with md5 passwords

> On 4 Jun 2025, at 22:15, Peter Eisentraut wrote: > I tend think pg_upgrade should stick to checking things that are necessary > for the upgrade to succeed. It shouldn't start being an interactive portal > to the release notes for aspects that are merely recommendations. Agreed, I was going

Re: PG 18 release notes draft committed

On Wed, Jun 4, 2025 at 1:45 PM Bruce Momjian wrote: > Now, if we do want to mention it, it should be done in a way that makes > it clear to readers whether they are affected by this change. We can > try text like: > > Execute non-SECURITY-DEFINER AFTER triggers as the role that was >

Re: pg_get_multixact_members not documented

v2 addresses the comments. Adds a new section called "Multixact Information Functions" and a reference to pg_get_multixact_members after the description of what multixact members are in maintenance.sgml. As I spent some time looking into this, I still think we should document this function becaus

Re: PG 18 release notes draft committed

On Wed, Jun 04, 2025 at 04:45:18PM -0400, Bruce Momjian wrote: > On Tue, Jun 3, 2025 at 10:21:23AM -0700, Noah Misch wrote: > > When a commit changes the user that runs a function in existing queries, I > > think that almost always needs a release notes entry. It would follow that > > commit 0146

Re: Incremental Sort Cost Estimation Instability

On Tue, Jun 3, 2025 at 5:02 PM Alexander Korotkov wrote: > On Wed, May 14, 2025 at 1:50 PM Andrei Lepikhov wrote: > > On 9/12/24 16:57, Tomas Vondra wrote: > > > On 9/12/24 12:12, David Rowley wrote: > > >> On Thu, 12 Sept 2024 at 21:51, Andrei Lepikhov wrote: > > >>> Initial problem causes wron

add function for creating/attaching hash table in DSM registry

Libraries commonly use shared memory to store hash tables. While it's possible to set up a dshash table using the DSM registry today, doing so is complicated; you need to set up two LWLock tranches, a DSA, and finally the dshash table. The attached patch adds a new function called GetNamedDSMHash

Re: like pg_shmem_allocations, but fine-grained for DSM registry ?

On Wed, Jun 04, 2025 at 09:03:03PM +0300, Florents Tselai wrote: > On 4 Jun 2025, at 7:19 PM, Nathan Bossart wrote: >> Would you mind combining the patches into just one patch? That's how I >> reviewed it, and that's how it would be committed. > > This works ? Yes, thanks. -- nathan

Re: PG 18 release notes draft committed

On Wed, Jun 4, 2025 at 02:02:38PM -0700, David G. Johnston wrote: > On Wed, Jun 4, 2025 at 1:45 PM Bruce Momjian wrote: > > Now, if we do want to mention it, it should be done in a way that makes > it clear to readers whether they are affected by this change.  We can > try text like:

Re: PG 18 release notes draft committed

On Wed, Jun 4, 2025 at 02:29:46PM -0700, Noah Misch wrote: > I agree with David G. Johnston's feedback on this. My draft didn't mention > SECURITY DEFINER, because I consider it redundant from a user's perspective. > If a function is SECURITY DEFINER, that always overrides other sources of user >

Re: PG 18 release notes draft committed

Bruce Momjian writes: > I think we have to keep the non-SECURITY-DEFINER designation to keep the > text accurate, but you are right it is part of the function, not the > trigger: > Execute deferred constraint triggers attached to > non-SECURITY-DEFINER functions as the role that was a

Re: PG 18 release notes draft committed

On Wed, Jun 04, 2025 at 06:10:38PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I think we have to keep the non-SECURITY-DEFINER designation to keep the > > text accurate, I don't see it that way, because there's currently no experiment the user can perform to distinguish between the follow

Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

On Wed, Jun 4, 2025 at 1:16 PM Tomas Vondra wrote: > On 6/4/25 19:59, Jim Nasby wrote: > > > > > > On Fri, May 23, 2025 at 4:29 PM Tomas Vondra > > wrote: > > > > Also, Alvaro seemed to think TAM is the way to go, and in order to > keep > > the OLTP performance he

Re: PG 18 release notes draft committed

On Wed, Jun 4, 2025 at 3:17 PM Noah Misch wrote: > On Wed, Jun 04, 2025 at 06:10:38PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > but you are right it is part of the function, not the > > > trigger: > > > > > Execute deferred constraint triggers attached to > > > non-SECURITY-

Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring

The new overhead for creating connections when io_method=io_uring is also a function of max_connections. I have been using the default (=100). But when I increase it to =1000 then the time to create a connection almost triples. That isn't a big surprise given the usage of TotalProcs here: https://g

Re: PG 18 release notes draft committed

"David G. Johnston" writes: > Is this covering the case of executing at the end of an outer SQL command > (thus not deferred) that contains volatile DML functions that temporarily > change current_user within the function? Not quite. I think that a non-deferred AFTER trigger would ordinarily run

Re: PG 18 release notes draft committed

On Wed, Jun 4, 2025 at 06:37:57PM -0400, Tom Lane wrote: > "David G. Johnston" writes: > > Is this covering the case of executing at the end of an outer SQL command > > (thus not deferred) that contains volatile DML functions that temporarily > > change current_user within the function? > > Not

Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

On Wed, Jun 4, 2025 at 5:19 PM Jim Nasby wrote: > What I can imagine is "VCI" as a "proxy" TAM on top of heap, keeping the >> columnar format in a separate fork. And using either that from custom >> scans, or the heap as a fallback for cases not supported by VCI. >> > > Yeah, there'd definitely n

Re: Custom Glibc collation version strings under LOCPATH

On Thu, Jun 5, 2025 at 3:44 AM Joe Conway wrote: > On 6/4/25 09:52, Joe Conway wrote: > > On 6/4/25 00:03, Thomas Munro wrote: > >> I'm interested in hearing about other concrete > >> examples of the locale-recompilation technique failing to be perfect, > >> and getting to the bottom of them; I ha

  1   2   >