Re: Fix slot synchronization with two_phase decoding enabled

2025-05-04 Thread Masahiko Sawada
On Sat, May 3, 2025 at 10:23 AM Tom Lane wrote: > > BF member mule just showed what seems an identical failure [1]: > > 2025-05-03 17:46:20.088 CEST [24308:3] LOG: database system is ready to > accept read-only connections > 2025-05-03 17:46:20.091 CEST [24321:1] LOG: slot sync worker started >

Re: PG 18 release notes draft committed

2025-05-04 Thread Jelte Fennema-Nio
On Sun, 4 May 2025 at 03:21, Bruce Momjian wrote: > So the logic is something I posted to this thread already: > > So, a few things. First, these set of commits was in a group of 10 > that > I added since there have been complaints in the past that optimizer > improvement

Re: PG 18 release notes draft committed

2025-05-04 Thread Jelte Fennema-Nio
On Fri, 2 May 2025 at 04:45, Bruce Momjian wrote: > I have committd the first draft of the PG 18 release notes. Some suggestions for additional commits to list for the items in the changelog: 1. I think 5070349102af12832c8528651c8ed18b16346323 should be listed as a commit for "Add libpq connectio

Re: queryId constant squashing does not support prepared statements

2025-05-04 Thread Dmitry Dolgov
> On Thu, May 01, 2025 at 09:55:47PM GMT, Dmitry Dolgov wrote: > > On Thu, May 01, 2025 at 09:29:13AM GMT, Michael Paquier wrote: > > > > I agree that the current solution we have in the tree feels incomplete > > because we are not taking into account the most common cases that > > users would care

PATCH: pg_dump to support "on conflict do update"

2025-05-04 Thread Tanin Na Nakorn
Hi hackers, Here's the patch (against the latest master) that will make pg_dump support "on conflict do update" . I've used this patch on v16 for our company's CI (on Github Actions), and it works perfectly fine. Users would be able to use it like this: ./src/bin/pg_dump/pg_dump $DATABASE_URL \

Re: PG 18 release notes draft committed

2025-05-04 Thread Álvaro Herrera
Regarding these items * Allow ALTER TABLE to set the NOT VALID attribute of NOT NULL constraints (Rushabh Lathia, Jian He) * Allow NOT VALID foreign key constraints on partitioned tables (Amul Sul) * Allow modification of the inheritability of constraints (Suraj Kharage, Álvaro Herrera) Th

Re: Options to control remote transactions’ access/deferrable modes in postgres_fdw

2025-05-04 Thread Etsuro Fujita
On Sun, Mar 30, 2025 at 7:14 PM Etsuro Fujita wrote: > On Thu, Mar 27, 2025 at 1:25 PM Ashutosh Bapat > wrote: > > On Tue, Mar 25, 2025 at 4:01 PM Etsuro Fujita > > wrote: > > > In the patch I also fixed a bug; I trusted XactReadOnly to see if the > > > local transaction is READ ONLY, but I not

Re: PG 18 release notes draft committed

2025-05-04 Thread Jelte Fennema-Nio
On Sun, 4 May 2025 at 22:28, Alexander Borisov wrote: > I'm actually a bit confused, and didn't expect such a heated discussion > about creating an entry about my patch in Release Notes. I definitely understand this. And to make my own opinion on this matter extremely clear: I *do* think it's imp

Re: PG 18 release notes draft committed

2025-05-04 Thread Bruce Momjian
On Sun, May 4, 2025 at 11:49:47AM +0200, Jelte Fennema-Nio wrote: > On Fri, 2 May 2025 at 04:45, Bruce Momjian wrote: > > I have committd the first draft of the PG 18 release notes. > > Some suggestions for additional commits to list for the items in the > changelog: > 1. I think 5070349102af12

Re: PG 18 release notes draft committed

2025-05-04 Thread Bruce Momjian
On Sun, May 4, 2025 at 01:35:30PM +0200, Álvaro Herrera wrote: > Regarding these items > > * Allow ALTER TABLE to set the NOT VALID attribute of NOT NULL constraints > (Rushabh Lathia, Jian He) > > * Allow NOT VALID foreign key constraints on partitioned tables (Amul Sul) > > * Allow modifica

Re: PG 18 release notes draft committed

2025-05-04 Thread Atsushi Torikoshi
Hi, On Fri, May 2, 2025 at 11:44 AM Bruce Momjian wrote: > > I have committd the first draft of the PG 18 release notes. The item > count looks strong: > > release-7.4: 263 > release-8.0: 230 > release-8.1: 174 > release-8.2: 215 > release-8.3: 214 >

Re: Add an option to skip loading missing publication to avoid logical replication failure

2025-05-04 Thread vignesh C
On Fri, 2 May 2025 at 09:23, vignesh C wrote: > > On Fri, 2 May 2025 at 06:30, Tom Lane wrote: > > > > vignesh C writes: > > > I agree with your analysis. I was able to reproduce the issue by > > > delaying the invalidation of the subscription until the walsender > > > finished decoding the INSE

Re: PG 18 release notes draft committed

2025-05-04 Thread Jonathan S. Katz
On 5/3/25 7:48 PM, Alexander Borisov wrote: 04.05.2025 02:28, Bruce Momjian wrote: It doesn't warrant its own item because it is not user-facing work.  The best we can do is add the commit to an existing item and add you as a co-author on an existing item.  You will see several items that a

Re: ZStandard (with dictionaries) compression support for TOAST compression

2025-05-04 Thread Nikhil Kumar Veldanda
Hi Robert > But I don't quite understand the point of this > response: it seems like you're just restating what the design does > without really justifying it. The question here isn't whether a 3-byte > header can describe a length up to 16MB; I think we all know our > powers of two well enough to

Re: Prevent an error on attaching/creating a DSM/DSA from an interrupt handler.

2025-05-04 Thread Mihail Nikalayeu
Hello, everyone. Not sure if it helps but encountered the same problem in relation to injection points: https://www.postgresql.org/message-id/flat/CANtu0oiTgFW47QgpTwrMOVm3Bq4N0Y5bjvTy5sP0gYWLQuVgjw%40mail.gmail.com

Re: PG 18 release notes draft committed

2025-05-04 Thread Bruce Momjian
On Sun, May 4, 2025 at 10:41:30PM +0900, Atsushi Torikoshi wrote: > > I will continue improving it until beta 1, and until the final release. > > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) > > Thanks for your work! > > > Add REJECT_LIMIT to control the number of inval

Re: PG 18 release notes draft committed

2025-05-04 Thread Alexander Borisov
04.05.2025 12:19, Jelte Fennema-Nio wrote: On Sun, 4 May 2025 at 03:21, Bruce Momjian wrote: So the logic is something I posted to this thread already: So, a few things. First, these set of commits was in a group of 10 that I added since there have been complaints in the pa

[PATCH] Allow parallelism for plpgsql return expression after commit 556f7b7

2025-05-04 Thread DIPESH DHAMELIYA
Hello everyone, With the commit 556f7b7bc18d34ddec45392965c3b3038206bb62, Any plpgsql function that returns scalar value would not be able to use parallelism to evaluate a return statement. It will not be considered for parallel execution because we are passing maxtuples = 2 to exec_run_select fro

Re: pg_createsubscriber: Fix incorrect handling of cleanup flags

2025-05-04 Thread David G. Johnston
On Sun, May 4, 2025 at 8:45 PM Nisha Moond wrote: > Attached is the patch implementing the above proposed solution. > Reviews and feedback are most welcome. > I feel like this is just papering over the issue - which is that these two drop functions are being used for multiple differently named p

Re: Add an option to skip loading missing publication to avoid logical replication failure

2025-05-04 Thread Amit Kapila
On Fri, May 2, 2025 at 10:24 PM Tom Lane wrote: > > vignesh C writes: > > Due to the asynchronous nature of these processes, the ALTER > > SUBSCRIPTION command may not be immediately observed by the apply > > worker. Meanwhile, the walsender may process and decode an INSERT > > statement. > > If

Re: [PoC] Federated Authn/z with OAUTHBEARER

2025-05-04 Thread Wolfgang Walther
Jacob Champion: libintl is already coming in via frontend_stlib_code, so that's fine. So now I'm wondering if any other static clients of libpq-int.h (if there are any) need the ssl dependency too, for correctness, or if it's just me. Looks like it's just me. And using partial_dependency for th

pg_createsubscriber: Fix incorrect handling of cleanup flags

2025-05-04 Thread Nisha Moond
Hi Hackers, In pg_createsubscriber, the flags 'made_publication' and 'made_replslot' are used to track whether the tool itself created a publication or replication slot on the primary (publisher) node. If a failure happens during the process, these flags help the tool decide whether it should clea