On Sun, May 4, 2025 at 01:35:30PM +0200, Álvaro Herrera wrote: > Regarding these items > > * Allow ALTER TABLE to set the NOT VALID attribute of NOT NULL constraints > (Rushabh Lathia, Jian He) > > * Allow NOT VALID foreign key constraints on partitioned tables (Amul Sul) > > * Allow modification of the inheritability of constraints (Suraj Kharage, > Álvaro Herrera) > > The syntax is ALTER TABLE ... ALTER CONSTRAINT ... [NO] INHERIT. > > * Store column NOT NULL specifications in pg_constraint (Álvaro Herrera, > Bernd Helmle) > > This allows names to be specified for NOT NULL constraint. This also adds > NOT > NULL constraints to foreign tables and NOT NULL inheritance control to local > tables. > > > I think the wording and order of them is a bit unclear. I would put the > last item first, immediately followed by the other two; alternatively we > could merge them all into a single one:
I moved the last item to first in the group. > * Store NOT NULL constraints in pg_constraint for better preservability > (Álvaro, Bernd, Suraj, Rushabh, Jian) > > The constraint names are well defined and are preserved across > dump/restore. Also, the NOT VALID and NO INHERIT properties work > as expected and can be modified by users via ALTER TABLE. > > Or something along those lines. I think the merged text is too confusing. > This one in particular: > Allow modification of the inheritability of constraints (Suraj Kharage, > Álvaro Herrera) > > The syntax is ALTER TABLE ... ALTER CONSTRAINT ... [NO] INHERIT. > > only works with not-null constraints, which is why I suggest to merge > together with the above item. Ideally, on the next release somebody > would work to make that feature more general (work with other types of > constraints). Yes, I see that detail in the docs of the first commit, and in the second commit text. I modified to say NOT NULL. > > I think this item > Allow CHECK and foreign key constraints to be specified as NOT ENFORCED > (Amul Sul) > > This also adds column pg_constraint.conenforced. > > should come second or maybe even first in that section, as it is I think > the most user-visible. I made it second. > These two items > Allow NOT VALID foreign key constraints on partitioned tables (Amul Sul) > > Allow dropping of constraints ONLY on partitioned tables (Álvaro Herrera) > > This was previously erroneously prohibited. > > can mostly be considered bug-fixes, so they should be last in the > section; they aren't new features, just making existing features work > correctly. The one I have second is I think of lesser importance. Agreed, moved as you suggested. I have trouble figuring out the importance sometimes, and this section is very large. Patch attached. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml index bd2b2ed6315..764c929823f 100644 --- a/doc/src/sgml/release-18.sgml +++ b/doc/src/sgml/release-18.sgml @@ -1530,23 +1530,6 @@ This is specified by WITHOUT OVERLAPS on the last column. </para> </listitem> - -<!-- -Author: Peter Eisentraut <pe...@eisentraut.org> -2024-11-15 [9321d2fdf] Fix collation handling for foreign keys ---> - -<listitem> -<para> -Require primary/foreign key relationships to use either deterministic collations or the the same nondeterministic collations (Peter Eisentraut) -<ulink url="&commit_baseurl;9321d2fdf">§</ulink> -</para> - -<para> -The restore of a pg_dump, also used by pg_upgrade, will fail if these requirements are not met; schema changes must be made for these upgrade methods to succeed. -</para> -</listitem> - <!-- Author: Peter Eisentraut <pe...@eisentraut.org> 2025-01-11 [ca87c415e] Add support for NOT ENFORCED in CHECK constraints @@ -1567,42 +1550,46 @@ This also adds column pg_constraint.conenforced. </listitem> <!-- -Author: Álvaro Herrera <alvhe...@alvh.no-ip.org> -2025-04-07 [a379061a2] Allow NOT NULL constraints to be added as NOT VALID +Author: Peter Eisentraut <pe...@eisentraut.org> +2024-11-15 [9321d2fdf] Fix collation handling for foreign keys --> <listitem> <para> -Allow ALTER TABLE to set the NOT VALID attribute of NOT NULL constraints (Rushabh Lathia, Jian He) -<ulink url="&commit_baseurl;a379061a2">§</ulink> +Require primary/foreign key relationships to use either deterministic collations or the the same nondeterministic collations (Peter Eisentraut) +<ulink url="&commit_baseurl;9321d2fdf">§</ulink> +</para> + +<para> +The restore of a pg_dump, also used by pg_upgrade, will fail if these requirements are not met; schema changes must be made for these upgrade methods to succeed. </para> </listitem> <!-- Author: Álvaro Herrera <alvhe...@alvh.no-ip.org> -2025-01-23 [b663b9436] Allow NOT VALID foreign key constraints on partitioned t +2024-11-08 [14e87ffa5] Add pg_constraint rows for not-null constraints --> <listitem> <para> -Allow NOT VALID foreign key constraints on partitioned tables (Amul Sul) -<ulink url="&commit_baseurl;b663b9436">§</ulink> +Store column NOT NULL specifications in pg_constraint (Álvaro Herrera, Bernd Helmle) +<ulink url="&commit_baseurl;14e87ffa5">§</ulink> +</para> + +<para> +This allows names to be specified for NOT NULL constraint. This also adds NOT NULL constraints to foreign tables and NOT NULL inheritance control to local tables. </para> </listitem> <!-- Author: Álvaro Herrera <alvhe...@alvh.no-ip.org> -2024-09-30 [4dea33ce7] Don't disallow DROP of constraints ONLY on partitioned t +2025-04-07 [a379061a2] Allow NOT NULL constraints to be added as NOT VALID --> <listitem> <para> -Allow dropping of constraints ONLY on partitioned tables (Álvaro Herrera) -<ulink url="&commit_baseurl;4dea33ce7">§</ulink> -</para> - -<para> -This was previously erroneously prohibited. +Allow ALTER TABLE to set the NOT VALID attribute of NOT NULL constraints (Rushabh Lathia, Jian He) +<ulink url="&commit_baseurl;a379061a2">§</ulink> </para> </listitem> @@ -1615,7 +1602,7 @@ Author: Álvaro Herrera <alvhe...@alvh.no-ip.org> <listitem> <para> -Allow modification of the inheritability of constraints (Suraj Kharage, Álvaro Herrera) +Allow modification of the inheritability of NOT NULL constraints (Suraj Kharage, Álvaro Herrera) <ulink url="&commit_baseurl;f4e53e10b">§</ulink> <ulink url="&commit_baseurl;4a02af8b1">§</ulink> </para> @@ -1627,17 +1614,29 @@ The syntax is ALTER TABLE ... ALTER CONSTRAINT ... [NO] INHERIT. <!-- Author: Álvaro Herrera <alvhe...@alvh.no-ip.org> -2024-11-08 [14e87ffa5] Add pg_constraint rows for not-null constraints +2025-01-23 [b663b9436] Allow NOT VALID foreign key constraints on partitioned t --> <listitem> <para> -Store column NOT NULL specifications in pg_constraint (Álvaro Herrera, Bernd Helmle) -<ulink url="&commit_baseurl;14e87ffa5">§</ulink> +Allow NOT VALID foreign key constraints on partitioned tables (Amul Sul) +<ulink url="&commit_baseurl;b663b9436">§</ulink> </para> +</listitem> + +<!-- +Author: Álvaro Herrera <alvhe...@alvh.no-ip.org> +2024-09-30 [4dea33ce7] Don't disallow DROP of constraints ONLY on partitioned t +--> +<listitem> <para> -This allows names to be specified for NOT NULL constraint. This also adds NOT NULL constraints to foreign tables and NOT NULL inheritance control to local tables. +Allow dropping of constraints ONLY on partitioned tables (Álvaro Herrera) +<ulink url="&commit_baseurl;4dea33ce7">§</ulink> +</para> + +<para> +This was previously erroneously prohibited. </para> </listitem>
