Re: ecdh support causes unnecessary roundtrips

> On 4 Mar 2025, at 20:19, Daniel Gustafsson wrote: >> On 4 Mar 2025, at 20:13, Jacob Champion >> wrote: >> Just a reminder that, if we do want to change this for 18 onward, the >> window is closing. Adding x25519 to the default groups seems like a >> good idea to me, whether we can get somethi

Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

Hi, On 2025-03-04 17:51:17 +0900, Michael Paquier wrote: > On Mon, Mar 03, 2025 at 02:23:51PM +0900, Michael Paquier wrote: > > This has always been set last and it's still the case in the patch, so > > let's just remove that. > > This first one has been now applied as c76db55c9085. Attached is t

Re: scalability bottlenecks with (many) partitions (and more)

On 2025-03-04 Tu 6:04 PM, Tom Lane wrote: Andrew Dunstan writes: Will check your patch out too. Comparing previous run against current, I now see that my patch caused it to skip these steps: module-ldap_password_func-check module-pg_bsd_indent-check contrib-sepgsql-check Skipping the ldap an

Re: Make COPY format extendable: Extract COPY TO format implementations

Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Mon, 3 Mar 2025 11:06:39 -0800, Masahiko Sawada wrote: > I agree with the fix and the patch looks good to me. I've updated the > commit message and am going to push, barring any objections. Thanks! I've r

Re: scalability bottlenecks with (many) partitions (and more)

Andrew Dunstan writes: > On 2025-03-04 Tu 5:28 PM, Tom Lane wrote: >> ... I eventually concluded that there's >> something wrong with the "scalar glob()" idiom you used. > Well, in scalar context it should give us back the first item found, or > undef if nothing is found, AIUI. That's what I wo

Re: Next commitfest app release is planned for March 18th

On 3/5/25 12:14 AM, Jelte Fennema-Nio wrote: On Tue, 4 Mar 2025 at 22:01, Andreas Karlsson wrote: What I need to see is the below (plus any future commit fests). Thanks you for describing how you use the current homepage. That's super helpful. I am interested in the dates when commit fests

Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

On Tue, Mar 04, 2025 at 04:53:14PM -0800, Jacob Champion wrote: > I'll work on a fix, but it probably won't be fast since I need to > learn more about the injection points architecture. The test may need > to be disabled, or the patch backed out, depending on how painful the > flake is for everybod

Re: Add an option to skip loading missing publication to avoid logical replication failure

On Tue, Mar 4, 2025 at 12:23 PM vignesh C wrote: > > There is almost negligible dip with the above suggested way, the test > results for the same is given below(execution time is in milli > seconds): > Brach/records | 100 | 1000 | 1| 10 | 100 > Head | 10

Re: Doc fix of aggressive vacuum threshold for multixact members storage

Good points, thank you. I'm good with going ahead as you've suggested. Best regards, Alex Friedman

Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

On Tue, Mar 4, 2025 at 4:10 PM Andres Freund wrote: > This seems to trigger a bunch of CI failures, e.g.: > > https://cirrus-ci.com/task/5350341408980992 > https://cirrus-ci.com/task/5537391798124544 > https://cirrus-ci.com/task/4657439905153024 Hm. All Windows. > https://api.cirrus-ci.com/v1/ar

Re: [RFC] Lock-free XLog Reservation from WAL

On 2/23/2025 8:03 PM, Yura Sokolov wrote: 14.02.2025 11:41, Zhou, Zhiguo пишет: On 2/11/2025 9:25 AM, Japin Li wrote: On Mon, 10 Feb 2025 at 22:12, "Zhou, Zhiguo" wrote: On 2/5/2025 4:32 PM, Japin Li wrote: On Mon, 27 Jan 2025 at 17:30, "Zhou, Zhiguo" wrote: On 1/26/2025 10:59 PM, Yura

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

On Tue, Mar 4, 2025 at 4:44 PM Jakub Wartak wrote: > > On Tue, Mar 4, 2025 at 4:59 AM Amit Kapila wrote: > > > > > > > > > Sure thing. I've just added '(..) In the extreme cases this can..' as > > > > it is pretty rare to hit it. Patch attached. > > > > > > When the clock moves forward or backwar

Re: Separate GUC for replication origins

On Wed, Mar 5, 2025 at 6:24 AM Euler Taveira wrote: > > On Sat, Mar 1, 2025, at 10:08 AM, Amit Kapila wrote: > > On Thu, Feb 13, 2025 at 6:48 AM Masahiko Sawada wrote: > > > > Thank you for updating the patch! The patch looks mostly good to me. > > > > + /* > + * Prior to PostgreSQL 18, max_repli

Re: Considering fractional paths in Append node

On 5/3/2025 03:27, Alexander Korotkov wrote: On Mon, Mar 3, 2025 at 1:04 PM Andrei Lepikhov wrote: 2. As usage of root->tuple_fraction RelOptInfo it has been criticized, do you think we could limit this to some simple cases? For instance, check that RelOptInfo is the final result relation for

Re: Add contrib/pg_logicalsnapinspect

Hi, On Tue, Mar 04, 2025 at 10:25:57PM -0800, Masahiko Sawada wrote: > On Tue, Mar 4, 2025 at 1:56 PM Andres Freund wrote: > > > Thank you for the report. +1 > It seems that bgwriter wrote another RUNNING_XACTS record during the > test, making the logical decoding write an extra snapshot on the

Re: Draft for basic NUMA observability

Hi! On Thu, Feb 27, 2025 at 4:34 PM Bertrand Drouvot wrote: > I did some tests and it looks like it's giving correct results. I don't see -2 > anymore and every backend reports correct distribution (with or without hp, > with "small" or "large" shared buffer). Cool! Attached is v7 that is fully

Re: [PATCH] Add native windows on arm64 support

On Tue, 8 Oct 2024 at 20:17, Thomas Munro wrote: > On Wed, Oct 9, 2024 at 12:58 PM Dave Cramer > wrote: > > ..\src\include/port/atomics/arch-x86.h:39: warning: > "pg_memory_barrier_impl" redefined > > It shouldn't be including that. Does the patch here help? > > > https://www.postgresql.org/mes

Re: Reduce the instruction overhead of OpenSSL calls

> On 27 Feb 2025, at 14:16, ryanewang(王蕾) wrote: > > Hi， > From the openssl documentation, when the value of ret is greater than 0, the > SSL_get_error() function returns SSL_ERROR_NONE. > So, it seems that when the return value of SSL_read() or SSL_write() function > is greater than 0, we don

Re: Log connection establishment timings

Hi, On Mon, Mar 03, 2025 at 06:24:59PM -0500, Melanie Plageman wrote: > On Mon, Mar 3, 2025 at 11:14 AM Bertrand Drouvot > wrote: > > > > > > On Fri, Feb 28, 2025 at 05:52:35PM -0500, Melanie Plageman wrote: > > > > +bool > > +check_log_connections(char **newval, void **extra, GucSource source) >

Re: tests for pg_stat_progress_copy.tuples_skipped

po 3. 3. 2025 v 10:05 odesílatel Fujii Masao napsal: > > > > On 2025/01/10 23:50, jian he wrote: > > hi. > > seems no regress tests for pg_stat_progress_copy.tuples_skipped. > > > > CopyFrom > > pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED, > >cstate->n

Re: Allow table AMs to define their own reloptions

04.03.2025 09:16, Julien Tachoires пишет: > Hi Yura, > > On Sun, Mar 02, 2025 at 06:20:07PM +0300, Yura Sokolov wrote: >> Your forgot another one attempt discussion with patch [1] with alive >> commitfest entry [2] >> >> [1] https://postgr.es/m/flat/3766675.7eaCOWfIcx%40thinkpad-pgpro >> [2] https

Re: Next commitfest app release is planned for March 18th

On 04.03.25 02:21, Jelte Fennema-Nio wrote: 1. Major change: The homepage is revamped completely! It now shows a dashboard of open patches where you are author/reviewer/committer if you are logged in. These patches are ordered & grouped in a hopefully useful way. If you're not logged in it will s

Re: tests for pg_stat_progress_copy.tuples_skipped

On Mon, Mar 3, 2025 at 5:05 PM Fujii Masao wrote: > > Thanks for the patch! > > The patch basically looks good to me. > I’ve made some minor cosmetic adjustments — the updated patch is attached. > > Unless there are any objections, I'm thinking to commit it. > I checked it again manually. It look

reduce overhead in shared memory TID store

Going from one to two vacuum workers doesn't scale as well as we'd like, and this thread is about ways of mitigating that. The easiest thing that shows some benefit is separating the two paths by preventing inlining of one or the other: #define RT_PREFIX shared_ts #define RT_SHMEM -#define RT_S

Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2

Hi, Rebased the patch to add support for OLD.* and NEW.*. Andreas From ffa108d03455fc3d901ff32b585dd8dc62a25963 Mon Sep 17 00:00:00 2001 From: Andreas Karlsson Date: Mon, 18 Nov 2024 00:29:15 +0100 Subject: [PATCH v5] Add support for ON CONFLICT DO SELECT [ FOR ... ] Adds support for DO SELECT

Re: per backend WAL statistics

Hi, On Tue, Mar 04, 2025 at 09:28:27AM +0900, Michael Paquier wrote: > On Mon, Mar 03, 2025 at 09:17:30AM +, Bertrand Drouvot wrote: > > On Mon, Mar 03, 2025 at 10:48:23AM +0900, Michael Paquier wrote: > >> Something that's still not quite right is that the WAL receiver and > >> the WAL summar

Re: Accidental assignment instead of compare in GetOperatorFromCompareType?

On 03.03.25 06:05, Jacob Brazeal wrote: Hi all, It looks like commit 630f9a43cece93cb4a5c243b30e34abce6a89514 omitted an equals sign in an ereport() in GetOperatorFromCompareType, giving the line: cmptype = COMPARE_EQ ? errmsg("could not identify an equality operator for type %s", format_typ

Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

On Mon, Mar 03, 2025 at 02:23:51PM +0900, Michael Paquier wrote: > This has always been set last and it's still the case in the patch, so > let's just remove that. This first one has been now applied as c76db55c9085. Attached is the rest to add the wait events (still need to have a closer look at

Re: Add assertion for failed alloc to palloc0() and palloc_extended()

On 3/4/25 3:01 AM, Michael Paquier wrote: On Mon, Mar 03, 2025 at 01:13:05PM +0900, Michael Paquier wrote: In short, LGTM. Will apply if there are no objections. And applied as 40d3f8274499. Thanks! Andreas

Re: ci: Allow running mingw tests by default via environment variable

Hi, On Tue, 4 Mar 2025 at 03:28, Thomas Munro wrote: > > On Fri, Apr 26, 2024 at 12:02 AM Nazir Bilal Yavuz wrote: > > On Sat, 13 Apr 2024 at 05:12, Andres Freund wrote: > > > I propose that we instead run the task automatically if > > > $REPO_MINGW_TRIGGER_BY_DEFAULT is set, typically in cirru

encode/decode support for base64url

Hello, Sometimes support for base64url from RFC 4648 would be useful. Does anyone else need a patch like this? -- Przemysław Sztoch | Mobile +48 509 99 00 66

Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

On Tue, Mar 4, 2025 at 10:30 AM Shubham Khanna wrote: > > Fixed the suggested changes. The attached patch contains the required changes. > Hi Shubham, Thanks for the patch! I tested its functionality and didn't find any issues so far. I'll continue with further testing. Here are some review comm

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

Hi, On Tue, Mar 4, 2025 at 4:59 AM Amit Kapila wrote: > > > > > > Sure thing. I've just added '(..) In the extreme cases this can..' as > > > it is pretty rare to hit it. Patch attached. > > > > When the clock moves forward or backward, couldn't it affect > > not only the standby but also the pr

Re: 64 bit numbers vs format strings

On 02.03.25 22:08, Thomas Munro wrote: And one more thing like that: in a couple of places we see warnings on macOS CI that I'd missed: when printing the result of i64abs() as PRId64, because it happens to use labs() and it happens to define int64_t as long long, and when printing a Datum as PRIx

Re: encode/decode support for base64url

> On 4 Mar 2025, at 09:54, Przemysław Sztoch wrote: > Sometimes support for base64url from RFC 4648 would be useful. > Does anyone else need a patch like this? While not a frequent ask, it has been mentioned in the past. I think it would make sense to add so please do submit a patch for it for

Re: Docs for pg_basebackup needs v17 note for incremental backup

> On 27 Feb 2025, at 19:06, David G. Johnston > wrote: > > On Thu, Feb 6, 2025 at 2:46 PM Daniel Gustafsson > wrote: >> I'd be happy to help getting this in, do you have a suggested wording? > > Thank you. > > Attached. Patch LGTM so I've applied it. -- Daniel Gusta

Re: Next commitfest app release is planned for March 18th

On Tue, 4 Mar 2025 at 10:22, Peter Eisentraut wrote: > I don't know if I like that. I can see the point of getting to the > action quicker, but this sort of obscures the hierarchy of the site and > the data. Before it was like, select a commitfest, select a filter, > here are some patches. Now

Re: Next commitfest app release is planned for March 18th

On 2025-Mar-04, Jelte Fennema-Nio wrote: > 1. Major change: The homepage is revamped completely! It now shows a > dashboard of open patches where you are author/reviewer/committer if > you are logged in. These patches are ordered & grouped in a hopefully > useful way. If you're not logged in it wi

Re: Add Pipelining support in psql

On Tue, Mar 4, 2025 at 1:57 AM Michael Paquier wrote: > Anyway, can we really say that the set of printQueryOpt saved at > execution is the correct set to use? It is possible to have the > opposite argument and say that we should just apply the printQueryOpt > at the moment where \getresult is ru

Re: Add -k/--link option to pg_combinebackup

> With regard to the second question, why does this test need to create > three tables with a million rows each instead of some small number of > rows? If you need to fill multiple blocks, consider making the rows > wider instead of inserting such a large number. Makes sense! Changed that to use t

Re: FileFallocate misbehaving on XFS

On Fri, Jan 31, 2025 at 3:33 PM Jean-Christophe Arnu wrote: > > Hello Mike, > > We encountered the same problem with a fixed allocsize=262144k. Removing this > option seemed to fix the problem.We are now in an XFS managed allocation > heuristic way. The problem does not show up since the change

Re: Cannot find a working 64-bit integer type on Illumos

On 10.12.24 03:02, Thomas Munro wrote: On Thu, Dec 5, 2024 at 12:16 PM Tom Lane wrote: Now you already snuck the camel's nose under the tent by including stdint.h there, and maybe these additional headers wouldn't do any further damage. Even though we fixed the immediate issue (thanks), this

Re: Add -k/--link option to pg_combinebackup

On Tue, Mar 4, 2025 at 7:07 AM Israel Barth Rubio wrote: > About the last one, related to the copy method, my first thought was to do > something like you did (in the sense of using == instead of !=). However, I > was concerned that I would change the previous behavior. But I do prefer > how it st

Re: Next commitfest app release is planned for March 18th

On Tue, 4 Mar 2025 at 17:31, Peter Geoghegan wrote: > > Peter Geoghegan suggested adding a "dashboard" of this > > kind. Feedback on this is very welcome, but depending on the > > complexity I don't know when I'll get to it. I'll be a bit more busy > > the next few weeks and also have some holiday

Re: Next commitfest app release is planned for March 18th

On Tue, Mar 4, 2025 at 3:06 PM Jelte Fennema-Nio wrote: > So patches with failing CI in the "in progress cf" will sort below > healthy patches in the "open cf". I don't think you necessarily said > that, but this seemed nice to me. And it's easy to spot which patches > are for which CF because of

Re: Next commitfest app release is planned for March 18th

On Tue, 4 Mar 2025 at 11:35, Álvaro Herrera wrote: > https://commitfest.postgresql.org/me I've restored the original homepage and moved this new dashboard (minus the "Archive" link) to /me: https://commitfest-test.postgresql.org/me/

Re: Next commitfest app release is planned for March 18th

On Tue, 4 Mar 2025 at 17:15, Peter Eisentraut wrote: > I think the option of having a list of things that I'm involved in as an > author *or* reviewer is actually very useful and something I have wanted > from time to time. But that is apparently not accessible using the > normal search/filter me

Re: SQL:2023 JSON simplified accessor support

On 2025-03-04 Tu 10:34 AM, Mark Dilger wrote: On Tue, Mar 4, 2025 at 6:05 AM Mark Dilger wrote: But then I tried: +DO $$ +DECLARE +  a jsonb := '{"": 6, "NU": [{"": [[3]]}, [6], [2], "bCi"], "aaf": [-6, -8]}'::jsonb; +BEGIN +  WHILE a IS NOT NULL +  LOOP

Re: Next commitfest app release is planned for March 18th

On Mon, Mar 3, 2025 at 8:21 PM Jelte Fennema-Nio wrote: > As always, please test out the current staging website[1] to give some > feedback. > HTTP auth user and password are both pgtest. So, that worked for me, but then it wants me to log into my postgreql.org account, and that doesn't seem to

Re: scalability bottlenecks with (many) partitions (and more)

Andres Freund writes: > On 2025-03-04 19:58:38 +0100, Tomas Vondra wrote: >> I noticed sifaka started failing right after I pushed this: > It's worth noting that > a) sifaka doesn't build with ldap support > b) the failure is in checkprep, not when running the tests > c) the buildfarm unfortunate

Re: making EXPLAIN extensible

On Tue, Mar 4, 2025 at 1:53 PM Jeff Davis wrote: > I don't expect there to be zillions of extensions that only add new and > exciting explain options. Instead, it seems more likely that all > TableAM and CustomScan extensions will have 1-3 new explain options, > and that some of those might collid

Re: Next commitfest app release is planned for March 18th

On Tue, 4 Mar 2025 at 22:04, Peter Geoghegan wrote: > > On Tue, Mar 4, 2025 at 4:02 PM Jelte Fennema-Nio wrote: > > You have to create a *new* account to do so, because the staging auth > > and prod auth > > systems are separate. Then you can mark yourself as author/reviewer of > > a few patches

Re: making EXPLAIN extensible

+1 to the general idea, I didn't look at the patches yet. On Fri, 2025-02-28 at 15:32 -0500, Robert Haas wrote: > 1. It is much more verbose. I theorize that people will be unhappy > about having to type EXPLAIN (pg_overexplain.range_table) rather than > just EXPLAIN (range_table). That was my fi

Re: scalability bottlenecks with (many) partitions (and more)

Hi, On 2025-03-04 16:30:34 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2025-03-04 19:58:38 +0100, Tomas Vondra wrote: > >> I noticed sifaka started failing right after I pushed this: > > > It's worth noting that > > a) sifaka doesn't build with ldap support > > b) the failure is in che

Re: Next commitfest app release is planned for March 18th

On Tue, Mar 4, 2025 at 4:38 PM Jacob Brazeal wrote: > Out of curiosity, what features would make it most useful to you? Right now > it's trying to do all of the following: > * Summarize threads > * Help you find threads about things you're interested in, independent of > what you've commented on

Snapshot related assert failure on skink

Hi, I just saw a BF failure on skink (valgrind) that asserts out. Check the 002_compare_backups failure in: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-03-04%2017%3A35%3A01 TRAP: failed Assert("TransactionIdPrecedesOrEquals(TransactionXmin, RecentXmin)"), File: "../pgs

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

On Mon, Mar 3, 2025 at 10:02 PM Fujii Masao wrote: > I've pushed the patch. Thanks! Hi all, > +tests += { > + 'name': 'ecpg', > + 'sd': meson.current_source_dir(), > + 'bd': meson.current_build_dir(), > + 'tap': { > +'tests': [ > + 't/001_ecpg_err_warn_msg.pl', > + 't/002_ecpg_

Re: scalability bottlenecks with (many) partitions (and more)

Andrew Dunstan writes: > I think I found a logic bug. Testing. Not sure what you are looking at, but I was trying to fix it by making the loop over test modules skip unbuilt modules, borrowing the test you added in v19 to skip unbuilt contrib modules. It's a little more complicated for the other

Re: Next commitfest app release is planned for March 18th

> It'd be nice if the UI had usable hyperlinks that could be bookmarked > by my browser. One hyperlink for each of the views. Sounds reasonable! > Probably "Recommended patches for you to check". Things that are on > the periphery of my interests have the greatest chance of being picked > up, I th

Re: bogus error message for ALTER TABLE ALTER CONSTRAINT

On 2025-Mar-04, Nathan Bossart wrote: > On Tue, Mar 04, 2025 at 07:22:22PM +0100, Álvaro Herrera wrote: > > I just discovered that trying to set a foreign key as NO INHERIT in > > ALTER TABLE ALTER CONSTRAINT returns an absurd error message: > > Here's the fix along with some additional cleanup.

Re: ecdh support causes unnecessary roundtrips

> On 4 Mar 2025, at 20:13, Jacob Champion > wrote: > > On Mon, Jul 29, 2024 at 3:26 PM Daniel Gustafsson wrote: >>> On 17 Jun 2024, at 19:56, Andres Freund wrote: >>> On 2024-06-17 19:51:45 +0200, Daniel Gustafsson wrote: >> Changing the default of the ecdh GUC would perhaps be doable? >

Re: ecdh support causes unnecessary roundtrips

On Mon, Jul 29, 2024 at 3:26 PM Daniel Gustafsson wrote: > > On 17 Jun 2024, at 19:56, Andres Freund wrote: > > On 2024-06-17 19:51:45 +0200, Daniel Gustafsson wrote: > > >> Changing the default of the ecdh GUC would perhaps be doable? > > > > I was wondering whether we could change the default s

Re: Non-text mode for pg_dumpall

A database name containing a newline breaks things for this patch: CREATE DATABASE "foo bar"; $ pg_dumpall -Fc --file test shell command argument contains a newline or carriage return: " dbname='foo bar'" -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

bogus error message for ALTER TABLE ALTER CONSTRAINT

I just discovered that trying to set a foreign key as NO INHERIT in ALTER TABLE ALTER CONSTRAINT returns an absurd error message: create table pk (a int primary key); create table fk (a int references pk); alter table fk alter constraint fk_a_fkey deferrable, alter constraint fk_a_fkey no inheri

Re: scalability bottlenecks with (many) partitions (and more)

Hi, On 2025-03-04 19:58:38 +0100, Tomas Vondra wrote: > Pushed, with the tweaks to use FastPathLockSlotsPerBackend() in a couple > more places. Thanks! > I noticed sifaka started failing right after I pushed this: > > https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=sifaka&br=master

Re: Rename some signal and interrupt handling functions for consistency

On 04/03/2025 21:38, Nathan Bossart wrote: On Tue, Mar 04, 2025 at 08:22:02PM +0200, Heikki Linnakangas wrote: To make things less confusing, the attached patch renames all the functions that are part of the overall signal/interrupt handling system but are *not* executed in a signal handler to e

Re: Make tuple deformation faster

On Thu, 2024-10-10 at 02:59 +1300, David Rowley wrote: > > A few weeks ago David and I discussed this patch. We were curious > > *why* the > > flags approach was slower. ... > > Could it make sense to use bitfields instead of flag values, to > > reduce the > > impact? > > Yeah. That's a good ide

Re: Clarification on Role Access Rights to Table Indexes

On Wed, Feb 19, 2025 at 03:53:48PM +0530, Ayush Vatsa wrote: > It seems there's a general consensus that we should maintain a > original design to support pg_prewarm, with a minor adjustment: > when querying indexes, we should verify the privileges of the parent table. > > I´ve attached a patch fo

Re: Rename some signal and interrupt handling functions for consistency

On Tue, Mar 04, 2025 at 08:22:02PM +0200, Heikki Linnakangas wrote: > To make things less confusing, the attached patch renames all the functions > that are part of the overall signal/interrupt handling system but are *not* > executed in a signal handler to e.g. ProcessSomething(), rather than > Ha

Re: Next commitfest app release is planned for March 18th

On Tue, 4 Mar 2025 at 18:25, Peter Geoghegan wrote: > From the looks of the screen shot that you posted (can't seem to find > the same dashboard view on https://commitfest-test.postgresql.org?), The dashboard is only available if you login. You probably have to create an account to do so, because

Re: per backend WAL statistics

On Tue, Mar 04, 2025 at 08:48:28AM +, Bertrand Drouvot wrote: > s/report/Report/ and s/system/system./? to be consistent with the other single > line comments around. Right. > Yeah, I also think that's the right location. We could be more optimal for the WAL receiver if we add more timestamp

Re: Non-text mode for pg_dumpall

On Wed, 5 Mar 2025 at 01:02, Álvaro Herrera wrote: > > A database name containing a newline breaks things for this patch: > > CREATE DATABASE "foo > bar"; > > > $ pg_dumpall -Fc --file test > shell command argument contains a newline or carriage return: " dbname='foo > bar'" > > -- > Álvaro Herrer

Re: MergeJoin beats HashJoin in the case of multiple hash clauses

On Mon, Mar 3, 2025 at 10:24 AM Andrei Lepikhov wrote: > On 17/2/2025 01:34, Alexander Korotkov wrote: > > Hi, Andrei! > > > > On Tue, Oct 8, 2024 at 8:00 AM Andrei Lepikhov wrote: > > Thank you for your work on this subject. I agree with the general > > direction. While everyone has used conse

Re: support fast default for domain with constraints

jian he writes: > Thanks to commit aaaf9449ec6be62cb0d30ed3588dc384f56274bf[1], > ExprState.escontext (ErrorSaveContext) was added, and > ExecEvalConstraintNotNull, > ExecEvalConstraintCheck were changed to use errsave instead of hard error. > Now we can use it to evaluate CoerceToDomain in a sof

Monitoring gaps in XLogWalRcvWrite() for the WAL receiver

Hi all, While doing some monitoring of a replication setup for a stable branch, I have been surprised by the fact that we have never tracked WAL statistics for the WAL receiver in pg_stat_wal because we have never bothered to update its code so as WAL stats are reported. This is relevant for the

Re: Improve CRC32C performance on SSE4.2

On Wed, Mar 5, 2025 at 12:36 AM Nathan Bossart wrote: > > On Tue, Mar 04, 2025 at 12:09:09PM +0700, John Naylor wrote: > > On Tue, Mar 4, 2025 at 2:11 AM Nathan Bossart > > wrote: > >> This could potentially lead to a small regression for machines with SSE > >> 4.2 but not PCLMUL, but that may b

Re: Wrong results with subquery pullup and grouping sets

On Wed, Mar 5, 2025 at 11:02 AM Richard Guo wrote: > create table t (a int); > insert into t values (1); > > # select a, b > from (select a, a as b from t) ss > group by grouping sets(a, b) > having b = 1; > a | b > ---+--- > 1 | > (1 row) > > Note that the having clause filters out the wr

Re: Considering fractional paths in Append node

On Mon, Mar 3, 2025 at 1:04 PM Andrei Lepikhov wrote: > > On 2/3/2025 09:53, Alexander Korotkov wrote: > > Hi, Andrei! > > > > On Fri, Dec 6, 2024 at 10:13 AM Andrei Lepikhov wrote: > >> > >> On 12/6/24 13:48, Andrei Lepikhov wrote: > >>> On 11/2/24 01:18, Nikita Malakhov wrote: > I've corre

Re: Reduce TupleHashEntryData struct size by half

On Fri, 2025-02-28 at 17:09 +1300, David Rowley wrote: > * my_log2() takes a "long" parameter type but transitionSpace is a > "Size". These types aren't the same width on all platforms we > support. > Maybe pg_nextpower2_size_t() is a better option. Done. > * Should the following have MAXALIGN(tu

Re: is git.postgresql.org working fine?

Jaime Casanova writes: > I just tried to clone from git.postgresql.org and it stalled at 99% of > receiving objects, but I could clone from github without any problems. > Is it only me? I've had trouble in the past with cloning on old/slow machines --- it seems to time out after awhile. But AFA

Wrong results with subquery pullup and grouping sets

While working on the expansion of virtual generated columns, Dean encountered $subject in [1], which can be reproduced using the query below. create table t (a int); insert into t values (1); # select a, b from (select a, a as b from t) ss group by grouping sets(a, b) having b = 1; a | b -

RE: Selectively invalidate caches in pgoutput module

On Tuesday, March 4, 2025 7:44 PM Kuroda, Hayato/黒田 隼人 wrote: Hi, > > > > When the ALTER PUBLICATION command is executed, all entries in > > RelationSyncCache > > > will be discarded anyway. This mechanism works well but is sometimes > > > not > > efficient. > > > For example, when the ALTER P

Add regression test checking combinations of (object,backend_type,context) in pg_stat_io

Hi all, While working on I/O statistics, I have noticed that it is not complicated to break the set of rows returned by pg_stat_io if one is not careful when updating pgstat_tracks_io_object(). Attached is a patch that I've found useful as a sanity check, returning all the combinations supported

Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2

On 3/4/25 10:24 AM, Andreas Karlsson wrote: Rebased the patch to add support for OLD.* and NEW.*. Apparently the CI did not like that version. Andreas From 795c78c79bc7b2dbddfa828e4c01c5641d0be272 Mon Sep 17 00:00:00 2001 From: Andreas Karlsson Date: Mon, 18 Nov 2024 00:29:15 +0100 Subject: [

support fast default for domain with constraints

hi. Thanks to commit aaaf9449ec6be62cb0d30ed3588dc384f56274bf[1], ExprState.escontext (ErrorSaveContext) was added, and ExecEvalConstraintNotNull, ExecEvalConstraintCheck were changed to use errsave instead of hard error. Now we can use it to evaluate CoerceToDomain in a soft error way, that is wh

<    1   2