On Tue, 8 Oct 2024 at 20:17, Thomas Munro <thomas.mu...@gmail.com> wrote:
> On Wed, Oct 9, 2024 at 12:58 PM Dave Cramer <davecramer@postgres.rocks> > wrote: > > ..\src\include/port/atomics/arch-x86.h:39: warning: > "pg_memory_barrier_impl" redefined > > It shouldn't be including that. Does the patch here help? > > > https://www.postgresql.org/message-id/CA%2BhUKG%2BOu%2BC%2BpXioo_W1gKcwRCEN1WNrLBBPSMJyxjgc%2B1JEJA%40mail.gmail.com Well it's been a while, but I did get around to trying this. With your latest patch I get the following error C:\Users\davec\projects\postgresql\src\include\port/atomics.h(78): fatal error C1189: #error: atomic_uint is not always lock-free Cheers, Dave