Re: Increased work_mem for "logical replication tablesync worker" only?

2025-02-03 Thread Dmitry Koterov
Here is the list of tmp files: postgres@pg-101a:~/17/main/base/pgsql_tmp$ ls -la total 5422297 drwx-- 2 postgres postgres 9 Feb 3 04:08 . drwx-- 8 postgres postgres 8 Jan 29 01:27 .. -rw--- 1 postgres postgres 1073741824 Feb 3 04:05 pgsql_tmp196534.0 -rw--- 1 po

Re: why there is not VACUUM FULL CONCURRENTLY?

2025-02-03 Thread Antonin Houska
Antonin Houska wrote: > Alvaro Herrera wrote: > > > > > > > > From bf2ec8c5d753de340140839f1b061044ec4c1149 Mon Sep 17 00:00:00 2001 > > > From: Antonin Houska > > > Date: Mon, 13 Jan 2025 14:29:54 +0100 > > > Subject: [PATCH 4/8] Add CONCURRENTLY option to both VACUUM FULL and > > > CLUSTE

Re: sinvaladt.c: remove msgnumLock, use atomic operations on maxMsgNum

2025-02-03 Thread Heikki Linnakangas
On 03/02/2025 13:05, Yura Sokolov wrote: Investigating some performance issues of a client, our engineers found msgnumLock to be contended. Looking closer it is obvious it is not needed at all: it used only as memory barrier. It is even stated in comment at file start: * We deal with that by ha

Re: new commitfest transition guidance

2025-02-03 Thread Michail Nikolaev
Hello! I think it is a good idea to sent notification (at least once) to the authors of entries. Because it is easy to miss that thread. Best regards, Mikhail.

Re: Doc fix of aggressive vacuum threshold for multixact members storage

2025-02-03 Thread Sami Imseih
Thanks for the patch! This does look like a documentation bug indeed. I have a few comments: 1/ Remove this as "(50% of the maximum, which is about 20GB)," [1] tried to avoid explaining this level of detail, and I agree with that. 2/ c/"about 10GB"/"10GB" the "about" does not seem necessary he

Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

2025-02-03 Thread Álvaro Herrera
> --- a/src/backend/catalog/heap.c > +++ b/src/backend/catalog/heap.c > @@ -101,9 +101,6 @@ static ObjectAddress AddNewRelationType(const char > *typeName, > > Oid new_row_type, >

Re: NOT ENFORCED constraint feature

2025-02-03 Thread Alvaro Herrera
On 2025-Feb-03, Ashutosh Bapat wrote: > ``` > If the > constraint is NOT ENFORCED, the database system will > not check the constraint. It is then up to the application code to > ensure that the constraints are satisfied. The database system might > still assume tha

Re: Using Expanded Objects other than Arrays from plpgsql

2025-02-03 Thread Pavel Borisov
Hi, Tom On Mon, 3 Feb 2025 at 07:02, Michel Pelletier wrote: > > On Sun, Feb 2, 2025 at 1:57 PM Tom Lane wrote: >> >> I wrote: >> > Hmm, it seemed to still apply for me. But anyway, I needed to make >> > the other changes, so here's v4. >> >> PFA v5. The new 0001 patch refactors the free_xxx i

Re: SQLFunctionCache and generic plans

2025-02-03 Thread Pavel Stehule
Hi čt 30. 1. 2025 v 9:50 odesílatel Alexander Pyhalov napsal: > Alexander Pyhalov писал(а) 2025-01-29 17:35: > > Tom Lane писал(а) 2025-01-17 21:27: > >> Alexander Pyhalov writes: > >>> I've rebased patch on master. Tests pass here. > >> > >> The cfbot still doesn't like it; my guess is that yo

Re: Extensible storage manager API - SMGR hook Redux

2025-02-03 Thread Andreas Karlsson
On 9/21/24 8:24 PM, Nitin Jadhav wrote: I reviewed the discussion and took a look at the patch sets. It seems like many things are combined here. Based on the subject, I initially thought it aimed to provide the infrastructure to easily extend storage managers. This would allow anyone to create t

Re: pgbench with partitioned tables

2025-02-03 Thread Sergey Tatarintsev
03.02.2025 14:57, Álvaro Herrera пишет: On 2025-Feb-03, Sergey Tatarintsev wrote: Thanks for the note. I changed the query in the patch (v2 patch attached) Btw, an additional benefit from the patch is that we can use foreign tables (for example, to test postgres_fdw optimizations) Good though

Re: Show WAL write and fsync stats in pg_stat_io

2025-02-03 Thread Michael Paquier
On Mon, Feb 03, 2025 at 10:37:54AM +, Bertrand Drouvot wrote: > Based on those results the patch does not show a noticable impact when IO > timing > tracking is/are enabled. I have spent a good portion of my day doing benchmarking with your scenarios as much as Nazir's scenarios posted at [1]

Re: Non-text mode for pg_dumpall

2025-02-03 Thread jian he
hi. This attached patch solves problems mentioned in [1]. so pg_restore --file restoring multiple databases will have the ```\connect dbname``` command in it. the output plain text file can be used in psql. pg_restore --file output will be: -- -- Database "template1" dump -- -- Dumped from data

Re: Avoid updating inactive_since for invalid replication slots

2025-02-03 Thread Amit Kapila
On Tue, Feb 4, 2025 at 12:05 PM vignesh C wrote: > > On Tue, 4 Feb 2025 at 11:52, Nisha Moond wrote: > > > > Here is the v2 patch with above change and other comments from [1] and > > [2] incorporated. > > One small suggestion: > Since we will not be retaining inactive time for invalid slots afte

Re: Make COPY format extendable: Extract COPY TO format implementations

2025-02-03 Thread Sutou Kouhei
Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Mon, 03 Feb 2025 13:38:04 +0700, Vladlen Popolitov wrote: > I would like to inform about the security breach in your design of > COPY TO/FROM. Thanks! I didn't notice it. > You use FORMAT option to add ne

Re: Avoid updating inactive_since for invalid replication slots

2025-02-03 Thread Nisha Moond
On Tue, Feb 4, 2025 at 9:33 AM Zhijie Hou (Fujitsu) wrote: > > On Monday, February 3, 2025 8:03 PM Nisha Moond > wrote: > > > > Hi Hackers, > > (CC people involved in the earlier discussion) > > > > Right now, it is possible for the 'inactive_since' value of an invalid > > replication > > slot

Re: Increased work_mem for "logical replication tablesync worker" only?

2025-02-03 Thread Amit Kapila
On Mon, Feb 3, 2025 at 5:51 PM Dmitry Koterov wrote: > > Here is the list of tmp files: > > postgres@pg-101a:~/17/main/base/pgsql_tmp$ ls -la > total 5422297 > drwx-- 2 postgres postgres 9 Feb 3 04:08 . > drwx-- 8 postgres postgres 8 Jan 29 01:27 .. > -rw--- 1 postgr

Re: Increased work_mem for "logical replication tablesync worker" only?

2025-02-03 Thread Amit Kapila
On Mon, Feb 3, 2025 at 6:19 PM Dmitry Koterov wrote: > > What's also suspicious is that on the destination node, after copying > finishes, > > # explain select 1 from mytable; > Seq Scan on mytable (cost=0.00..6821514.12 rows=250410012 width=4) > > # SELECT relname, n_live_tup FROM pg_stat_user_

Re: Avoid updating inactive_since for invalid replication slots

2025-02-03 Thread vignesh C
On Tue, 4 Feb 2025 at 11:52, Nisha Moond wrote: > > Here is the v2 patch with above change and other comments from [1] and > [2] incorporated. One small suggestion: Since we will not be retaining inactive time for invalid slots after server restart, the inactive time will be lost in this case, sh

Re: plperl version on the meson setup summary screen

2025-02-03 Thread Zharkov Roman
Hello, Here is a new patch version. I tried to use perl 'version' instead of 'api_versionstring' to sync with configure script. -- Roman ZharkovFrom: Zharkov Roman Date: Thu, 17 Oct 2024 13:09:51 +0700 Subject: [PATCH] Show plperl version in the meson setup summary. Use perl 'version' instea

Re: new commitfest transition guidance

2025-02-03 Thread Daniel Gustafsson
> On 4 Feb 2025, at 06:50, Tom Lane wrote: > > Peter Eisentraut writes: >> During the developer meeting at FOSDEM last Thursday, > > BTW, are there minutes available from that meeting? In past years > some notes have been posted on the wiki, but I'm failing to find > anything right now. They

Re: Show WAL write and fsync stats in pg_stat_io

2025-02-03 Thread Michael Paquier
On Mon, Feb 03, 2025 at 02:34:29PM +0300, Nazir Bilal Yavuz wrote: > On Mon, 3 Feb 2025 at 11:50, Bertrand Drouvot > wrote: >> === 1 >> >> + pgstat_count_io_op_time(IOOBJECT_WAL, IOCONTEXT_INIT, IOOP_WRITE, >> + io_start, 1, >> wal_segm

Re: Show WAL write and fsync stats in pg_stat_io

2025-02-03 Thread Bertrand Drouvot
Hi, On Mon, Feb 03, 2025 at 01:07:26PM +0900, Michael Paquier wrote: > On Fri, Jan 31, 2025 at 11:29:31AM +0300, Nazir Bilal Yavuz wrote: > > On Wed, 29 Jan 2025 at 18:16, Bertrand Drouvot > > wrote: > >> I think that's the main reason why ff99918c625 added this new GUC (looking > >> at > >> the

Re: Non-text mode for pg_dumpall

2025-02-03 Thread Srinath Reddy
Hi, I found a bug ,while using "./pg_restore pdd -f -" actually it has to copy everything(global sql commands + remaining dump ) into stdout as per the "-f, --file=FILENAME output file name (- for stdout)" but it is copying global sql commands to a file literally naming it as "-" and remaining

Re: Introduce XID age and inactive timeout based replication slot invalidation

2025-02-03 Thread Amit Kapila
On Fri, Jan 31, 2025 at 5:50 PM Nisha Moond wrote: > > Please find the attached v66 patch set. The base patch(v65-001) is > committed now, so I have rebased the patches. > * The time when the slot became inactive. NULL if the -slot is currently being streamed. +sl

<    1   2