Hi,
On January 28, 2025 7:13:16 AM EST, Jelte Fennema-Nio
wrote:
>Since about ~11 hours ago the ecpg test is consistently failing on
>Window with this error[1]:
>
>> Could not open file
>> C:/cirrus/build/src/interfaces/ecpg/test/compat_informix/dec_test.c for
>> reading
>
>I took a quick loo
Peter Eisentraut writes:
> On 27.08.24 10:12, Peter Eisentraut wrote:
>> Here is a new patch version.
>> I simplified the uses of sed and awk inside the Perl script. I also
>> fixed "make installcheck". I noticed that meson installs sepgsql.sql
>> into the wrong directory, so that's fixed also
Hi,
On 2024-12-02 16:39:28 +0200, Heikki Linnakangas wrote:
> From eff8de11fbfea4e2aadce9c1d71452b0f5a1b80b Mon Sep 17 00:00:00 2001
> From: Heikki Linnakangas
> Date: Mon, 2 Dec 2024 15:51:54 +0200
> Subject: [PATCH v5 1/4] Replace Latches with Interrupts
Your email has only three attachements
On 2025/01/22 3:24, Andrey M. Borodin wrote:
On 12 Jan 2025, at 17:43, Andrey M. Borodin wrote:
I attach a prototype patch.
Here's v2, now it passes all the tests with wal_debug.
I like the idea of WAL compression more.
With the current approach, each backend needs to allocate memory
On Mon, Jan 27, 2025 at 12:45 PM Melanie Plageman
wrote:
>
> On Fri, Jan 24, 2025 at 3:43 PM Robert Haas wrote:
> >
> > On Fri, Jan 24, 2025 at 3:02 PM Melanie Plageman
> > wrote:
> attached v11 uses a fraction with this name. It follows the
> conventions and I find it descriptive.
>
> Changing
Manika Singhal писал(а) 2025-01-28 16:42:
Hi,
"C:\Users\Administrator\AppData\Local\Temp\2\postgresql_installer_cd746730f8"
"C:\Program Files\PostgreSQL\17" "C:\Program
Files\PostgreSQL\17\data" 5432 "Turkish,Türkiye" 0
Hi!
Your example has not-ascii characters in command line. It is not
Hi Robert
On 28.01.25 05:54, Robert Treat wrote:
> Was playing around with the patch and was thinking about this wording:
> "The xmldocument function returns the input argument
> unchanged... and is provided for compatibility."
>
> When I run an example similar to the db2 example you gave earlier
On 20.01.25 17:53, Amul Sul wrote:
Attached is a new set of patches. Please ignore patch 0001 here, which
was posted separately [1] -- proposes allowing invalid foreign key
constraints on partitioned tables. Patch 0002 refactors
tryAttachPartitionForeignKey(), primarily needed by the new patch
v9
Dear PostgreSQL Development Team,
I would like to request the addition of support for the *AES-128-CFB* mode
in the pgcrypto extension. Currently, pgcrypto supports AES encryption
modes like ECB and CBC, but it does not include CFB mode, which is
essential for certain use cases.
In managed enviro
On 1/28/25 11:36, Andrei Lepikhov wrote:
On 1/27/25 16:50, Alexander Korotkov wrote:
qsort(matches, n, sizeof(OrArgIndexMatch), or_arg_index_match_cmp);
To fit an index, the order of elements in the target array of the
`ScalarArrayOpExpr` may change compared to the initial list of OR
expressio
On Mon, Dec 30, 2024 at 11:05 AM Peter Smith wrote:
>
> I think we are often too quick to throw out perfectly good tests.
> Citing that some similar GUCs don't do testing as a reason to skip
> them just seems to me like an example of "two wrongs don't make a
> right".
>
> There is a third option.
> On 21 Jan 2025, at 16:47, Roman Eskin wrote:
>
>>
>> Persisting recovery signal file for some _timeout_ seems super dangerous to
>> me. In distributed systems every extra _timeout_ is a source of complexity,
>> uncertainty and despair.
>
> The approach is not about persisting the signal
On Mon, Jan 27, 2025 at 4:20 PM Amit Kapila wrote:
>
> On Mon, Jan 27, 2025 at 11:00 AM Nisha Moond wrote:
> >
> > I discussed the above comments further with Peter off-list, and here
> > are the v63 patches with the following changes:
> > patch-001: The Assert and related comments have been upd
Hi,
I was chatting with Heikki about this patch and he mentioned that he recalls a
patch that did some work to unify the signal replacement, procsignal.h and
CHECK_FOR_INTERRUPTS(). Thomas, that was probably from you? Do you have a
pointer, if so?
It does seem like we're going to have to do some
On Mon, Jan 27, 2025 at 1:22 PM Melanie Plageman
wrote:
>
> On Mon, Jan 27, 2025 at 12:52 PM Masahiko Sawada
> wrote:
> >
> > Thank you for updating the patch. I was reviewing the v10 patch and
> > had some comments. I believe these comments are still valid for v11,
> > but please ignore them if
On Wed, Jan 29, 2025 at 10:15 AM Andres Freund wrote:
> I was chatting with Heikki about this patch and he mentioned that he recalls a
> patch that did some work to unify the signal replacement, procsignal.h and
> CHECK_FOR_INTERRUPTS(). Thomas, that was probably from you? Do you have a
> pointer,
On Fri, 24 Jan 2025 at 20:50, jian he wrote:
>
> On Thu, Jan 23, 2025 at 6:35 PM Mahendra Singh Thalor
> wrote:
>
> hi.
> After some tests and thinking about your reply, I admit that using
> expand_dbname_patterns
> in pg_restore will not work.
> We need to do pattern matching against the map.dat
On Tue, Jan 28, 2025 at 3:26 PM Amit Kapila wrote:
>
> On Mon, Dec 30, 2024 at 11:05 AM Peter Smith wrote:
> >
> > I think we are often too quick to throw out perfectly good tests.
> > Citing that some similar GUCs don't do testing as a reason to skip
> > them just seems to me like an example of
> On 28 Jan 2025, at 11:46, Vladyslav Nebozhyn wrote:
> • Ease of Implementation: OpenSSL already provides a straightforward API
> for AES-128-CFB, so adding it to pgcrypto should require only a few lines of
> code.
IIRC we already support CFB for Blowfish so I think it would be quite easy
Since about ~11 hours ago the ecpg test is consistently failing on
Window with this error[1]:
> Could not open file
> C:/cirrus/build/src/interfaces/ecpg/test/compat_informix/dec_test.c for
> reading
I took a quick look at possible causes but couldn't find a clear
winner. My current guess is th
Dear Sawada-san,
I love the idea. I've roughly tested the patch and worked on my env.
Here are initial comments...
1. xloglevelworker.c
```
+#include "replication/logicalxlog.h"
```
xloglevelworker.c includes replication/logicalxlog.h, but it does not exist.
The line had to be removed to build a
On Mon, 27 Jan 2025 at 15:29, Peter Eisentraut wrote:
>
> On 15.01.25 20:37, Peter Eisentraut wrote:
> > On 15.01.25 15:12, Dean Rasheed wrote:
> >> On Tue, 14 Jan 2025 at 13:37, Peter Eisentraut
> >> wrote:
> >>>
> >>> Here is a new patch with that fixed and also a few
> >>> tweaks suggested by
Hello Hackers,
(CC people involved in the earlier discussion)
While implementing slot invalidation based on inactive(idle) timeout
(see [1]), several general optimizations and improvements were
identified.
This thread is a spin-off from [1], intended to address these
optimizations separately from
>> +/*
>> + * ignorenulls_getfuncarginframe
>> + * For IGNORE NULLS, get the next nonnull value in the frame, moving
>> forward or backward
>> + * until we find a value or reach the frame's end.
>> + */
>> +static Datum
>> +ignorenulls_getfuncarginframe(WindowObject winobj, int argno,
>>
>> Do you
On Thu, Jan 23, 2025 at 9:58 AM vignesh C wrote:
>
I have pushed the remaining part of this patch. Now, we can review the
proposed documentation part.
I feel we don't need the Examples sub-section for this part of the
docs. The behavior is quite clear from the "Behavior Summary"
sub-section tabl
On Tue, Jan 28, 2025 at 7:03 PM Ashutosh Bapat
wrote:
>
> On Tue, Jan 28, 2025 at 4:31 PM Junwang Zhao wrote:
> >
> > On Tue, Jan 28, 2025 at 6:17 PM Ashutosh Bapat
> > wrote:
> > >
> > > On Fri, Jan 24, 2025 at 9:16 PM Junwang Zhao wrote:
> > > >
> > > > I figured out it's because I have `-DWR
On Tue, Jan 28, 2025 at 4:01 PM Peter Eisentraut wrote:
>
> On 20.01.25 17:53, Amul Sul wrote:
> >> Attached is a new set of patches. Please ignore patch 0001 here, which
> >> was posted separately [1] -- proposes allowing invalid foreign key
> >> constraints on partitioned tables. Patch 0002 refa
On Tue, Jan 28, 2025 at 6:17 PM Ashutosh Bapat
wrote:
>
> On Fri, Jan 24, 2025 at 9:16 PM Junwang Zhao wrote:
> >
> > I figured out it's because I have `-DWRITE_READ_PARSE_PLAN_TREES` this
> > option,
> > removing this option clears the warning, but I'm not sure if this is a
> > hidden issue.
>
On Tue, Jan 28, 2025 at 4:31 PM Junwang Zhao wrote:
>
> On Tue, Jan 28, 2025 at 6:17 PM Ashutosh Bapat
> wrote:
> >
> > On Fri, Jan 24, 2025 at 9:16 PM Junwang Zhao wrote:
> > >
> > > I figured out it's because I have `-DWRITE_READ_PARSE_PLAN_TREES` this
> > > option,
> > > removing this option
Am Freitag, dem 24.01.2025 um 19:06 +0100 schrieb Alvaro Herrera:
> > So we behave exactly the same way as px_crypt_md5(): It stops after
> > the
> > first '$' after the magic byte preamble. For shacrypt, this could
> > be
> > the next '$' after the closing one of the non-mandatory 'rounds'
> > opt
On Mon, Jan 27, 2025 at 7:01 PM Peter Smith wrote:
>
> On Tue, Jan 28, 2025 at 4:31 AM Masahiko Sawada wrote:
> >
> > On Sun, Jan 26, 2025 at 10:26 PM Amit Kapila
> > wrote:
> > >
> > > On Fri, Jan 24, 2025 at 12:38 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Wed, Jan 22, 2025 at 7:35
When dealing with a tricky bug in an extension [1] last week, I found out that
one should not rely on a PG core functions to leave CurrentMemoryContext
always unchanged. While the change of memory context makes sense for functions
involved in error handling or transaction control, it's less obvious
Hi,
> The correct version is as follows.
>
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
Thanks for your feedback!
> About the tests pushed to the SSL test suite, I'm +-0. 003_sslinfo.pl
> is a bit
> I feel that observability is important, and I don't understand why we
> would want to have the information for only a portion of the
> functionality's usage (even if it's the most important).
In my opinion, the requirement for parallel usage in
the utility statement is different. In fact, I thin
On Tue, Jan 28, 2025 at 01:33:58PM +0300, Aleksander Alekseev wrote:
> Thanks for your feedback!
set_masklen(inet) could be covered for the -1 case, and it was missing
in the patch submitted. For consistency with the other queries,
moving the call of abbrev(inet) with the existing abbrev(cidr) ma
Hi Ajin,
Some review comments for patch v12-0001.
==
Commit message
1.
Track transactions which have snapshot changes with a new flag
RBTXN_HAS_SNAPSHOT_CHANGES
~
The commit message only says *what* it does, but not *why* this patch
even exists. TBH, I don't understand why this patch need
On Thu, Jan 23, 2025 at 1:12 AM Sutou Kouhei wrote:
>
> Hi,
>
> I noticed that the last patch set (v27) can't be applied to
> the current master. I've rebased on the current master and
> created v28 patch set. No code change.
Thank you for updating the patch!
While 0001 and 0002 look good to me
On Tue, Jan 28, 2025 at 7:59 PM Amit Kapila wrote:
>
> On Thu, Jan 23, 2025 at 9:58 AM vignesh C wrote:
> >
>
> I have pushed the remaining part of this patch. Now, we can review the
> proposed documentation part.
>
> I feel we don't need the Examples sub-section for this part of the
> docs. The
On Fri, Jan 24, 2025 at 10:38 PM Peter Geoghegan wrote:
> I can reproduce this. However, it should be noted that the regression
> completely goes away if I make one small change to your test case: all
> I need to do is make sure that the CREATE INDEX happens *before*
> inserting any rows into the
On Wed, Jan 15, 2025 at 07:51:39PM -0500, Peter Geoghegan wrote:
> I was able to get the lcov git master branch's tip to produce a
> Postgres coverage report (same compiler version and OS as before).
> Unfortunately, I had to use an even grottier incantation to get this
> to work:
>
> make -s cove
I happened across a not-great behavior in expand_insert_targetlist.
If a column is omitted in an INSERT, and there's no column
default, the code generates a NULL Const to be inserted.
Furthermore, if the column is of a domain type, we wrap the
Const in CoerceToDomain, so as to throw a run-time erro
On Sun, Jan 26, 2025 at 9:49 PM Tom Lane wrote:
> Srinath Reddy writes:
> > as suggested did the changes and attached the patch for the same.
>
> Uh ... what in the world is the point of changing
> BufferIsExclusiveLocked's signature?
>
>
as suggested did not change the BufferIsExclusiveLocked's
On Tue, Jan 28, 2025 at 1:39 AM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Sawada-san,
>
> I love the idea. I've roughly tested the patch and worked on my env.
> Here are initial comments...
Thank you for looking at the patch!
>
> 1. xloglevelworker.c
> ```
> +#include "replication/logicalxlog.h"
>
Hi Nisha,
Some review comments for patch v1-0001.
==
src/backend/replication/logical/slotsync.c
ReplSlotSyncWorkerMain:
1.
+ /* Use same inactive_since time for all slots */
+ now = GetCurrentTimestamp();
+
LWLockAcquire(ReplicationSlotControlLock, LW_SHARED);
for (int i = 0; i < max_r
Hi Nisha,
Some review comments for the patch v1-0002.
==
src/backend/replication/slot.c
1.
+
+/*
+ * Raise an error based on the slot's invalidation cause.
+ */
+static void
+RaiseSlotInvalidationError(ReplicationSlot *slot)
+{
+ StringInfo err_detail = makeStringInfo();
+
+ Assert(slot->dat
On Wed, Jan 29, 2025 at 6:03 AM Peter Smith wrote:
>
> On Tue, Jan 28, 2025 at 7:59 PM Amit Kapila wrote:
> >
> > On Thu, Jan 23, 2025 at 9:58 AM vignesh C wrote:
> > >
> >
> > I have pushed the remaining part of this patch. Now, we can review the
> > proposed documentation part.
> >
> > I feel
hi.
I reviewed 0001 only.
in src/backend/statistics/mvdistinct.c
no need #include "nodes/pg_list.h" since
src/include/statistics/statistics.h sub level include "nodes/pg_list.h"
no need #include "utils/palloc.h"
sicne #include "postgres.h"
already included it.
select '[{"6, -32768,,": -11}]':
I see that various comments in xact.c talk about start and end callbacks,
but only end seems to be implemented at the moment. I also can't find any
discussion about start of transaction callbacks in the mailing list
archives. Would a patch in this direction be of interest?
I was looking at this ba
> All the changes mentioned above are included in the v13 patch. Since the
> patch status is 'Ready for Committer,' I believe it is now better for
> upstream inclusion, with improved details in tests and documentation. Do
> you have any further suggestions?
I am not quite clear on the sample_1.out
Tom Lane писал(а) 2025-01-24 06:13:
v.popoli...@postgrespro.ru writes:
[ v2-0001-work_mem_vars-limit-increased-in-64bit-Windows.patch ]
Hi Tom,
Thank you for the interest to the patch and comments.
Comment A.
Is there a reason not to do them all the same way? I'd suggest
"(Size) 1024", losi
On 01/28/25 03:14, Jim Jones wrote:
> I'd say the difference is due to how the two systems handle the XML data
> type and unquoted identifiers in general, rather than a difference in
> the behaviour of the function itself.
I'd go further and say it's entirely down to how the two systems
handle un
Tom Lane писал(а) 2025-01-24 06:13:
v.popoli...@postgrespro.ru writes:
[ v2-0001-work_mem_vars-limit-increased-in-64bit-Windows.patch ]
Hi Tom,
Thank you for the interest to the patch and comments.
Comment A.
Is there a reason not to do them all the same way? I'd suggest
"(Size) 1024", losi
On 28.01.25 11:58, Amul Sul wrote:
This behavior is not correct:
+-- Changing it back to ENFORCED will leave the constraint in the NOT
VALID state
+ALTER TABLE FKTABLE ALTER CONSTRAINT fktable_ftest1_fkey ENFORCED;
+-- Which needs to be explicitly validated.
+ALTER TABLE FKTABLE VALIDATE CONSTRA
On 28.01.2025 20:21, Sami Imseih wrote:
All the changes mentioned above are included in the v13 patch. Since the
patch status is 'Ready for Committer,' I believe it is now better for
upstream inclusion, with improved details in tests and documentation. Do
you have any further suggestions?
I am
Hi all,
I propose adding the --clean-publisher-objects option to the
pg_createsubscriber utility. As discussed in [1], this feature ensures
a clean and streamlined setup of logical replication by removing stale
or unnecessary publications from the subscriber node. These
publications, replicated du
Dear Shubham,
> I propose adding the --clean-publisher-objects option to the
> pg_createsubscriber utility. As discussed in [1], this feature ensures
> a clean and streamlined setup of logical replication by removing stale
> or unnecessary publications from the subscriber node. These
> publication
Hi,
As part of a discussion in [1], I am starting this thread to address
the issue reported for foreign tables.
Logical replication of foreign tables is not supported, and we throw
an error in this case. But when we create a publication on a
partitioned table that has a foreign table as a partiti
On Tue, 28 Jan 2025 at 17:28, Nisha Moond wrote:
>
> On Tue, Jan 28, 2025 at 3:26 PM Amit Kapila wrote:
> >
> > On Mon, Dec 30, 2024 at 11:05 AM Peter Smith wrote:
> > >
> > > I think we are often too quick to throw out perfectly good tests.
> > > Citing that some similar GUCs don't do testing a
Hello all!
Currently, according to logical replication restriction sections at [1],
"Attempts to replicate ... foreign tables, will result in an error."
But we don't care about partitioned tables with foreign partitions.
As we discussed here
https://www.postgresql.org/message-id/CAA4eK1Lhh4S
23.01.2025 09:46, Amit Kapila пишет:
On Wed, Jan 22, 2025 at 9:44 PM Sergey Tatarintsev
wrote:
22.01.2025 18:41, Shlok Kyal пишет:
Also we still don't care about foreign partitions (as I wrote earlier
we should raise an ERROR for such publications).
I think dealing with this separately from
On 1/27/25 07:47, Peter Eisentraut wrote:
> On 24.01.25 03:55, Tom Lane wrote:
>> I've now run an exhaustive search through the last three months of
>> buildfarm runs, and found just one additional instance of the same
>> failure. The three matches are
>>
>>
https://buildfarm.postgresql.org/cgi-
On Sat, Jan 25, 2025 at 3:35 AM Devulapalli, Raghuveer
wrote:
> > #1 - The choice of AVX-512. There is no such thing as a "CRC instruction
> > operating
> > on 8 bytes", and the proposed algorithm is a multistep process using
> > carryless
> > multiplication and requiring at least 256 bytes of
On Tue, Jan 28, 2025 at 12:01 PM Ashutosh Bapat
wrote:
>
> If we want to stick to --database= supporting a pattern looks better
> than just a single special pattern *.
>
This sounds reasonable to me as well. Note that the interaction of
other parameters like --replication-slot is not yet discusse
I noticed a few incorrect usages of it's vs its and decided to search
systematically for any mistakes. Overall, we use it right more than 99% of
the time but there were still about 20 mistakes.
Jacob
v1-its.patch
Description: Binary data
On Tue, Jan 28, 2025 at 10:58 PM Nisha Moond wrote:
> Please find the attached v64 patches. The changes in this version
> w.r.t. older patch v63 are as -
> - The changes from the v63-0001 patch have been moved to a separate thread
> [1].
> - The v63-0002 patch has been split into two parts in v64
On Thu, Jan 23, 2025 at 8:52 AM Anton A. Melnikov
wrote:
>
> Hi!
>
> On 22.01.2025 11:37, John Naylor wrote:
> > On Fri, Jan 17, 2025 at 4:50 PM John Naylor wrote:
> >>
> >> It would be a lot more readable to revert the offending commit
> >> instead, since its predecessor had a much simpler bytew
On Tue, 28 Jan 2025 at 17:28, Nisha Moond wrote:
>
> Please find the attached v64 patches. The changes in this version
> w.r.t. older patch v63 are as -
> - The changes from the v63-0001 patch have been moved to a separate thread
> [1].
> - The v63-0002 patch has been split into two parts in v64:
On Wed, Jan 29, 2025 at 1:46 PM Jacob Brazeal wrote:
>
> I noticed a few incorrect usages of it's vs its and decided to search
> systematically for any mistakes. Overall, we use it right more than 99% of
> the time but there were still about 20 mistakes.
LGTM, except maybe this one:
- * try re
On Wed, Jan 29, 2025 at 1:46 PM Jacob Brazeal wrote:
>
> I noticed a few incorrect usages of it's vs its and decided to search
> systematically for any mistakes. Overall, we use it right more than 99% of
> the time but there were still about 20 mistakes.
I just noticed this, too:
-# DROP DATAB
Hi,
Thank you for the patchset. Having per-backend WAL statistics,
in addition to cluster-wide ones, is useful.
I had a few comments while looking at v6-0003-* patch.
+ /*
+ * This could be an auxiliary process but these do not report backend
+ * statistics due to pgstat_tracks_backend_bktype(),
On Wed, Jan 29, 2025 at 2:26 PM Jacob Brazeal wrote:
>
> > I just noticed this, too:
> >
> > -# DROP DATABASE should drops it's slots, including active slots.
> > +# DROP DATABASE should drops its slots, including active slots.
> >
> > "should drop"
>
> Ah, good catch. Fixed in v3.
(Note: You for
hi.
select '{"1, 0B100101":"NaN"}'::pg_ndistinct;
pg_ndistinct
{"1, 37": -2147483648}
(1 row)
this is not what we expected?
For the VALUE part of pg_ndistinct, float8 has 3 special values: inf, -inf, NaN.
For the key part of pg_ndistinct, see example.
select '{"1,
72 matches
Mail list logo
