Thank you for Review.
Could you explain how to reproduce this? In my quick test,
lock waits canceled by lock_timeout didn’t report either xid or PID,
so I might be missing something.
It seems to be outputting on my end, how about you?
= Console =
postgres=# SHOW log_lock_waits;
log_loc
On Wed, 16 Oct 2024 at 23:25, Shubham Khanna
wrote:
>
> On Wed, Oct 9, 2024 at 9:08 AM vignesh C wrote:
> >
> > On Tue, 8 Oct 2024 at 11:37, Shubham Khanna
> > wrote:
> > >
> > > On Fri, Oct 4, 2024 at 9:36 AM Peter Smith wrote:
> > > >
> > > > Hi Shubham, here are my review comments for v36-0
Hello Ranier,
16.10.2024 14:14, Ranier Vilela wrote:
Em qua., 16 de out. de 2024 às 04:45, Peter Eisentraut
escreveu:
This wouldn't fix anything, I think. If colors is NULL, then strsep()
already returns NULL, so the added code does nothing.
If *colors* is NULL, then the delimiter
On Wed, 16 Oct 2024 at 23:25, Shubham Khanna
wrote:
>
> On Wed, Oct 9, 2024 at 9:08 AM vignesh C wrote:
> >
> > On Tue, 8 Oct 2024 at 11:37, Shubham Khanna
> > wrote:
> > >
> > > On Fri, Oct 4, 2024 at 9:36 AM Peter Smith wrote:
> > > >
> > > > Hi Shubham, here are my review comments for v36-0
Hi Jian,
On Thu, Oct 17, 2024 at 5:59 AM jian he wrote:
> in [3] I mentioned adding "ParseLoc location" to ExplainStmt, then you
> found some problems at [4] with multi statements,
> now I found a way to resolve it.
> I also add "ParseLoc location;" to typedef struct CopyStmt.
> copy (select 1) t
Hi, Yurii!
Please look at the bug report, I filed yesterday almost simultaneously with
you:
https://www.postgresql.org/message-id/18658-7dab125ec688c70b%40postgresql.org
Thanks!
On Thu, Oct 17, 2024 at 12:49 PM Yurii Rashkovskii
wrote:
> Hi pg-hackers,
>
> I am encountering an assertion failur
On Thu, Oct 17, 2024, at 01:50, Michael Paquier wrote:
> On Wed, Oct 16, 2024 at 02:50:53PM +0900, Michael Paquier wrote:
>> You are right. f6d4c9cf162b got that wrong. Will fix and backpatch
>> with the extra tests.
>
> And done down to 17 for 0002, down to 16 for 0001, with tweaks in 0001
> to
I think there should be a mention of virtual environments in the plpython
docs.
Something like $attached maybe?
v1-0001-Add-tip-on-using-virtual-envs-with-Pl-Python.patch
Description: Binary data
I've run some additional tests, mostly pgbench with
options=-cjit_above_cost=0 for an extended duration on an instance
that was impacted. I haven't seen any issues nor performance
regressions compared to the unpatched version.
I will switch the commitfest entry to Ready for Committer if there's
no
On 10/15/24 15:08, Alexander Korotkov wrote:
Yep, they didn't get updated. Fixed in the attached patchset.
Let me wear Alexander Lakhin's mask for a moment and say that the code
may cause a segfault:
#0 0x55e0da186000 in insert_rel_type_cache_if_needed (typentry=0x0)
at typcache.c:3066
On Thu, Oct 17, 2024 at 10:36 PM Anthonin Bonnefoy
wrote:
> I've run some additional tests, mostly pgbench with
> options=-cjit_above_cost=0 for an extended duration on an instance
> that was impacted. I haven't seen any issues nor performance
> regressions compared to the unpatched version.
>
> I
Em qui., 17 de out. de 2024 às 07:30, Alexander Lakhin
escreveu:
> Hello Ranier,
>
> 16.10.2024 14:14, Ranier Vilela wrote:
>
> Em qua., 16 de out. de 2024 às 04:45, Peter Eisentraut <
> pe...@eisentraut.org> escreveu:
>
>>
>> This wouldn't fix anything, I think. If colors is NULL, then strsep()
On Wed, Oct 16, 2024, at 21:13, Joel Jacobson wrote:
> Therefore, maybe DELIMITER NONE would be a better default
> for RAW? Especially since it's then also more honest in being "raw".
>
> If needing to import an unstructured text file that is just newline
> delimited, and not wanting the entire fil
On 04.09.24 08:54, jian he wrote:
On Tue, Sep 3, 2024 at 5:41 PM Peter Eisentraut wrote:
I like this patch version (v4). It's the simplest, probably also
easiest to backpatch.
I am actually confused.
In this email thread [1], I listed 3 corn cases.
I thought all these 3 corner cases should
> On 17 Oct 2024, at 04:45, Bruce Momjian wrote:
> I looked at this and decided the GUC section was illogical, so I just
> moved the variables up into the be-secure.c section. Patch attached.
No objections.
--
Daniel Gustafsson
Hi,
4ac2a9bec introduced reject_limit option to the COPY command, and I was
wondering if it might be beneficial to add the same option to file_fdw.
Although there may be fewer practical use cases compared to COPY, it
could still be useful in situations where the file being read via
file_fdw
On Fri, Jun 21, 2024 at 10:30:08AM +0800, jian he wrote:
> hi.
> -
> 9.16.2.1.1. Boolean Predicate Check Expressions
> As an extension to the SQL standard, a PostgreSQL path expression can
> be a Boolean predicate, whereas the SQL standard allows predicates
> only within filters. While
Hi,
Andy, your words make sense, but to me it seems that in
add_paths_to_append_rel
we have no other options than tuple_fraction from root, and rows (if any)
in paths
we take into account, please correct me if I am wrong.
Thank you!
Also, on top of that I have an idea of pruning unnecessary part
Considering both points, I’m leaning toward adding a new GUC parameter
to control whether detailed logs should be generated for failed
NOWAIT locks (and possibly for those canceled by lock_timeout).
Alternatively, if adding a new GUC is not ideal, we could extend
log_lock_waits to accept a new
On 2024/10/17 22:15, Seino Yuki wrote:
Considering both points, I’m leaning toward adding a new GUC parameter
to control whether detailed logs should be generated for failed
NOWAIT locks (and possibly for those canceled by lock_timeout).
Alternatively, if adding a new GUC is not ideal, we co
Florents Tselai writes:
> I think there should be a mention of virtual environments in the plpython
> docs.
Why? We are not here to teach people how to use Python. More, this
patch seems like not merely teaching Python, but teaching the use of
specific Python installation patterns that might or
On Oct 16, 2024, at 6:01 PM, Shayon Mukherjee wrote:
I'll take some time to think this through and familiarize myself with the
new systable_inplace_update_begin. In the meantime, aside from the in-place
updates on pg_index, I would love to learn any first impressions or
feedback on the patch folk
On Thu, Oct 17, 2024 at 02:07:00PM +0800, jian he wrote:
> On Thu, Oct 17, 2024 at 7:59 AM Bruce Momjian wrote:
> >
> >
> > Where are we on this? I still see this behavior.
> >
> > ---
>
> > > but I found following two examp
Nikita Malakhov writes:
> Hi,
>
> Andy, your words make sense, but to me it seems that in
> add_paths_to_append_rel
> we have no other options than tuple_fraction from root, and rows (if any) in
> paths
> we take into account, please correct me if I am wrong.
One of the option might be applyin
On Thu, Oct 17, 2024 at 2:03 PM Tom Lane wrote:
> What I'm still confused about is whether this is anything that
> a typical user of Python shouldn't be expected to know already.
I mean... I think I agree, but also it seems like people regularly
find ways to shoot themselves in the foot, so I'm n
On Wed, Oct 16, 2024 at 4:20 PM Jeff Davis wrote:
> The comments around ThrowErrorData() and how it might apply to soft
> errors is slightly confusing. Attached a patch which hopefully
> clarifies things.
>
> From a distance, ThrowErrorData() is somewhat like ReThrowError(), but
> it's actually q
On Thu, Oct 17, 2024 at 02:07:32PM +0900, Seino Yuki wrote:
> I've fixed the patch and will register it in the CF.
Thanks. Here is what I have staged for commit.
--
nathan
>From 8aff8ec54a6588614f952693f509b75bf240851c Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Thu, 17 Oct 2024 16:56:
On Wed, Oct 16, 2024 at 10:54:45AM -0500, Nathan Bossart wrote:
> Here is a new version of the patch set with this #ifdef added. I plan to
> give each of the code paths adjusted by 0001 a closer look, but otherwise
> I'm hoping to commit these soon.
0002 and 0003 look sane enough to me as shaped.
On Sun, Aug 4, 2024 at 3:51 AM Andrey M. Borodin wrote:
>
>
>
> > On 28 Jul 2024, at 23:44, Andrey M. Borodin wrote:
> >
> > PFA version accepting offset interval.
>
> There was a bug: when time was not moving on, I was updating used time by a
> nanosecond, instead of 1/4096 of millisecond.
> V2
On Tue, 15 Oct 2024 at 05:21, Alena Rybakina wrote:
> As I see it, node->eflags can be zero if it passes the output of a
> subquery, during the initialization of the Material node execution, and
> when the subquery is rescanned.
Do you have a test case that calls Material with zero eflags? I tri
Alexander Lakhin writes:
> I've spent a day testing ecpg preprocessor and found another couple of
> bugs:
Thanks for the report! The first couple of these seem simple
enough to fix, so I've done so. As for
> Also, processing of .../ecpg/test/sql/include.pgc, containing only:
> EXEC SQL INCLUDE
> On 17 Oct 2024, at 5:10 PM, Peter Eisentraut wrote:
>
> On 17.10.24 15:56, Tom Lane wrote:
>> Florents Tselai writes:
>>> I think there should be a mention of virtual environments in the plpython
>>> docs.
>> Why? We are not here to teach people how to use Python. More, this
>> patch seems
Hi all,
This was on my TODO bucket for some time. The isolation test
"inplace" in the isolation test suite for injection_points relies on a
couple of behaviors implemented in the backend. One of them is that a
point detach should not affect a wait. Rather than having to guess
this stuff from th
On Thu, Oct 17, 2024 at 10:21:54AM +0200, Joel Jacobson wrote:
> I believe the correction should be to use COPY TO stdout instead of
> COPY FROM stdin, since FORCE_QUOTE is only applicable with COPY TO.
> This way, the test correctly verifies the disallowed combination of
> FORCE_QUOTE
> with a no
On Fri, Oct 18, 2024 at 2:05 AM Bruce Momjian wrote:
>
> On Thu, Oct 17, 2024 at 02:47:57PM -0300, Marcos Pegoraro wrote:
> > Em qui., 17 de out. de 2024 às 13:31, Bruce Momjian
> > escreveu:
> >
> > Oh, okay, but I think we need to say JSON null so we are clear --- patch
> >
> >
> > But true
Hello,
Would it be convinient to show the plperl version on the meson setup
summary
screen? Now it displays only 'YES' or 'NO'. This is the expected
behavior of
the meson build system and explains in its source code:
https://github.com/mesonbuild/meson/blob/5f0bd8ff1e7fc43199d4b371fc4625f80bab
Jacob Champion writes:
> On Thu, Oct 17, 2024 at 1:10 PM Florents Tselai
> wrote:
>> Which means that if you want non-standard packages in your Pl/Python code,
>> you’ll have to `sudo python3 -m pip install` things
> Or `sudo apt install python3-`, or `pip install --user
> ` as the database user
On Thu, Oct 17, 2024 at 04:59:54PM -0500, Nathan Bossart wrote:
> Thanks. Here is what I have staged for commit.
Fine by me. Thanks.
--
Michael
signature.asc
Description: PGP signature
On Thu, 2024-10-17 at 20:54 -0400, Corey Huinker wrote:
> There is some uncertainty on what, if anything, should be returned by
> pg_set_relation_stats() and pg_set_attribute_stats().
...
> This re-raises the question of whether the pg_set_*_stats functions
> should return anything at all.
What
On 10/18/24 07:54, Andy Fan wrote:
Nikita Malakhov writes:
The effect is easily seen in one of standard PG tests:
"""
I think that things might work out better if we redefined the startup
cost as "estimated cost to retrieve the first tuple", rather than its
current very-squishy definition as "
I will send the version with the GUC parameter added from the previous
patch.
I made some minor code refactoring.
Regards,
--
Yuki Seino
NTT DATA CORPORATION
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 934ef5e469..ff6bde0b49 100644
--- a/doc/src/sgml/config.sgml
+++
On Thu, Oct 17, 2024 at 1:10 PM Florents Tselai
wrote:
> Which means that if you want non-standard packages in your Pl/Python code,
> you’ll have to `sudo python3 -m pip install` things
Or `sudo apt install python3-`, or `pip install --user
` as the database user, or...
Virtualenvs are great --
On Wed, 16 Oct 2024 at 20:03, Peter Geoghegan wrote:
>
> On Fri, Oct 11, 2024 at 7:29 PM Peter Geoghegan wrote:
> > Attached is v5
>
> Now I'm attaching a v6, which further polishes things. Current plan is to
> commit something very close to this in the next day or two.
>
> v6 is mostly just furt
Currently, we are discussing two improvements:
1. Log output when NOWAIT fails.
2. Adding control via GUC parameters (NOWAIT, lock_timeout,
cancellation).
I'm not sure why it's challenging to provide detailed log messages for
lock waits canceled
by lock_timeout or user cancellation, while it'
Nikita Malakhov writes:
> The effect is easily seen in one of standard PG tests:
> Vanilla (current master):
> explain analyze
> select t1.unique1 from tenk1 t1
> inner join tenk2 t2 on t1.tenthous = t2.tenthous and t2.thousand = 0
>union all
> (values(1)) limit 1;
>
On Wed, Oct 16, 2024 at 7:20 PM Corey Huinker
wrote:
> Code fix with comment on why nobody expects a relpages -1. Test case to
>> demonstrate that relpages -1 can happen, and updated doc to reflect the new
>> lower bound.
>>
>
> Additional fixes, now in a patch-set:
>
> 1. Allow relpages to be se
On 2024/10/18 9:37, Seino Yuki wrote:
Currently, we are discussing two improvements:
1. Log output when NOWAIT fails.
2. Adding control via GUC parameters (NOWAIT, lock_timeout, cancellation).
I'm not sure why it's challenging to provide detailed log messages for lock
waits canceled
by loc
Hi
pá 18. 10. 2024 v 7:22 odesílatel Laurenz Albe
napsal:
> On Wed, 2024-03-06 at 14:32 +0100, Laurenz Albe wrote:
> > On Mon, 2023-11-06 at 18:29 +0100, Tomas Vondra wrote:
> > > On 11/6/23 14:23, Laurenz Albe wrote:
> > > > This behavior looks buggy to me. What do you think?
> > > > I cannot
During our discussion, I also thought it would be useful to provide detailed logs
> for lock waits canceled by user actions or lock_timeout.
Thank you. I understand now.
You want to output the logs based on a different trigger than
log_lock_waits.
At first, I found that strange, but I see no
On Thu, Oct 17, 2024 at 09:21:11AM +0200, Anthonin Bonnefoy wrote:
> I'm not sure about this approach. It moves the responsibility of
> tracking the location and length from the nested statement to the top
> level statement.
> - The location you added in ExplainStmt and CopyStmt has a different
> m
Antonin Houska wrote:
> I'd like to play with the code a bit and provide some review before or during
> the next CF. That will probably generate some more questions.
This is the 1st round, based on reading the code. I'll continue paying
attention to the project and possibly post some more commen
On 2024/10/18 7:10, Michael Paquier wrote:
On Thu, Oct 17, 2024 at 04:59:54PM -0500, Nathan Bossart wrote:
Thanks. Here is what I have staged for commit.
Fine by me. Thanks.
LGTM, too. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headqu
On Tue, Oct 15, 2024 at 10:11:40AM +0200, Anthonin Bonnefoy wrote:
> I've updated the patchset with additional tests for COPY in 0001. 0002
> includes the necessary modifications to handle COPY.
Beginning with the beginning of this patch series.
+SELECT toplevel, calls, query FROM pg_stat_stateme
On Fri, Oct 18, 2024, at 00:52, Michael Paquier wrote:
> On Thu, Oct 17, 2024 at 10:21:54AM +0200, Joel Jacobson wrote:
>> I believe the correction should be to use COPY TO stdout instead of
>> COPY FROM stdin, since FORCE_QUOTE is only applicable with COPY TO.
>> This way, the test correctly verif
On 2024/10/16 18:52, Fujii Masao wrote:
On 2024/10/16 15:04, Yuto Sasaki (Fujitsu) wrote:
>Hmm, I'm not sure we want that, because if we do this, then
>ECPGget_sqlca() gets run with the debug_mutex held. In the original
>coding, it's run without the mutex.
Thank you for pointing that ou
Hi Amit,
> On Thu, Oct 3, 2024 at 8:53 AM Tatsuo Ishii wrote:
>>
>> > parameter in this case (it is an "optional" parameter, though). However,
>> > when we refer to the stored catalog value, we should call it an option or
>> > a property and calling it parameter is not suitable.
>>
>> Not sure. T
On Tue, Oct 8, 2024 at 3:38 PM Amit Kapila wrote:
> On Tue, Oct 8, 2024 at 2:25 PM shveta malik
> wrote:
> >
> > On Mon, Oct 7, 2024 at 4:03 PM vignesh C wrote:
> > >
> >
> > With parallel streaming as default, do you think there is a need to
> > increase the default for 'max_logical_replicatio
On Sat, Oct 5, 2024 at 6:23 PM Richard Guo wrote:
>
> On Fri, Sep 27, 2024 at 11:53 AM Richard Guo wrote:
> > Here is an updated version of this patch that fixes the rowcount
> > estimate issue along this routine. (see set_joinpath_size.)
>
in the function setup_eager_aggregation,
can we be mor
> On 16 Oct 2024, at 11:05, Michael Paquier wrote:
>
> This part of the patch looks structurally wrong to me because we've
> already spent some time refactoring the clock APIs into instr_time.h
> that deals about cross-platform requirements for monotonic times.
> Particularly, on MacOS, we hav
On Thu, Oct 17, 2024 at 10:37:46PM +0800, jian he wrote:
>
> - false, or unknown.
> + false, or NULL.
>
> nearby are all examples related to jsonb_path_query.
> As mentioned before, jsonb_path_query returns JSON null.
> so change to
> + false, or null
> would be better.
>
> since we
On 2024/10/17 22:45, torikoshia wrote:
Hi,
4ac2a9bec introduced reject_limit option to the COPY command, and I was
wondering if it might be beneficial to add the same option to file_fdw.
Although there may be fewer practical use cases compared to COPY, it could
still be useful in situation
On 17.10.24 15:56, Tom Lane wrote:
Florents Tselai writes:
I think there should be a mention of virtual environments in the plpython
docs.
Why? We are not here to teach people how to use Python. More, this
patch seems like not merely teaching Python, but teaching the use of
specific Python
On Thu, Oct 17, 2024 at 9:59 PM Bruce Momjian wrote:
>
>
> > > > >> the predicate: true, false, or unknown."
> > > > >> "unknown" is wrong, because `select 'unknown'::jsonb;` will fail.
> > > > >> here "unknown" should be "null"? see jsonb_path_query doc entry also.
> > > > >>
> >
> > doc
> > (ht
Em qui., 17 de out. de 2024 às 13:31, Bruce Momjian
escreveu:
> Oh, okay, but I think we need to say JSON null so we are clear --- patch
>
But true, false and null are all JSON, since you cannot do
select jsonb_path_query('{}'::jsonb,'$.track.segments[*].HR > 130') = true;
So, it would be bette
Hello Tom,
16.10.2024 19:26, Tom Lane wrote:
Alexander Lakhin writes:
Maybe you would like to fix in passing several (not new) defects, I've
found while playing with ecpg under Valgrind:
Done. After evaluation I concluded that none of these were worth the
trouble to back-patch, but by all me
On Thu, Oct 17, 2024 at 02:47:57PM -0300, Marcos Pegoraro wrote:
> Em qui., 17 de out. de 2024 às 13:31, Bruce Momjian
> escreveu:
>
> Oh, okay, but I think we need to say JSON null so we are clear --- patch
>
>
> But true, false and null are all JSON, since you cannot do
> select jsonb_pat
66 matches
Mail list logo
