On Thu, 2024-10-17 at 20:54 -0400, Corey Huinker wrote: > There is some uncertainty on what, if anything, should be returned by > pg_set_relation_stats() and pg_set_attribute_stats().
... > This re-raises the question of whether the pg_set_*_stats functions > should return anything at all. What is the benefit of a return value from the pg_set_*_stats variants? As far as I can tell, there is none because they throw an ERROR if anything goes wrong, so they should just return VOID. What am I missing? The return value is more interesting for pg_restore_relation_stats() and pg_restore_attribute_stats(), which will be used by pg_dump and which are designed to keep going on non-fatal errors. Isn't that what this discussion should be about? Magnus, you previously commented that you'd like some visibility for tooling: https://www.postgresql.org/message-id/CABUevEz1gLOkWSh_Vd9LQh-JM4i%3DMu7PVT9ffc77TmH0Zh3TzA%40mail.gmail.com Is a return value what you had in mind? Or some other function that can help find missing stats later, or something else entirely? Regards, Jeff Davis
