On Mon, 23 Sept 2024 at 19:39, jian he wrote:
> sql-analyze.html
> For partitioned tables, ANALYZE gathers statistics by sampling rows
> from all partitions. Each leaf partition is also recursively analyzed
> and the statistics updated. This recursive part may be disabled by
> using the ONLY keywo
On 9/23/24 01:06, Tom Lane wrote:
> Tomas Vondra writes:
>> On 9/22/24 17:45, Tom Lane wrote:
>>> #define FAST_PATH_GROUP(index) \
>>> - (AssertMacro(((index) >= 0) && ((index) < FP_LOCK_SLOTS_PER_BACKEND)), \
>>> + (AssertMacro((uint32) (index) < FP_LOCK_SLOTS_PER_BACKEND), \
>>> ((index
On Sun, Sep 22, 2024 at 7:24 PM Joe Conway wrote:
>
> On 9/21/24 01:31, shihao zhong wrote:
> > Nisha Moond writes:
> >> Thoughts? Looking forward to hearing others' opinions!
> >
> > Had a productive conversation with Amit Kaplia today about time skew
> > in distributed systems, and wanted to sh
On Fri, Sep 20, 2024 at 7:51 PM Tom Lane wrote:
>
> Nisha Moond writes:
> > While considering the implementation of timestamp-based conflict
> > resolution (last_update_wins) in logical replication (see [1]), there
> > was a feedback at [2] and the discussion on whether or not to manage
> > clock
> On Mon, 23 Sept 2024 at 18:28, Tatsuo Ishii wrote:
>> I agree and made necessary changes. See attached v4 patches.
>
> Looks good to me.
Thank you for the review! I have pushed the patch.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://ww
Hi,
On Sat, 21 Sept 2024 at 09:01, jian he wrote:
>
> hi. Thanks for your work!
Thank you for looking into this!
> I do find some issues.
>
>
> TESTS="copy jsonb jsonb" meson test --suite regress
> one will fail. not sure this is expected?
Yes, that is expected.
> in [1] you mentioned "setup"
David Rowley писал(а) 2024-09-23 04:28:
On Fri, 20 Sept 2024 at 01:55, Пополитов Владлен
wrote:
Currently PostgreSQL built on 64-bit Windows has 2Gb limit for
GUC variables due to sizeof(long)==4 used by Windows compilers.
Technically 64-bit addressing for maintenance_work_mem is possible,
but
On Mon, Sep 16, 2024 at 4:19 PM Tomas Vondra wrote:
> On 9/16/24 15:11, Jakub Wartak wrote:
> > On Fri, Sep 13, 2024 at 1:45 AM Tomas Vondra wrote:
> >
> >> [..]
> >
> >> Anyway, at this point I'm quite happy with this improvement. I didn't
> >> have any clear plan when to commit this, but I'm co
On 10.09.24 14:50, Daniel Gustafsson wrote:
On 1 Jul 2024, at 12:22, Daniel Gustafsson wrote:
Attached is a v2 which fixes a conflict, if there is no interest in Markdown
I'll drop 0001 and the markdown-specifics from 0002 to instead target increased
consistency.
Since there doesn't seem to
On Fri, 20 Sept 2024 at 04:16, Peter Smith wrote:
>
> On Fri, Sep 20, 2024 at 3:26 AM Masahiko Sawada wrote:
> >
> > On Thu, Sep 19, 2024 at 2:32 AM Amit Kapila wrote:
> > >
> ...
> > > I think that the column list should take priority and we should
> > > publish the generated column if it is me
On Fri, 20 Sept 2024 at 17:15, Shubham Khanna
wrote:
>
> On Wed, Sep 11, 2024 at 8:55 AM Peter Smith wrote:
>
> I have fixed all the comments. The attached patches contain the desired
> changes.
> Also the merging of 0001 and 0002 can be done once there are no
> comments on the patch to help in
Hello Nathan,
20.09.2024 19:51, Nathan Bossart wrote:
Here's a (probably naive) attempt at fixing these, too. I'll give each
path a closer look once it feels like we've identified all the bugs.
Thank you for the updated patch!
I tested it with two code modifications (1st is to make each crea
On 12/9/2024 12:12, David Rowley wrote:
On Thu, 12 Sept 2024 at 21:51, Andrei Lepikhov wrote:
Initial problem causes wrong cost_sort estimation. Right now I think
about providing cost_sort() the sort clauses instead of (or in addition
to) the pathkeys.
I'm not quite sure why the sort clauses
> On 17 Sep 2024, at 21:22, Nathan Bossart wrote:
>
> Here are a few miscellaneous cleanup patches for pg_upgrade. I don't think
> there's anything controversial here.
No objections to any of these changes, LGTM.
--
Daniel Gustafsson
On Sat, Sep 21, 2024 at 6:34 AM John H wrote:
>
> On Fri, Sep 20, 2024 at 2:44 AM shveta malik wrote:
> > > >
> > >
> > > The difference is that the purpose of 'synchronized_standby_slots' is
> > > to mention slot names for which the user expects logical walsenders to
> > > wait before sending th
On Wed, Sep 18, 2024 at 5:10 PM Andrei Lepikhov wrote:
> On 13/9/2024 01:38, Alexander Korotkov wrote:
> > I've tried to implement handling of concurrent invalidation similar to
> > commit fdd965d074. However that appears to be more difficult that I
> > thought, because for some datatypes like ar
Hi David,
Thank you so much for the review and pointers. I totally missed expression
indexes. I am going to do another proper pass along with your feedback and
follow up with an updated patch and any questions.
Excited to be learning so much about the internals.
Shayon
> On Sep 22, 2024, at
On Mon, Sep 23, 2024 at 04:00:00PM +0300, Alexander Lakhin wrote:
> I tested it with two code modifications (1st is to make each created
> expression index TOASTed (by prepending 1M of spaces to the indexeprs
> value) and 2nd to make each created index an expression index (by
> modifying index_elem
Hi Magnus,
On 2024-Sep-23, Magnus Holmgren wrote:
> We've set allow_system_table_mods = on so that we could rename
> pg_database and in its place put a custom view that only lists the
> databases the current user has CONNECT privileges to. This is because
> 1) we allow customers direct (read onl
Hello,
We've set allow_system_table_mods = on so that we could rename
pg_database and in its place put a custom view that only lists the
databases the current user has CONNECT privileges to. This is because
1) we allow customers direct (read only) access to their databases, but
2) we don't want t
On Wed, 31 Jul 2024 at 15:42, Daniel Verite wrote:
>
> Sutou Kouhei wrote:
>
> > BTW, here is a diff after pgindent:
>
> PFA a v5 with the cosmetic changes applied.
Thank you Daniel for working on it. I've tested the patch and it seems
it works as expected.
I have a couple of minor comme
Hi,
I've spent a bit more time on this, mostly running tests to get a better
idea of the practical benefits.
Firstly, I think there's a bug in ReorderBufferCompress() - it's legal
for pglz_compress() to return -1. This can happen if the data is not
compressible, and would not fit into the output
Daniel Gustafsson writes:
>> On 20 Sep 2024, at 21:00, Tom Lane wrote:
>> Per cfbot, rebased over d5622acb3. No functional changes.
> Looking over these I don't see anything mis-characterized so +1 on going ahead
> with these. It would be neat if we end up translating xml2 errors into XQuery
>
> On Sun, Sep 22, 2024 at 01:15:54PM GMT, Dmitry Dolgov wrote:
> > On Sat, Sep 21, 2024 at 05:25:30PM GMT, Tom Lane wrote:
> >
> > Is there a way to get the llvm library's version at run time? If so
> > we could consider building a new function to return that.
>
> Yes, there is a C api LLVMGetVers
On Mon, 23 Sept 2024 at 18:28, Tatsuo Ishii wrote:
> I agree and made necessary changes. See attached v4 patches.
Looks good to me.
David
Good morning!
FYI: I know many people are/were tracking this email thread rather
than the newer and more recent one "scalability bottlenecks with
(many) partitions (and more)", but please see [1] [2] , where Tomas
committed enhanced fast-path locking to the master(18).
Thanks Tomas for persisten
Hi,
I would like to know if the PostgreSQL 17 GAis happening this week or is
there a change in dates?
On Fri, Aug 23, 2024 at 7:44 PM Jonathan S. Katz
wrote:
> Hi,
>
> The date for PostgreSQL 17 Release Candidate 1 (RC1) is September 5,
> 2024. Please ensure all open items[1] are completed and
On Mon, Sep 23, 2024 at 12:46 PM David Rowley wrote:
>
> On Mon, 23 Sept 2024 at 15:29, jian he wrote:
> > Given the above context, I am still confused with this sentence in
> > sql-analyze.html.
> > "If ONLY is specified before the table name, only that table is analyzed."
> >
> > like in the ab
On 9/23/24 05:03, Richard Guo wrote:
> On Sun, Sep 22, 2024 at 1:38 PM David Rowley wrote:
>> Just looking at the commit message:
>>
>>> The rationale is based on the assumption that incremental sort is
>>> always faster than full sort when there are presorted keys, a premise
>>> that has been app
On Mon, Sep 23, 2024 at 03:04:22PM +0200, Daniel Gustafsson wrote:
> No objections to any of these changes, LGTM.
Thanks for reviewing. I'll commit these once the v17 release freeze is
over (since 0001 needs to be back-patched there).
--
nathan
Tomas Vondra writes:
> Thanks. Pushed a fix for these issues, hopefully coverity will be happy.
Thanks.
> BTW is the coverity report accessible somewhere? I know someone
> mentioned that in the past, but I don't recall the details. Maybe we
> should have a list of all these resources, useful for
On 12/9/2024 16:57, Tomas Vondra wrote:
On 9/12/24 12:12, David Rowley wrote:
On Thu, 12 Sept 2024 at 21:51, Andrei Lepikhov wrote:
but doesn't estimate_num_groups()
supposed to already do that? The comment says:
* 3. If the list contains Vars of different relations that are known equal
David Rowley писал(а) 2024-09-23 15:35:
On Mon, 23 Sept 2024 at 21:01, Vladlen Popolitov
wrote:
Thank you for proposal, I looked at the patch and source code from
this
point of view. In this approach we need to change all .
I counted the appearences of these vars in the code:
maintenance_work_
On Mon, 23 Sept 2024 at 23:23, jian he wrote:
> looks fine. but maybe we can add the following information
> "if The ONLY is specified, the second set of
> statistics won't include each children individual statistics"
> I think that's the main difference between specifying ONLY or not?
Ok, I thin
On Thu, 12 Sept 2024 at 11:01, Peter Smith wrote:
>
> Because this feature is now being implemented as a PUBLICATION option,
> there is another scenario that might need consideration; I am thinking
> about where the same table is published by multiple PUBLICATIONS (with
> different option settings
On Fri, 20 Sept 2024 at 17:15, Shubham Khanna
wrote:
>
> On Wed, Sep 11, 2024 at 8:55 AM Peter Smith wrote:
> >
> > Here are a some more review comments for patch v30-0001.
> >
> > ==
> > src/sgml/ref/create_publication.sgml
> >
> > 1.
> > +
> > + If the publisher-side colum
On Mon, 23 Sept 2024 at 21:01, Vladlen Popolitov
wrote:
> Thank you for proposal, I looked at the patch and source code from this
> point of view. In this approach we need to change all .
> I counted the appearences of these vars in the code:
> maintenance_work_mem appears 63 times in 20 files
> w
On 12/9/2024 16:57, Tomas Vondra wrote:
On 9/12/24 12:12, David Rowley wrote:
On Thu, 12 Sept 2024 at 21:51, Andrei Lepikhov wrote:
I'm not sure how to fix this, but it seems estimate_num_groups() needs
to do things differently. And I agree looking for the minimum ndistinct
seems like the righ
Hi hackers,
I just noticed that all indents in upgrade scripts of pg_stat_statemets are
made using spaces, except for "CREATE FUNCTION pg_stat_statements_reset"
statement in pg_stat_statements--1.6--1.7.sql and
pg_stat_statements--1.10--1.11.sql.
I made a patch to fix it in pg_stat_statements--1.
Hi,
On Mon, 23 Sept 2024 at 11:46, Nazir Bilal Yavuz wrote:
> On Sat, 21 Sept 2024 at 09:01, jian he wrote:
> > in [1] you mentioned "setup", but that "setup" is more or less like
> > "meson test --suite setup --suite regress"
> > but originally, I thought was about "src/test/regress/sql/test_s
On Mon, 23 Sept 2024 at 19:28, Sandeep Thakkar
wrote:
> I would like to know if the PostgreSQL 17 GAis happening this week or is
> there a change in dates?
Nothing so far has come up to cause the dates to change.
David
On Mon, Sep 16, 2024 at 3:44 PM Andrei Lepikhov wrote:
> On 9/9/2024 12:36, Alexander Korotkov wrote:
> > Also, I agree it get it's wrong to directly copy RestrictInfo struct
> > in group_similar_or_args(). Instead, I've renamed
> > make_restrictinfo_internal() to make_plain_restrictinfo(), which
> On 20 Sep 2024, at 21:00, Tom Lane wrote:
>
> I wrote:
>> [ v1-clean-up-errcodes-for-xml.patch ]
>
> Per cfbot, rebased over d5622acb3. No functional changes.
Looking over these I don't see anything mis-characterized so +1 on going ahead
with these. It would be neat if we end up translating
On Mon, Sep 23, 2024 at 6:04 PM David Rowley wrote:
>
>
> If this is confusing, I think there's a bunch of detail that I tried
> to keep that's just not that useful. The part about analyzing
> partitions just once and the part about not collecting non-inheritance
> stats for the partitioned table
Hi, all
I haven't paid attention to this topic in a long time, thanks all for the
advices, I will study them then update.
Thanks again.
Zhang Mingli
www.hashdata.xyz
On Sep 18, 2024 at 15:50 +0800, David Rowley , wrote:
> On Wed, 18 Sept 2024 at 19:28, Peter Eisentraut wrote:
> >
> > On 12.0
On 09.09.24 23:38, Shayon Mukherjee wrote:
*Problem*:
Adding and removing indexes is a common operation in PostgreSQL. On
larger databases, however, these operations can be resource-intensive.
When evaluating the performance impact of one or more indexes, dropping
them might not be ideal since
On Mon, Sep 23, 2024 at 7:53 PM David Rowley wrote:
>
> On Mon, 23 Sept 2024 at 23:23, jian he wrote:
> > looks fine. but maybe we can add the following information
> > "if The ONLY is specified, the second set of
> > statistics won't include each children individual statistics"
> > I think that'
Hi. Here are my review comments for v32-0001
You wrote: "I have addressed all the comments in the v32-0001 Patch.",
however, I found multiple old review comments not addressed. Please
give a reason if a comment is deliberately left out, otherwise, I will
assume they are omitted by accident and so
On Fri, Sep 20, 2024 at 09:37:54AM +0900, Michael Paquier wrote:
> What do you think about adding a test with DETACH FINALIZE when
> attempting it on a normal table, its path being under a different
> subcommand than DETACH [CONCURRENTLY]?
>
> There are no tests for normal tables with DETACH CONCU
Hi. Here are my v32-0002 review comments:
==
src/backend/replication/logical/tablesync.c
1. fetch_remote_table_info
/*
- * Get column lists for each relation.
+ * Get column lists for each relation, and check if any of the
+ * publications have the 'publish_generated_columns' parameter ena
On Mon, Sep 23, 2024 at 8:31 PM David Rowley wrote:
> On Tue, 24 Sept 2024 at 03:14, Peter Eisentraut
> wrote:
> >
> > On 09.09.24 23:38, Shayon Mukherjee wrote:
> > > ALTER INDEX index_name ENABLE;
> > > ALTER INDEX index_name DISABLE;
> >
> > I think a better approach would be to make the list
That's a good point.
+1 for the idea of the GUC setting, especially since, as you mentioned, it
allows unprivileged users to access it and being per-session..
I am happy to draft a patch for this as well. I think I have a working idea so
far of where the necessary checks might go. However if yo
Dmitry Dolgov <9erthali...@gmail.com> writes:
> On Sun, Sep 22, 2024 at 01:15:54PM GMT, Dmitry Dolgov wrote:
>> About a new function, I think that the llvm runtime version has to be
>> shown in some form by pgsql_version. The idea is to skip an emails
>> exchange like "here is the bug report" -> "c
Hi Peter,
Thank you so much for helping!
On Mon, Sep 16, 2024 at 12:44 PM Peter Eisentraut wrote:
>
> On 29.08.24 18:33, Alexandra Wang wrote:
> > I’ve implemented the member and array accessors and attached two
> > alternative patches:
> >
> > 1. v1-0001-Add-JSON-JSONB-simplified-accessor.patch
On Thu, Sep 19, 2024 at 10:44 PM Amit Kapila wrote:
>
> On Thu, Sep 19, 2024 at 10:33 PM Masahiko Sawada
> wrote:
> >
> > On Wed, Sep 18, 2024 at 8:55 PM Amit Kapila wrote:
> > >
> > > On Thu, Sep 19, 2024 at 6:46 AM David Rowley wrote:
> > > >
> > > > On Thu, 19 Sept 2024 at 11:54, Masahiko S
On Tue, 24 Sept 2024 at 03:14, Peter Eisentraut wrote:
>
> On 09.09.24 23:38, Shayon Mukherjee wrote:
> > ALTER INDEX index_name ENABLE;
> > ALTER INDEX index_name DISABLE;
>
> I think a better approach would be to make the list of disabled indexes
> a GUC setting, which would then internally have
Hi Tomas,
Le lun. 23 sept. 2024 à 18:13, Tomas Vondra a écrit :
>
> Hi,
>
> I've spent a bit more time on this, mostly running tests to get a better
> idea of the practical benefits.
Thank you for your code review and testing!
> Firstly, I think there's a bug in ReorderBufferCompress() - it's l
On Tue, 24 Sept 2024 at 02:47, Vladlen Popolitov
wrote:
> I agree, it is better to fix all them together. I also do not like this
> hack, it will be removed from the patch, if I check and change
> all at once.
> I think, it will take about 1 week to fix and test all changes. I will
> estimate the
On Tue, 24 Sept 2024 at 02:01, Tomas Vondra wrote:
>
> On 9/23/24 05:03, Richard Guo wrote:
> > On Sun, Sep 22, 2024 at 1:38 PM David Rowley wrote:
> >> Just looking at the commit message:
> >>
> >>> The rationale is based on the assumption that incremental sort is
> >>> always faster than full s
I found an old thread here [0].
Also, a question: If we go with the GUC approach, how do we expect
`pg_get_indexdef` to behave?
I suppose it would behave no differently than it otherwise would, because
there's no new SQL grammar to support and, given its GUC status, it seems
reasonable that `p
Hi,
Thank you for considering another idea.
On Fri, Sep 20, 2024 at 2:46 AM Amit Kapila wrote:
>
> On Fri, Sep 20, 2024 at 8:25 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > Apart from the vacuum_defer_cleanup_age idea.
> >
>
> I think you meant to say vacuum_committs_age idea.
>
> > we’ve given mor
On 2024-09-20 Fr 12:38 AM, Tom Lane wrote:
Michael Paquier writes:
On Fri, Sep 20, 2024 at 11:51:49AM +0800, Junwang Zhao wrote:
Should you also bump the catalog version?
No need to worry about that when sending a patch because committers
take care of that when merging a patch into the tree
On Mon, Sep 23, 2024 at 7:57 AM Peter Smith wrote:
>
> My review comments for v8-0001
>
> ==
> contrib/pg_logicalinspect/pg_logicalinspect.c
>
> 1.
> +/*
> + * Lookup table for SnapBuildState.
> + */
> +
> +#define SNAPBUILD_STATE_INCR 1
> +
> +static const char *const SnapBuildStateDesc[] = {
On 19/9/2024 09:55, Andrei Lepikhov wrote:
This wrong prediction makes things much worse if the query has more
upper query blocks.
His question was: Why not consider the grouping column unique in the
upper query block? It could improve estimations.
After a thorough investigation, I discovered th
If one of the use cases is soft-dropping indexes, would a GUC approach
still support that? ALTER TABLE?
On Mon, 23 Sept 2024 at 22:04, David Rowley wrote:
> Can you have a look at the attached and let me know if it's easier to
> understand now?
Pushed.
David
On Sun, 22 Sep 2024 17:59:34 +0900 (JST)
Tatsuo Ishii wrote:
> > I would like to improve the following two points on the result outputs
> > of pgbench related to faild transaction. The patch is attached.
> >
> > (1) Output per-script statistics even when there are no successful
> > transaction i
On Tuesday, September 24, 2024 5:05 AM Masahiko Sawada
wrote:
>
> Thank you for considering another idea.
Thanks for reviewing the idea!
>
> On Fri, Sep 20, 2024 at 2:46 AM Amit Kapila wrote:
> >
> > On Fri, Sep 20, 2024 at 8:25 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > Apart from the
On Fri, Sep 20, 2024 at 12:22 PM Bertrand Drouvot
wrote:
>
>
> Please find attached v8, that:
>
Thank You for the patch. In one of my tests, I noticed that I got
negative checksum:
postgres=# SELECT * FROM pg_get_logical_snapshot_meta('0/3481F20');
magic| checksum | version
On Tue, Sep 24, 2024 at 2:35 AM Masahiko Sawada wrote:
>
> >
> > As each apply worker needs a separate slot to retain deleted rows, the
> > requirement for slots will increase. The other possibility is to
> > maintain one slot by launcher or some other central process that
> > traverses all subscr
On Mon, Sep 23, 2024 at 10:50:21AM -0500, Nathan Bossart wrote:
> I carefully inspected all the code paths this patch touches, and I think
> I've got all the details right, but I would be grateful if someone else
> could take a look.
No objections from here with putting the snapshots pops and push
On Mon, Sep 23, 2024 at 8:32 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Tuesday, September 24, 2024 5:05 AM Masahiko Sawada
> wrote:
> >
> > Thank you for considering another idea.
>
> Thanks for reviewing the idea!
>
> >
> > On Fri, Sep 20, 2024 at 2:46 AM Amit Kapila wrote:
> > >
> > > On Fri, Sep
On Mon, Sep 23, 2024 at 10:01 PM Tomas Vondra wrote:
> You don't need any skew. Consider this perfectly uniform dataset:
>
> create table t (a int, b int);
> insert into t select 10 * random(), 100 * random()
> from generate_series(1,100) s(i);
> create index on t (a);
> vacuum analyze;
On Thu, Oct 06, 2022 at 01:52:46PM +0900, Michael Paquier wrote:
> For the archives' sake: this has been applied as of 6a20b04 and
> c3315a7.
Corey (added in CC.), has noticed that the issue fixed by c3315a7 in
16~ for advisory locks is not complicated to reach, leading to
failures in some of our
On Tue, Sep 24, 2024 at 9:02 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Tuesday, September 24, 2024 5:05 AM Masahiko Sawada
> wrote:
> >
> > Thank you for considering another idea.
>
> Thanks for reviewing the idea!
>
> >
> > On Fri, Sep 20, 2024 at 2:46 AM Amit Kapila wrote:
> > >
> > > On Fri, Sep
Updated the patch.
On 2024-07-23 23:06, torikoshia wrote:
On Tue, Jul 23, 2024 at 1:35 PM Fujii Masao
wrote:
Thanks for your review.
On 2024/07/22 21:37, torikoshia wrote:
On Fri, Jul 19, 2024 at 11:48 PM Junwang Zhao
wrote:
Thanks for the comment.
In patch 0002, the ratio is calculate
> On 23 Sep 2024, at 19:17, Tom Lane wrote:
> Daniel Gustafsson writes:
>
>> There is an ERRCODE_INTERNAL_ERROR in xml_out_internal() which seems a tad
>> odd
>> given that any error would be known to be parsing related and b) are caused
>> by
>> libxml and not internally. Not sure if it's wo
On Sat, Sep 21, 2024 at 5:15 AM Alvaro Herrera wrote:
>
> Okay, so here is v4 with these problems fixed, including correct
> propagation of constraint names to children tables, which I had
> inadvertently broken earlier. This one does pass the pg_upgrade tests
> and as far as I can see pg_dump do
78 matches
Mail list logo
