Re: Clock-skew management in logical replication

2024-09-20 Thread shihao zhong
Nisha Moond writes: > Thoughts? Looking forward to hearing others' opinions! Had a productive conversation with Amit Kaplia today about time skew in distributed systems, and wanted to share some thoughts. Essentially, we're grappling with the classic distributed snapshot problem. In a multi-activ

Re: pg_checksums: Reorder headers in alphabetical order

2024-09-20 Thread Fujii Masao
On 2024/09/21 12:09, Tom Lane wrote: Fujii Masao writes: I don’t have any objections to this commit, but I’d like to confirm whether we really want to proactively reorder #include directives, even for standard C library headers. I'm hesitant to do that. We can afford to insist that our ow

Re: pg_checksums: Reorder headers in alphabetical order

2024-09-20 Thread Tom Lane
Fujii Masao writes: > I don’t have any objections to this commit, but I’d like to confirm > whether we really want to proactively reorder #include directives, > even for standard C library headers. I'm hesitant to do that. We can afford to insist that our own header files be inclusion-order-inde

Re: pg_checksums: Reorder headers in alphabetical order

2024-09-20 Thread Fujii Masao
On 2024/09/21 5:20, Nathan Bossart wrote: On Fri, Sep 20, 2024 at 01:56:16PM -0500, Nathan Bossart wrote: On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote: I noticed two headers are not in alphabetical order in pg_checkums.c, patch attached. This appears to be commit 280e5f1's

Re: meson and check-tests

2024-09-20 Thread jian he
On Fri, Sep 20, 2024 at 6:25 PM Nazir Bilal Yavuz wrote: > > Hi, > > I’ve been working on a patch and wanted to share my approach, which > might be helpful for others. The patch removes the '--schedule' and > '${schedule_file}' options from the regress/regress test command when > the TESTS environ

Re: meson and check-tests

2024-09-20 Thread Nazir Bilal Yavuz
Hi, I’ve been working on a patch and wanted to share my approach, which might be helpful for others. The patch removes the '--schedule' and '${schedule_file}' options from the regress/regress test command when the TESTS environment variable is set. Instead, it appends the TESTS variable to the end

Clock-skew management in logical replication

2024-09-20 Thread Nisha Moond
Hello Hackers, (CC people involved in the earlier discussion) While considering the implementation of timestamp-based conflict resolution (last_update_wins) in logical replication (see [1]), there was a feedback at [2] and the discussion on whether or not to manage clock-skew at database level. We

Re: Documentation to upgrade logical replication cluster

2024-09-20 Thread Amit Kapila
On Mon, May 6, 2024 at 10:40 AM vignesh C wrote: > > The v9 version patch was not applying on top of HEAD because of few > commits, the updated v10 version patch is rebased on top of HEAD. > Let's say publisher is in node1 and subscriber is + in node2. The subscriber node2 has + two sub

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2024-09-20 Thread Tomas Vondra
On 9/19/24 21:22, Peter Geoghegan wrote: > On Mon, Sep 16, 2024 at 6:05 PM Tomas Vondra wrote: >> For example, one of the slowed down queries is query 702 (top of page 8 >> in the PDF). The query is pretty simple: >> >> explain (analyze, timing off, buffers off) >> select id1,id2 from t_10

RE: Using per-transaction memory contexts for storing decoded tuples

2024-09-20 Thread Hayato Kuroda (Fujitsu)
Dear Sawada-san, > Thank you for your interest in this patch. I've just shared some > benchmark results (with a patch) that could be different depending on > the environment[1]. I would be appreciated if you also do similar > tests and share the results. Okay, I did similar tests, the attached sc

FullTransactionIdAdvance question

2024-09-20 Thread Andy Fan
Hi, static inline void FullTransactionIdAdvance(FullTransactionId *dest) { dest->value++; /* see FullTransactionIdAdvance() */ if (FullTransactionIdPrecedes(*dest, FirstNormalFullTransactionId)) return; while (XidFromFullTransactionId(*dest) < Fi

Re: Allow logical failover slots to wait on synchronous replication

2024-09-20 Thread shveta malik
On Thu, Sep 19, 2024 at 12:02 PM Amit Kapila wrote: > > On Tue, Sep 17, 2024 at 9:08 AM shveta malik wrote: > > > > On Mon, Sep 16, 2024 at 4:04 PM Amit Kapila wrote: > > > > > > On Mon, Sep 16, 2024 at 2:55 PM shveta malik > > > wrote: > > > > > > > > On Mon, Sep 16, 2024 at 11:13 AM Amit Kap

Re: Conflict detection for update_deleted in logical replication

2024-09-20 Thread Amit Kapila
On Fri, Sep 20, 2024 at 8:25 AM Zhijie Hou (Fujitsu) wrote: > > Apart from the vacuum_defer_cleanup_age idea. > I think you meant to say vacuum_committs_age idea. > we’ve given more thought to our > approach for retaining dead tuples and have come up with another idea that can > reliably detect

Re: [PATCH] Support Int64 GUCs

2024-09-20 Thread Alexander Korotkov
Hi, Aleksander! Thank you for your work on this subject. On Thu, Sep 12, 2024 at 2:08 PM Aleksander Alekseev wrote: > Attached is a self-sufficient patch extracted from a larger patchset > [1]. The entire patchset probably will not proceed further in the > nearest future. Since there was interes

Why mention to Oracle ?

2024-09-20 Thread Marcos Pegoraro
Why PostgreSQL DOCs needs to show or compare the Oracle way of doing things ? I understand that on page Porting from Oracle PL/SQL is ok to mention Oracle, but there are other places where it's not needed. Or, if it's ok to mention, why not mention SQL Server or MySQL or any other ? Bug Reporting

Re: not null constraints, again

2024-09-20 Thread Alvaro Herrera
On 2024-Sep-20, Tender Wang wrote: > By the way, the v3 failed applying on Head(d35e293878) > git am v3-0001-Catalog-not-null-constraints.patch > Applying: Catalog not-null constraints > error: patch failed: doc/src/sgml/ref/create_table.sgml:77 Yeah, there's a bunch of conflicts in current mast

Re: not null constraints, again

2024-09-20 Thread jian he
> > We only have this Synopsis > > ALTER [ COLUMN ] column_name { SET | DROP } NOT NULL > > Yeah, this syntax is intended to add a "normal" not-null constraint, > i.e. one that inherits. > > > --tests from src/test/regress/sql/inherit.sql > > CREATE TABLE inh_nn_parent (a int, NOT NULL a NO INHERIT

Re: SQLFunctionCache and generic plans

2024-09-20 Thread Alexander Korotkov
Hi, Alexander! On Tue, Sep 3, 2024 at 10:33 AM Alexander Pyhalov wrote: > Tom Lane писал(а) 2023-02-07 18:29: > > Ronan Dunklau writes: > >> The following comment can be found in functions.c, about the > >> SQLFunctionCache: > > > >> * Note that currently this has only the lifespan of the calli

Re: not null constraints, again

2024-09-20 Thread Alvaro Herrera
On 2024-Sep-20, jian he wrote: > about set_attnotnull. > > we can make set_attnotnull look less recursive. > instead of calling find_inheritance_children, > let's just one pass, directly call find_all_inheritors > overall, I think it would be more intuitive. > > please check the attached refac

Re: [PATCH] Support Int64 GUCs

2024-09-20 Thread Alexander Korotkov
On Thu, Sep 12, 2024 at 2:29 PM Pavel Borisov wrote: > Hi, Alexander! > Thank you for working on this! > > On Thu, 12 Sept 2024 at 15:08, Aleksander Alekseev > wrote: >> >> Hi, >> >> Attached is a self-sufficient patch extracted from a larger patchset >> [1]. The entire patchset probably will no

Re: Documentation to upgrade logical replication cluster

2024-09-20 Thread vignesh C
On Fri, 20 Sept 2024 at 16:24, Amit Kapila wrote: > > On Mon, May 6, 2024 at 10:40 AM vignesh C wrote: > > > > The v9 version patch was not applying on top of HEAD because of few > > commits, the updated v10 version patch is rebased on top of HEAD. > > > > Let's say publisher is in node1 and subs

Re: attndims, typndims still not enforced, but make the value within a sane threshold

2024-09-20 Thread Junwang Zhao
Hi Tom and Michael, On Fri, Sep 20, 2024 at 12:38 PM Tom Lane wrote: > > Michael Paquier writes: > > On Fri, Sep 20, 2024 at 11:51:49AM +0800, Junwang Zhao wrote: > >> Should you also bump the catalog version? > > > No need to worry about that when sending a patch because committers > > take car

Re: not null constraints, again

2024-09-20 Thread jian he
about set_attnotnull. we can make set_attnotnull look less recursive. instead of calling find_inheritance_children, let's just one pass, directly call find_all_inheritors overall, I think it would be more intuitive. please check the attached refactored set_attnotnull. regress test passed, i onl

Re: Pgoutput not capturing the generated columns

2024-09-20 Thread Shubham Khanna
On Tue, Sep 17, 2024 at 1:14 PM Peter Smith wrote: > > Here are some review comments for v31-0001 (for the docs only) > > There may be some overlap here with some comments already made for > v30-0001 which are not yet addressed in v31-0001. > > == > Commit message > > 1. > When introducing the

Re: Pgoutput not capturing the generated columns

2024-09-20 Thread Shubham Khanna
On Tue, Sep 17, 2024 at 3:12 PM Peter Smith wrote: > > Review comments for v31-0001. > > (I tried to give only new comments, but there might be some overlap > with comments I previously made for v30-0001) > > == > src/backend/catalog/pg_publication.c > > 1. > + > + if (publish_generated_column

Re: Pgoutput not capturing the generated columns

2024-09-20 Thread Shubham Khanna
On Wed, Sep 18, 2024 at 8:58 AM Peter Smith wrote: > > Hi, here are my review comments for patch v31-0002. > > == > > 1. General. > > IMO patches 0001 and 0002 should be merged when next posted. IIUC the > reason for the split was only because there were 2 different authors > but that seems to

Re: Should rolpassword be toastable?

2024-09-20 Thread Jonathan S. Katz
On 9/20/24 1:23 AM, Michael Paquier wrote: On Thu, Sep 19, 2024 at 09:46:00PM -0500, Nathan Bossart wrote: On Thu, Sep 19, 2024 at 07:37:55PM -0400, Jonathan S. Katz wrote: Shouldn't we enforce the limit in every case in encrypt_password, not just this one? (I do agree that encrypt_password is

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2024-09-20 Thread Tomas Vondra
On 9/18/24 20:52, Peter Geoghegan wrote: > On Wed, Sep 18, 2024 at 7:36 AM Tomas Vondra wrote: >> Makes sense. I started with the testing before before even looking at >> the code, so it's mostly a "black box" approach. I did read the 1995 >> paper before that, and the script generates queries wit

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2024-09-20 Thread Peter Geoghegan
On Fri, Sep 20, 2024 at 9:45 AM Tomas Vondra wrote: > 3) restart cluster, drop caches > > 4) run the query from the SQL script > > I suspect you don't do (3). I didn't mention this explicitly, my message > only said "with uncached data", so maybe that's the problem? You're right that I didn't do

Re: Clock-skew management in logical replication

2024-09-20 Thread Tom Lane
Nisha Moond writes: > While considering the implementation of timestamp-based conflict > resolution (last_update_wins) in logical replication (see [1]), there > was a feedback at [2] and the discussion on whether or not to manage > clock-skew at database level. FWIW, I cannot see why we would do

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2024-09-20 Thread Tomas Vondra
On 9/20/24 16:21, Peter Geoghegan wrote: > On Fri, Sep 20, 2024 at 9:45 AM Tomas Vondra wrote: >> 3) restart cluster, drop caches >> >> 4) run the query from the SQL script >> >> I suspect you don't do (3). I didn't mention this explicitly, my message >> only said "with uncached data", so maybe th

Re: Should rolpassword be toastable?

2024-09-20 Thread Nathan Bossart
On Fri, Sep 20, 2024 at 10:06:28AM -0400, Jonathan S. Katz wrote: > On 9/20/24 1:23 AM, Michael Paquier wrote: >> Not sure. Is this really something we absolutely need? Sure, this >> generates a better error when inserting a record too long to >> pg_authid, but removing the toast relation is enou

Re: [Proposal] Add foreign-server health checks infrastructure

2024-09-20 Thread Fujii Masao
On 2024/09/20 12:00, Hayato Kuroda (Fujitsu) wrote: Dear members, (This mail is just a wrap-up) I found that the final patch was pushed 2 days ago [1] and BF animals say OK for now. Therefore, I've closed the CF entry as "committed". Thanks! We can extend the feature to other platforms,

Re: Large expressions in indexes can't be stored (non-TOASTable)

2024-09-20 Thread Nathan Bossart
On Fri, Sep 20, 2024 at 08:16:24AM +0900, Michael Paquier wrote: > Perhaps the reason why these snapshots are pushed should be documented > with a comment? Definitely. I'll add those once we are more confident that we've identified all the bugs. -- nathan

Re: Large expressions in indexes can't be stored (non-TOASTable)

2024-09-20 Thread Nathan Bossart
On Fri, Sep 20, 2024 at 07:00:00AM +0300, Alexander Lakhin wrote: > I've found another two paths to reach that condition: > CREATE INDEX CONCURRENTLY ON def (vec_quantizer(id, :'b')); > ERROR:  cannot fetch toast data without an active snapshot > > REINDEX INDEX CONCURRENTLY def_vec_quantizer_idx;

Re: pg_checksums: Reorder headers in alphabetical order

2024-09-20 Thread Nathan Bossart
On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote: > I noticed two headers are not in alphabetical order in pg_checkums.c, > patch attached. This appears to be commit 280e5f1's fault. Will fix. -- nathan

Re: Cleaning up ERRCODE usage in our XML code

2024-09-20 Thread Tom Lane
I wrote: > [ v1-clean-up-errcodes-for-xml.patch ] Per cfbot, rebased over d5622acb3. No functional changes. regards, tom lane diff --git a/contrib/xml2/xpath.c b/contrib/xml2/xpath.c index 0fdf735faf..ef78aa00c8 100644 --- a/contrib/xml2/xpath.c +++ b/contrib/xml2/xpath.

pgbench: Improve result outputs related to failed transactinos

2024-09-20 Thread Yugo Nagata
Hi, I would like to improve the following two points on the result outputs of pgbench related to faild transaction. The patch is attached. (1) Output per-script statistics even when there are no successful transaction if there is any failed transactions due to serialization or deadlock errors. P

Re: Should rolpassword be toastable?

2024-09-20 Thread Tom Lane
Nathan Bossart writes: > Here is a v3 patch set that fixes the test comment and a compiler warning > in cfbot. Nitpick: the message should say "%d bytes" not "%d characters", because we're counting bytes. Passes an eyeball check otherwise. regards, tom lane

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2024-09-20 Thread Peter Geoghegan
On Fri, Sep 20, 2024 at 10:59 AM Peter Geoghegan wrote: > On Fri, Sep 20, 2024 at 10:07 AM Tomas Vondra wrote: > > Yes, I think backpatching to 17 would be fine. I'd be worried about > > maybe disrupting some monitoring in production systems, but for 17 that > > shouldn't be a problem yet. So fin

Re: Why mention to Oracle ?

2024-09-20 Thread Tomas Vondra
On 9/20/24 19:48, Marcos Pegoraro wrote: > Em sex., 20 de set. de 2024 às 13:18, David G. Johnston > mailto:david.g.johns...@gmail.com>> escreveu: > > It would be a boon to the community if someone were to put together > a web/wiki page or mini-app that details this kind of information >

Re: FullTransactionIdAdvance question

2024-09-20 Thread Andres Freund
Hi, On 2024-09-20 17:38:40 +0800, Andy Fan wrote: > static inline void > FullTransactionIdAdvance(FullTransactionId *dest) > { > dest->value++; > > /* see FullTransactionIdAdvance() */ > if (FullTransactionIdPrecedes(*dest, FirstNormalFullTransactionId)) > return;

Re: First draft of PG 17 release notes

2024-09-20 Thread Laurenz Albe
On Fri, 2024-09-20 at 10:02 -0400, Jonathan S. Katz wrote: > Attached is a proposal for the major features section. This borrows from > the release announcement draft[1] and lists out features and themes that > have broad user impact. This was a bit challenging for this release, > because there

Re: pgsql: Don't enter parallel mode when holding interrupts.

2024-09-20 Thread Noah Misch
On Thu, Sep 19, 2024 at 09:25:05AM -0400, Robert Haas wrote: > On Wed, Sep 18, 2024 at 3:27 AM Laurenz Albe wrote: > > On Wed, 2024-09-18 at 02:58 +, Noah Misch wrote: > > > Don't enter parallel mode when holding interrupts. > > > > > > Doing so caused the leader to hang in wait_event=Parallel

Re: First draft of PG 17 release notes

2024-09-20 Thread Tom Lane
Bruce Momjian writes: > Patch applied to PG 17. I don't see a push? regards, tom lane

Re: First draft of PG 17 release notes

2024-09-20 Thread Laurenz Albe
On Fri, 2024-09-20 at 13:47 -0400, Jonathan S. Katz wrote: > Please see attached. > + > + > + Various query performance improvements, including to sequential reads > + using streaming I/O, write throughput under high concurrency, and > + searches over multiple values in a b

Re: First draft of PG 17 release notes

2024-09-20 Thread Bruce Momjian
On Fri, Sep 20, 2024 at 04:05:11PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Patch applied to PG 17. > > I don't see a push? Push was delayed because my test script found some uncommitted files due to earlier testing. Should be fine now. -- Bruce Momjian https://momjian.us

Re: pg_checksums: Reorder headers in alphabetical order

2024-09-20 Thread Nathan Bossart
On Fri, Sep 20, 2024 at 01:56:16PM -0500, Nathan Bossart wrote: > On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote: >> I noticed two headers are not in alphabetical order in pg_checkums.c, >> patch attached. > > This appears to be commit 280e5f1's fault. Will fix. Committed, thanks!

Re: First draft of PG 17 release notes

2024-09-20 Thread Tom Lane
Laurenz Albe writes: > [ assorted corrections ] I fixed a couple of these before seeing your message. regards, tom lane

Re: pg_checksums: Reorder headers in alphabetical order

2024-09-20 Thread Michael Banck
On Fri, Sep 20, 2024 at 03:20:16PM -0500, Nathan Bossart wrote: > On Fri, Sep 20, 2024 at 01:56:16PM -0500, Nathan Bossart wrote: > > On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote: > >> I noticed two headers are not in alphabetical order in pg_checkums.c, > >> patch attached. > > >

Re: Pgoutput not capturing the generated columns

2024-09-20 Thread Masahiko Sawada
On Thu, Sep 19, 2024 at 9:26 PM Amit Kapila wrote: > > On Fri, Sep 20, 2024 at 4:16 AM Peter Smith wrote: > > > > On Fri, Sep 20, 2024 at 3:26 AM Masahiko Sawada > > wrote: > > > > > > On Thu, Sep 19, 2024 at 2:32 AM Amit Kapila > > > wrote: > > > > > > > > > > > > Users can use a publication

Re: Why mention to Oracle ?

2024-09-20 Thread Marcos Pegoraro
Em sex., 20 de set. de 2024 às 15:11, Tomas Vondra escreveu: > IMHO it's quite reasonable to say "we do X, but this other product > (which is what we try to mimic) does Y". > Ok, for Data Type Formatting Functions is fine, if they were really copied from, but the others ... Bug Reporting Guideli

Re: Why mention to Oracle ?

2024-09-20 Thread Jonah H. Harris
On Fri, Sep 20, 2024 at 4:27 PM Marcos Pegoraro wrote: > Em sex., 20 de set. de 2024 às 15:11, Tomas Vondra > escreveu: > >> IMHO it's quite reasonable to say "we do X, but this other product >> (which is what we try to mimic) does Y". >> > > Ok, for Data Type Formatting Functions is fine, if th

Re: Why mention to Oracle ?

2024-09-20 Thread Roberto Mello
On Fri, Sep 20, 2024 at 11:43 AM Marcos Pegoraro wrote: > > My suggestion is: Postgres DOCs are written and have to be read by > Postgres users, just that. If you are Oracle user, search for a tutorial on > how to migrate to Postgres or find tools for it, but not in DOCs > As Tomas, Tom and othe

Re: Why mention to Oracle ?

2024-09-20 Thread Tomas Vondra
On 9/20/24 14:36, Marcos Pegoraro wrote: > Why PostgreSQL DOCs needs to show or compare the Oracle way of doing > things ? > > I understand that on page Porting from Oracle PL/SQL is ok to mention > Oracle, but there are other places where it's not needed. Or, if it's ok > to mention, why not m

pg_checksums: Reorder headers in alphabetical order

2024-09-20 Thread Michael Banck
Hi, I noticed two headers are not in alphabetical order in pg_checkums.c, patch attached. Michael >From e4d6d6503b4c14685424c6a04c5eb2ae29024bf6 Mon Sep 17 00:00:00 2001 From: Michael Banck Date: Fri, 20 Sep 2024 19:17:43 +0200 Subject: [PATCH] Reorder headers in pg_checkums.c in alphabetical o

Re: Using per-transaction memory contexts for storing decoded tuples

2024-09-20 Thread Masahiko Sawada
On Thu, Sep 19, 2024 at 10:46 PM Amit Kapila wrote: > > On Fri, Sep 20, 2024 at 5:13 AM David Rowley wrote: > > > > On Fri, 20 Sept 2024 at 05:03, Masahiko Sawada > > wrote: > > > I've done other benchmarking tests while changing the memory block > > > sizes from 8kB to 8MB. I measured the exec

Re: [18] Fix a few issues with the collation cache

2024-09-20 Thread Jeff Davis
On Wed, 2024-08-14 at 16:30 -0700, Jeff Davis wrote: > On Thu, 2024-08-08 at 12:24 -0700, Jeff Davis wrote: > > The collation cache, which maps collation oids to pg_locale_t > > objects, > > has a few longstanding issues: > > Here's a patch set v2. Updated and rebased. Regards, Jeff Davi

Re: Allow logical failover slots to wait on synchronous replication

2024-09-20 Thread John H
Hi, On Mon, Sep 16, 2024 at 2:25 AM shveta malik wrote: > > > > > > If we don't do something similar, then aren't there chances that we > > > keep on waiting on the wrong lsn[mode] for the case when mode = > > > SYNC_REP_WAIT_APPLY while sync-rep-wait infrastructure is updating > > > different m

Re: Why don't we consider explicit Incremental Sort?

2024-09-20 Thread Richard Guo
On Sun, Sep 15, 2024 at 6:01 AM Tomas Vondra wrote: > Hmmm ... I wasn't involved in that discussion and I haven't studied the > thread now, but this seems a bit weird to me. If the presorted keys have > low cardinality, can't the full sort be faster? > > Maybe it's not possible with the costing ch

Re: not null constraints, again

2024-09-20 Thread Alvaro Herrera
On 2024-Sep-20, Tender Wang wrote: > jian he 于2024年9月20日周五 11:34写道: > > > another bug. > > I will dig later, just want to share it first. > > > > minimum producer: > > drop table if exists pp1,cc1, cc2,cc3; > > create table pp1 (f1 int ); > > create table cc1 () inherits (pp1); > > create table

Re: attndims, typndims still not enforced, but make the value within a sane threshold

2024-09-20 Thread Bruce Momjian
On Fri, Sep 20, 2024 at 10:11:00AM +0800, jian he wrote: > On Wed, Sep 18, 2024 at 10:35 PM jian he wrote: > > > > > The last time this was discussed, I think the conclusion was > > > we should remove attndims and typndims entirely on the grounds > > > that they're useless. I certainly don't see

Re: First draft of PG 17 release notes

2024-09-20 Thread Jonathan S. Katz
On 5/9/24 12:03 AM, Bruce Momjian wrote: I have committed the first draft of the PG 17 release notes; you can see the results here: release-17: 188 I welcome feedback. For some reason it was an easier job than usual. Attached is a proposal for the major features section. This borro

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2024-09-20 Thread Peter Geoghegan
On Fri, Sep 20, 2024 at 10:07 AM Tomas Vondra wrote: > Yes, I think backpatching to 17 would be fine. I'd be worried about > maybe disrupting some monitoring in production systems, but for 17 that > shouldn't be a problem yet. So fine with me. I'll commit minimal changes to _bt_first that at leas

Re: Why mention to Oracle ?

2024-09-20 Thread Tom Lane
Tomas Vondra writes: > On 9/20/24 14:36, Marcos Pegoraro wrote: >> Why PostgreSQL DOCs needs to show or compare the Oracle way of doing >> things ? > I didn't dig into all the places you mention, but I'd bet those places > reference Oracle simply because it was the most common DB people either >

Re: Why mention to Oracle ?

2024-09-20 Thread David G. Johnston
On Fri, Sep 20, 2024 at 5:37 AM Marcos Pegoraro wrote: > Why PostgreSQL DOCs needs to show or compare the Oracle way of doing > things ? > > I understand that on page Porting from Oracle PL/SQL is ok to mention > Oracle, but there are other places where it's not needed. Or, if it's ok to > mentio

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2024-09-20 Thread Fujii Masao
On 2024/09/19 19:16, Anton A. Melnikov wrote: On 18.09.2024 21:04, Fujii Masao wrote: -    CreateCheckPoint(flags); -    ckpt_performed = true; +    ckpt_performed = CreateCheckPoint(flags); This change could result in the next scheduled checkpoint being

Re: Why mention to Oracle ?

2024-09-20 Thread Marcos Pegoraro
Em sex., 20 de set. de 2024 às 12:53, Tom Lane escreveu: > As far as the mentions in "Data Type Formatting Functions" go, those > are there because those functions are not in the SQL standard; we > stole the API definitions for them from Oracle, lock stock and barrel. > (Except for the discrepanc

Re: Why mention to Oracle ?

2024-09-20 Thread Marcos Pegoraro
Em sex., 20 de set. de 2024 às 11:56, Tomas Vondra escreveu: > It's not quite clear to me whether your suggestion is to not mention any > other databases ever, or to always mention every existing one. ;-) > My suggestion is: Postgres DOCs are written and have to be read by Postgres users, just t

Re: First draft of PG 17 release notes

2024-09-20 Thread Jonathan S. Katz
On 9/20/24 12:55 PM, Laurenz Albe wrote: On Fri, 2024-09-20 at 10:02 -0400, Jonathan S. Katz wrote: Attached is a proposal for the major features section. This borrows from the release announcement draft[1] and lists out features and themes that have broad user impact. This was a bit challenging

Re: Why mention to Oracle ?

2024-09-20 Thread Marcos Pegoraro
Em sex., 20 de set. de 2024 às 13:18, David G. Johnston < david.g.johns...@gmail.com> escreveu: > It would be a boon to the community if someone were to put together a > web/wiki page or mini-app that details this kind of information and, if > considered accurate and relevant enough by the communi

Re: Why mention to Oracle ?

2024-09-20 Thread Tomas Vondra
On 9/20/24 19:31, Marcos Pegoraro wrote: > Em sex., 20 de set. de 2024 às 12:53, Tom Lane > escreveu: > > As far as the mentions in "Data Type Formatting Functions" go, those > are there because those functions are not in the SQL standard; we > stole the

Re: First draft of PG 17 release notes

2024-09-20 Thread Bruce Momjian
On Fri, Sep 20, 2024 at 01:47:43PM -0400, Jonathan Katz wrote: > On 9/20/24 12:55 PM, Laurenz Albe wrote: > > On Fri, 2024-09-20 at 10:02 -0400, Jonathan S. Katz wrote: > > > Attached is a proposal for the major features section. This borrows from > > > the release announcement draft[1] and lists o

Re: Allow logical failover slots to wait on synchronous replication

2024-09-20 Thread John H
Hi, On Fri, Sep 20, 2024 at 2:44 AM shveta malik wrote: > > > > > > > The difference is that the purpose of 'synchronized_standby_slots' is > > to mention slot names for which the user expects logical walsenders to > > wait before sending the logical changes to subscribers. OTOH, > > 'synchronous