Hi Tom and Michael, On Fri, Sep 20, 2024 at 12:38 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Michael Paquier <mich...@paquier.xyz> writes: > > On Fri, Sep 20, 2024 at 11:51:49AM +0800, Junwang Zhao wrote: > >> Should you also bump the catalog version? > > > No need to worry about that when sending a patch because committers > > take care of that when merging a patch into the tree. Doing that in > > each patch submitted just creates more conflicts and work for patch > > authors because they'd need to recolve conflicts each time a > > catversion bump happens. And that can happen on a daily basis > > sometimes depending on what is committed. > > Right. Sometimes the committer forgets to do that :-(, which is > not great but it's not normally a big problem either. We've concluded > it's better to err in that direction than impose additional work > on patch submitters. > > If you feel concerned about the point, best practice is to include a > mention that catversion bump is needed in your draft commit message. > > regards, tom lane
Got it, thanks for both of your explanations. -- Regards Junwang Zhao
