Re: Add pg_get_acl() function get the ACL for a database object

2024-07-04 Thread Michael Paquier
On Tue, Jul 02, 2024 at 12:38:07PM +0200, Joel Jacobson wrote: > Rebased version. > Uses ACL acronym added in commit 00d819d46a6f5b7e9d2e02948a1c80d11c4ce260: > doc: Add ACL acronym for "Access Control List" Forgot to push the send button for this one yesterday, done now.. While looking at th

Re: Add new COPY option REJECT_LIMIT

2024-07-04 Thread Fujii Masao
On 2024/07/04 12:05, torikoshia wrote: I'm going to update it after discussing the option format as described below. Thanks! I agree that it's possible to use only REJECT_LIMIT without ON_ERROR. I also think it's easy to understand that REJECT_LIMIT=0 is ON_ERROR=stop. However, expressing

Re: Use generation memory context for tuplestore.c

2024-07-04 Thread Alexander Lakhin
Hello David, 03.07.2024 13:41, David Rowley wrote: Lastly, I think this would benefit from a test in regress/sql/explain.sql, as the test changes that were included removed the only occurrance of a Materialize node from the regression tests' EXPLAIN outputs. I've modified the tests where the

Re: Update platform notes to build Postgres on macos

2024-07-04 Thread Kashif Zeeshan
Hi I think the documentation should be updated and all pre-reqs must be added. Regards Kashif Zeeshan On Thu, Jul 4, 2024 at 11:02 PM Said Assemlal wrote: > Hi, > > > I just built postgresql on macos sonoma (v14) and I had to install the > following packages: > >- * icu - https://ports.

Re: Logical Replication of sequences

2024-07-04 Thread Peter Smith
Hi Vignesh. After applying the v20240703-0003 patch, I was always getting errors when running the subscription TAP tests. # +++ tap check in src/test/subscription +++ t/001_rep_changes.pl ... ok t/002_types.pl . ok t/003_constraints.pl ... ok t/004_sync

Re: Flush pgstats file during checkpoints

2024-07-04 Thread Michael Paquier
On Sat, Jun 29, 2024 at 11:13:04PM +0200, Tomas Vondra wrote: > I think those are two independent issues - knowing that the snapshot is > from the last checkpoint, and knowing that it's correct (not corrupted). > And yeah, we should be careful about fsync/durable_rename. Yeah, that's bugging me as

Re: Use generation memory context for tuplestore.c

2024-07-04 Thread David Rowley
On Fri, 5 Jul 2024 at 16:00, Alexander Lakhin wrote: > Please look at a segfault crash introduced with 1eff8279d: > CREATE TABLE t1(i int); > CREATE TABLE t2(i int) PARTITION BY RANGE (i); > CREATE TABLE t2p PARTITION OF t2 FOR VALUES FROM (1) TO (2); > > EXPLAIN ANALYZE SELECT * FROM t1 JOIN t2 O

Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows

2024-07-04 Thread Michael Paquier
On Sat, Jun 29, 2024 at 07:12:11PM -0700, Noah Misch wrote: > Commits 9886744 and b83747a added /D to two %comspec% callers. I gather they > arose to make particular cmd.exe invocations have just one child. However, > http://postgr.es/m/20240111.173322.1809044112677090191.horikyota@gmail.com

Re: Test to dump and restore objects left behind by regression

2024-07-04 Thread Michael Paquier
On Fri, Jun 28, 2024 at 06:00:07PM +0530, Ashutosh Bapat wrote: > Here's a description of patches and some notes > 0001 > --- > 1. Per your suggestion the logic to handle dump output differences is > externalized in PostgreSQL::Test::AdjustDump. Instead of eliminating those > differences altoge

Re: walsender.c comment with no context is hard to understand

2024-07-04 Thread Amit Kapila
On Fri, Jun 28, 2024 at 6:30 PM Bertrand Drouvot wrote: > > On Fri, Jun 28, 2024 at 03:15:22PM +0530, Amit Kapila wrote: > > On Fri, Jun 28, 2024 at 12:55 PM Peter Smith wrote: > > > > > > > I don't know whether your assumption is correct. AFAICS, those two > > lines should be together. Let us ee

Re: Use generation memory context for tuplestore.c

2024-07-04 Thread David Rowley
On Wed, 3 Jul 2024 at 22:41, David Rowley wrote: > > On Wed, 3 Jul 2024 at 00:20, Matthias van de Meent > > Lastly, I think this would benefit from a test in > > regress/sql/explain.sql, as the test changes that were included > > removed the only occurrance of a Materialize node from the regressio

Re: Conflict Detection and Resolution

2024-07-04 Thread Dilip Kumar
On Thu, Jul 4, 2024 at 5:37 PM Amit Kapila wrote: > > So, the situation will be the same. We can even > > > decide to spill the data to files if the decision is that we need to > > > wait to avoid network buffer-fill situations. But note that the wait > > > in apply worker has consequences that t

Re: walsender.c comment with no context is hard to understand

2024-07-04 Thread Amit Kapila
On Mon, Jul 1, 2024 at 5:04 AM Peter Smith wrote: > > On Fri, Jun 28, 2024 at 4:18 PM Amit Kapila wrote: > > > ... > > Shouldn't the check for flushptr (if (flushptr < targetPagePtr + > > reqLen)) be moved immediately after the call to WalSndWaitForWal(). > > The comment seems to suggests the sam

<    1   2