On Mon, Jul 1, 2024 at 5:04 AM Peter Smith <smithpb2...@gmail.com> wrote: > > On Fri, Jun 28, 2024 at 4:18 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > ... > > Shouldn't the check for flushptr (if (flushptr < targetPagePtr + > > reqLen)) be moved immediately after the call to WalSndWaitForWal(). > > The comment seems to suggests the same: "Make sure we have enough WAL > > available before retrieving the current timeline. .." > > OK, I have changed the code as suggested. Please see the attached v2 patch. >
LGTM. I'll push this early next week unless someone thinks otherwise. I have added a commit message in the attached. -- With Regards, Amit Kapila.
v3-0001-To-improve-the-code-move-the-error-check-in-logic.patch
Description: Binary data
