On Tue, Feb 13, 2024 at 01:13:43AM +0900, Yugo NAGATA wrote:
> I attached an updated patch that adds comments noting to use
> IsQueryIdEnabled()
> instead of accessing the variables directly.
Sounds good to me, thanks.
--
Michael
signature.asc
Description: PGP signature
Hi,
In <20240209192705.5qdilvviq3py2...@awork3.anarazel.de>
"Re: Make COPY format extendable: Extract COPY TO format implementations" on
Fri, 9 Feb 2024 11:27:05 -0800,
Andres Freund wrote:
>> +static void
>> +CopyFromTextInFunc(CopyFromState cstate, Oid atttypid,
>> +
On Mon, Feb 12, 2024 at 11:30:40PM -0500, shihao zhong wrote:
> I'd like to bring to your attention that I recently identified some
> functions in pgcrypto that are using PG_GETARG functions in a way that
> doesn't match the expected function signature of the stored
> procedures. This patch propose
On Tue, Feb 13, 2024 at 12:41 AM Andres Freund wrote:
> Hi,
>
> On 2024-02-12 17:04:23 -0600, Nathan Bossart wrote:
> > On Mon, Feb 12, 2024 at 01:31:30PM -0800, Andres Freund wrote:
> > > One thing that's worth checking is if this ends up with *worse* code
> when the
> > > comparators are inline
On Mon, Feb 12, 2024 at 7:59 AM Amit Kapila wrote:
>
> On Fri, Feb 9, 2024 at 9:32 PM Shubham Khanna
> wrote:
> >
> > Currently the documentation of upgrade for streaming replication
> > section says that logical replication slots will be copied
> > irrespective of the version, but the logical re
On Mon, 2024-02-12 at 12:24 -0500, Corey Huinker wrote:
> > Do you plan to add it to the commitfest? If yes, I'd set it "ready for
> > committer".
>
> Commitfest entry reanimated.
Truly... you created a revenant in the already closed commitfest.
I closed that again and added a new entry in th
On Tue, Feb 13, 2024 at 1:03 AM Jeff Davis wrote:
>
> For 0004, we need to resolve why callers are using XLOG_BLCKSZ and we
> can fix that independently, as discussed here:
>
> https://www.postgresql.org/message-id/CALj2ACV=C1GZT9XQRm4iN1NV1T=hla_hsgwnx2y5-g+mswd...@mail.gmail.com
Thanks. I start
On Fri, Feb 9, 2024 at 10:04 AM Amit Kapila wrote:
>
> +reserve_wal_for_local_slot(XLogRecPtr restart_lsn)
> {
> ...
> + /*
> + * Find the oldest existing WAL segment file.
> + *
> + * Normally, we can determine it by using the last removed segment
> + * number. However, if no WAL segment files ha
On 13/2/2024 07:00, jian he wrote:
+ newa = makeNode(ArrayExpr);
+ /* array_collid will be set by parse_collate.c */
+ newa->element_typeid = scalar_type;
+ newa->array_typeid = array_type;
+ newa->multidims = false;
+ newa->elements = aexprs;
+ newa->location = -1;
I am confused by the comments
On 12/2/2024 17:51, Alena Rybakina wrote:
On 12.02.2024 12:01, Andrei Lepikhov wrote:
On 12/2/2024 15:55, Alena Rybakina wrote:
As I understand it, match_clauses_to_index is necessary if you have a
RestrictInfo (rinfo1) variable, so maybe we should run it after the
make_restrictonfo procedure,
Hi,
I addressed the comments and updated the patch.
> Should these be "publisher node" and "subscriber node" instead? Do we
> want to define the term "node"? I think in everyday conversations we
> use "node" quite a lot, so maybe we do need an entry for it. (Maybe
> just suffices, plus add und
Hi!
> If the changes of Alena are ok, can you merge the changes and post an
> updated version so that CFBot can apply the patch and verify the
> changes. As currently CFBot is trying to apply only Alena's changes
> and failing with the following at [1]:
I think this is a very nice and pretty simp
Am Montag, dem 12.02.2024 um 21:00 +0800 schrieb jian he:
> +
> + Per default btree_gist builts
> GiST indexe with
> + sortsupport in sorted
> mode. This usually results in a
> + much better index quality and smaller index sizes by much faster
> index built speed. It is still
> + possible to r
Hi,
On Tue, Feb 13, 2024 at 04:08:23AM +, Zhijie Hou (Fujitsu) wrote:
> On Tuesday, February 13, 2024 9:16 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > Here is the new version patch which addressed above and most of Bertrand's
> > comments.
> >
> > TODO: trying to add one test for the case the
On Tue, Feb 13, 2024 at 4:59 PM Bertrand Drouvot
wrote:
>
> On Tue, Feb 13, 2024 at 04:08:23AM +, Zhijie Hou (Fujitsu) wrote:
> > On Tuesday, February 13, 2024 9:16 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > Here is the new version patch which addressed above and most of Bertrand's
> > >
On 22/11/2023 13:02, Andrew Dunstan wrote:
I've been trying to get meson working with Cygwin. On a fresh install
(Cygwin 3.4.9, gcc 11.4.0, meson 1.0.2, ninja 1.11.1) I get a bunch of
errors like this:
ERROR: incompatible library
"/home/andrew/bf/buildroot/HEAD/pgsql.build/tmp_install/home
On Tuesday, February 13, 2024 2:51 PM Amit Kapila
wrote:
>
> On Tue, Feb 13, 2024 at 9:38 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > Here is the V85_2 patch set that added the test and fixed one typo,
> > there are no other code changes.
> >
>
> Few comments on the latest changes:
Thanks for th
On Tuesday, February 13, 2024 7:30 PM Bertrand Drouvot
wrote:
>
> On Tue, Feb 13, 2024 at 04:08:23AM +, Zhijie Hou (Fujitsu) wrote:
> > On Tuesday, February 13, 2024 9:16 AM Zhijie Hou (Fujitsu)
> wrote:
> > >
> > > Here is the new version patch which addressed above and most of
> > > Bertr
On Mon, Feb 12, 2024 at 8:48 PM Peter Eisentraut wrote:
>
> On 08.02.24 08:20, Ashutosh Bapat wrote:
> > On Wed, Feb 7, 2024 at 12:47 PM Ashutosh Bapat
> > wrote:
> >
> >> 0001 fixes compression inheritance
> >> 0002 fixes storage inheritance
> >>
> >
> > The first patch does not update compressi
Dear Vignesh,
Since the original author seems bit busy, I updated the patch set.
> 1) Cleanup function handler flag should be reset, i.e.
> dbinfo->made_replslot = false; should be there else there will be an
> error during drop replication slot cleanup in error flow:
> +static void
> +drop_repl
Dear hackers,
I've replied for trackability.
> Further comments for v17.
>
> 01.
> This program assumes that the target server has same major version with this.
> Because the target server would be restarted by same version's pg_ctl command.
> I felt it should be ensured by reading the PG_VERSIO
Dear Shubham,
Thanks for testing the patch!
>
> I tried verifying few scenarios by using 5 databases and came across
> the following errors:
>
> ./pg_createsubscriber -D ../new_standby -P "host=localhost port=5432
> dbname=postgres" -S "host=localhost port=9000 dbname=postgres" -d db1
> -d db2
On Sat, Feb 10, 2024 at 10:55 PM Andrew Dunstan wrote:
>
> On 2024-02-08 Th 21:02, Jeevan Chalke wrote:
>
>
>
> On Thu, Feb 8, 2024 at 2:22 PM jian he
> wrote:
>
>> On Thu, Feb 8, 2024 at 1:27 PM Jeevan Chalke
>> wrote:
>> >
>> >
>> >
>> > On Wed, Feb 7, 2024 at 9:13 PM jian he
>> wrote:
>> >>
On Mon, Feb 12, 2024 at 6:52 AM Ashutosh Bapat
wrote:
>
> >
> > > We defer actual action triggered by a signal till CHECK_FOR_INTERRUPTS
> > > is called. I understand that we can't do that here since we want to
> > > capture the backtrace at that moment and can't wait till next CFI. But
> > > prin
(moving to pgsql-hackers)
On 29/01/2024 14:06, Heikki Linnakangas wrote:
If you call dsa_allocate_extended(DSA_ALLOC_NO_OOM), it will still
ereport an error if you run out of space (originally reported at [0]).
Attached patch adds code to test_dsa.c to demonstrate that:
postgres=# select test_
HI Tatsuo,
On Mon, 29 Jan 2024 at 20:15, Tatsuo Ishii wrote:
> Hello Dave,
>
> > Tatsuo Ishii writes:
> >> Below is outputs from "pgproto" command coming with Pgpool-II.
> >> (Lines starting "FE" represents a message from frontend to backend.
> >> Lines starting "BE" represents a message from
On Mon, Feb 5, 2024 at 05:29:08PM +, John Morris wrote:
> >> It seems something you want to keep for your personal use.
>
> >> I think this filter is the kind of genious idea that it's OK if you
>
> >> can do it at home
>
> I don’t agree with your characterization.
>
> The purpose of the
On 1/8/24 16:51, Alvaro Herrera wrote:
> On 2023-Dec-12, Tomas Vondra wrote:
>
>> I propose we do a much simpler thing instead - allow the cache may be
>> initialized / cleaned up repeatedly, and make sure it gets reset at
>> convenient place (typically after index_insert calls that don't go
>> th
On Tue, Feb 13, 2024 at 05:28:32PM +0900, Michael Paquier wrote:
> On Tue, Feb 13, 2024 at 01:13:43AM +0900, Yugo NAGATA wrote:
> > I attached an updated patch that adds comments noting to use
> > IsQueryIdEnabled()
> > instead of accessing the variables directly.
>
> Sounds good to me, thanks.
Hi,
On Tue, Feb 13, 2024 at 05:20:35PM +0530, Amit Kapila wrote:
> On Tue, Feb 13, 2024 at 4:59 PM Bertrand Drouvot
> wrote:
> > - 84% of the slotsync.c code is covered, the parts that are not are mainly
> > related to "errors".
> >
> > Worth to try to extend the coverage? (I've in mind 731, 739,
On Sun, Jan 28, 2024 at 1:07 AM Tomas Vondra
wrote:
> Right, locks + apply in commit order gives us this guarantee (I can't
> think of a case where it wouldn't be the case).
I couldn't find any cases of inadequate locking other than the one I mentioned.
> Doesn't the whole logical replication cr
On Tue, Feb 13, 2024, at 10:28, Laurenz Albe wrote:
> On Mon, 2024-02-12 at 12:24 -0500, Corey Huinker wrote:
>> > Do you plan to add it to the commitfest? If yes, I'd set it "ready for
>> > committer".
>>
>> Commitfest entry reanimated.
>
> Truly... you created a revenant in the already closed
On Tue, Feb 13, 2024 at 5:06 AM Andres Freund wrote:
>
> I doubt there's a sane way to use WALRead() without *first* ensuring that the
> range of data is valid. I think we're better of moving that responsibility
> explicitly to the caller and adding an assertion verifying that.
>
> It doesn't real
Dave Cramer
www.postgres.rocks
On Mon, 12 Feb 2024 at 16:19, Andres Freund wrote:
> Hi,
>
> On 2024-02-12 12:50:12 -0800, Andres Freund wrote:
> > On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote:
> > I wonder if this indicates that we are either missing memory barriers
> > somewhere or that
Hi,
On 2024-02-13 12:49:33 -0500, Dave Cramer wrote:
> > I think I might have been on to something - if my human emulation of a
> > preprocessor isn't wrong, we'd end up with
> >
> > #define S_UNLOCK(lock) \
> > do { _ReadWriteBarrier(); (*(lock)) = 0; } while (0)
> >
> > on msvc + arm. A
On Mon, Feb 12, 2024 at 9:38 AM Daniel Gustafsson wrote:
> > On 11 Feb 2024, at 19:19, David Benjamin wrote:
> > It turns out the parts that came from the OpenSSL socket BIO were a
> no-op, and in fact PostgreSQL is relying on it being a no-op. Instead, it's
> cleaner to just define a custom BIO
Hi Andrew, Additionally info:
Thank you very much for your email. Additionally info:
This is what I have been able to setup for the Azure Flexserver PostgreSQL:
[image: image.png]
And this is what I am trying to do:( just drew the bottom to diagrams) So
that we have one way to log into for all us
On Tue, Feb 13, 2024 at 09:43:18AM +0100, Mats Kindahl wrote:
> Maybe we should change to use the original version equivalent to the inline
> function above since that works better with surrounding code?
I don't think that's necessary. We just need to be cognizant of it when
using inlined sorts,
Hi all,
Attached is a patch that fixes some overflow/underflow hazards that I
discovered in the interval rounding code.
The lines look a bit long, but I did run the following before committing:
`$ curl https://buildfarm.postgresql.org/cgi-bin/typedefs.pl -o
src/tools/pgindent/typedefs.list && src
Joseph Koshakow writes:
> Attached is a patch that fixes some overflow/underflow hazards that I
> discovered in the interval rounding code.
I think you need to use ereturn not ereport here; see other error
cases in AdjustIntervalForTypmod.
(We'd need ereport in back branches, but this problem se
On 2/7/24 22:48, Melanie Plageman wrote:
> ...
>
> Attached is a patch which implements a real queue and fixes some of
> the issues with the previous version. It doesn't pass tests yet and
> has issues. Some are bugs in my implementation I need to fix. Some are
> issues we would need to solve in t
On Wed, Jan 31, 2024 at 11:59:21AM +0100, Alvaro Herrera wrote:
> On 2024-Jan-31, vignesh C wrote:
>
> > Are we planning to do anything more on this? I was not sure if we
> > should move this to next commitfest or return it.
>
> Well, the patches don't apply anymore since .cirrus.tasks.yml has be
Hi,
On 2024-02-13 13:31:22 -0500, Joseph Koshakow wrote:
> Attached is a patch that fixes some overflow/underflow hazards that I
> discovered in the interval rounding code.
Random, mildly related thought: I wonder if it's time to, again, look at
enabling -ftrapv in assert enabled builds. I had l
On Tue, Feb 13, 2024 at 2:01 PM Tomas Vondra
wrote:
> On 2/7/24 22:48, Melanie Plageman wrote:
> I admit I haven't thought about kill_prior_tuple until you pointed out.
> Yeah, prefetching separates (de-synchronizes) the two scans (index and
> heap) in a way that prevents this optimization. Or at
On Tue, Feb 13, 2024 at 1:46 PM Tom Lane wrote:
>I think you need to use ereturn not ereport here; see other error
>cases in AdjustIntervalForTypmod.
Attached is an updated patch that makes this adjustment.
>(We'd need ereport in back branches, but this problem seems to
>me to p
Joseph Koshakow writes:
> On Tue, Feb 13, 2024 at 1:46 PM Tom Lane wrote:
>> (We'd need ereport in back branches, but this problem seems to
>> me to probably not be worth back-patching.)
> Agreed, this seems like a pretty rare overflow/underflow.
OK, pushed to HEAD only. I converted the second
On Tue, Jan 02, 2024 at 03:58:25PM +0530, Amit Kapila wrote:
> Pushed.
pg_upgrade/t/004_subscription.pl says
|my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE} || '--copy';
..but I think maybe it should not.
When you try to use --link, it fails:
https://cirrus-ci.com/task/4669494061170688
|Adding ".old
On Wed, Feb 14, 2024 at 3:23 AM Heikki Linnakangas wrote:
> On 29/01/2024 14:06, Heikki Linnakangas wrote:
> > If you call dsa_allocate_extended(DSA_ALLOC_NO_OOM), it will still
> > ereport an error if you run out of space (originally reported at [0]).
> >
> > Attached patch adds code to test_dsa.
On Tue, 13 Feb 2024 at 12:52, Andres Freund wrote:
> Hi,
>
> On 2024-02-13 12:49:33 -0500, Dave Cramer wrote:
> > > I think I might have been on to something - if my human emulation of a
> > > preprocessor isn't wrong, we'd end up with
> > >
> > > #define S_UNLOCK(lock) \
> > > do { _Rea
On Mon, Feb 12, 2024 at 09:49:45AM -0600, Nathan Bossart wrote:
> Okay. I'll plan on committing this in the next few days.
Here is what I have staged for commit.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From bfe542c5d7b3c981e75ac6551abb34fbdf646eea Mon Sep 17 00:00:00 2001
On Tue, Feb 13, 2024 at 03:05:14PM -0600, Justin Pryzby wrote:
> On Tue, Jan 02, 2024 at 03:58:25PM +0530, Amit Kapila wrote:
> > Pushed.
>
> pg_upgrade/t/004_subscription.pl says
>
> |my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE} || '--copy';
>
> ..but I think maybe it should not.
>
> When you try
Hi!
On Wed, Jan 31, 2024 at 11:57 AM Andrey Borodin wrote:
> > On 31 Jan 2024, at 14:27, Japin Li wrote:
> >
> > LGTM.
> >
> > If there is no other objections, I'll change it to ready for committer
> > next Monday.
>
> I think we have a quorum, so I decided to go ahead and flipped status to RfC.
On Thu, Feb 08, 2024 at 05:25:01PM +0900, Sutou Kouhei wrote:
> In <20240206222445.hzq22pb2nye7r...@awork3.anarazel.de>
> "Re: confusing / inefficient "need_transcoding" handling in copy" on Tue, 6
> Feb 2024 14:24:45 -0800,
> Andres Freund wrote:
>
>> One unfortunate issue: We don't have an
On Tue, Feb 13, 2024 at 11:23:47PM +0800, Julien Rouhaud wrote:
> +1!
Okay, applied as-is, then.
--
Michael
signature.asc
Description: PGP signature
On Tue, Feb 13, 2024 at 11:51 AM Joel Jacobson wrote:
> On Tue, Feb 13, 2024, at 10:28, Laurenz Albe wrote:
> > On Mon, 2024-02-12 at 12:24 -0500, Corey Huinker wrote:
> >> > Do you plan to add it to the commitfest? If yes, I'd set it "ready
> for committer".
> >>
> >> Commitfest entry reanimate
On Feb 12, 2024, at 15:55, David E. Wheeler wrote:
> Happy to move it wherever makes the most sense.
Update with a bunch of the suggested changes. Some questions still open from
the previous post, though.
Best,
David
v5-0001-Add-parse_type-SQL-function.patch
Description: Binary data
On Tue, Feb 13, 2024 at 9:25 AM Jeff Davis wrote:
> On Sun, 2024-02-11 at 22:04 +0530, Robert Haas wrote:
> > "icu_multilib must be loaded via shared_preload_libraries.
> > icu_multilib ignores any ICU library with a major version greater
> > than
> > that with which PostgreSQL was built."
> >
> >
Hi Dave,
>> From [1] I think the JDBC driver sends something like below if
>> autosave=always option is specified.
>>
>> "BEGIN READ ONLY" Parse/Bind/Eexecute (in the extended query protocol)
>> "SAVEPOINT PGJDBC_AUTOSAVE" (in the simple query protocol)
>>
>> It seems the SAVEPOINT is sent without
On Tue, Feb 13, 2024 at 05:36:36PM +0900, Michael Paquier wrote:
> You've indeed grabbed some historical inconsistencies here. Please
> note that your patch has reversed diffs (for example, the SQL
> definition of pgp_sym_encrypt_bytea uses bytea,text,text as arguments
> and your resulting patch s
On Thu, Oct 5, 2023 at 9:07 PM David Rowley wrote:
> Thanks. Pushed.
FYI somehow this plan from a8a968a8212e flipped in this run:
=== dumping
/home/bf/bf-build/mylodon/HEAD/pgsql.build/testrun/recovery/027_stream_regress/data/regression.diffs
===
diff -U3
/home/bf/bf-build/mylodon/HEAD/pgsql/s
On Wed, 14 Feb 2024 07:21:54 +0900
Michael Paquier wrote:
> On Tue, Feb 13, 2024 at 11:23:47PM +0800, Julien Rouhaud wrote:
> > +1!
>
> Okay, applied as-is, then.
Thank you!
Regards,
Yugo Nagata
> --
> Michael
--
Yugo NAGATA
Attached 2 patches.
Per Andres's suggestion, 0001 adds an:
Assert(startptr + count <= LogwrtResult.Write)
Though if we want to allow the caller (e.g. in an extension) to
determine the valid range, perhaps using WaitXLogInsertionsToFinish(),
then the check is wrong. Maybe we should just get rid
On Tue, 2024-02-13 at 22:47 +0530, Bharath Rupireddy wrote:
> c) If planning to replicate unflushed data, then ensure all the
> WALRead() callers wait until startptr+count is past the current
> insert
> position with WaitXLogInsertionsToFinish().
WALRead() can't read past the Write pointer, so the
On Tue, Feb 13, 2024 at 9:25 PM Bertrand Drouvot
wrote:
>
> On Tue, Feb 13, 2024 at 05:20:35PM +0530, Amit Kapila wrote:
> > On Tue, Feb 13, 2024 at 4:59 PM Bertrand Drouvot
> > wrote:
> > > - 84% of the slotsync.c code is covered, the parts that are not are mainly
> > > related to "errors".
> >
Hi,
In
"Re: confusing / inefficient "need_transcoding" handling in copy" on Wed, 14
Feb 2024 06:56:16 +0900,
Michael Paquier wrote:
> We have a couple of non-ASCII characters in the tests, but I suspect
> that this one will not be digested correctly everywhere, even if
> EUC_JP should be O
Hi,
On 2024-02-12 17:33:24 -0800, Jeff Davis wrote:
> On Mon, 2024-02-12 at 15:36 -0800, Andres Freund wrote:
> >
> > It doesn't really seem like a necessary, or even particularly useful,
> > part. You couldn't just call WALRead() for that, since the caller
> > would need
> > to know the range up
On Thu, Feb 8, 2024, at 12:04 AM, Hayato Kuroda (Fujitsu) wrote:
> >
> Remember the target server was a standby (read only access). I don't expect an
> application trying to modify it; unless it is a buggy application.
> >
>
> What if the client modifies the data just after the promotion?
> Naivel
On 13/2/2024 17:03, Andrei Lepikhov wrote:
On 13/2/2024 07:00, jian he wrote:
The time is the last result of the 10 iterations.
I'm not sure about the origins of such behavior, but it seems to be an
issue of parallel workers, not this specific optimization.
Having written that, I'd got a backbu
On Fri, Feb 9, 2024, at 3:27 AM, vignesh C wrote:
> On Wed, 7 Feb 2024 at 10:24, Euler Taveira wrote:
> >
> > On Fri, Feb 2, 2024, at 6:41 AM, Hayato Kuroda (Fujitsu) wrote:
> >
> > Thanks for updating the patch!
>
> Thanks for the updated patch, few comments:
> Few comments:
> 1) Cleanup functio
On Tue, Feb 13, 2024 at 05:33:40PM +0900, Sutou Kouhei wrote:
> Hi,
>
> In <20240209192705.5qdilvviq3py2...@awork3.anarazel.de>
> "Re: Make COPY format extendable: Extract COPY TO format implementations"
> on Fri, 9 Feb 2024 11:27:05 -0800,
> Andres Freund wrote:
>
>>> +static void
>>> +Cop
Dear Justin,
> pg_upgrade/t/004_subscription.pl says
>
> |my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE} || '--copy';
>
> ..but I think maybe it should not.
>
> When you try to use --link, it fails:
> https://cirrus-ci.com/task/4669494061170688
>
> |Adding ".old" suffix to old global/pg_control
On Wednesday, February 14, 2024 10:40 AM Amit Kapila
wrote:
>
> On Tue, Feb 13, 2024 at 9:25 PM Bertrand Drouvot
> wrote:
> >
> > On Tue, Feb 13, 2024 at 05:20:35PM +0530, Amit Kapila wrote:
> > > On Tue, Feb 13, 2024 at 4:59 PM Bertrand Drouvot
> > > wrote:
> > > > - 84% of the slotsync.c cod
On 30/1/2024 12:44, Ashutosh Bapat wrote:
Thanks Vignesh. PFA patches rebased on the latest HEAD. The patch
addressing Amit's comments is still a separate patch for him to
review.
Thanks for this improvement. Working with partitions, I frequently see
peaks of memory consumption during planning.
> On Feb 13, 2024, at 3:11 PM, Melanie Plageman
> wrote:
Thanks for the patch...
> Attached is a patch set which refactors BitmapHeapScan such that it
> can use the streaming read API [1]. It also resolves the long-standing
> FIXME in the BitmapHeapScan code suggesting that the skip fetch
>
Hi
more minor issues.
+ FindFKComparisonOperators(
+ fkconstraint, tab, i, fkattnum,
+ &old_check_ok, &old_pfeqop_item,
+ pktypoid[i], fktypoid[i], opclasses[i],
+ is_temporal, false,
+ &pfeqoperators[i], &ppeqoperators[i], &ffeqoperators[i]);
+ }
+ if (is_temporal) {
+ pkattnum[numpks] = pkperiod
Hi,
In
"Re: Make COPY format extendable: Extract COPY TO format implementations" on
Wed, 14 Feb 2024 12:28:38 +0900,
Michael Paquier wrote:
>> How about the attached patch approach? If it's a desired
>> approach, I can also write a separated patch for COPY TO.
>
> Hmm, I have not studied
On Wed, 14 Feb 2024 at 09:07, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Justin,
>
> > pg_upgrade/t/004_subscription.pl says
> >
> > |my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE} || '--copy';
> >
> > ..but I think maybe it should not.
> >
> > When you try to use --link, it fails:
> > https://cirrus-ci.co
Dear Vignesh,
Thanks for verifying the fix!
> Your proposal to change the tests in the following order: a) failure
> due to the insufficient max_replication_slot b) failure because the
> pg_subscription_rel has 'd' state c) successful upgrade. looks good to
> me.
Right.
> I have also verified t
2024年2月7日(水) 12:51 Ian Lawrence Barwick :
>
> 2024年2月6日(火) 19:54 Peter Eisentraut :
> >
> > I'm proposing here a way to pass extra options to initdb when run
> > internally during test setup in pg_regress or
> > PostgreSQL::Test::Cluster's init (which covers just about all test
> > suites other tha
On 29/1/2024 10:18, Richard Guo wrote:
In [1] we've reached a conclusion that for a MATERIALIZED CTE it's okay
to 'allow our statistics or guesses for the sub-query to subsequently
influence what the upper planner does'. Commit f7816aec23 exposes
column statistics to the upper planner. In the l
On 2024-02-13 11:30, torikoshia wrote:
I'll update the patch including other points such as removing ensuring
no page lock code.
Updated the patch.
Using injection point support we should be able to add tests for
testing pg_log_query_plan behaviour when there are page locks held or
when auto
On Wed, Feb 14, 2024 at 9:50 AM Andrei Lepikhov
wrote:
>
> On 30/1/2024 12:44, Ashutosh Bapat wrote:
> > Thanks Vignesh. PFA patches rebased on the latest HEAD. The patch
> > addressing Amit's comments is still a separate patch for him to
> > review.
> Thanks for this improvement. Working with par
On Wed, Feb 14, 2024 at 02:08:51PM +0900, Sutou Kouhei wrote:
> I understand the feeling. SQL uses "prepared" for "prepared
> statement". There are similar function names such as
> InputFunctionCall()/InputFunctionCallSafe()/DirectInputFunctionCallSafe().
> They
> execute (call) an input function
On Fri, Feb 2, 2024 at 12:03 AM Robert Haas wrote:
> On Thu, Feb 1, 2024 at 2:18 AM Amul Sul wrote:
> > I intended to minimize the out param of parse_manifest_file(), which
> currently
> > returns manifest_files_hash and manifest_wal_range, and I need two more
> --
> > manifest versions and the
On Thu, Feb 8, 2024 at 3:18 AM Melanie Plageman
wrote:
> - kill prior tuple
>
> This optimization doesn't work with index prefetching with the current
> design. Kill prior tuple relies on alternating between fetching a
> single index tuple and visiting the heap. After visiting the heap we
> can po
On Tue, Feb 13, 2024 at 7:53 PM Heikki Linnakangas wrote:
> However, I must say that the dsm_impl_op() interface is absolutely
> insane. It's like someone looked at ioctl() and thought, "hey that's a
> great idea!".
As the person who wrote that code, this made me laugh.
I agree it's not the pret
On Fri, Jan 19, 2024 at 05:41:45PM +0900, torikoshia wrote:
> We already have additional description below the table which explains each
> column of the system view. For example pg_locks:
> https://www.postgresql.org/docs/devel/view-pg-locks.html
I was reading the patch, and using int[] as a repre
A recent commit added the following message:
> "wal_level" must be >= logical.
The use of the term "logical" here is a bit confusing, as it's unclear
whether it's meant to be a natural language word or a token. (I
believe it to be a token.)
On the contrary, we already have the following message:
On Wed, 7 Feb 2024 at 16:27, vignesh C wrote:
>
> On Wed, 7 Feb 2024 at 15:21, Amit Kapila wrote:
> >
> > On Tue, Feb 6, 2024 at 8:21 PM Tom Lane wrote:
> > >
> > > Amit Kapila writes:
> > > > Yeah, I was worried about that. The other idea I have previously
> > > > thought was to change Alter S
On 14/2/2024 13:32, Ashutosh Bapat wrote:
On Wed, Feb 14, 2024 at 9:50 AM Andrei Lepikhov
wrote:
On 30/1/2024 12:44, Ashutosh Bapat wrote:
Thanks Vignesh. PFA patches rebased on the latest HEAD. The patch
addressing Amit's comments is still a separate patch for him to
review.
Thanks for this
At Wed, 14 Feb 2024 16:26:52 +0900 (JST), Kyotaro Horiguchi
wrote in
> > "wal_level" must be >= logical.
..
> > wal_level must be set to "replica" or "logical" at server start.
..
> I suggest making the quoting policy consistent.
Just after this, I found another inconsistency regarding quotatio
Hi,
I recently observed an assertion failure twice in t/001_rep_changes.pl
on HEAD with the backtrace [1] on my dev EC2 c5.4xlarge instance [2].
Unfortunately I'm not observing it again. I haven't got a chance to
dive deep into it. However, I'm posting it here just for the records,
and in case som
On Tue, Feb 6, 2024 at 4:24 PM Peter Eisentraut wrote:
> I think this can be useful for a wide variety of uses, like running all
> tests with checksums enabled, or with JIT enabled, or with different GUC
> settings, or with different locale settings. (The existing pg_regress
> --no-locale option
> On 13 Feb 2024, at 22:29, Nathan Bossart wrote:
>
> On Mon, Feb 12, 2024 at 09:49:45AM -0600, Nathan Bossart wrote:
>> Okay. I'll plan on committing this in the next few days.
>
> Here is what I have staged for commit.
LGTM.
--
Daniel Gustafsson
94 matches
Mail list logo
