Re: Functions to return random numbers in a given range

2024-01-26 Thread David Zhang
Thank you for the patch. I applied this patch manually to the master branch, resolving a conflict in `numeric.h`. It successfully passed both `make check` and `make check-world`. Best regards, David

Re: A performance issue with Memoize

2024-01-26 Thread David Rowley
On Sat, 27 Jan 2024 at 09:41, Tom Lane wrote: > > David Rowley writes: > > I've adjusted the comments to what you mentioned and also leaned out > > the pretty expensive test case to something that'll run much faster > > and pushed the result. > > drongo and fairywren are consistently failing the

Re: A performance issue with Memoize

2024-01-26 Thread Tom Lane
David Rowley writes: > On Sat, 27 Jan 2024 at 09:41, Tom Lane wrote: >> drongo and fairywren are consistently failing the test case added >> by this commit. I'm not quite sure why the behavior of Memoize >> would be platform-specific when we're dealing with integers, >> but ... > Maybe snprintf

Re: make dist using git archive

2024-01-26 Thread Eli Schwartz
Hello, meson developer here. On 1/23/24 4:30 AM, Peter Eisentraut wrote: > On 22.01.24 21:04, Tristan Partin wrote: >> I am not really following why we can't use the builtin Meson dist >> command. The only difference from my testing is it doesn't use a >> --prefix argument. > > Here are some pro

Bug: The "directory" control parameter does not work

2024-01-26 Thread David E. Wheeler
Hackers, I wanted to try to customize the subdirectory for an extension. The docs[1] say: > directory (string) > > The directory containing the extension's SQL script file(s). Unless an > absolute path is given, the name is relative to the installation's SHAREDIR > directory. The default behav

Re: Bug: The "directory" control parameter does not work

2024-01-26 Thread David E. Wheeler
On Jan 26, 2024, at 4:40 PM, David E. Wheeler wrote: > But it doesn’t seem to work. I tried this experiment: I made a simpler test case here: https://github.com/theory/test-extension-directory Not the difference between actual and expected output. Best, David

Re: proposal: psql: show current user in prompt

2024-01-26 Thread Jelte Fennema-Nio
On Fri, 26 Jan 2024 at 21:35, Pavel Stehule wrote: > I see a possibility of disabling reporting as possibly dangerous. Without > reporting encoding you can break psql. So it should be limited just to few > values where is known behave. I agree that client_encoding is a GUC that likely all clie

Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

2024-01-26 Thread Jelte Fennema-Nio
On Fri, 26 Jan 2024 at 18:19, Alvaro Herrera wrote: > Yeah, I see that point of view as well. I like the end result; the > additional protos in libpq-int.h don't bother me. Does anybody else > wants to share their opinion on it? If none, then I'd consider going > ahead with this version. To be

Re: Bug: The "directory" control parameter does not work

2024-01-26 Thread David E. Wheeler
On Jan 26, 2024, at 5:05 PM, David E. Wheeler wrote: > I made a simpler test case here: > > https://github.com/theory/test-extension-directory > > Not the difference between actual and expected output. Bah! Need to also set `MODULEDIR = extension/click` and then it works. D

Re: Opportunistically pruning page before update

2024-01-26 Thread James Coleman
On Tue, Jan 23, 2024 at 2:46 AM Dilip Kumar wrote: > > On Tue, Jan 23, 2024 at 7:18 AM James Coleman wrote: > > > > On Mon, Jan 22, 2024 at 8:21 PM James Coleman wrote: > > > > > > See rebased patch attached. > > > > I just realized I left a change in during the rebase that wasn't necessary. > >

Re: [PoC/RFC] Multiple passwords, interval expirations

2024-01-26 Thread vignesh C
On Tue, 10 Oct 2023 at 16:37, Gurjeet Singh wrote: > > > On Mon, Oct 9, 2023 at 2:31 AM Gurjeet Singh wrote: > > > > > > Next steps: > > > - Break the patch into a series of smaller patches. > > > - Add TAP tests (test the ability to actually login with these passwords) > > > - Add/update documen

Re: [CAUTION!! freemail] Re: Partial aggregates pushdown

2024-01-26 Thread vignesh C
On Thu, 7 Dec 2023 at 05:41, fujii.y...@df.mitsubishielectric.co.jp wrote: > > Hi Mr.Haas. > > > -Original Message- > > From: Robert Haas > > Sent: Wednesday, December 6, 2023 10:25 PM > > On Wed, Dec 6, 2023 at 3:41 AM fujii.y...@df.mitsubishielectric.co.jp > > wrote: > > > Are you conc

Re: Wrong rows estimations with joins of CTEs slows queries by more than factor 500

2024-01-26 Thread vignesh C
On Mon, 8 Jan 2024 at 22:21, Tom Lane wrote: > > Richard Guo writes: > > On Sun, Jan 7, 2024 at 6:41 AM Tom Lane wrote: > >> Thanks for the report! I guess we need something like the attached. > > > +1. > > Pushed, thanks for looking at it. I have changed the status of the commitfest entry to

Re: Request for comment on setting binary format output per session

2024-01-26 Thread vignesh C
On Mon, 31 Jul 2023 at 21:58, Dave Cramer wrote: > > > Dave Cramer > > > On Mon, 10 Jul 2023 at 03:56, Daniel Gustafsson wrote: >> >> > On 25 Apr 2023, at 16:47, Dave Cramer wrote: >> >> > Patch attached with comments removed >> >> This patch no longer applies, please submit a rebased version on

Re: dblink query interruptibility

2024-01-26 Thread Noah Misch
On Thu, Jan 25, 2024 at 12:28:43PM +0900, Fujii Masao wrote: > On Thu, Jan 25, 2024 at 5:45 AM Noah Misch wrote: > > On Thu, Jan 25, 2024 at 04:23:39AM +0900, Fujii Masao wrote: > > > I found that this patch was committed at d3c5f37dd5 and changed the > > > error message in postgres_fdw slightly.

Re: Reducing memory consumed by RestrictInfo list translations in partitionwise join planning

2024-01-26 Thread vignesh C
On Tue, 31 Oct 2023 at 10:48, Ashutosh Bapat wrote: > > On Thu, Sep 14, 2023 at 4:39 PM Ashutosh Bapat > wrote: > > > > The patch set is thus > > 0001 - patch used to measure memory used during planning > > > > 0002 - Patch to free intermediate Relids computed by > > adjust_child_relids_multileve

Re: POC, WIP: OR-clause support for indexes

2024-01-26 Thread vignesh C
On Tue, 5 Dec 2023 at 16:25, Andrei Lepikhov wrote: > > Here is fresh version with the pg_dump.pl regex fixed. Now it must pass > buildfarm. > > Under development: > 1. Explanation of the general idea in comments (Robert's note) > 2. Issue with hiding some optimizations (Alexander's note and examp

Re: Separate memory contexts for relcache and catcache

2024-01-26 Thread vignesh C
On Wed, 3 Jan 2024 at 16:56, Melih Mutlu wrote: > > Hi, > > torikoshia , 4 Ara 2023 Pzt, 07:59 tarihinde şunu > yazdı: >> >> Hi, >> >> I also think this change would be helpful. >> >> I imagine you're working on the Andres's comments and you already notice >> this, but v1 patch cannot be applied

Re: Some revises in adding sorting path

2024-01-26 Thread vignesh C
On Mon, 17 Jul 2023 at 14:25, Richard Guo wrote: > > > On Wed, Mar 29, 2023 at 4:00 AM David Rowley wrote: >> >> If you write some tests for this code, it will be useful to prove that >> it actually does something, and also that it does not break again in >> the future. I don't really want to jus

Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx

2024-01-26 Thread vignesh C
On Fri, 19 Jan 2024 at 10:50, Michael Paquier wrote: > > On Thu, Jan 18, 2024 at 09:25:16AM +0100, Anthonin Bonnefoy wrote: > > From what I can tell, there's no change in the behaviour. All paths > > would eventually go through HandleSlashCmds's cleaning logic. This is > > also mentioned in ignore

Re: Support run-time partition pruning for hash join

2024-01-26 Thread vignesh C
On Tue, 7 Nov 2023 at 13:25, Richard Guo wrote: > > > On Mon, Nov 6, 2023 at 11:00 PM Alexander Lakhin wrote: >> >> Please look at a warning and an assertion failure triggered by the >> following script: >> set parallel_setup_cost = 0; >> set parallel_tuple_cost = 0; >> set min_parallel_table_sca

Re: psql's FETCH_COUNT (cursor) is not being respected for CTEs

2024-01-26 Thread vignesh C
On Tue, 2 Jan 2024 at 20:28, Daniel Verite wrote: > > Hi, > > PFA a rebased version. CFBot shows that the patch does not apply anymore as in [1]: === Applying patches on top of PostgreSQL commit ID a3a836fb5e51183eae624d43225279306c2285b8 === === applying patch ./v5-0001-Implement-retrieval-of-

Re: Improving btree performance through specializing by key shape, take 2

2024-01-26 Thread vignesh C
On Mon, 30 Oct 2023 at 21:50, Matthias van de Meent wrote: > > On Thu, 26 Oct 2023 at 00:36, Peter Geoghegan wrote: > > Most of the work with something like > > this is the analysis of the trade-offs, not writing code. There are > > all kinds of trade-offs that you could make with something like

Re: Reducing connection overhead in pg_upgrade compat check phase

2024-01-26 Thread vignesh C
On Fri, 27 Oct 2023 at 18:50, Daniel Gustafsson wrote: > > Attached is a v10 rebase of this patch which had undergone significant bitrot > due to recent changes in the pg_upgrade check phase. This brings in the > changes into the proposed structure without changes to queries, with no > additional

Re: Synchronizing slots from primary to standby

2024-01-26 Thread Amit Kapila
On Thu, Jan 25, 2024 at 6:42 PM Zhijie Hou (Fujitsu) wrote: > > Here is the V69 patch set which includes the following changes. > > V69-0001, V69-0002 > Few minor comments on v69-0001 1. In libpqrcv_create_slot(), I see we are using two types of syntaxes based on 'use_new_options_syntax' (aka ser

Re: User functions for building SCRAM secrets

2024-01-26 Thread vignesh C
On Sat, 2 Dec 2023 at 12:22, John Naylor wrote: > > On Wed, Mar 22, 2023 at 9:06 PM Jonathan S. Katz wrote: > > > > Maybe I'm not conveying the problem this is solving -- I'm happy to go > > one more round trying to make it clearer -- but if this is not clear, > > it'd be good to at develop an al

Re: A performance issue with Memoize

2024-01-26 Thread Alexander Lakhin
Hello, 27.01.2024 00:09, Tom Lane wrote: David Rowley writes: On Sat, 27 Jan 2024 at 09:41, Tom Lane wrote: drongo and fairywren are consistently failing the test case added by this commit. I'm not quite sure why the behavior of Memoize would be platform-specific when we're dealing with int

Re: MultiXact\SLRU buffers configuration

2024-01-26 Thread Andrey Borodin
> On 20 Jan 2024, at 08:31, vignesh C wrote: > > On Mon, 9 Jan 2023 at 09:49, Andrey Borodin wrote: >> >> On Tue, Jan 3, 2023 at 5:02 AM vignesh C wrote: >>> does not apply on top of HEAD as in [1], please post a rebased patch: >>> >> Thanks! Here's the rebase. > > I'm seeing that there h

Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

2024-01-26 Thread vignesh C
On Wed, 22 Nov 2023 at 21:54, Daniel Verite wrote: > > Shlok Kyal wrote: > > > > The error was corrected and a new diff file was created. > > > The diff file was created based on 16 RC1. > > > We confirmed that 5 places where errors occurred when performing > > > make check were changed to

Re: cleanup patches for incremental backup

2024-01-26 Thread Alexander Lakhin
Hello Robert, 26.01.2024 21:37, Robert Haas wrote: On Fri, Jan 26, 2024 at 12:39 PM Nathan Bossart wrote: On Fri, Jan 26, 2024 at 11:04:37AM -0500, Robert Haas wrote: Here is v2 with that addition. Looks reasonable. Thanks for the report & review. I have committed that version. While try

Re: proposal: psql: show current user in prompt

2024-01-26 Thread Pavel Stehule
so 27. 1. 2024 v 0:04 odesílatel Jelte Fennema-Nio napsal: > On Fri, 26 Jan 2024 at 21:35, Pavel Stehule > wrote: > > I see a possibility of disabling reporting as possibly dangerous. > Without reporting encoding you can break psql. So it should be limited just > to few values where is known beh

<    1   2