Re: Python installation selection in Meson

2023-11-29 Thread Peter Eisentraut
On 28.11.23 19:16, Andres Freund wrote: On 2023-11-28 19:02:42 +0100, Peter Eisentraut wrote: I noticed that under meson, the selection of the Python installation using the 'PYTHON' option doesn't work completely. The 'PYTHON' option determined the Python binary that will be used to call the va

Re: GUC names in messages

2023-11-29 Thread Michael Paquier
On Thu, Nov 30, 2023 at 03:29:49PM +0900, Kyotaro Horiguchi wrote: > In this patch, the quotation marks cannot be changed from double > quotes. Indeed, that's a good point. I completely forgot about that. -- Michael signature.asc Description: PGP signature

Re: Synchronizing slots from primary to standby

2023-11-29 Thread Peter Smith
Here are some review comments for v41-0001. == doc/src/sgml/ref/alter_subscription.sgml 1. + + When altering the + slot_name, + the failover property of the new slot may differ from the + failover + parameter specified in the subscription, you need to adjust the

[PATCH] plpython function causes server panic

2023-11-29 Thread Hao Zhang
Hi hackers, I found a problem when executing the plpython function: After the plpython function returns an error, in the same session, if we continue to execute plpython function, the server panic will be caused. *Reproduce* preparation SET max_parallel_workers_per_gather=4; SET parallel_setup_co

RE: Is this a problem in GenericXLogFinish()?

2023-11-29 Thread Hayato Kuroda (Fujitsu)
Dear Alexander, > > Good catch, thank you for reporting! I will investigate more about it and > post my > analysis. > Again, good catch. Here is my analysis and fix patch. I think it is sufficient to add an initialization for writebuf. In the reported case, neither is_prim_bucket_same_wrt nor

Re: Testing autovacuum wraparound (including failsafe)

2023-11-29 Thread Masahiko Sawada
On Wed, Nov 29, 2023 at 5:27 AM Masahiko Sawada wrote: > > On Tue, Nov 28, 2023 at 7:16 PM Daniel Gustafsson wrote: > > > > > On 28 Nov 2023, at 03:00, Masahiko Sawada wrote: > > > > > > On Mon, Nov 27, 2023 at 10:40 PM Daniel Gustafsson > > > wrote: > > >> > > >>> On 27 Nov 2023, at 14:06, Ma

Re: GUC names in messages

2023-11-29 Thread Peter Smith
On Thu, Nov 30, 2023 at 4:59 PM Michael Paquier wrote: > > On Tue, Nov 28, 2023 at 11:54:33AM +1100, Peter Smith wrote: > > Here is patch set v3. > > > > Patches 0001 and 0002 are unchanged from v2. > > After some grepping, I've noticed that 0002 had a mistake with > track_commit_timestamp: some a

<    1   2