On Wed, Nov 29, 2023 at 5:27 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Tue, Nov 28, 2023 at 7:16 PM Daniel Gustafsson <dan...@yesql.se> wrote: > > > > > On 28 Nov 2023, at 03:00, Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > > > On Mon, Nov 27, 2023 at 10:40 PM Daniel Gustafsson <dan...@yesql.se> > > > wrote: > > >> > > >>> On 27 Nov 2023, at 14:06, Masahiko Sawada <sawada.m...@gmail.com> wrote: > > >> > > >>> Is it true that we can modify the timeout after creating > > >>> BackgroundPsql object? If so, it seems we don't need to introduce the > > >>> new timeout argument. But how? > > >> > > >> I can't remember if that's leftovers that incorrectly remains from an > > >> earlier > > >> version of the BackgroundPsql work, or if it's a very bad explanation of > > >> ->set_query_timer_restart(). The timeout will use the timeout_default > > >> value > > >> and that cannot be overridden, it can only be reset per query. > > > > > > Thank you for confirming this. I see there is the same problem also in > > > interactive_psql(). So I've attached the 0001 patch to fix these > > > documentation issues. > > > > -A default timeout of $PostgreSQL::Test::Utils::timeout_default is set up, > > -which can be modified later. > > +A default timeout of $PostgreSQL::Test::Utils::timeout_default is set up. > > > > Since it cannot be modified, I think we should just say "A timeout of .." > > and > > call it a default timeout. This obviously only matters for the backpatch > > since > > the sentence is removed in 0002. > > Agreed. > > I've attached new version patches (0002 and 0003 are unchanged except > for the commit message). I'll push them, barring any objections. >
Pushed. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
