On Mon, 11 Sept 2023 at 08:51, Hongxu Ma wrote:
>
> I created a patch to fix it.
> Really appreciate to anyone can help to review it.
> Thanks.
I think "product" as a variable name isn't very descriptive. Let's
call it total_cells (or something similar instead).
Other than that I think it's a go
On Mon, Sep 11, 2023 at 02:42:16PM +0900, bt23nguyent wrote:
> A minor issue with the description here is that while the description for
> the new flush argument in pg_logical_emit_message() with bytea type is
> clearly declared, there is no description of flush argument in the former
> pg_logical_
On Mon, Sep 11, 2023, at 11:51 AM, Andy Fan wrote:
> Hi,
>
> On Thu, Jun 15, 2023 at 4:30 PM Andrey Lepikhov
> wrote:
>> Hi, all.
>>
>> Some of my clients use JOIN's with three - four clauses. Quite
>> frequently, I see complaints on unreasonable switch of JOIN algorithm to
>> Merge Join in
> Consider a scenario like this,
>
> Server A: primary
> Server B :replica of A
> Server C :replica of B
>
> and somehow A down ,so B gets promoted.
> Server A: down
> Server B :new primary
> Server C :replica of B
>
> In this case, pg_rewind can be used to reconstruct the cascade; the
source is C
On Mon, Sep 11, 2023 at 12:08 PM Michael Paquier wrote:
>
> On Fri, Sep 08, 2023 at 11:50:37AM +0530, Amit Kapila wrote:
> > On Fri, Sep 8, 2023 at 10:08 AM Michael Paquier wrote:
> >>
> >>
> >> +/*
> >> + * This is used to track the last persisted confirmed_flush LSN value
> >> to
> >>
Hi PG Hackers.
We are interested in enhancing the functionality of the pgoutput plugin by
adding support for generated columns.
Could you please guide us on the necessary steps to achieve this? Additionally,
do you have a platform for tracking such feature requests? Any insights or
assistance
On Sat, 9 Sept 2023 at 14:25, Imseih (AWS), Sami wrote:
>
> > This looks mostly fine to me modulo "sort or hash". I do see many
> > instances of "and/or" in the docs. Maybe that would work better.
>
> "sort or hash operations at the same time" is clear explanation IMO.
Just for anyone else follow
On Thu, 27 Apr 2023 at 13:18, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Julien,
>
> Thank you for updating the patch! Followings are my comments.
>
> 01. documentation
>
> In this page steps to upgrade server with pg_upgrade is aligned. Should we
> write
> down about subscriber? IIUC, it is suffici
On Wed, 10 May 2023 at 13:29, Peter Smith wrote:
>
> Here are some review comments for the v5-0001 patch code.
>
> ==
> General
>
> 1. ALTER SUBSCRIPTION name ADD TABLE (relid = XYZ, state = 'x' [, lsn =
> 'X/Y'])
>
> I was a bit confused by this relation 'state' mentioned in multiple
> place
On Thu, Aug 31, 2023 at 6:23 PM Peter Eisentraut
wrote:
> Attached is an updated patch set.
> There was some discussion about whether the catalog files are the right
> place to keep syscache information. Personally, I would find that more
> convenient. (Note that we also recently moved the def
Hi,
Thanks for the reply!
On Fri, 8 Sept 2023 at 11:05, Daniel Gustafsson wrote:
>
> > On 7 Sep 2023, at 18:06, Nazir Bilal Yavuz wrote:
>
> > if the changes are only in the docs, don't run
> > all tasks except building the docs task; this could help to save more
> > CI times.
>
> A related ide
On Fri, 8 Sept 2023 at 21:08, Pavel Stehule wrote:
> ok changed - there is minor problem - almost all PQ functions are of int
> type, but ProtocolVersion is uint
Your current implementation requires using the PG_PROTOCOL macros to
compare versions. But clients cannot currently use those macros s
On Mon, 4 Sept 2023 at 13:26, Amit Kapila wrote:
>
> On Mon, Sep 4, 2023 at 11:51 AM Amit Kapila wrote:
> >
> > On Wed, Jul 19, 2023 at 12:47 PM Michael Paquier
> > wrote:
> > >
> > > On Wed, May 10, 2023 at 05:59:24PM +1000, Peter Smith wrote:
> > > > 1. ALTER SUBSCRIPTION name ADD TABLE (reli
On Wed, 10 May 2023 at 13:39, Peter Smith wrote:
>
> On Mon, Apr 24, 2023 at 4:19 PM Julien Rouhaud wrote:
> >
> > Hi,
> >
> > On Thu, Apr 13, 2023 at 03:26:56PM +1000, Peter Smith wrote:
> > >
> > > 1.
> > > All the comments look alike, so it is hard to know what is going on.
> > > If each of th
Hi,
> I would like to propose a patch that allows administrators to disable `ALTER
> SYSTEM` via either a runt-time option to pass to the Postgres server process
> at startup (e.g. `--disable-alter-system=true`, false by default) or a new
> GUC (or even both), without changing the current defau
@Tom and @Robert, since you originally suggested extending the
protocol for this, I think some input from you on the protocol design
would be quite helpful. BTW, this protocol extension is the main
reason I personally care for this patch, because it would allow
PgBouncer to ask for updates on certa
11.09.2023 08:26, jian he wrote:
hi.
Thanks for reviewing it.
DETAIL: Unexpected end of input.
In many cases, ending errors will happen, so I consolidate it.
SELECT '{{},}'::text[];
solved by tracking current token type and previous token type.
select '{\{}'::text[];
solved by update dstend
Thank you for having a look at this. Apologies for not getting back to
you sooner.
On Wed, 5 Jul 2023 at 21:44, Heikki Linnakangas wrote:
>
> On 10/02/2023 04:51, David Rowley wrote:
> > I've attached another set of patches. I do need to spend longer
> > looking at this. I'm mainly attaching thes
On Mon, 11 Sept 2023 at 13:59, Jelte Fennema wrote:
> I think that would make the client code even simpler than it is now.
To be clear, I'm not saying we should do this. There's benefits to
using a dedicated new message type too (e.g. clearer errors if a proxy
like pgbouncer does not understand i
On Fri, Sep 8, 2023 at 11:06 AM Robert Haas wrote:
>
> On Thu, Sep 7, 2023 at 6:23 PM Melanie Plageman
> wrote:
> > I mostly wanted to remove the NULL checks because I found them
> > distracting (so, a stylistic complaint). However, upon further
> > reflection, I actually think it is better if he
> On 11 Sep 2023, at 13:03, Nazir Bilal Yavuz wrote:
>> Almost, but not entirely. There are a set of scripts which generate content
>> for the docs based on files in src/, like
>> src/backend/catalog/sql_features.txt
>> and src/include/parser/kwlist.h. If those source files change, or their
>>
On Fri, Sep 8, 2023 at 1:23 PM Dilip Kumar wrote:
> 2.
> - if ((failed = ExecRelCheck(resultRelInfo, slot, estate)) != NULL)
> + if ((failed = ExecRelCheck(resultRelInfo, slot, estate,
> checkConstraint, &recheckConstraints)) != NULL && !recheckConstraints)
>
>
> Why recheckConstraints need to ge
Dear Dilip,
Thank you for reviewing! PSA new version.
>
> 1.
> Note that slot restoration must be done after the final pg_resetwal command
> during the upgrade because pg_resetwal will remove WALs that are required by
> the slots. Due to this restriction, the timing of restoring replication slot
Dear Amit,
Thank you for giving a suggestion!
> >
> > > 2. Why get_old_cluster_logical_slot_infos() need to use
> > > pg_malloc_array whereas for similar stuff get_rel_infos() use
> > > pg_malloc()?
> >
> > They did a same thing. I used pg_malloc_array() macro to keep the code
> > within 80 colu
On Sat, Sep 9, 2023 at 5:14 PM Alvaro Herrera wrote:
>
> On 2023-Sep-08, Magnus Hagander wrote:
>
> > Now, it might be that you don't care at all about the *security* side
> > of the feature, and only care about the convenience side. But in that
> > case, the original suggestion from Tom of using
On Mon, Sep 11, 2023 at 1:56 PM Martín Marqués wrote:
>
> Hi,
>
> > I would like to propose a patch that allows administrators to disable
> > `ALTER SYSTEM` via either a runt-time option to pass to the Postgres server
> > process at startup (e.g. `--disable-alter-system=true`, false by default)
I only add below:
Datum fake_dinstance2(PG_FUNCTION_ARGS)
{
PG_RETURN_INT16(0);
}
in src/backend/utils/adt/int8.c, and the I run “make install”,
But I can’t find the fake_distance2 in src/backend/utils/fmgrtab.c which is
generated by src/backend/utils/Gen_fmgrtab.pl. What else do I need t
Hi Magnus,
On Mon, 11 Sept 2023 at 16:04, Magnus Hagander wrote:
> But to do that, there would need to be a very in-your-face warning in
> the documentation about it like "note that this only disables the
> ALTER SYSTEM command. It does not prevent a superuser from changing
> the configuration r
On Mon, Sep 11, 2023 at 10:02:55PM +1200, David Rowley wrote:
> On Sat, 9 Sept 2023 at 14:25, Imseih (AWS), Sami wrote:
> >
> > > This looks mostly fine to me modulo "sort or hash". I do see many
> > > instances of "and/or" in the docs. Maybe that would work better.
> >
> > "sort or hash operation
Greetings,
* Magnus Hagander (mag...@hagander.net) wrote:
> On Mon, Sep 11, 2023 at 1:56 PM Martín Marqués
> wrote:
> > > I would like to propose a patch that allows administrators to disable
> > > `ALTER SYSTEM` via either a runt-time option to pass to the Postgres
> > > server process at sta
Hi,
> I only add below:
>
> Datum fake_dinstance2(PG_FUNCTION_ARGS)
> {
> PG_RETURN_INT16(0);
> }
> in src/backend/utils/adt/int8.c, and the I run “make install”,
> But I can’t find the fake_distance2 in src/backend/utils/fmgrtab.c which is
> generated by src/backend/utils/Gen_fmgrtab.pl.
Hi Stephen,
On Mon, 11 Sept 2023 at 17:12, Stephen Frost wrote:
> A lot of the objections seem to be on the grounds of returning a
> 'permission denied' kind of error and I generally agree with that being
> the wrong approach.
>
> As an alternative idea- what if we had something in postgresql.co
Hi,
> The attached patch updates minRecoveryPoint and minRecoveryPointTLI at this
> point by mimicking CreateEndOfRecoveryRecord().
> With this patch, you can run pg_rewind with cascade standby immediately.
> (without waiting for checkpointing)
Many thanks for submitting the patch. I added it t
On Mon, 11 Sept 2023 at 11:11, Magnus Hagander wrote:
> I'm actually going to put a strong +1 to Gabriele's proposal. It's an
> > undeniable problem (I'm only seeing arguments regarding other ways the
> > system would be insecure), and there might be real use cases for users
> > outside kubernete
Hi
po 11. 9. 2023 v 17:59 odesílatel jacktby jacktby
napsal:
> I only add below:
>
> Datum fake_dinstance2(PG_FUNCTION_ARGS)
> {
> PG_RETURN_INT16(0);
> }
> in src/backend/utils/adt/int8.c, and the I run “make install”,
> But I can’t find the fake_distance2 in src/backend/utils/fmgrtab.c
> 2023年9月11日 23:51，Aleksander Alekseev 写道：
>
> Hi,
>
>> I only add below:
>>
>> Datum fake_dinstance2(PG_FUNCTION_ARGS)
>> {
>>PG_RETURN_INT16(0);
>> }
>> in src/backend/utils/adt/int8.c, and the I run “make install”,
>> But I can’t find the fake_distance2 in src/backend/utils/fmgrta
Dear Amit,
Thank you for reviewing!
> Few comments:
> ==
> 1.
> +linkend="view-pg-replication-slots">pg_replication_slots.c
> onfirmed_flush_lsn
> + of all slots on the old cluster must be the same as the latest
> + checkpoint location.
>
> We can add something li
On 2023-09-11 12:28, jacktby jacktby wrote:
2023年9月11日 23:51，Aleksander Alekseev 写道：
often better) add a corresponding extension to /contrib/. You can find
a complete example here [1] for instance, see v4-0001 patch and the
function pg_get_relation_publishing_info(). Make sure it has a proper
vo
po 11. 9. 2023 v 18:18 odesílatel Pavel Stehule
napsal:
> Hi
>
> po 11. 9. 2023 v 17:59 odesílatel jacktby jacktby
> napsal:
>
>> I only add below:
>>
>> Datum fake_dinstance2(PG_FUNCTION_ARGS)
>> {
>> PG_RETURN_INT16(0);
>> }
>> in src/backend/utils/adt/int8.c, and the I run “make insta
On Mon, 2023-09-11 at 07:24 +0900, Michael Paquier wrote:
> I'm OK with enforcing COLLPROVIDER_LIBC in this path, but I also
> value
> consistency across all the error messages of this file. After
> sleeping on it, and as that's a set of elogs, "unsupported
> collprovider" is fine for me across th
po 11. 9. 2023 v 13:24 odesílatel Jelte Fennema napsal:
> On Fri, 8 Sept 2023 at 21:08, Pavel Stehule
> wrote:
> > ok changed - there is minor problem - almost all PQ functions are of int
> type, but ProtocolVersion is uint
>
> Your current implementation requires using the PG_PROTOCOL macros to
On Sun, Sep 3, 2023 at 12:17 PM Thomas Munro wrote:
> (Huh, while contemplating trying that, I just noticed that the GCC
> build farm's AIX 7.2 system seems to have given up the ghost a few
> weeks ago. I wonder if it'll come back online with the current
> release, or if that's the end... There
On Sat, Sep 9, 2023 at 9:00 PM Alexander Lakhin wrote:
> Yes, I think we deal with something like that. I can try to deduce a minimum
> change that affects reproducing the issue, but may be it's not that important.
> Perhaps we now should think of escalating the problem to FreeBSD developers?
> I
On Sat, Sep 9, 2023 at 4:21 AM Tatsuo Ishii wrote:
> Then we will get for str_set:
> r0: B
> r1: AB
>
> Because r0 only has classifier B, r1 can have A and B. Problem is,
> r2. If we choose A at r1, then r2 = B. But if we choose B at t1, then
> r2 = AB. I guess this is the issue you pointed out.
Hi Kuroda-san, here are my review comments for v34-0002
There is likely to be some overlap because others have modified and/or
commented on some of the same points as me, and v35 was already posted
before this review. I'll leave it to you to sort out any clashes and
ignore them where appropriate.
On Mon, Sep 11, 2023 at 12:15:49PM -0700, Jeff Davis wrote:
> That's fine with me.
Okay. Then, please find attached a v4 for HEAD and REL_16_STABLE.
--
Michael
diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
index aa9da99308..c02fa7b203 100644
--- a/src/backend/
Em seg., 11 de set. de 2023 às 21:03, Michael Paquier
escreveu:
> On Mon, Sep 11, 2023 at 12:15:49PM -0700, Jeff Davis wrote:
> > That's fine with me.
>
> Okay. Then, please find attached a v4 for HEAD and REL_16_STABLE.
>
LGTM.
best regards,
Ranier Vilela
Hi Kuroda-san.
Here are some additional review comments for v35-0002 (and because we
overlapped, my v34-0002 review comments have not been addressed yet)
==
Commit message
1.
Note that the pg_resetwal command would remove WAL files, which are required as
restart_lsn. If WALs required by log
Hi,
On 2023-08-29 17:54:24 +0200, Alvaro Herrera wrote:
> On 2023-Aug-27, Thomas Munro wrote:
>
> > On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule
> > wrote:
> > > So it looks so IPC::Run::run is ignore parent environment
> >
> > I guess the new initdb template captures lc_messages in
> > postg
On Monday, September 11, 2023 9:22 PM Kuroda, Hayato/黒田 隼人
wrote:
>
> Thank you for reviewing! PSA new version.
Thanks for updating the patch, few cosmetic comments:
1.
#include "access/transam.h"
#include "catalog/pg_language_d.h"
+#include "fe_utils/string_utils.h"
#include "pg_upgrade.h"
Thank you for your advice, Jelte.
I have refactored my code, please see the attached patch. (and I put it into
https://commitfest.postgresql.org/45/ for trace)
Thanks.
From: Jelte Fennema
Sent: Monday, September 11, 2023 15:04
To: Hongxu Ma
Cc: David G. Johnsto
On Fri, Sep 8, 2023 at 8:28 AM Nathan Bossart wrote:
>
> On Thu, Sep 07, 2023 at 12:36:29PM +1200, Peter Smith wrote:
> > Modified as suggested. PSA v3.
>
> Thanks. I've attached v4 with a couple of small changes. Notably, I've
> moved the worker_type column to before the pid column, as it felt
On Tue, Sep 12, 2023 at 01:07:51PM +1000, Peter Smith wrote:
> The type is only assigned during worker process launch, and during
> process cleanup [1]. It's only possible to be UNKNOWN after
> logicalrep_worker_cleanup().
>
> AFAIK the stats can never see a worker with an UNKNOWN type, although
>
On Tue, Sep 12, 2023 at 02:39:55AM +, Hongxu Ma wrote:
> Thank you for your advice, Jelte.
> I have refactored my code, please see the attached patch. (and I put
> it into https://commitfest.postgresql.org/45/ for trace)
{
+ long total_cells;
long is 4 bytes on Windows, and 8 bytes bas
On Tue, Sep 12, 2023 at 02:33:25AM +, Zhijie Hou (Fujitsu) wrote:
> 2.
> + if (*invalidated && SlotIsLogical(s) && IsBinaryUpgrade)
> + elog(ERROR, "Replication slots must not be invalidated
> during the upgrade.");
>
> I think normally the first letter is lowe
Michael Paquier writes:
> On Tue, Sep 12, 2023 at 02:39:55AM +, Hongxu Ma wrote:
> + long total_cells;
> long is 4 bytes on Windows, and 8 bytes basically elsewhere. So you
> would still have the same problem on Windows, no?
More to the point: what about the multiplication in printTab
> 2023年9月12日 00:34，Chapman Flack 写道：
>
> On 2023-09-11 12:28, jacktby jacktby wrote:
>>> 2023年9月11日 23:51，Aleksander Alekseev 写道：
>>> often better) add a corresponding extension to /contrib/. You can find
>>> a complete example here [1] for instance, see v4-0001 patch and the
>>> function pg_
On Mon, Sep 11, 2023 at 02:49:49PM +0530, Amit Kapila wrote:
> I don't know if the difference is worth inventing a new BACKEND_TYPE_*
> but if you think so then we can probably discuss this in a new thread.
> I think we may want to improve some comments as a separate patch to
> make this evident.
On 10.08.23 07:58, Peter Eisentraut wrote:
There are also a couple of issues in the MSVC legacy build system that
would need to be tightened up in order to survive with fatal Perl
warnings. Obviously, there is a question whether it's worth spending
any time on that anymore.
It looks like the
On Mon, Sep 11, 2023 at 07:04:30PM +0300, Aleksander Alekseev wrote:
> Many thanks for submitting the patch. I added it to the nearest open
> commitfest [1].
>
> IMO a test is needed that makes sure no one is going to break this in
> the future.
You definitely need more complex test scenarios for
On Wed, Sep 06, 2023 at 12:45:24AM +0900, Yugo NAGATA wrote:
> I attached the update patch. I removed the incorrect comments and
> unnecessary lines. Also, I rewrote the test to use "skip_all" instead
> of SKIP because we skip the whole test rather than a part of it.
Thanks for checking how IPC::
>> What about leaving this (reevaluation) for now? Because:
>>
>> 1) we don't have CLASSIFIER
>> 2) we don't allow to give CLASSIFIER to PREV as its arggument
>>
>> so I think we don't need to worry about this for now.
>
> Sure. I'm all for deferring features to make it easier to iterate; I
> just
I like this work a lot. It's good to give developers easy to verify
guidance about formatting the --help messages.
However, I think instead of just adding a bunch of line breaks to
satisfy the test, we should really try to make the lines shorter by
rewording. Otherwise, chances are we are ma
63 matches
Mail list logo
