Dear Amit,

Thank you for giving a suggestion!

> >
> > >  2. Why get_old_cluster_logical_slot_infos() need to use
> > > pg_malloc_array whereas for similar stuff get_rel_infos() use
> > > pg_malloc()?
> >
> > They did a same thing. I used pg_malloc_array() macro to keep the code
> > within 80 columns.
> >
> 
> I think it is better to be consistent with the existing code in this
> case. Also, see, if the usage in get_loadable_libraries() can also be
> changed back to use pg_malloc().

Fixed as you said. The line becomes too long, so a variable was newly 
introduced.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Reply via email to