On Tue, 29 Aug 2023 at 07:37, Bruce Momjian wrote:
> nargs = 0;
> foreach(lc, args)
> {
> actual_arg_types[nargs++] = exprType((Node *) lfirst(lc));
> }
Does it still produce the warning if you form the above more like?
nargs = list
On Tue, Aug 29, 2023 at 11:55:48AM +1200, David Rowley wrote:
> On Tue, 29 Aug 2023 at 07:37, Bruce Momjian wrote:
> > nargs = 0;
> > foreach(lc, args)
> > {
> > actual_arg_types[nargs++] = exprType((Node *) lfirst(lc));
> > }
>
> Do
Thanks for the insightful response! I have attached an updated patch
that moves the proposed logic to the end of StartupXLOG where it seems
more correct to do this. It also helps with backporting (if it's
needed) since the archiver process only has access to shared memory
starting from Postgres 14.
On Mon, Aug 28, 2023 at 07:10:38PM -0400, Bruce Momjian wrote:
> On Tue, Aug 29, 2023 at 07:30:15AM +0900, Michael Paquier wrote:
> > On Mon, Aug 28, 2023 at 03:37:20PM -0400, Bruce Momjian wrote:
> > > I don't see a clean way of avoiding the warning except by initializing
> > > the array, which se
> Yeah, both of you are right here. Anyway, it seems to me that there
> is a bit more going on in protocol.h. I have noticed two more things
> that are incorrect:
> - HandleParallelMessage is missing a message for 'P', but I think that
> we should have a code for it as well as part of the paralle
On Mon, Aug 28, 2023 at 4:15 PM Melanie Plageman
wrote:
> On Mon, Aug 28, 2023 at 5:06 PM Peter Geoghegan wrote:
> > What I've described in a scheme for deciding to not freeze where that
> > would usually happen -- a scheme for *vetoing* page freezing -- rather
> > than a scheme for deciding to f
On Mon, Aug 28, 2023 at 05:29:56PM +1200, Thomas Munro wrote:
> CI shows Windows
> consuming 4 CPUs at 100% for a full 10 minutes to run a test suite
> that finishes in 2-3 minutes everywhere else with the same number of
> CPUs. Could there be an event handling snafu in IPC::Run or elsewhere
> nea
On Sun, Aug 27, 2023 at 5:52 PM Michael Paquier wrote:
> From what I can see, this is is a rather old issue, because
> ListenSocket[] is filled with PGINVALID_SOCKET *after* starting the
> syslogger. It seems to me that we should just initialize the array
> before starting the syslogger, so as we
On Tue, Aug 29, 2023 at 6:56 AM David Rowley wrote:
>
> I'm just not sure if it's unable to figure out if at least nargs
> elements is set or if it won't be happy until all 100 elements are
> set.
It looks like the former, since I can silence it on gcc 13 / -O1 by doing:
/* keep compiler quiet *
Thank you for your interest in this problem and help, and I'm sorry that
I didn't respond to this email for a long time. To be honest, I wanted
to investigate the problems in more detail and already answer more
clearly, but unfortunately I have not found anything more significant yet.
On 21.08
On Mon, Aug 28, 2023 at 5:35 AM Peter Smith wrote:
>
> On Fri, Aug 25, 2023 at 8:15 PM Amit Kapila wrote:
>
> IMO there are inconsistencies in the second patch that was pushed.
>
> 1. In the am_xxx functions, why is there Assert 'in_use' only for the
> APPLY / PARALLEL_APPLY workers but not for T
On Tue, Aug 29, 2023 at 1:48 PM Noah Misch wrote:
> https://github.com/cpan-authors/IPC-Run/issues/166#issuecomment-1288190929
Interesting. But that shows a case with no pipes connected, using
select() as a dumb sleep and ignoring SIGCHLD. In our usage we have
pipes connected, and I think selec
On Tue, Aug 29, 2023 at 1:23 AM Andrew Dunstan wrote:
> I like the idea of using a pure perl pq implementation, not least because it
> could expand our ability to test things at the protocol level. Not sure how
> much work it would be. I'm willing to help if we want to go that way.
Cool. Let's
On Mon, 28 Aug 2023 at 18:56, Amit Kapila wrote:
>
> On Thu, Aug 24, 2023 at 11:44 AM vignesh C wrote:
> >
>
> The patch looks mostly good to me. I have made minor changes which are
> as follows: (a) removed the autovacuum =off and
> wal_receiver_status_interval = 0 setting as those doesn't seem
At Mon, 28 Aug 2023 13:36:00 +0200, Alvaro Herrera
wrote in
> On 2023-Aug-28, Kyotaro Horiguchi wrote:
>
> > But with these tables:
> >
> > create table p (a int, b int not null default 0);
> > create table c1 (a int, b int not null NO INHERIT default 1) inherits (p);
> >
> > I get:
> >
> >
On Mon Aug 28, 2023 at 2:37 PM CDT, Bruce Momjian wrote:
I don't see a clean way of avoiding the warning except by initializing
the array, which seems wasteful.
For what it's worth, we recently committed a patch[0] that initialized
an array due to a similar warning being generated on Fedora 38
Hi,
On 8/28/23 10:04 AM, Michael Paquier wrote:
On Mon, Jul 17, 2023 at 10:16:02AM +0900, Michael Paquier wrote:
So you mean to switch a line that now looks like that:
WAIT_EVENT_FOO_BAR FooBar"Waiting on Foo Bar."
To that:
FOO_BAR "Waiting on Foo Bar."
Or even that:
WAIT_EVENT_FOO_
On 29/08/2023 01:28, Michael Paquier wrote:
In case you've not noticed:
https://www.postgresql.org/message-id/zovvuqe0rdj2s...@paquier.xyz
But it does not really matter now ;)
Ah sorry, missed that thread.
Yes, so it seems. Syslogger is started before the ListenSockets array is
initialized,
On Mon, Aug 28, 2023 at 1:01 PM Peter Smith wrote:
>
> Hi, here are my review comments for v26-0003
>
> It seems I must defend some of my previous suggestions from v25* [1],
> so here goes...
>
> ==
> src/bin/pg_upgrade/check.c
>
> 1. check_and_dump_old_cluster
>
> CURRENT CODE (with v26-0003
On 29/08/2023 06:18, Peter Geoghegan wrote:
On Sun, Aug 27, 2023 at 5:52 PM Michael Paquier wrote:
From what I can see, this is is a rather old issue, because
ListenSocket[] is filled with PGINVALID_SOCKET *after* starting the
syslogger. It seems to me that we should just initialize the array
On Tue, Aug 29, 2023 at 09:27:48AM +0300, Heikki Linnakangas wrote:
> Just to close the loop on this thread: I committed and backpatched Michael's
> fix.
Thanks!
--
Michael
signature.asc
Description: PGP signature
On Tue, Aug 29, 2023 at 08:17:10AM +0200, Drouvot, Bertrand wrote:
> Agree that done that way one could easily grep the events from the
> source code and match them with wait_event_names.txt. Then I don't
> think the "search" issue in the code is still a concern with the
> current proposal.
It cou
On Tue, Aug 29, 2023 at 1:48 PM Noah Misch wrote:
> On Mon, Aug 28, 2023 at 05:29:56PM +1200, Thomas Munro wrote:
> > 1. Don't fork anything at all: open (and cache) a connection directly
> > from Perl.
> > 1a. Write xsub or ffi bindings for libpq. Or vendor (parts) of the
> > popular Perl xsub
On 29/08/2023 09:21, Heikki Linnakangas wrote:
Thinking about this some more, the ListenSockets array is a bit silly
anyway. We fill the array starting from index 0, always append to the
end, and never remove entries from it. It would seem more
straightforward to keep track of the used size of th
On 2023-08-26 21:03, James Coleman wrote:
On Fri, Aug 25, 2023 at 7:43 AM James Coleman wrote:
On Thu, Aug 17, 2023 at 10:02 AM torikoshia
wrote:
>
> On 2023-06-16 01:34, James Coleman wrote:
> > Attached is v28
> > which sets ProcessLogQueryPlanInterruptActive to false in errfinish
> > whe
While translating a message, I found a questionable behavior in \d+,
introduced by a recent commit b0e96f3119. In short, the current code
hides the constraint's origin when "NO INHERIT" is used.
For these tables:
create table p (a int, b int not null default 0);
create table c1 (a int, b int not
On Sun, Aug 27, 2023 at 7:53 PM Masahiko Sawada
wrote:
>
> I've updated the regression tests for tidstore so that it uses SQL
> functions to add blocks/offsets and dump its contents. The new test
> covers the same test coverages but it's executed using SQL functions
> instead of executing all test
Hi, here are my comments for patch v26-0002.
==
1. About the PG17 limitation
In my previous review of v25-0002, I suggested that the PG17
limitation should be documented atop one of the source files. See
[1]#3, [1]#7, [1]#10
I just wanted to explain the reason for that suggestion.
Currently
Hi, here are my review comments for v26-0003
It seems I must defend some of my previous suggestions from v25* [1],
so here goes...
==
src/bin/pg_upgrade/check.c
1. check_and_dump_old_cluster
CURRENT CODE (with v26-0003 patch applied)
/* Extract a list of logical replication slots */
get_ol
On Mon, Jul 17, 2023 at 10:16:02AM +0900, Michael Paquier wrote:
> So you mean to switch a line that now looks like that:
> WAIT_EVENT_FOO_BAR FooBar"Waiting on Foo Bar."
> To that:
> FOO_BAR "Waiting on Foo Bar."
> Or even that:
> WAIT_EVENT_FOO_BAR "Waiting on Foo Bar."
>
> Sure, i
On Mon, Aug 28, 2023 at 5:14 AM Michael Paquier wrote:
>
> On Fri, Aug 25, 2023 at 11:08:25AM +0530, Dilip Kumar wrote:
> > Here is the updated version of the patch.
>
> The concept of the patch looks sound to me. I have a few comments.
Thanks for the review
> +* This special record, ho
On Mon, Aug 28, 2023 at 11:50:45AM +0530, Ashutosh Sharma wrote:
> Thanks for reviewing the patch and adding a CF entry for it. PFA patch
> that addresses your review comments.
That looks OK seen from here. Perhaps others have more comments?
> And... Sorry for the delayed response. I totally mis
On Sat, Aug 26, 2023 at 1:58 AM Jelte Fennema wrote:
>
> The cached plan for a prepared statements can get invalidated when DDL
> changes the tables used in the query, or when search_path changes. When
> this happens the prepared statement can still be executed, but it will
> be replanned in the n
On Thu, Aug 24, 2023 at 9:36 AM Vaibhav Dalvi <
vaibhav.da...@enterprisedb.com> wrote:
> Hi Amul,
>
>
> On Wed, Aug 2, 2023 at 4:06 PM Amul Sul wrote:
>
>> Hi,
>>
>> Currently, we have an option to drop the expression of stored generated
>> columns
>> as:
>>
>> ALTER [ COLUMN ] column_name DROP E
PQputCopyEnd returns 1 or -1, never 0, I guess the comment was
copy/paste from PQputCopyData's comment, this should be fixed.
--
Regards
Junwang Zhao
v1-0001-PQputCopyEnd-never-returns-0-fix-the-inaccurate-c.patch
Description: Binary data
On Fri, Aug 25, 2023 at 5:35 AM Vik Fearing wrote:
> On 8/2/23 12:35, Amul Sul wrote:
> > Hi,
> >
> > Currently, we have an option to drop the expression of stored generated
> > columns
> > as:
> >
> > ALTER [ COLUMN ] column_name DROP EXPRESSION [ IF EXISTS ]
> >
> > But don't have support to up
On 2023-Aug-28, Kyotaro Horiguchi wrote:
> But with these tables:
>
> create table p (a int, b int not null default 0);
> create table c1 (a int, b int not null NO INHERIT default 1) inherits (p);
>
> I get:
>
> > Not-null constraints:
> >"c1_b_not_null" NOT NULL "b" *NO INHERIT*
>
> Here,
Hi
I workin with protocol and reading related code.
I found in routine EndCommand one strange thing
void
EndCommand(const QueryCompletion *qc, CommandDest dest, bool
force_undecorated_output)
{
<-->char<--><-->completionTag[COMPLETION_TAG_BUFSIZE];
<-->Size<--><-->len;
<-->switch (dest)
<-->{
<
Hi Junwang,
> PQputCopyEnd returns 1 or -1, never 0, I guess the comment was
> copy/paste from PQputCopyData's comment, this should be fixed.
The patch LGTM but I wonder whether we should also change all the
existing calls of PQputCopyEnd() from:
```
PQputCopyEnd(...) <= 0
```
... to:
```
PQpu
Dear hackers,
I also tested for logical slots on the physical standby. PSA the script.
confirmed_flush_lsn for such slots were successfully persisted.
# Topology
In this test nodes are connected each other.
node1 --(physical replication)-->node2--(logical replication)-->node3
# Test method
An
Hi
>>
>>
>> But afaict there's no problem with using pqParseInput3() and
>> PQexecFinish() even if the message isn't handled as part of the
>> transaction. Some other messages that pqParseInput3 handles which are
>> not part of the transaction are 'N' (Notice) and 'K' (secret key).
>>
>
> I have
Hi Pavel,
> There is message PqMsgClose, but this should be used from client side. Here
> should be used PqMsg_CommandComplete instead?
It seems so. This change was introduced in f4b54e1ed98 [1]:
```
--- a/src/backend/tcop/dest.c
+++ b/src/backend/tcop/dest.c
@@ -176,7 +176,7 @@ EndCommand(cons
On Thu, 2023-08-17 at 09:37 +0900, Michael Paquier wrote:
> I have just noticed that we do not have a CF entry for this proposal,
> so I have added one with Laurenz as author:
> https://commitfest.postgresql.org/44/4504/
I have changed the author to Fujii Masao.
Yours,
Laurenz Albe
On Thu, 2023-08-24 at 18:23 +0200, Matthias van de Meent wrote:
> On Wed, 19 Jul 2023 at 15:13, Thom Brown wrote:
> >
> > On Wed, 19 Jul 2023, 13:58 Laurenz Albe, wrote:
> > > I agree that the name "max_local_update" could be improved.
> > > Perhaps "avoid_hot_above_size_mb".
> >
> > Or "hot_ta
On 10.06.23 22:24, Andres Freund wrote:
Looks like we ought to add --exported-interfaces-only?
Btw., this option requires libabigail 2.1, which isn't available
everywhere yet. For example, Debian oldstable (used on Cirrus) doesn't
have it yet. So I'll leave this patch set as is for now. If
> On 23 Aug 2023, at 23:12, Daniel Gustafsson wrote:
>
>> On 23 Aug 2023, at 23:02, Tom Lane wrote:
>>
>> Daniel Gustafsson writes:
>>> On 23 Aug 2023, at 21:22, Andres Freund wrote:
I think there's more effective ways to make this cheaper. The basic thing
would be to use libpq inst
On 25.08.23 13:38, Alvaro Herrera wrote:
I have now pushed this again. Hopefully it'll stick this time.
We may want to make some further tweaks to the behavior in some cases --
for example, don't disallow ALTER TABLE DROP NOT NULL when the
constraint is both inherited and has a local definition
po 28. 8. 2023 v 13:58 odesílatel Pavel Stehule
napsal:
> Hi
>
>
>>>
>>>
>>> But afaict there's no problem with using pqParseInput3() and
>>> PQexecFinish() even if the message isn't handled as part of the
>>> transaction. Some other messages that pqParseInput3 handles which are
>>> not part of t
Dear Peter,
Thank you for reviewing! PSA new version patch set.
> ==
> 1. About the PG17 limitation
>
> In my previous review of v25-0002, I suggested that the PG17
> limitation should be documented atop one of the source files. See
> [1]#3, [1]#7, [1]#10
>
> I just wanted to explain the re
Dear Peter,
Thank you for reviewing!
> 1. check_and_dump_old_cluster
>
> CURRENT CODE (with v26-0003 patch applied)
>
> /* Extract a list of logical replication slots */
> get_old_cluster_logical_slot_infos();
>
> ...
>
> /*
> * Logical replication slots can be migrated since PG17. See commen
On 25.08.2023 8:57 PM, Jelte Fennema wrote:
The cached plan for a prepared statements can get invalidated when DDL
changes the tables used in the query, or when search_path changes. When
this happens the prepared statement can still be executed, but it will
be replanned in the new context. Thi
When looking at pg_regress I noticed that the --use-existing support didn't
seem to work. ISTM that the removal/creation of test databases and roles
doesn't run since the conditional is reversed. There is also no support for
using a non-default socket directory with PG_REGRESS_SOCK_DIR. The atta
On 2023-08-28 Mo 01:29, Thomas Munro wrote:
Hi,
Every time we run a SQL query, we fork a new psql process and a new
cold backend process. It's not free on Unix, and quite a lot worse on
Windows, at around 70ms per query. Take amcheck/001_verify_heapam for
example. It runs 272 subtests firing
On Thu, Aug 24, 2023 at 11:44 AM vignesh C wrote:
>
The patch looks mostly good to me. I have made minor changes which are
as follows: (a) removed the autovacuum =off and
wal_receiver_status_interval = 0 setting as those doesn't seem to be
required for the test; (b) changed a few comments and var
On 22.08.23 16:26, Aleksander Alekseev wrote:
Hi Peter,
This started out as a small patch to make pg_controldata use the logging
API instead of printf statements, and then it became a larger patch to
adjust error and warning messages about invalid WAL segment sizes
(IsValidWalSegSize()) across
On Fri, Aug 11, 2023 at 9:50 AM Amit Langote wrote:
> After removing the unnecessary cleanup code from most node types’ ExecEnd*
> functions, one thing I’m tempted to do is remove the functions that do
> nothing else but recurse to close the outerPlan, innerPlan child nodes. We
> could instead
> On 22 Aug 2023, at 23:23, Greg Sabino Mullane wrote:
>
> Thank you for the feedback, everyone. Attached is version 4 of the patch,
> featuring a few tests and minor rewordings.
I had another look, and did some playing around with this and I think this
version is ready to go in, so I will try
On Mon, Aug 28, 2023 at 7:48 PM Aleksander Alekseev
wrote:
>
> Hi Junwang,
>
> > PQputCopyEnd returns 1 or -1, never 0, I guess the comment was
> > copy/paste from PQputCopyData's comment, this should be fixed.
>
> The patch LGTM but I wonder whether we should also change all the
> existing calls
I would like to be the commitfest manager for CF 2023-09.
On Mon, Aug 28, 2023 at 3:01 AM torikoshia wrote:
>
> On 2023-08-26 21:03, James Coleman wrote:
> > On Fri, Aug 25, 2023 at 7:43 AM James Coleman wrote:
> >>
> >> On Thu, Aug 17, 2023 at 10:02 AM torikoshia
> >> wrote:
> >> >
> >> > On 2023-06-16 01:34, James Coleman wrote:
> >> > > Attached is
On Wed, 19 Jul 2023 at 14:58, Laurenz Albe wrote:
>
> On Thu, 2023-07-06 at 22:18 +0200, Matthias van de Meent wrote:
> > On Wed, 5 Jul 2023 at 19:55, Thom Brown wrote:
> > >
> > > On Wed, 5 Jul 2023 at 18:05, Matthias van de Meent
> > > wrote:
> > > > So what were you thinking of? A session GUC
Re: Andres Freund
> > Thanks. I realised that it's easy enough to test that theory about
> > cleanup locks by hacking ConditionalLockBufferForCleanup() to return
> > false randomly. Then the test occasionally fails as described. Seems
> > like we'll need to fix that test, but it's not evidence o
On Fri, Jul 28, 2023 at 3:27 PM Melanie Plageman
wrote:
> On Fri, Jul 28, 2023 at 3:00 PM Peter Geoghegan wrote:
> > > Is this test meant to guard against unnecessary freezing or to avoid
> > > freezing when the cost is too high? That is, are we trying to
> > > determine how likely it is that the
Hi
po 28. 8. 2023 v 14:00 odesílatel Aleksander Alekseev <
aleksan...@timescale.com> napsal:
> Hi Pavel,
>
> > There is message PqMsgClose, but this should be used from client side.
> Here should be used PqMsg_CommandComplete instead?
>
> It seems so. This change was introduced in f4b54e1ed98 [1]
Hi,
> here is a patch - all tests passed
LGTM and added to the nearest CF just in case [1].
[1]: https://commitfest.postgresql.org/44/4523/
--
Best regards,
Aleksander Alekseev
Hi Peter,
> I would like to be the commitfest manager for CF 2023-09.
Many thanks for volunteering! If at some point you will require a bit
of help please let me know.
--
Best regards,
Aleksander Alekseev
On Mon, Aug 28, 2023 at 4:20 PM John Naylor
wrote:
>
> On Sun, Aug 27, 2023 at 7:53 PM Masahiko Sawada wrote:
> >
> > I've updated the regression tests for tidstore so that it uses SQL
> > functions to add blocks/offsets and dump its contents. The new test
> > covers the same test coverages but i
On Thu, Aug 24, 2023 at 6:25 PM Michael Paquier wrote:
> LD_PRELOAD is the only thing I can think about, but that's very fancy.
> Even with that, having a certificate with a NULL peer_cn could prove
> to be useful in the SSL suite to stress more patterns around it?
+1. Last we tried it, OpenSSL d
On Mon, Aug 28, 2023 at 10:52 AM Matthias van de Meent
wrote:
> In this new patch, I've updated a few comments to get mostly within
> line length limits; the name of the storage parameter is now
> "local_update_limit", as per discussion on naming.
> I've also added local_update_limit to psql's aut
On Mon, Aug 28, 2023 at 11:36 AM Aleksander Alekseev
wrote:
>
> Hi Peter,
>
> > I would like to be the commitfest manager for CF 2023-09.
>
> Many thanks for volunteering! If at some point you will require a bit
> of help please let me know.
I too had planned to volunteer to help. I volunteer to
On 2023-Aug-28, Peter Eisentraut wrote:
> It looks like we forgot about domain constraints? For example,
>
> create domain testdomain as int not null;
>
> should create a row in pg_constraint?
Well, at some point I purposefully left them out; they were sufficiently
different from the ones in t
On Mon, 28 Aug 2023 at 17:14, Robert Haas wrote:
>
> On Mon, Aug 28, 2023 at 10:52 AM Matthias van de Meent
> wrote:
> > In this new patch, I've updated a few comments to get mostly within
> > line length limits; the name of the storage parameter is now
> > "local_update_limit", as per discussion
On Thu, Aug 24, 2023 at 10:05 AM Heikki Linnakangas wrote:
> On 24/08/2023 15:48, Thomas Munro wrote:
> > LGTM. I vaguely recall thinking that it might be better to keep
> > EXEC_BACKEND and !EXEC_BACKEND working the same which might be why I
> > didn't try this one, but it looks fine with the c
On Mon, Aug 28, 2023 at 11:50 AM Matthias van de Meent
wrote:
> Agreed on all points. But isn't that true for most most tools on bloat
> prevention and/or detection? E.g. fillfactor, autovacuum_*, ...
Not nearly to the same extent, IMHO. A lot of those parameters can be
left alone forever and you
Hi Melanie,
On 8/28/23 11:42, Melanie Plageman wrote:
I too had planned to volunteer to help. I volunteer to do a
triage/summary of patch statuses, as has been done occasionally in the
past [1].
Have folks found this helpful in the past?
Having a summary to begin with is very helpful for revi
On Mon, Aug 28, 2023 at 10:00 AM Melanie Plageman
wrote:
> For the second goal, I've relied on past data to predict future
> behavior, so I tried several criteria to estimate the likelihood that a
> page will not be imminently modified. What was most effective was
> Andres' suggestion of comparing
On Mon, 28 Aug 2023 at 15:05, Konstantin Knizhnik wrote:
> The following assignment of format is not corrects:
>
> It has to be copied as below:
>
> portal->formats = (int16 *)
> MemoryContextAlloc(portal->portalContext,
> natts * sizeof(int16));
>
On Mon, Aug 28, 2023 at 7:00 AM Melanie Plageman
wrote:
> I believe that there are two goals that should dictate whether or not we
> should perform opportunistic freezing:
>
> 1. Is it cheap? For example, if the buffer is already dirty, then no
> write amplification occurs, since it must be wr
On Mon, 28 Aug 2023 at 11:27, jian he wrote:
> With parameters, it also works, only a tiny issue with error reporting.
>
> prepstmt2 | PREPARE prepstmt2(bigint) AS SELECT * FROM pcachetest
> WHERE q1 = $1; | {bigint}| {bigint,bigint,bigint}
> ERROR: column "q1" does not exist at character
On 28.08.2023 18:12, Jacob Champion wrote:
On Thu, Aug 24, 2023 at 6:25 PM Michael Paquier wrote:
LD_PRELOAD is the only thing I can think about, but that's very fancy.
Even with that, having a certificate with a NULL peer_cn could prove
to be useful in the SSL suite to stress more patterns aro
Hi,
Attached is the PostgreSQL 16 RC1 release announcement draft.
Currently there is only one item in it, as there was only one open item
marked as closed. If there are any other fixes for the RC1 that were
specific to v16 and should be included in the announcement, please let
me know.
Plea
On 8/22/23 16:24, Peter Eisentraut wrote:
On 22.08.23 15:29, Tom Lane wrote:
Alvaro Herrera writes:
Yeah, I've been proposing this kind of thing for many years; the
problem, until not long ago, was that the tooling was unable to process
non-Latin1 characters in all the output formats that we u
On Mon, Aug 28, 2023 at 7:00 AM Melanie Plageman
wrote:
> To do this, we need to save that insert LSN
> somewhere. In the attached WIP patch, I saved it in the table stats, for
> now -- knowing that those are not crash-safe.
What patch? You didn't actually attach one.
> Other discarded heuristic
On Debian 12, gcc version 12.2.0 (Debian 12.2.0-14) generates a warning
on PG 13 to current, but only with -O1 optimization level, and not at
-O0/-O2/-O3:
clauses.c: In function ‘recheck_cast_function_args’:
clauses.c:4293:19: warning: ‘actual_arg_types’ may be used
uninitialized
On Mon, Aug 28, 2023 at 3:09 PM Peter Geoghegan wrote:
> I've long emphasized the importance of designs that just try to avoid
> disaster. With that in mind, I wonder: have you thought about
> conditioning page freezing on whether or not there are already some
> frozen tuples on the page? You coul
On Mon, Aug 28, 2023 at 12:26 PM Robert Haas wrote:
>
> On Mon, Aug 28, 2023 at 10:00 AM Melanie Plageman
> wrote:
> Then there's the question of whether it's the right metric. My first
> reaction is to think that it sounds pretty good. One thing I really
> like about it is that if the table is b
On 28/08/2023 18:55, Jeff Janes wrote:
Since this commit, I'm getting a lot (63 per restart) of messages:
LOG: could not close client or listen socket: Bad file descriptor
All I have to do to get the message is turn logging_collector = on and
restart.
The close failure condition existed be
On Mon, Aug 28, 2023 at 1:17 PM Robert Haas wrote:
> I'm sure this could be implemented, but it's unclear to me why you
> would expect it to perform well. Freezing a page that has no frozen
> tuples yet isn't cheaper than freezing one that does, so for this idea
> to be a win, the presence of froz
>> Hi Pavel,
>>
>> > There is message PqMsgClose, but this should be used from client side.
>> Here should be used PqMsg_CommandComplete instead?
>>
>> It seems so. This change was introduced in f4b54e1ed98 [1]:
>>
>> ```
>> --- a/src/backend/tcop/dest.c
>> +++ b/src/backend/tcop/dest.c
>> @@ -176,
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Hello,
I've reviewed your patch and it applies and builds without er
On Tue, Aug 29, 2023 at 1:58 AM Christoph Berg wrote:
> This should be fixed before the 16 release.
Here's what I was thinking of doing for this, given where we are in
the release schedule:
* commit the signal-refactoring patch in master only
* plan to back-patch it into 16 in a later point rele
On Mon, Aug 28, 2023 at 11:52:15PM +0300, Heikki Linnakangas wrote:
> On 28/08/2023 18:55, Jeff Janes wrote:
>> Since this commit, I'm getting a lot (63 per restart) of messages:
>>
>> LOG: could not close client or listen socket: Bad file descriptor
>> All I have to do to get the message is tu
On Mon, Aug 28, 2023 at 03:37:20PM -0400, Bruce Momjian wrote:
> I don't see a clean way of avoiding the warning except by initializing
> the array, which seems wasteful.
Or just initialize the array with a {0}?
--
Michael
signature.asc
Description: PGP signature
On Mon, Aug 28, 2023 at 11:42:22AM -0400, Melanie Plageman wrote:
> I too had planned to volunteer to help. I volunteer to do a
> triage/summary of patch statuses, as has been done occasionally in the
> past [1].
> Have folks found this helpful in the past?
With the number of patches in place, get
On Mon, Aug 28, 2023 at 09:46:07PM +0800, Junwang Zhao wrote:
> Yeah, it makes sense to me, or maybe just `PQputCopyEnd(...) == -1`,
> let's wait for some other opinions.
One can argue that PQputCopyEnd() returning 0 could be possible in an
older version of libpq these callers are linking to, but
On Tue, Aug 29, 2023 at 06:12:00AM +0900, Tatsuo Ishii wrote:
> I think EndReplicationCommand needs to be fixed as well.
Yeah, both of you are right here. Anyway, it seems to me that there
is a bit more going on in protocol.h. I have noticed two more things
that are incorrect:
- HandleParallelMe
On Tue, Aug 29, 2023 at 07:30:15AM +0900, Michael Paquier wrote:
> On Mon, Aug 28, 2023 at 03:37:20PM -0400, Bruce Momjian wrote:
> > I don't see a clean way of avoiding the warning except by initializing
> > the array, which seems wasteful.
>
> Or just initialize the array with a {0}?
Uh, doesn'
On Mon, Aug 28, 2023 at 5:06 PM Peter Geoghegan wrote:
>
> On Mon, Aug 28, 2023 at 1:17 PM Robert Haas wrote:
> > I'm sure this could be implemented, but it's unclear to me why you
> > would expect it to perform well. Freezing a page that has no frozen
> > tuples yet isn't cheaper than freezing o
On Mon, Aug 28, 2023 at 02:09:37PM +0200, Laurenz Albe wrote:
> On Thu, 2023-08-17 at 09:37 +0900, Michael Paquier wrote:
> > I have just noticed that we do not have a CF entry for this proposal,
> > so I have added one with Laurenz as author:
> > https://commitfest.postgresql.org/44/4504/
>
> I h
While working on a set of patches to combine the freeze and visibility
map WAL records into the prune record, I wrote the attached patches
reusing the tuple visibility information collected in heap_page_prune()
back in lazy_scan_prune().
heap_page_prune() collects the HTSV_Result for every tuple o
100 matches
Mail list logo
