On Thu, Aug 24, 2023 at 11:44 AM vignesh C <vignes...@gmail.com> wrote: >
The patch looks mostly good to me. I have made minor changes which are as follows: (a) removed the autovacuum =off and wal_receiver_status_interval = 0 setting as those doesn't seem to be required for the test; (b) changed a few comments and variable names in the code and test; Shall we change the test file name from always_persist to save_logical_slots_shutdown and move to recovery/t/ as this test is about verification after the restart of the server? -- With Regards, Amit Kapila.
v5-0001-Persist-to-disk-logical-slots-during-a-shutdown-c.patch
Description: Binary data
