Re: psql: Add role's membership options to the \du+ command

2023-04-15 Thread Pavel Luzanov
On 14.04.2023 10:28, Kyotaro Horiguchi wrote: As David-G appears to express concern in upthread, I don't think a direct Japanese translation from "rolename from rolename" works well, as the "from" needs accompanying verb. I, as a Japanese speaker, I prefer a more non-sentence-like notation, simil

Re: [RFC] Add jit deform_counter

2023-04-15 Thread Dmitry Dolgov
> On Fri, Mar 31, 2023 at 07:39:27PM +0200, Dmitry Dolgov wrote: > > On Wed, Mar 29, 2023 at 01:50:37PM +1300, David Rowley wrote: > > On Sun, 12 Jun 2022 at 21:14, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > I've noticed that JIT performance counter generation_counter seems to > > > includ

Re: Protecting allocator headers with Valgrind

2023-04-15 Thread Noah Misch
On Wed, Apr 12, 2023 at 01:28:08AM +1200, David Rowley wrote: > Any objections? Not objecting. I think the original Valgrind integration refrained from this because it would have added enough Valgrind client requests to greatly slow Valgrind runs. Valgrind reduced the cost of client requests in

Incremental sort for access method with ordered scan support (amcanorderbyop)

2023-04-15 Thread Miroslav Bendik
Current version of postgresql don't support incremental sort using ordered scan on access method. Example database: CREATE TABLE t (id serial, p point, PRIMARY KEY(id)); INSERT INTO t (SELECT generate_series(1, 1000), point(random(), random())); CREATE INDEX p_idx ON t USING gist(p); ANALYZE;

Re: Unexpected (wrong?) result querying boolean partitioned table with NULL partition

2023-04-15 Thread David Kimura
On Wed, Apr 12, 2023 at 4:13 AM David Rowley wrote: > > There seems to be a bunch of tests checking this already, all of them > assuming the incorrect plans. Given that the plan alone wasn't sufficient to catch this error previously, would it be worthwhile to add some data to the tests to make it

Re: Direct I/O

2023-04-15 Thread Mikael Kjellström
On 2023-04-14 21:33, Andres Freund wrote: Oh! I was misled by the buildfarm label on morepork, which claims it's running clang 10.0.1. But actually, per its configure report, it's running configure: using compiler=gcc (GCC) 4.2.1 20070719 Huh. I wonder if that was an accident in

Re: Direct I/O

2023-04-15 Thread Tom Lane
Thomas Munro writes: > As far as I can tell, the failure to honour large alignment attributes > even though the compiler passes our configure check that you can do > that was considered to be approximately a bug[1] or at least a thing > to be improved in fairly old GCC times but the fix wasn't bac

Race conditions in has_table_privilege() and friends

2023-04-15 Thread Tom Lane
I noticed that prion recently failed [1] with SELECT schema_to_xml_and_xmlschema('testxmlschema', true, true, 'foo'); ... +ERROR: relation with OID 30019 does not exist +CONTEXT: SQL statement "SELECT oid FROM pg_catalog.pg_class WHERE relnamespace = 29949 AND relkind IN ('r','m','v') AND pg_

Re: Should vacuum process config file reload more often

2023-04-15 Thread Daniel Gustafsson
> On 11 Apr 2023, at 17:05, Masahiko Sawada wrote: > The comment of message_level_is_interesting() says: > > * This is useful to short-circuit any expensive preparatory work that > * might be needed for a logging message. > > Which can apply to taking a lwlock, I think. I agree that we can, an

Re: segfault tied to "IS JSON predicate" commit

2023-04-15 Thread Justin Pryzby
On Thu, Apr 13, 2023 at 09:14:01PM -0700, Peter Geoghegan wrote: > I find that if I run the following test against a standard debug build > on HEAD, my local installation reliably segfaults: > > $ meson test --setup running --suite test_rls_hooks-running > > Attached is a "bt full" run from gdb a

Re: Direct I/O

2023-04-15 Thread Thomas Munro
On Sun, Apr 16, 2023 at 6:19 AM Tom Lane wrote: > So apparently, the fact that you even get a warning about the > alignment not being honored is something OpenBSD patched in > after-the-fact; it's not there in genuine vintage gcc. Ah, that is an interesting discovery, and indeed kills the configu

Re: Direct I/O

2023-04-15 Thread Tom Lane
Thomas Munro writes: > Full GCC support including stack objects actually began in 4.6, it > seems. Hmm. The oldest gcc versions remaining in the buildfarm seem to be curculio | configure: using compiler=gcc (GCC) 4.2.1 20070719 frogfish | configure: using compiler=gcc (Debian 4.6.3

Re: Direct I/O

2023-04-15 Thread Justin Pryzby
On Sat, Apr 15, 2023 at 02:19:35PM -0400, Tom Lane wrote: > PS: I don't quite understand how it managed to get through initdb > when CREATE DATABASE doesn't work. Maybe there is a different > code path taken in standalone mode? ad43a413c4f7f5d024a5b2f51e00d280a22f1874 initdb: When running CRE

Re: segfault tied to "IS JSON predicate" commit

2023-04-15 Thread Peter Geoghegan
On Sat, Apr 15, 2023 at 2:46 PM Justin Pryzby wrote: > I think what happened is that you (and I) are in the habbit of running > "meson test tmp_install" to compile new binaries and install them into > ./tmp_install, and then run a server out from there. That's not my habit; this is running agains

Re: v16dev: invalid memory alloc request size 8488348128

2023-04-15 Thread Justin Pryzby
On Sat, Apr 15, 2023 at 11:33:58AM +1200, David Rowley wrote: > On Sat, 15 Apr 2023 at 10:48, Justin Pryzby wrote: > > > > On Sat, Apr 15, 2023 at 10:04:52AM +1200, David Rowley wrote: > > > Which aggregate function is being called here? Is it a custom > > > aggregate written in C, by any chance?

Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode

2023-04-15 Thread David Rowley
On Sat, 15 Apr 2023 at 12:59, David Rowley wrote: > These are all valid points. I've attached a patch aiming to address > each of them. I tweaked this a little further and pushed it. David

Re: segfault tied to "IS JSON predicate" commit

2023-04-15 Thread Peter Geoghegan
On Sat, Apr 15, 2023 at 4:11 PM Peter Geoghegan wrote: > $ meson test --setup tmp_install --list | grep install > postgresql:setup / tmp_install > postgresql:setup / install_test_files > > But not the running setup: > > $ meson test --setup running --list | grep install | wc -l > 0 There is a con

Re: Where are we on supporting LLVM's opaque-pointer changes?

2023-04-15 Thread Thomas Munro
On Sat, Apr 15, 2023 at 2:31 AM Tom Lane wrote: > I know we've been letting this topic slide, but we are out of runway. > I propose adding this as a must-fix open item for PG 16. I had a patch that solved many of the problems[1], but it isn't all the way there and I got stuck. I am going to look

idea: multiple arguments to_regclass function

2023-04-15 Thread Pavel Stehule
Hi I missing some variants of to_regclass to_regclass(schemaname, objectname) to_regclass(catalogname, schemaname, objectname) It can helps with object identification, when I have separated schema and name What do you think about this? Regards Pavel

Re: Protecting allocator headers with Valgrind

2023-04-15 Thread David Rowley
On Sun, 16 Apr 2023 at 03:26, Noah Misch wrote: > Not objecting. I think the original Valgrind integration refrained from this > because it would have added enough Valgrind client requests to greatly slow > Valgrind runs. Valgrind reduced the cost of client requests in later years, > so this new