Re: daitch_mokotoff module

Andres Freund writes: > On 2023-04-07 21:13:43 -0400, Tom Lane wrote: >> I pushed this after some mostly-cosmetic fiddling. Most of the >> buildfarm seems okay with it, but crake's perlcritic run is not: >> >> ./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" used at >> line

Re: Kerberos delegation support in libpq and postgres_fdw

Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * David Christensen (da...@pgguru.net) wrote: > > Ok, based on the interdiff there, I'm happy with that last change. Marking > > as Ready For Committer. > > Great, thanks! > > I'm going to go through it again myself but I feel reasonably

Re: Partial aggregates pushdown

On Fri, Apr 7, 2023 at 09:25:52AM +, fujii.y...@df.mitsubishielectric.co.jp wrote: > Hi Mr.Momjian > > > First, my apologies for not addressing this sooner. I was so focused on my > > own tasks that I didn't realize this very important patch was not getting > > attention. I will try my bes

Re: daitch_mokotoff module

I wrote: > I pushed this after some mostly-cosmetic fiddling. Most of the > buildfarm seems okay with it, Spoke too soon [1]: make[1]: Entering directory '/home/linux1/build-farm-16-pipit/buildroot/HEAD/pgsql.build/contrib/fuzzystrmatch' '/usr/bin/perl' daitch_mokotoff_header.pl daitch_mokotoff

Re: Partial aggregates pushdown

Bruce Momjian writes: > What I don't want is an error-prone setup where administrators have to > remember what the per-server settings are. Based on your suggestion, > let's allow CREATE SERVER to have an option 'enable_async_aggregate' (is > that the right name?), which defaults to 'true' for _a

Re: Kerberos delegation support in libpq and postgres_fdw

Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Stephen Frost (sfr...@snowman.net) wrote: > > * David Christensen (da...@pgguru.net) wrote: > > > Ok, based on the interdiff there, I'm happy with that last change. > > > Marking > > > as Ready For Committer. > > > > Great, thanks! > >

longfin missing gssapi_ext.h

Greetings, Looks like longfin has a particularly old Kerberos/GSSAPI installation on it which pre-dates MIT release 1.11 from circa 2012 and is missing gssapi_ext.h, causing the recently committed patch to add Kerberos credential delegation to fail to build. I'm inclined to update our configure c

Re: longfin missing gssapi_ext.h

Stephen Frost writes: > Looks like longfin has a particularly old Kerberos/GSSAPI installation > on it It's whatever Apple is shipping, or was shipping last year or so. > I'm inclined to update our configure check to explicitly check for the > needed function (gss_store_cred_into) Sounds like a

Re: longfin missing gssapi_ext.h

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Looks like longfin has a particularly old Kerberos/GSSAPI installation > > on it > > It's whatever Apple is shipping, or was shipping last year or so. Sadly they've not been maintaining the Kerberos libraries at all o

Re: longfin missing gssapi_ext.h

Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> It's whatever Apple is shipping, or was shipping last year or so. > Sadly they've not been maintaining the Kerberos libraries at all on > their systems. Indeed :-(. I wouldn't be surprised if there are security issues in their ve

Re: Partial aggregates pushdown

On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > What I don't want is an error-prone setup where administrators have to > > remember what the per-server settings are. Based on your suggestion, > > let's allow CREATE SERVER to have an option 'enable_async_aggre

Re: longfin missing gssapi_ext.h

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> It's whatever Apple is shipping, or was shipping last year or so. > > > Sadly they've not been maintaining the Kerberos libraries at all on > > their systems. > > Indeed :-(

Re: longfin missing gssapi_ext.h

Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Stephen Frost writes: > > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > >> It's whatever Apple is shipping, or was shipping last year or so. > > > > > Sadly they've not been maintaining the Kerbero

Re: Commitfest 2023-03 starting tomorrow!

On Fri, Apr 7, 2023 at 6:29 PM Tom Lane wrote: > Kirk Wolak writes: > > The %T added to the PSQL Prompt is about 5 lines of code. Reviewed and > > Ready to commit. > > That could knock one more off really quickly :-) > > I'm still objecting to it, for the same reason as before. > >

Re: Partial aggregates pushdown

Bruce Momjian writes: > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: >> Uh, what? Why would we not be able to tell from the remote server's >> version number whether it has this ability? > The issue is not a mismatch of postgres_fdw versions but the extension > versions and whether

Re: longfin missing gssapi_ext.h

Stephen Frost writes: > Looks like buildfarm animal hake, at least, has a version recent enough > to have gssapi_ext.h ... but still older than 1.11 and therefore > doesn't have the type gss_key_value_element_desc defined, so maybe the > check for gss_store_cred_into would be better? Well, now we

Re: daitch_mokotoff module

On 2023-04-07 Fr 21:52, Tom Lane wrote: I wrote: I pushed this after some mostly-cosmetic fiddling. Most of the buildfarm seems okay with it, Spoke too soon [1]: make[1]: Entering directory '/home/linux1/build-farm-16-pipit/buildroot/HEAD/pgsql.build/contrib/fuzzystrmatch' '/usr/bin/perl' d

Re: Partial aggregates pushdown

On Fri, Apr 7, 2023 at 10:44:09PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > >> Uh, what? Why would we not be able to tell from the remote server's > >> version number whether it has this ability? > > > The issue is not a misma

Re: daitch_mokotoff module

Andrew Dunstan writes: > On 2023-04-07 Fr 21:52, Tom Lane wrote: >> pipit appears to be running a reasonably current system (RHEL8), so >> the claim that "open" is a Perl core module appears false. We need >> to rewrite this to not use that. > I think it is a core module (See

Re: Partial aggregates pushdown

On Fri, Apr 7, 2023 at 10:53:53PM -0400, Bruce Momjian wrote: > On Fri, Apr 7, 2023 at 10:44:09PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > > >> Uh, what? Why would we not be able to tell from the remote server's > > >> ve

Re: longfin missing gssapi_ext.h

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Looks like buildfarm animal hake, at least, has a version recent enough > > to have gssapi_ext.h ... but still older than 1.11 and therefore > > doesn't have the type gss_key_value_element_desc defined, so maybe the > >

Re: daitch_mokotoff module

I wrote: > Anyway, I assume this is just syntactic sugar for something > we can do another way? If it's at all fundamental, I'll have > to back the patch out. On closer inspection, this script is completely devoid of any need to deal in non-ASCII data at all. So I just nuked the "use" lines.

Re: Minimal logical decoding on standbys

Hi, On 2023-04-07 18:32:04 -0400, Melanie Plageman wrote: > Code review only of 0001-0005. > > I noticed you had two 0008, btw. Yea, sorry for that. One was the older version. Just before sending the patch I saw another occurance of a test failure, which I then fixed. In the course of that I cha

Re: Minimal logical decoding on standbys

On Fri, Apr 7, 2023 at 11:42 PM Andres Freund wrote: > > On 2023-04-07 08:47:57 -0700, Andres Freund wrote: > > Integrated all of these. > > Here's my current version. Changes: > - Integrated Bertrand's changes > - polished commit messages of 0001-0003 > - edited code comments for 0003, including

Re: Minimal logical decoding on standbys

Hi, On 2023-04-08 09:15:05 +0530, Amit Kapila wrote: > The new approach for invalidation looks clean. BTW, I see minor > inconsistency in the following two error messages (errmsg): Thanks for checking. > if (MyReplicationSlot->data.invalidated == RS_INVAL_WAL) > ereport(ERROR, > (errcode(ERRCOD

Re: Partial aggregates pushdown

On 2023-04-07 22:53:53 -0400, Bruce Momjian wrote: > On Fri, Apr 7, 2023 at 10:44:09PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote: > > >> Uh, what? Why would we not be able to tell from the remote server's > > >> version number

Re: Minimal logical decoding on standbys

On 4/8/23 12:01 AM, Andres Freund wrote: Hi, On 2023-04-08 09:15:05 +0530, Amit Kapila wrote: The new approach for invalidation looks clean. BTW, I see minor inconsistency in the following two error messages (errmsg): Thanks for checking. if (MyReplicationSlot->data.invalidated == RS_INVAL

Re: longfin missing gssapi_ext.h

Stephen Frost writes: > I'm open to considering support for older versions, however ... NetBSD 9.3, which is their *latest production release*, doesn't have gssapi_ext.h [1]. For that matter, it doesn't look like their not-yet-released 10.0BETA does either (my NetBSD 10 animals would be failing

Re: Minimal logical decoding on standbys

On Sat, Apr 8, 2023 at 9:31 AM Andres Freund wrote: > > On 2023-04-08 09:15:05 +0530, Amit Kapila wrote: > > The new approach for invalidation looks clean. BTW, I see minor > > inconsistency in the following two error messages (errmsg): > > Thanks for checking. > > > > if (MyReplicationSlot->data.

Re: Direct I/O

I did some testing with non-default block sizes, and found a few minor things that needed adjustment. The short version is that I blocked some configurations that won't work or would break an assertion. After a bit more copy-editing on docs and comments and a round of automated indenting, I have n

Re: Direct I/O

On Sat, Apr 8, 2023 at 4:47 PM Thomas Munro wrote: > After a bit more copy-editing on docs and comments and a round of > automated indenting, I have now pushed this. I will now watch the > build farm. I tested on quite a few OSes that I have access to, but > this is obviously a very OS-sensitive

Re: Direct I/O

Thomas Munro writes: > I did some testing with non-default block sizes, and found a few minor > things that needed adjustment. https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-04-08%2004%3A42%3A04 This seems like another thing that should not have been pushed mere hours befo

Re: check_GUC_init(wal_writer_flush_after) fails with non-default block size

Hi, On 2023-04-08 13:18:55 +1200, Thomas Munro wrote: > If you build with --with-wal-blocksize=/-Dwal_blocksize= anything but > 8, this breaks: > > running bootstrap script ... LOG: GUC (PGC_INT) > wal_writer_flush_after, boot_val=256, C-var=128 > TRAP: failed Assert("check_GUC_init(hentry->gucv

Re: Non-superuser subscription owners

On Thu, Mar 30, 2023 at 9:35 PM Robert Haas wrote: > > On Tue, Mar 28, 2023 at 1:52 PM Jeff Davis wrote: > > On Fri, 2023-03-24 at 00:17 -0700, Jeff Davis wrote: > > > The other patch you posted seems like it makes a lot of progress in > > > that direction, and I think that should go in first. Th

Re: CREATE SUBSCRIPTION -- add missing tab-completes

On Fri, Apr 7, 2023 at 6:59 PM Masahiko Sawada wrote: > > On Fri, Apr 7, 2023 at 6:10 PM Amit Kapila wrote: > > > > On Fri, Apr 7, 2023 at 1:12 PM Masahiko Sawada > > wrote: > > > > > > > Do you mean that because 'password_required' is used each time we make > > a connection to a publisher duri

Re: Direct I/O

Hi, On 2023-04-08 16:59:20 +1200, Thomas Munro wrote: > On Sat, Apr 8, 2023 at 4:47 PM Thomas Munro wrote: > > After a bit more copy-editing on docs and comments and a round of > > automated indenting, I have now pushed this. I will now watch the > > build farm. I tested on quite a few OSes tha

Re: Minimal logical decoding on standbys

Hi, On 2023-04-07 11:12:26 -0700, Andres Freund wrote: > + > + > + confl_active_logicalslot > bigint > + > + > + Number of active logical slots in this database that have been > + invalidated because they conflict with recovery (note that inactive > ones

Re: Minimal logical decoding on standbys

Hi, New wording works for me, thanks! Bertrand Le sam. 8 avr. 2023, 08:26, Andres Freund a écrit : > Hi, > > On 2023-04-07 11:12:26 -0700, Andres Freund wrote: > > + > > + > > + confl_active_logicalslot > bigint > > + > > + > > + Number of active logical slot

<    1   2