On Tue, Aug 2, 2022 at 3:13 PM Richard Guo wrote:
> On Sun, Jul 31, 2022 at 12:07 AM Tom Lane wrote:
>
>> [ wanders away wondering if JOIN_RIGHT_SEMI should become a thing ... ]
>
> Maybe this is something we can do. Currently for the query below:
>
> # explain select * from foo where a in (sele
On Fri, Apr 7, 2023 at 2:28 PM Amit Kapila wrote:
>
> On Wed, Apr 5, 2023 at 5:58 AM Peter Smith wrote:
> >
> > There are some recent comment that added new options for CREATE SUBSCRIPTION
> >
> ...
> > PSA patches to add those tab completions.
> >
>
> LGTM, so pushed. BTW, while looking at this,
Hi,
On 2023-04-07 08:09:50 +0200, Drouvot, Bertrand wrote:
> Hi,
>
> On 4/7/23 7:56 AM, Andres Freund wrote:
> > Hi,
> >
> > On 2023-04-07 07:02:04 +0200, Drouvot, Bertrand wrote:
> > > Done in V63 attached and did change the associated comment a bit.
> >
> > Can you send your changes incrementall
The patch set does not apply any more.
I tried to rebase locally; even leaving out 1 ("libpq: Run pgindent
after a9e9a9f32b3"), patch 4 ("Start using new libpq cancel APIs") is
harder to resolve following 983ec23007b (I suppose).
Appart from that, the implementation in v19 sounds good to me,
Hi,
On 2023-04-06 18:15:14 -0700, Andres Freund wrote:
> I think it might be worth having a C test for some of the bufmgr.c API. Things
> like testing that retrying a failed relation extension works the second time
> round.
A few hours after this I hit a stupid copy-pasto (21d7c05a5cf) that would
On Tues, Apr 4, 2023 at 23:48 PM Tom Lane wrote:
> Nathan Bossart writes:
> > On Wed, Feb 22, 2023 at 12:40:07PM +, wangw.f...@fujitsu.com wrote:
> >> After some rethinking, I think users can easily get exact value according
> >> to
> >> exact formula, and I think using accurate formula can
On Fri, Apr 7, 2023 at 1:12 PM Masahiko Sawada wrote:
>
> On Fri, Apr 7, 2023 at 2:28 PM Amit Kapila wrote:
> >
> > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith wrote:
> > >
> >
> > LGTM, so pushed. BTW, while looking at this, I noticed that newly
> > added options "password_required" and "run_as_
Hi Mr.Momjian
> First, my apologies for not addressing this sooner. I was so focused on my
> own tasks that I didn't realize this very important patch was not getting
> attention. I will try my best to get it into PG 17.
Thank you very much for your comments.
I will improve this patch for PG17.
On Thu, Apr 6, 2023 at 6:57 PM Masahiko Sawada wrote:
>
> On Thu, Mar 30, 2023 at 10:11 PM Masahiko Sawada
> wrote:
> >
> > On Thu, Mar 30, 2023 at 12:18 AM Masahiko Sawada
> > wrote:
> > >
> > >
> > > How can we postpone creating the pg_subscription_rel entries until the
> > > tablesync worke
Dear Julien,
Thank you for giving comments!
> As I mentioned in my original thread, I'm not very familiar with that code,
> but
> I'm a bit worried about "all the changes generated on publisher must be send
> and applied". Is that a hard requirement for the feature to work reliably?
I think th
On Thu, Feb 16, 2023 at 11:44 PM Andres Freund wrote:
>
> We really ought to replace the tid bitmap used for bitmap heap scans. The
> hashtable we use is a pretty awful data structure for it. And that's not
> filled in-order, for example.
I spent some time studying tidbitmap.c, and not only does
On Thu, Apr 06, 2023 at 03:14:20PM +, Imseih (AWS), Sami wrote:
>> Could it be worth thinking about a different design where
>> the value incremented and the parameters of
>> pgstat_progress_update_param() are passed through the 'P' message
>> instead?
>
> I am not sure how this is different t
On Friday, April 7, 2023 5:11 PM Amit Kapila wrote:
>
> On Fri, Apr 7, 2023 at 1:12 PM Masahiko Sawada
> wrote:
> >
> > On Fri, Apr 7, 2023 at 2:28 PM Amit Kapila
> wrote:
> > >
> > > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith
> wrote:
> > > >
> > >
> > > LGTM, so pushed. BTW, while looking at
> On 7 Apr 2023, at 08:52, Masahiko Sawada wrote:
> On Fri, Apr 7, 2023 at 8:08 AM Daniel Gustafsson wrote:
>> I had another read-through and test-through of this version, and have applied
>> it with some minor changes to comments and whitespace. Thanks for the quick
>> turnaround times on revi
On 2023-03-29 We 07:55, Tom Lane wrote:
Yurii Rashkovskii writes:
I would like to suggest a patch against master (although it may be worth
backporting it) that makes it possible to listen on any unused port.
I think this is a bad idea, mainly because this:
Instead, with this patch, one can
On Wed, Jan 25, 2023 at 8:57 PM Bharath Rupireddy
wrote:
> Thanks. I have some comments on
> v3-0002-Add-io_direct-setting-developer-only.patch:
>
> 1. I think we don't need to overwrite the io_direct_string in
> check_io_direct so that show_io_direct can be avoided.
Thanks for looking at this, a
Dear Julien,
> > Agreed, but then shouldn't the option be named "--logical-slots-only" or
> > something like that, same for all internal function names?
>
> Seems right. Will be fixed in next version. Maybe
> "--logical-replication-slots-only"
> will be used, per Peter's suggestion [1].
After co
On Fri, Apr 7, 2023 at 2:53 AM Masahiko Sawada wrote:
>
> On Fri, Apr 7, 2023 at 8:08 AM Daniel Gustafsson wrote:
> >
> > > On 7 Apr 2023, at 00:12, Melanie Plageman
> > > wrote:
> > >
> > > On Thu, Apr 6, 2023 at 5:45 PM Daniel Gustafsson wrote:
> > >>
> > >>> On 6 Apr 2023, at 23:06, Melanie
> On 7 Apr 2023, at 15:07, Melanie Plageman wrote:
> On Fri, Apr 7, 2023 at 2:53 AM Masahiko Sawada wrote:
>> + /* Only log updates to cost-related variables */
>> + if (vacuum_cost_delay == original_cost_delay &&
>> + vacuum_cost_limit == original_cost_limit)
>> +
On Fri, Apr 7, 2023 at 6:10 PM Amit Kapila wrote:
>
> On Fri, Apr 7, 2023 at 1:12 PM Masahiko Sawada wrote:
> >
> > On Fri, Apr 7, 2023 at 2:28 PM Amit Kapila wrote:
> > >
> > > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith wrote:
> > > >
> > >
> > > LGTM, so pushed. BTW, while looking at this, I
> On 5 Apr 2023, at 23:44, Daniel Gustafsson wrote:
>
> Unless there are objections I plan to get this in before the freeze, in order
> to have better interactive tests starting with 16. With a little bit of
> documentation polish I think it's ready.
When looking at the CFBot failure on Linux a
On Tue, Apr 4, 2023 at 1:25 AM Tom Lane wrote:
> Sorry for not looking at this sooner. I am okay with the regex
> changes proposed in v5-0001 through 0003, but I think you need to
> take another mopup pass there. Some specific complaints:
> * header comment for pg_regprefix has been falsified (s
Dear Peter,
Thank you for reviewing briefly. PSA new version.
If you can I want to ask the opinion about the checking by pg_upgrade [1].
> ==
> General
>
> 1.
> Since these two new options are made to work together, I think the
> names should be more similar. e.g.
>
> pg_dump: "--slot_only"
As announced on this list feature freeze is at 00:00 April 8 AoE.
That's less than 24 hours away. If you need to set your watches to AoE
timezone it's currently:
$ TZ=AOE+12 date
Fri 07 Apr 2023 02:05:50 AM AOE
As we stand we have:
Status summary:
Needs review: 82
Waiting on Auth
On 2023-04-06 Th 05:11, Peter Eisentraut wrote:
On 05.04.23 16:45, Andres Freund wrote:
I think it's still an issue that "make docs" builds html and man but
"ninja
docs" only builds html. For some reason the wiki page actually
claims that
ninja docs builds both, but this does not happen for
On 2023-04-07 Fr 09:32, Daniel Gustafsson wrote:
On 5 Apr 2023, at 23:44, Daniel Gustafsson wrote:
Unless there are objections I plan to get this in before the freeze, in order
to have better interactive tests starting with 16. With a little bit of
documentation polish I think it's ready.
Wh
On Fri, Apr 07, 2023 at 04:14:13AM +0200, Alvaro Herrera wrote:
> On 2023-Apr-06, Justin Pryzby wrote:
> > +ERROR: relation "c" already exists
>
> Do you intend to make an error here ?
These still look like mistakes in the tests.
> Also, I think these table names may be too generic, and conflic
Hi,
On 2023-04-07 15:32:12 +0200, Daniel Gustafsson wrote:
> > On 5 Apr 2023, at 23:44, Daniel Gustafsson wrote:
> >
> > Unless there are objections I plan to get this in before the freeze, in
> > order
> > to have better interactive tests starting with 16. With a little bit of
> > documentati
Hi,
On 2023-04-07 10:55:19 -0400, Andrew Dunstan wrote:
> It should probably be added to config/check_modules.pl if we're going to use
> it, but it seems to be missing for Strawberry Perl and msys/ucrt64 perl and
> I'm not sure how easy it will be to add there. It would certainly add an
> installa
Hi,
On 4/7/23 9:50 AM, Andres Freund wrote:
Hi,
Here's my current working state - I'll go to bed soon.
Thanks a lot for this Andres!
Changes:
- shared catalog relations weren't handled correctly, because the dboid is
InvalidOid for them. I wrote a test for that as well.
- ReplicationSl
On Fri, Apr 07, 2023 at 09:40:14AM +, Hayato Kuroda (Fujitsu) wrote:
>
> > As I mentioned in my original thread, I'm not very familiar with that code,
> > but
> > I'm a bit worried about "all the changes generated on publisher must be send
> > and applied". Is that a hard requirement for the
On Fri, Apr 07, 2023 at 12:51:51PM +, Hayato Kuroda (Fujitsu) wrote:
> Dear Julien,
>
> > > Agreed, but then shouldn't the option be named "--logical-slots-only" or
> > > something like that, same for all internal function names?
> >
> > Seems right. Will be fixed in next version. Maybe
> > "
Hi,
On 2023-04-07 17:13:13 +0200, Drouvot, Bertrand wrote:
> On 4/7/23 9:50 AM, Andres Freund wrote:
> > I added a check for !invalidated to
> > ReplicationSlotsComputeRequiredLSN() etc.
> >
>
> looked at 65-0001 and it looks good to me.
>
> > Added new patch moving checks for invalid logical s
Daniel Gustafsson writes:
> Ah, ok, now I see what you mean, thanks! I'll try to fix up the patch like
> this tomorrow.
Since we're running out of time, I took the liberty of fixing and
pushing this.
regards, tom lane
Andres Freund writes:
> On 2023-04-07 15:32:12 +0200, Daniel Gustafsson wrote:
>> I don't think we should go ahead with a patch that refactors interactive_psql
>> only to SKIP over it in CI (which is what the tab_completion test does now),
>> so
>> let's wait until we have that sorted before goin
> On 7 Apr 2023, at 16:58, Andres Freund wrote:
> Note it just fails on the 32build, not the 64bit build. Unfortunately I don't
> think debian's multiarch in bullseye support installing enough of perl in
> 32bit and 64bit.
I should probably avoid parsing logfiles with fever-induced brainfog, I
c
Hi,
On 2023-04-07 11:52:37 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-04-07 15:32:12 +0200, Daniel Gustafsson wrote:
> >> I don't think we should go ahead with a patch that refactors
> >> interactive_psql
> >> only to SKIP over it in CI (which is what the tab_completion test does
> On 7 Apr 2023, at 17:47, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> Ah, ok, now I see what you mean, thanks! I'll try to fix up the patch like
>> this tomorrow.
>
> Since we're running out of time, I took the liberty of fixing and
> pushing this.
Great, thanks!
--
Daniel Gustafsson
> On 7 Apr 2023, at 17:04, Andres Freund wrote:
> Afaict the failures are purely about patch 2, not 1, right?
Correct. The attached v6 wraps the interactive_psql test in a SKIP block with
a conditional on IO::Pty being available.
--
Daniel Gustafsson
v6-0002-Test-SCRAM-iteration-changes-wit
Attached v9 addresses review feedback as well as resolving merge
conflicts with recent relation extension patchset.
I've changed pgstat_count_io_op_time() to take a count and call
pgstat_count_io_op_n() so it can be used with smgrzeroextend(). I do
wish that the parameter to pgstat_count_io_op_n()
"wangw.f...@fujitsu.com" writes:
> On Tues, Apr 4, 2023 at 23:48 PM Tom Lane wrote:
>> I like the "per eligible process" wording, at least for guc_tables.c;
>> or maybe it could be "per server process"? That would be more
>> accurate and not much longer than what we have now.
> Thanks both for
I was reading the logical replication code and found a little
unnecessary work we are doing.
The confirmed_flushed_lsn cannot reasonably be ahead of the
current_lsn, so there is no point of calling
LogicalConfirmReceivedLocation() every time we update the candidate
xmin or restart_lsn.
Patch is a
Hi,
On 2023-04-07 08:47:57 -0700, Andres Freund wrote:
> Integrated all of these.
Here's my current version. Changes:
- Integrated Bertrand's changes
- polished commit messages of 0001-0003
- edited code comments for 0003, including
InvalidateObsoleteReplicationSlots()'s header
- added a bump o
Hi,
On 4/7/23 5:47 PM, Andres Freund wrote:
Hi,
- write a test that invalidated logical slots do not lead to retaining WAL
I'm not sure how to do that since pg_switch_wal() and friends can't be executed
on
a standby.
You can do it on the primary and wait for the records to have been appli
Hi,
On 4/7/23 8:12 PM, Andres Freund wrote:
Hi,
On 2023-04-07 08:47:57 -0700, Andres Freund wrote:
Integrated all of these.
Here's my current version. Changes:
- Integrated Bertrand's changes
- polished commit messages of 0001-0003
- edited code comments for 0003, including
InvalidateObso
Nathan Bossart writes:
> On Thu, Apr 06, 2023 at 01:32:35PM -0400, Tom Lane wrote:
>> There seems to be enough support for the existing summary function
>> definition to leave it as-is; Andres likes it for one, and I'm not
>> excited about trying to persuade him he's wrong. But a second
>> slight
Tomas Vondra writes:
> Hi, I think from the technical point of view it's sound and ready for
> commit. The patch stalled on the copyright/credit stuff, which is
> somewhat separate and mostly non-technical aspect of patches. Sorry for
> that, I'm sure it's annoying/frustrating :-(
> I see the cur
Hi,
On 2023-04-06 12:28:04 +0900, Michael Paquier wrote:
> As some say, the introduction of a new message type in pqmq.c would be
> basically a one-way door, because we'd have to maintain it in a stable
> branch.
Why would it mean that? Parallel workers are updated together with the leader,
so th
> The arguments of pgstat_progress_update_param() would be given by the
> worker directly as components of the 'P' message. It seems to me that
> this approach would have the simplicity to not require the setup of a
> shmem area for the extra counters, and there would be no need for a
> callback. H
> On 7 Apr 2023, at 18:14, Daniel Gustafsson wrote:
>> On 7 Apr 2023, at 17:04, Andres Freund wrote:
>> Afaict the failures are purely about patch 2, not 1, right?
>
> Correct. The attached v6 wraps the interactive_psql test in a SKIP block with
> a conditional on IO::Pty being available.
Thi
Attached v3 is cleaned up and includes a pg_walinspect docs update as
well as some edited comments in rmgr_utils.c
On Mon, Mar 27, 2023 at 6:27 PM Peter Geoghegan wrote:
>
> On Mon, Mar 27, 2023 at 2:29 PM Melanie Plageman
> wrote:
> > I went to add dedup records and noticed that since the actua
Hi,
I think there's some test instability:
Fail:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=parula&dt=2023-04-07%2018%3A43%3A02
Subsequent success, without relevant changes:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=parula&dt=2023-04-07%2020%3A22%3A01
Followed by a fail
Hi,
On 2023-04-07 13:38:43 -0700, Andres Freund wrote:
> I suspect there's a naming conflict between tests in different groups.
Yep:
test: create_aggregate create_function_sql create_cast constraints triggers
select inherit typed_table vacuum drop_if_exists updatable_views roleattributes
creat
Hi,
On 4/7/23 8:27 PM, Drouvot, Bertrand wrote:
Hi,
I think some of the patches might have more reviewers than really applicable,
and might also miss some. I'd appreciate if you could go over that...
Sure, will do in a couple of hours.
That looks good to me, just few remarks:
0005 is
Hi,
On 4/7/23 8:24 PM, Drouvot, Bertrand wrote:
Hi,
On 4/7/23 5:47 PM, Andres Freund wrote:
Hi,
- write a test that invalidated logical slots do not lead to retaining WAL
I'm not sure how to do that since pg_switch_wal() and friends can't be executed
on
a standby.
You can do it on the p
On 2023-Apr-07, Andres Freund wrote:
> src/test/regress/sql/triggers.sql
> 2127:create table child partition of parent for values in ('AAA');
> 2266:create table child () inherits (parent);
> 2759:create table child () inherits (parent);
>
> The inherit.sql part is new.
Yeah.
> I'll see how har
> On 7 Apr 2023, at 22:24, Daniel Gustafsson wrote:
>
>> On 7 Apr 2023, at 18:14, Daniel Gustafsson wrote:
>>> On 7 Apr 2023, at 17:04, Andres Freund wrote:
>
>>> Afaict the failures are purely about patch 2, not 1, right?
>>
>> Correct. The attached v6 wraps the interactive_psql test in a S
Greetings,
* David Christensen (da...@pgguru.net) wrote:
> On Wed, Apr 5, 2023 at 3:30 PM Stephen Frost wrote:
> > Per GSS docs, seems like we should be comparing to GSS_C_NO_CREDENTIAL
> > and validating that the gflags has the `deleg_flag` bit set before
> > considering whether there are valid
Hi,
On 2023-04-07 23:00:01 +0200, Alvaro Herrera wrote:
> On 2023-Apr-07, Andres Freund wrote:
>
> > src/test/regress/sql/triggers.sql
> > 2127:create table child partition of parent for values in ('AAA');
> > 2266:create table child () inherits (parent);
> > 2759:create table child () inherits (
On 2023-Apr-07, Andres Freund wrote:
> I just pushed a fix - sorry, I thought you might have stopped working for the
> day and CI finished with the modification a few seconds before your email
> arrived...
Ah, cool, no worries. I would have stopped indeed, but I had to stay
around in case of any
Hi,
On 2023-04-07 23:11:55 +0200, Alvaro Herrera wrote:
> On 2023-Apr-07, Andres Freund wrote:
>
> > I just pushed a fix - sorry, I thought you might have stopped working for
> > the
> > day and CI finished with the modification a few seconds before your email
> > arrived...
>
> Ah, cool, no wo
Hi,
On 2023-04-07 22:54:01 +0200, Drouvot, Bertrand wrote:
> That looks good to me
Cool.
I think I'll push these in a few hours. While this needed more changes than
I'd like shortly before the freeze, I think they're largely not in very
interesting bits and pieces - and this feature has been in
I gave a very quick look at 0001 and 0003. I find no fault with 0001.
It was clear back when we added that stuff that invalidated_at was not
terribly useful -- I was just too conservative to not have it -- but now
that a lot of time has passed and we haven't done anything with it,
removing it seem
Hi Andrew,
On Fri, Apr 7, 2023, 7:07 p.m. Andrew Dunstan wrote:
>
> On 2023-03-29 We 07:55, Tom Lane wrote:
>
> Yurii Rashkovskii writes:
>
> I would like to suggest a patch against master (although it may be worth
> backporting it) that makes it possible to listen on any unused port.
>
> I th
On Fri, Apr 7, 2023 at 1:33 PM Melanie Plageman
wrote:
> Attached v3 is cleaned up and includes a pg_walinspect docs update as
> well as some edited comments in rmgr_utils.c
Attached v4 has some small tweaks on your v3. Mostly just whitespace
tweaks. Two slightly notable tweaks:
* I changed the
Reviewed v8; largely looking good, though I notice this hunk, which may
arguably be a bug fix, but doesn't appear to be relevant to this specific
patch, so could probably be debated independently (and if a bug, should
probably be backpatched):
diff --git a/contrib/postgres_fdw/option.c b/contrib/p
Andres Freund writes:
> On 2023-04-07 23:11:55 +0200, Alvaro Herrera wrote:
>> Ah, cool, no worries. I would have stopped indeed, but I had to stay
>> around in case of any test failures.
> Looks like there's work for you if you want ;)
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=r
Greetings,
* David Christensen (da...@pgguru.net) wrote:
> Reviewed v8; largely looking good, though I notice this hunk, which may
> arguably be a bug fix, but doesn't appear to be relevant to this specific
> patch, so could probably be debated independently (and if a bug, should
> probably be bac
Ok, based on the interdiff there, I'm happy with that last change. Marking
as Ready For Committer.
Best,
David
> On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote:
> Looks like morepork wasn't happy with the interactive \password test.
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=morepork&dt=2023-04-07%2020%3A30%3A29
>
> Looking into why the timer timed out in that test.
Staring at this I
On Fri, Apr 7, 2023 at 10:21 AM Greg Stark wrote:
> As announced on this list feature freeze is at 00:00 April 8 AoE.
> That's less than 24 hours away. If you need to set your watches to AoE
> timezone it's currently:
>
> $ TZ=AOE+12 date
> Fri 07 Apr 2023 02:05:50 AM AOE
>
> As we stand we have:
Hi,
On 2023-04-07 17:46:33 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-04-07 23:11:55 +0200, Alvaro Herrera wrote:
> >> Ah, cool, no worries. I would have stopped indeed, but I had to stay
> >> around in case of any test failures.
>
> > Looks like there's work for you if you want
Andres Freund writes:
> On 2023-04-07 17:46:33 -0400, Tom Lane wrote:
>> After quickly eyeing the diffs, I'm just going to take the new output
>> as good. I'm not surprised that there are additional output messages
>> given the additional catalog entries this made. I *am* a bit surprised
>> that
Kirk Wolak writes:
> The %T added to the PSQL Prompt is about 5 lines of code. Reviewed and
> Ready to commit.
> That could knock one more off really quickly :-)
I'm still objecting to it, for the same reason as before.
regards, tom lane
Code review only of 0001-0005.
I noticed you had two 0008, btw.
On Fri, Apr 07, 2023 at 11:12:26AM -0700, Andres Freund wrote:
> Hi,
>
> On 2023-04-07 08:47:57 -0700, Andres Freund wrote:
> > Integrated all of these.
>
> From 0e038eb5dfddec500fbf4625775d1fa508a208f6 Mon Sep 17 00:00:00 2001
> F
Daniel Gustafsson writes:
>> On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote:
> Staring at this I've been unable to figure out if there an underlying problem
> here or a flaky testrun, since I can't reproduce it. Maybe the animal owner
> (on cc) have any insights?
> The test has passed on seve
... BTW, shouldn't
https://commitfest.postgresql.org/42/3869/
now get closed as committed?
regards, tom lane
> On 8 Apr 2023, at 00:35, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>>> On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote:
>> Staring at this I've been unable to figure out if there an underlying problem
>> here or a flaky testrun, since I can't reproduce it. Maybe the animal owner
>> (on
On Fri, Apr 7, 2023 at 5:43 PM Peter Geoghegan wrote:
>
> On Fri, Apr 7, 2023 at 1:33 PM Melanie Plageman
> wrote:
> > Attached v3 is cleaned up and includes a pg_walinspect docs update as
> > well as some edited comments in rmgr_utils.c
>
> Attached v4 has some small tweaks on your v3. Mostly ju
On Fri, Apr 7, 2023 at 4:01 PM Melanie Plageman
wrote:
> LGTM
Pushed, thanks.
--
Peter Geoghegan
> On 8 Apr 2023, at 00:59, Daniel Gustafsson wrote:
>
>> On 8 Apr 2023, at 00:35, Tom Lane wrote:
>>
>> Daniel Gustafsson writes:
On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote:
>>> Staring at this I've been unable to figure out if there an underlying
>>> problem
>>> here or a flaky t
On Fri, Apr 7, 2023 at 7:09 PM Peter Geoghegan wrote:
>
> On Fri, Apr 7, 2023 at 4:01 PM Melanie Plageman
> wrote:
> > LGTM
>
> Pushed, thanks.
It's come to my attention that I forgot to include the btree patch earlier.
PFA
From 4f502b2513ba79d738e7ed87aaf7d18ed2a2e30f Mon Sep 17 00:00:00 2001
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Stephen Frost writes:
> > Push, thanks again!
>
> Why'd you only change HEAD? Isn't the test equally fragile in the
> back branches?
Back-patched.
Thanks!
Stephen
signature.asc
Description: PGP signature
Greetings,
* Stephen Frost (sfr...@snowman.net) wrote:
> * Tom Lane (t...@sss.pgh.pa.us) wrote:
> > Stephen Frost writes:
> > > Push, thanks again!
> >
> > Why'd you only change HEAD? Isn't the test equally fragile in the
> > back branches?
>
> Following on from this after some additional cros
Greetings,
* David Christensen (da...@pgguru.net) wrote:
> Ok, based on the interdiff there, I'm happy with that last change. Marking
> as Ready For Committer.
Great, thanks!
I'm going to go through it again myself but I feel reasonably good about
it and if nothing else pops and there aren't ob
On Fri, Apr 7, 2023 at 4:21 PM Melanie Plageman
wrote:
> It's come to my attention that I forgot to include the btree patch earlier.
Pushed that one too.
Also removed the use of the "restrict" keyword here.
Thanks
--
Peter Geoghegan
On 2023-04-07 Fr 19:14, Daniel Gustafsson wrote:
On 8 Apr 2023, at 00:59, Daniel Gustafsson wrote:
On 8 Apr 2023, at 00:35, Tom Lane wrote:
Daniel Gustafsson writes:
On 7 Apr 2023, at 23:01, Daniel Gustafsson wrote:
Staring at this I've been unable to figure out if there an underlying p
On Sat, Apr 08, 2023 at 01:32:22AM +1200, Thomas Munro wrote:
> I'm hoping to get just the regex changes in ASAP, and then take a
> little bit longer on the recovery conflict patch itself (v6-0005) on
> the basis that it's bugfix work and not subject to the feature freeze.
Agreed. It would be goo
Hi,
On 2023-04-07 12:17:38 -0400, Melanie Plageman wrote:
> Attached v9 addresses review feedback as well as resolving merge
> conflicts with recent relation extension patchset.
I've edited it a bit more:
- removed pgstat_tracks_io_time() and replaced it by returning the new
IO_COL_INVALID = -
Michael Paquier writes:
> On Sat, Apr 08, 2023 at 01:32:22AM +1200, Thomas Munro wrote:
>> I'm hoping to get just the regex changes in ASAP, and then take a
>> little bit longer on the recovery conflict patch itself (v6-0005) on
>> the basis that it's bugfix work and not subject to the feature fre
On Fri, Apr 07, 2023 at 02:29:31PM -0400, Tom Lane wrote:
> I'm not sure if there is consensus for 0002, but I reviewed and pushed
> 0001. I made one non-cosmetic change: it no longer skips invalid
> buffers. Otherwise, the row for usage count 0 would be pretty useless.
> Also it seemed to me tha
Hi,
On 2023-04-07 18:26:28 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-04-07 17:46:33 -0400, Tom Lane wrote:
> >> After quickly eyeing the diffs, I'm just going to take the new output
> >> as good. I'm not surprised that there are additional output messages
> >> given the addition
Andrew Dunstan writes:
>> Actually, one quick datapoint. prion and mantid report running IPC::Run
>> version 0.92, and morepork 0.96. Animals that pass are running 20180523.0,
>> 20200505.0, 20220807.0 or similar versions. We don't print the IO::Pty
>> version
>> during configure, but maybe th
Hi,
On 2023-04-07 17:19:42 -0700, Andres Freund wrote:
> I think
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=drongo&dt=2023-04-07%2021%3A16%3A04
> might point out a problem with the pg_dump or pg_upgrade backward compat
> paths:
>
> --- C:\\prog\\bf/root/upgrade.drongo/HEAD/origin-R
I wrote:
> I've been doing some checking with perlbrew locally. It appears to not
> be about IO::Pty so much as IPC::Run: it works with IPC::Run 0.99 but
> not 0.79. Still bisecting to identify exactly what's the minimum
> okay version.
The answer is: it works with IPC::Run >= 0.98. The version
Hi,
On 2023-04-07 20:49:39 -0400, Tom Lane wrote:
> I wrote:
> > I've been doing some checking with perlbrew locally. It appears to not
> > be about IO::Pty so much as IPC::Run: it works with IPC::Run 0.99 but
> > not 0.79. Still bisecting to identify exactly what's the minimum
> > okay version.
Andres Freund writes:
> On 2023-04-07 20:49:39 -0400, Tom Lane wrote:
>> IPC::Run 0.98 is relatively new (2018), so I don't think it'd fly
>> to make that our new minimum version across-the-board. I recommend
>> just setting up this one test to SKIP if IPC::Run is too old.
> Does the test actual
I wrote:
> That seems fine to me. I'll check this over and see if I can get
> it pushed today.
I pushed this after some mostly-cosmetic fiddling. Most of the
buildfarm seems okay with it, but crake's perlcritic run is not:
./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" use
Hi,
If you build with --with-wal-blocksize=/-Dwal_blocksize= anything but
8, this breaks:
running bootstrap script ... LOG: GUC (PGC_INT)
wal_writer_flush_after, boot_val=256, C-var=128
TRAP: failed Assert("check_GUC_init(hentry->gucvar)"), File: "guc.c",
Line: 1519, PID: 84605
From 48d971e0b19f
Hi,
On 2023-04-07 21:13:43 -0400, Tom Lane wrote:
> I wrote:
> > That seems fine to me. I'll check this over and see if I can get
> > it pushed today.
>
> I pushed this after some mostly-cosmetic fiddling. Most of the
> buildfarm seems okay with it, but crake's perlcritic run is not:
>
> ./con
1 - 100 of 138 matches
Mail list logo
