On Wed, Feb 08, 2023 at 07:30:32AM -0500, Andrew Dunstan wrote:
> In the last 30 days, only the following buildfarm animals have reported
> running the ssl checks on the relevant branches:
>
> gokiburi
> hachi
FWIW, these two ones are using OpenSSL 1.1.1, so that's fine.
--
Michael
signature.
On Thu, Feb 09, 2023 at 08:56:24AM +0900, Michael Paquier wrote:
> On Wed, Feb 08, 2023 at 02:25:54PM -0800, Nathan Bossart wrote:
>> These are all good points. Perhaps there could be a base archiver
>> implementation that shell_archive uses (and that other modules could use if
>> desired, which m
Hi,
On 2023-02-08 14:03:49 -0800, Peter Geoghegan wrote:
> On Tue, Feb 7, 2023 at 6:47 PM Andres Freund wrote:
> > One thing I'm not quite sure what to do about is that we atm use a hardcoded
> > DEBUG2 (not controlled by VERBOSE) in a bunch of places:
> >
> > ereport(DEBUG2,
> >
On Thu, Feb 9, 2023 at 10:42 AM Jim Jones wrote:
>
> On 09.02.23 00:09, Peter Smith wrote:
> > I noticed the xmlFreeDoc(doc) within the PG_CATCH is guarded but the
> > other xmlFreeDoc(doc) is not. As the doc is assigned outside the
> > PG_TRY shouldn't those both be the same?
>
> Hi Peter,
>
> My
On Wed, Feb 08, 2023 at 04:21:57PM +0530, Nitin Jadhav wrote:
> Makes sense and the patch looks good to me.
Ah, OK. Thanks for the feedback!
I am wondering.. Did people notice that this adds GUC_NOT_IN_SAMPLE
to config_file in guc_tables.c? This makes sense in the long run
based on what this p
On 2023-02-08 12:16:46 -0800, Jeff Davis wrote:
> On Thu, 2023-02-02 at 18:10 -0500, Tom Lane wrote:
> > Yeah. I would be resistant to making ICU a required dependency,
> > but it doesn't seem unreasonable to start moving towards it being
> > our default collation support.
>
> Patch attached.
Unf
Hi,
I tried the committed pgindent.
The attached small patch changes spaces in the usage message to tabs.
Options other than --commit start with a tab.
Regards,
Noriyoshi Shinoda
From: Andrew Dunstan
Sent: Thursday, February 9, 2023 7:10 AM
To: Jelte Fennema
Cc: Robert Haas ; Tom Lane ; Justin
At Fri, 27 Jan 2023 06:57:01 +, "Hayato Kuroda (Fujitsu)"
wrote in
> I found cfbot failure, PSA fixed version.
+ Unlike , this function checks socket
+ health. This check is performed by polling the socket. This function is
+ currently available only on systems that suppor
On Thu, Feb 09, 2023 at 10:28:14AM +0900, Michael Paquier wrote:
> On Wed, Feb 08, 2023 at 04:21:57PM +0530, Nitin Jadhav wrote:
> > Makes sense and the patch looks good to me.
>
> Ah, OK. Thanks for the feedback!
>
> I am wondering.. Did people notice that this adds GUC_NOT_IN_SAMPLE
> to conf
On Wed, Feb 8, 2023 at 4:29 PM Andres Freund wrote:
> I find it useful information when debugging problems. Without it, the log
> doesn't tell you which index was processed when a problem started to occur. Or
> even that we were scanning indexes at all.
I guess it might have some limited value wh
Justin Pryzby writes:
> On Thu, Feb 09, 2023 at 10:28:14AM +0900, Michael Paquier wrote:
>> I am wondering.. Did people notice that this adds GUC_NOT_IN_SAMPLE
>> to config_file in guc_tables.c? This makes sense in the long run
>> based on what this parameter is by design, still there may be an
Hello.
While looking a patch, I found that pqSocketPoll passes through the
result from poll(2) to the caller and throws away revents. If I
understand it correctly, poll() *doesn't* return -1 nor errno by the
reason it has set POLLERR, POLLHUP, POLLNVAL, and POLLRDHUP for some
of the target sockets
Hi,
On 2023-02-08 18:37:41 -0800, Peter Geoghegan wrote:
> On Wed, Feb 8, 2023 at 4:29 PM Andres Freund wrote:
> > 2) Add a message to lazy_vacuum() or lazy_vacuum_all_indexes(), that
> > includes
> >- num_index_scans
> >- how many indexes we'll scan
> >- how many dead tids we're wor
Hi,
On 2023-02-07 22:38:14 -0800, Andres Freund wrote:
> I did another read through the series. I do have some minor changes, but
> they're minor. I think this is ready for commit. I plan to start pushing
> tomorrow.
Pushed the first (and biggest) commit. More tomorrow.
Already can't wait to se
Hi,
On 2023-02-08 17:18:13 -0500, Tom Lane wrote:
> However, I've not done anything about documenting what is the minimum ninja
> version.
Sorry, plan to tackle work around this tomorrow. Got stuck for much longer
than I had hoped to debug flapping tests (parts resolved, several others not).
My
At Wed, 8 Feb 2023 09:03:03 +, "Hayato Kuroda (Fujitsu)"
wrote in
> Thank you for reviewing! PSA new version.
+ if (statusinterval_ms > 0 && diffms > statusinterval_ms)
The next expected feedback time is measured from the last status
report. Thus, it seems to me this may sup
On 2023-02-08 10:55:44 -0800, Nathan Bossart wrote:
> done
Pushed. Thanks!
Hi all,
The following SQL sequence causes a failure of pg_upgrade when these
are executed on a cluster of ~13, doing an upgrade to 14~, assuming
that the relation page size is 8kB. This creates a partition table
with a set of values large enough that it can be created in ~13:
CREATE TABLE parent_
Michael Paquier writes:
> The following SQL sequence causes a failure of pg_upgrade when these
> are executed on a cluster of ~13, doing an upgrade to 14~, assuming
> that the relation page size is 8kB.
> ...
> No fields have been added to pg_class between 13 and 14, however the
> amount of data s
On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote:
> Some more accumulated/new typos.
0001 has been a debate for a long time, and it depends on the way SQL
is spelled. For reference:
$ git grep -i " an sql" -- *.c | wc -l
63
$ git grep -i " a sql" -- *.c | wc -l
135
0005 can indeed f
On Wednesday, February 8, 2023 6:47 PM Hayato Kuroda (Fujitsu)
wrote:
> PSA rebased patch that supports updated time-delayed patch[1].
Hi,
Thanks for creating the patch ! Minor review comments on v5-0002.
(1)
+ Decides the condition for exiting the walsender process.
+ 'wait_
On Thu, Feb 9, 2023 at 1:33 AM Andres Freund wrote:
>
> Hacking on a rough prototype how I think this should rather look, I had a few
> questions / remarks:
>
> - We probably need to call UpdateProgress from a bunch of places in decode.c
> as well? Indicating that we're lagging by a lot, just be
On Thu, Feb 09, 2023 at 12:33:06AM -0500, Tom Lane wrote:
> It might be worth expending a pre-check on, if only because the
> check could offer some advice about fixing the problem.
Based on the information coming from pg_class, yes, something could be
reported back. Now things get more hairy if
On Thu, Feb 9, 2023 at 3:36 AM Nathan Bossart wrote:
>
> + pg_atomic_exchange_u64(valptr, val);
>
> nitpick: I'd add a (void) at the beginning of these calls to
> pg_atomic_exchange_u64() so that it's clear that we are discarding the
> return value.
I did that in the attached v5 patch altho
On Wed, Feb 8, 2023 at 1:13 PM Amit Kapila wrote:
>
> On Wed, Feb 8, 2023 at 1:19 AM Andres Freund wrote:
> >
> > On 2023-02-01 11:23:57 +0530, Amit Kapila wrote:
> > > On Tue, Jan 31, 2023 at 6:08 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > Attached updated patches.
> > > >
> > >
> > > Tha
Michael Paquier writes:
> On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote:
>> Some more accumulated/new typos.
> 0005 can indeed fix a lot of confusion around the spaces after an
> "else if" block. Is that something that could be automated with the
> indentation, though? Same rema
On Sat, Jan 21, 2023 at 5:56 AM Bharath Rupireddy
wrote:
>
> On Fri, Dec 2, 2022 at 1:07 PM Drouvot, Bertrand
> wrote:
> >
> > Patch LGTM, marking it as Ready for Committer.
>
> Had to rebase, attached v5 patch for further consideration.
One more rebase due to 28e626bd (pgstat: Infrastructure fo
Hi,
On 2023-02-09 12:21:51 +0530, Bharath Rupireddy wrote:
> @@ -1105,18 +1105,22 @@ CREATE VIEW pg_stat_archiver AS
>
> CREATE VIEW pg_stat_bgwriter AS
> SELECT
> -pg_stat_get_bgwriter_timed_checkpoints() AS checkpoints_timed,
> -pg_stat_get_bgwriter_requested_checkpoints(
Hi,
On Tue, Feb 7, 2023 at 6:25 PM John Naylor wrote:
>
>
> On Tue, Jan 31, 2023 at 9:43 PM Masahiko Sawada wrote:
>
> > I've attached v24 patches. The locking support patch is separated
> > (0005 patch). Also I kept the updates for TidStore and the vacuum
> > integration from v23 separate.
>
>
On 09.02.23 02:01, Peter Smith wrote:
OTOH, if you are having to check for NULL doc anyway, maybe it's just
as easy only doing that up-front. Then you could quick-exit the
function without calling xmlDocDumpFormatMemory etc. in the first
place. For example:
doc = xml_parse(arg, XMLOPTION_DOCUMEN
Jim Jones writes:
> I see your point. If I got it right, you're suggesting the following
> change in the PG_TRY();
> PG_TRY();
> {
> int nbytes;
> if(!doc)
> xml_ereport(xmlerrcxt, ERROR, ERRCODE_INTERNAL_ERROR,
> "could not parse th
On Thu, Feb 9, 2023 at 12:17 AM Peter Smith wrote:
>
> On Wed, Feb 8, 2023 at 8:03 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> ...
> > > ==
> > >
> > > src/backend/replication/logical/worker.c
> > >
> > > 2. maybe_apply_delay
> > >
> > > + if (wal_receiver_status_interval > 0 &&
> > > + diffms
101 - 132 of 132 matches
Mail list logo
