On Thu, Feb 09, 2023 at 10:28:14AM +0900, Michael Paquier wrote: > On Wed, Feb 08, 2023 at 04:21:57PM +0530, Nitin Jadhav wrote: > > Makes sense and the patch looks good to me. > > Ah, OK. Thanks for the feedback! > > I am wondering.. Did people notice that this adds GUC_NOT_IN_SAMPLE > to config_file in guc_tables.c? This makes sense in the long run > based on what this parameter is by design, still there may be an > objection to doing that?
I think it's fine to add the flag. See also: https://www.postgresql.org/message-id/flat/20211129030833.gj17...@telsasoft.com |Since GUC_DISALLOW_IN_FILE effectively implies GUC_NOT_IN_SAMPLE in |src/backend/utils/misc/help_config.c:displayStruct(), many of the |redundant GUC_NOT_IN_SAMPLE could be removed. -- Justin
