Re: ANY_VALUE aggregate

2022-12-06 Thread David G. Johnston
On Mon, Dec 5, 2022 at 10:40 PM Vik Fearing wrote: > On 12/6/22 05:57, David G. Johnston wrote: > > On Mon, Dec 5, 2022 at 9:48 PM Vik Fearing > wrote: > > > >> I can imagine an optimization that would remove an ORDER BY clause > >> because it isn't needed for any other aggregate. > > > > > > I'

Re: [RFC] building postgres with meson - v13

2022-12-06 Thread Andres Freund
Hi, On 2022-09-26 14:15:35 -0700, Peter Geoghegan wrote: > On Mon, Sep 26, 2022 at 1:27 PM Andres Freund wrote: > > > Some feedback: > > > * I gather that "running" as it appears in commands like "meson test > > > --setup running" refers to a particular setup named "running", that > > > you inven

Re: Perform streaming logical transactions by background workers and parallel apply

2022-12-06 Thread Masahiko Sawada
On Thu, Dec 1, 2022 at 7:17 PM houzj.f...@fujitsu.com wrote: > > On Thursday, December 1, 2022 3:58 PM Masahiko Sawada > wrote: > > > > On Wed, Nov 30, 2022 at 10:51 PM houzj.f...@fujitsu.com > > wrote: > > > > > > On Wednesday, November 30, 2022 9:41 PM houzj.f...@fujitsu.com > > wrote: > > >

Re: Force streaming every change in logical decoding

2022-12-06 Thread Amit Kapila
On Wed, Dec 7, 2022 at 7:31 AM Masahiko Sawada wrote: > > On Wed, Dec 7, 2022 at 8:46 AM Peter Smith wrote: > > > > > > > > Yeah, I think this can also help in reducing the time for various > > > tests in test_decoding/stream and > > > src/test/subscription/t/*_stream_*.pl file by reducing the nu

Re: Avoid streaming the transaction which are skipped (in corner cases)

2022-12-06 Thread Amit Kapila
On Tue, Dec 6, 2022 at 11:55 AM shiy.f...@fujitsu.com wrote: > > On Mon, Dec 5, 2022 6:57 PM Amit Kapila wrote: > > > > On Mon, Dec 5, 2022 at 3:41 PM Dilip Kumar wrote: > > > > > > I think we need something like this[1] so that we can better control > > > the streaming. > > > > > > > +1. The ad

Re: Avoid streaming the transaction which are skipped (in corner cases)

2022-12-06 Thread Dilip Kumar
On Wed, Dec 7, 2022 at 9:28 AM Amit Kapila wrote: > > On Tue, Dec 6, 2022 at 11:55 AM shiy.f...@fujitsu.com > wrote: > > > > On Mon, Dec 5, 2022 6:57 PM Amit Kapila wrote: > > > > > > On Mon, Dec 5, 2022 at 3:41 PM Dilip Kumar wrote: > > > > > > > > I think we need something like this[1] so tha

RE: Avoid streaming the transaction which are skipped (in corner cases)

2022-12-06 Thread shiy.f...@fujitsu.com
On Wed, Dec 7, 2022 12:01 PM Dilip Kumar wrote: > > On Wed, Dec 7, 2022 at 9:28 AM Amit Kapila > wrote: > > > > On Tue, Dec 6, 2022 at 11:55 AM shiy.f...@fujitsu.com > > wrote: > > > > > > On Mon, Dec 5, 2022 6:57 PM Amit Kapila > wrote: > > > > > > > > On Mon, Dec 5, 2022 at 3:41 PM Dilip Kum

Re: Perform streaming logical transactions by background workers and parallel apply

2022-12-06 Thread Amit Kapila
On Wed, Dec 7, 2022 at 9:00 AM Masahiko Sawada wrote: > > On Thu, Dec 1, 2022 at 7:17 PM houzj.f...@fujitsu.com > wrote: > > > > > --- > > > if (am_parallel_apply_worker() && on_subinfo_change) { > > > /* > > > * If a parallel apply worker exits due to the subscription > > > * infor

Re: Perform streaming logical transactions by background workers and parallel apply

2022-12-06 Thread Masahiko Sawada
On Wed, Dec 7, 2022 at 1:29 PM Amit Kapila wrote: > > On Wed, Dec 7, 2022 at 9:00 AM Masahiko Sawada wrote: > > > > On Thu, Dec 1, 2022 at 7:17 PM houzj.f...@fujitsu.com > > wrote: > > > > > > > --- > > > > if (am_parallel_apply_worker() && on_subinfo_change) { > > > > /* > > > > * If a

Re: Time delayed LR (WAS Re: logical replication restrictions)

2022-12-06 Thread Amit Kapila
On Tue, Dec 6, 2022 at 5:44 PM Takamichi Osumi (Fujitsu) wrote: > > On Friday, December 2, 2022 4:05 PM Amit Kapila > wrote: > > On Tue, Nov 15, 2022 at 12:33 PM Amit Kapila > > wrote: > > > One more thing I would like you to consider is the point raised by me > > > related to this patch's inte

RE: Time delayed LR (WAS Re: logical replication restrictions)

2022-12-06 Thread Takamichi Osumi (Fujitsu)
On Wednesday, December 7, 2022 12:00 PM Kyotaro Horiguchi wrote: > At Tue, 6 Dec 2022 11:08:43 -0800, Andres Freund wrote > in > > Hi, > > > > The tests fail on cfbot: > > https://cirrus-ci.com/task/4533866329800704 > > > > They only seem to fail on 32bit linux. > > > > https://api.cirrus-ci.com

Re: Force streaming every change in logical decoding

2022-12-06 Thread Masahiko Sawada
On Wed, Dec 7, 2022 at 12:55 PM Amit Kapila wrote: > > On Wed, Dec 7, 2022 at 7:31 AM Masahiko Sawada wrote: > > > > On Wed, Dec 7, 2022 at 8:46 AM Peter Smith wrote: > > > > > > > > > > > Yeah, I think this can also help in reducing the time for various > > > > tests in test_decoding/stream and

Re: Question regarding "Make archiver process an auxiliary process. commit"

2022-12-06 Thread Sravan Kumar
On Tue, Dec 6, 2022 at 5:24 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Tue, Dec 6, 2022 at 4:57 PM Sravan Kumar > wrote: > > > > Thank you for the feedback. > > > > I'll be glad to help with the fix. Here's the patch for review. > > Thanks. +1 for fixing this. >> I

Re: Question regarding "Make archiver process an auxiliary process. commit"

2022-12-06 Thread Kyotaro Horiguchi
At Tue, 6 Dec 2022 17:23:50 +0530, Bharath Rupireddy wrote in > Thanks. +1 for fixing this. > > I would like to quote recent discussions on reducing the useless > wakeups or increasing the sleep/hibernation times in various processes > to reduce the power savings [1] [2] [3] [4] [5]. With that

Re: Question regarding "Make archiver process an auxiliary process. commit"

2022-12-06 Thread Kyotaro Horiguchi
At Wed, 7 Dec 2022 11:28:23 +0530, Sravan Kumar wrote in > On Tue, Dec 6, 2022 at 5:24 PM Bharath Rupireddy < > bharath.rupireddyforpostg...@gmail.com> wrote: > > > On Tue, Dec 6, 2022 at 4:57 PM Sravan Kumar > > wrote: > > > > > > Thank you for the feedback. > > > > > > I'll be glad to help w

Re: ExecRTCheckPerms() and many prunable partitions

2022-12-06 Thread Amit Langote
On Wed, Dec 7, 2022 at 12:19 AM Alvaro Herrera wrote: > I have pushed this finally. Thanks a lot. > I made two further changes: > > 1. there was no reason to rename ExecCheckPerms_hook, since its >signature was changing anyway. I reverted it to the original name. Sure, that makes sense. >

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-06 Thread Peter Smith
On Tue, Dec 6, 2022 at 5:57 AM samay sharma wrote: > > Hi, > > On Mon, Oct 24, 2022 at 12:45 AM Peter Smith wrote: >> >> Hi hackers. >> >> There is a docs Logical Replication section "31.10 Configuration >> Settings" [1] which describes some logical replication GUCs, and >> details on how they in

Re: Perform streaming logical transactions by background workers and parallel apply

2022-12-06 Thread Amit Kapila
On Wed, Dec 7, 2022 at 10:10 AM Masahiko Sawada wrote: > > On Wed, Dec 7, 2022 at 1:29 PM Amit Kapila wrote: > > > > Right, but the leader will anyway exit at some point either due to an > > ERROR like "lost connection ... to parallel worker" or with a LOG > > like: "... will restart because of a

Re: add \dpS to psql

2022-12-06 Thread Pavel Luzanov
On 06.12.2022 22:36, Nathan Bossart wrote: As discussed elsewhere [0], \dp doesn't show privileges on system objects, and this behavior is not mentioned in the docs. I've attached a small patch that adds support for the S modifier (i.e., \dpS) and the adjusts the docs. Thoughts? [0] https://p

Re: Force streaming every change in logical decoding

2022-12-06 Thread Amit Kapila
On Wed, Dec 7, 2022 at 10:55 AM Masahiko Sawada wrote: > > On Wed, Dec 7, 2022 at 12:55 PM Amit Kapila wrote: > > > > > On one side having separate GUCs for publisher and subscriber seems to > > give better flexibility but having more GUCs also sometimes makes them > > less usable. Here, my thoug

Generating code for query jumbling through gen_node_support.pl

2022-12-06 Thread Michael Paquier
Hi all, This thread is a follow-up of the recent discussion about query jumbling with DDL statements, where the conclusion was that we'd want to generate all this code automatically for all the nodes: https://www.postgresql.org/message-id/36e5bffe-e989-194f-85c8-06e7bc88e...@amazon.com What this

<    1   2