Re: Improve description of XLOG_RUNNING_XACTS

2022-11-03 Thread Ian Lawrence Barwick
2022年11月2日(水) 15:24 Amit Kapila : > > On Tue, Nov 1, 2022 at 4:33 PM Amit Kapila wrote: > > > > On Tue, Nov 1, 2022 at 12:53 PM Michael Paquier wrote: > > > > > > On Mon, Oct 17, 2022 at 02:53:57PM +0900, Michael Paquier wrote: > > > > No objections from here if you want to go ahead with v3 and p

Re: Support logical replication of DDLs

2022-11-03 Thread Peter Smith
Here are some more review comments for the v32-0001 file ddl_deparse.c (This is a WIP since it is such a large file) == 1. General - calling VA with 0 args There are some calls to new_objtree_VA() where 0 extra args are passed. e.g. See in deparse_AlterFunction * alterFunc = new_objtree_VA

Re: Adding doubly linked list type which stores the number of items in the list

2022-11-03 Thread Bharath Rupireddy
On Wed, Nov 2, 2022 at 2:23 PM Aleksander Alekseev wrote: > > Hi David, > > > Pushed. Thank you both for reviewing this. > > Thanks for applying the patch. > > >> Should we consider const'ifying the arguments of the dlist_*/dclist_* > >> functions that don't change the arguments? > >> [...] > > Y

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

2022-11-03 Thread Ian Lawrence Barwick
2022年10月10日(月) 18:16 Aleksander Alekseev : > > Hi hackers, > > > Sorry about that. > > No problem. > > > Thanks, Simon. Not 100% sure who exactly is invited to vote, but just > > in case here is +1 from me. These patches were "Ready for Committer" > > for several months now and are unlikely to get

Re: Add index scan progress to pg_stat_progress_vacuum

2022-11-03 Thread Ian Lawrence Barwick
2022年11月3日(木) 1:52 Imseih (AWS), Sami : > > Attached is v13-0001--Show-progress-for-index-vacuums.patch which addresses > the latest comments. The main changes are: > > 1/ Call the parallel_vacuum_progress_report inside the AMs rather than > vacuum_delay_point. > > 2/ A Boolean when set to True in

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

2022-11-03 Thread Dilip Kumar
On Thu, Nov 3, 2022 at 1:46 PM Maxim Orlov wrote: > > Hi! > >> >> This entry was marked "Ready for committer" in the CommitFest app but cfbot >> reports the patch no longer applies. > > Thanks for the reminder. I think, this should work. Have we measured the WAL overhead because of this patch set

Re: [PATCH] Add native windows on arm64 support

2022-11-03 Thread Ian Lawrence Barwick
2022年9月1日(木) 13:42 Michael Paquier : > > On Wed, Aug 31, 2022 at 10:22:06PM -0400, Tom Lane wrote: > > Michael Paquier writes: > > > The input object could also be reworked so as we would not have any > > > ordering issues, say "pre&deeppost". > > > Changing only the path, you could use "/e/n2" in

Re: Segfault on logical replication to partitioned table with foreign children

2022-11-03 Thread Ilya Gladyshev
On Wed, 2022-11-02 at 12:37 -0400, Tom Lane wrote: > Since we're getting pretty close to the next set of back-branch > releases, > I went ahead and pushed a minimal fix along the lines suggested by > Shi Yu. > (I realized that there's a second ExecFindPartition call in worker.c > that > also needs

Re: Prefetch the next tuple's memory during seqscans

2022-11-03 Thread John Naylor
On Tue, Nov 1, 2022 at 5:17 AM David Rowley wrote: > > My test is to run 16 queries changing the WHERE clause each time to > have WHERE a = 0, then WHERE a2 = 0 ... WHERE a16 = 0. I wanted to > know if prefetching only the first cache line of the tuple would be > less useful when we require eval

Re: Check SubPlan clause for nonnullable rels/Vars

2022-11-03 Thread Richard Guo
On Thu, Nov 3, 2022 at 4:26 AM Tom Lane wrote: > * I don't believe you can prove anything from an ALL_SUBLINK SubPlan, > because it will return true if the sub-query returns zero rows, no > matter what the testexpr is. (Maybe if you could prove the sub-query > does return a row, but I doubt it's

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

2022-11-03 Thread Ian Lawrence Barwick
2022年11月3日(木) 17:15 Maxim Orlov : > > Hi! > >> >> This entry was marked "Ready for committer" in the CommitFest app but cfbot >> reports the patch no longer applies. > > Thanks for the reminder. I think, this should work. Thanks for the quick update, cfbot reports no issues. I've set the CF entry

Re: Adding CommandID to heap xlog records

2022-11-03 Thread Ian Lawrence Barwick
2022年9月30日(金) 1:04 Matthias van de Meent : > > On Wed, 28 Sept 2022 at 19:40, Bruce Momjian wrote: > > > > On Thu, Sep 22, 2022 at 11:12:32PM +0200, Matthias van de Meent wrote: > > > On Thu, 8 Sept 2022 at 23:24, Tom Lane wrote: > > > > > > > > Matthias van de Meent writes: > > > > > Please fin

Re: Commit fest 2022-11

2022-11-03 Thread Ian Lawrence Barwick
2022年11月3日(木) 11:33 Ian Lawrence Barwick : > > 2022年11月2日(水) 19:10 Greg Stark : > > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > > > Two people showing up to help is really great, thanks! I'll be around > > > as well this month, so I'll do my share of patches, as usual. > > > > F

Re: Allow single table VACUUM in transaction block

2022-11-03 Thread Simon Riggs
On Tue, 1 Nov 2022 at 23:56, Simon Riggs wrote: > > I haven't checked the rest of the patch, but +1 for allowing VACUUM FULL > > within a user txn. > > My intention was to prevent that. I am certainly quite uneasy about > changing anything related to CLUSTER/VF, since they are old, complex > and

Re: Pluggable toaster

2022-11-03 Thread Aleksander Alekseev
Hi Nikita, > I'm going to submit a more detailed code review soon. As promised, here is my feedback. ``` + Toaster could be assigned to toastable column with expression + STORAGE external TOASTER toaster_name ``` 1.1. Could you please clarify what is the motivation behind such a verbo

Re: Lockless queue of waiters in LWLock

2022-11-03 Thread Pavel Borisov
Hi, hackers! > I'm planning to gather more detailed statistics on different > LWLockAcquire calls soon to understand prospects for further > optimizations. So, I've made more measurements. 1. Applied measuring patch 0001 to a patch with lockless queue optimization (v2) from [0] in this thread and

Fix comments atop ReorderBufferAddInvalidations

2022-11-03 Thread Amit Kapila
The comments atop seem to indicate that we always accumulate invalidation messages in top-level transactions which is neither required nor match with the code. This is introduced in the commit c55040ccd0 and I have observed it while working on a fix for commit 16b1fe0037. -- With Regards, Amit Ka

Re: [PATCH] Add native windows on arm64 support

2022-11-03 Thread Niyas Sait
> I've gone ahead and marked it as "Committed", as that appears to have happened > back in August as 36389a060c. > If for whatever reason that was the Wrong Thing To Do, please let me know. 36389a060c commit enables ASLR for windows but does not include other changes required for Arm64. I've atta

Re: confirmed_flush_lsn shows LSN of the data that has not yet been received by the logical subscriber.

2022-11-03 Thread Amit Kapila
On Mon, Sep 19, 2022 at 8:09 PM Ashutosh Sharma wrote: > > Thanks for the clarification. Attached is the patch with the changes. > Please have a look. > LGTM. I'll push this tomorrow unless there are any other comments/suggestions for this. -- With Regards, Amit Kapila.

Re: Pluggable toaster

2022-11-03 Thread Nikita Malakhov
Hi! Thank you very much for the feedback. Answering accordingly to questions/remarks order: >I'm in the process of testing and reviewing the v23 patchset. So far I >just wanted to report that there seems to be certain issues with the >formatting and/or trailing whitespaces in the patches: Accept

Add explicit casts in four places to simplehash.h

2022-11-03 Thread David Geier
Hi hackers, While working on an extension, I found that simplehash.h is missing explicit casts in four places. Without these casts, compiling code including simplehash.h yields warnings if the code is compiled with -Wc++-compat. PostgreSQL seems to mostly prefer omitting the explicit casts,

Re: Incorrect include file order in guc-file.l

2022-11-03 Thread Michael Paquier
On Thu, Nov 03, 2022 at 12:40:19PM +0700, John Naylor wrote: > On Wed, Nov 2, 2022 at 1:01 PM Julien Rouhaud wrote: >> Agreed, it's apparently an oversight in dac048f71eb. +1 for the patch. > > I've pushed this, thanks! Thanks for the commit. I've wanted to get it done yesterday but life took

Re: [PATCH] Add native windows on arm64 support

2022-11-03 Thread Michael Paquier
On Thu, Nov 03, 2022 at 11:06:46AM +, Niyas Sait wrote: > > I've gone ahead and marked it as "Committed", as that appears to have > happened > > back in August as 36389a060c. > > If for whatever reason that was the Wrong Thing To Do, please let me know. > > 36389a060c commit enables ASLR for w

Re: pg_basebackup's --gzip switch misbehaves

2022-11-03 Thread Michael Paquier
On Wed, Nov 02, 2022 at 09:42:12PM +0100, Daniel Gustafsson wrote: > I think that's a good idea, not everyone running tests will read the internals > documentation (or even know abou it even). How about the attached? Thanks for the patch. Perhaps this should be mentioned additionally in install-

Re: Allow file inclusion in pg_hba and pg_ident files

2022-11-03 Thread Michael Paquier
On Wed, Nov 02, 2022 at 09:06:02PM +0800, Julien Rouhaud wrote: > Maybe one alternative approach would be to keep modifying the current test, > and > only do the split when committing the first part? The split itself should be > easy and mechanical: just remove everything unneeded (different file

Re: Commit fest 2022-11

2022-11-03 Thread Michael Paquier
On Thu, Nov 03, 2022 at 06:48:34PM +0900, Ian Lawrence Barwick wrote: > I am wondering what the best thing to do with cases like this is: > > https://commitfest.postgresql.org/40/3977/ > > where there were multiple patches in the original post, and some but not all > were applied - so those o

Re: Incorrect include file order in guc-file.l

2022-11-03 Thread John Naylor
On Thu, Nov 3, 2022 at 6:40 PM Michael Paquier wrote: > > On Thu, Nov 03, 2022 at 12:40:19PM +0700, John Naylor wrote: > > On Wed, Nov 2, 2022 at 1:01 PM Julien Rouhaud wrote: > >> Agreed, it's apparently an oversight in dac048f71eb. +1 for the patch. > > > > I've pushed this, thanks! > > Thanks

Re: real/float example for testlibpq3

2022-11-03 Thread Peter Eisentraut
On 01.11.22 09:15, Tom Lane wrote: Peter Eisentraut writes: If we want to start documenting the binary format for all data types, it should go into the "Data Types" chapter. There, we already document the text format in great detail, so putting the binary format in there as well would make sen

Re: Pluggable toaster

2022-11-03 Thread Aleksander Alekseev
Hi Nikita, Please, avoid top-posting [1]. > Toaster is set for the table column. Each TOASTable column could have > a different Toaster, so column option is the most obvious place to add it. This is a major limitation. IMO the user should be able to set a custom TOASTer for the entire table as w

Re: real/float example for testlibpq3

2022-11-03 Thread Tom Lane
Peter Eisentraut writes: > On 01.11.22 09:15, Tom Lane wrote: >> Agreed that the libpq manual is not the place for this, but I feel >> like it will also be clutter in "Data Types". Perhaps we should >> invent a new appendix or the like? Somewhere near the wire protocol >> docs seems sensible. >

Re: Moving forward with TDE

2022-11-03 Thread Aleksander Alekseev
Hi David, > Working with Stephen, I am attempting to pick up some of the work that > was left off with TDE and the key management infrastructure. I have > rebased Bruce's KMS/TDE patches as they existed on the > https://wiki.postgresql.org/wiki/Transparent_Data_Encryption wiki > page, which are e

Re: Pluggable toaster

2022-11-03 Thread Nikita Malakhov
Hi, Setting TOAST for table and database is a subject for discussion. There is already default Toaster. Also, there is not much sense in setting Jsonb Toaster as default even for table, do not say database, because table could contain other TOASTable columns not of Json type. To be able to set cu

Re: Add explicit casts in four places to simplehash.h

2022-11-03 Thread Tom Lane
David Geier writes: > What about, while not being strictly necessary for PostgreSQL itself, > also adding such casts to simplehash.h so that it can be used in code > where -Wc++-compat is enabled? Seems reasonable, so done (I fixed one additional spot you missed). The bigger picture here is th

Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment

2022-11-03 Thread Maxim Orlov
Hi! Part of the work that Thomas mentions in [1], regarding Direct I/O, > has certain requirements that pointers must be page-aligned. > > I've attached a patch which implements palloc_aligned() and > MemoryContextAllocAligned() ... > I've done a quick look and the patch is looks good to me. Let's

Re: [BUG] Logical replica crash if there was an error in a function.

2022-11-03 Thread Tom Lane
Amit Kapila writes: > LGTM. I don't know if it is a good idea to omit the test case for this > scenario. If required, we can reuse the test case from Sawada-San's > patch in the email [1]. I don't think the cost of that test case is justified by the tiny probability that it'd ever catch anything.

Re: parse partition strategy string in gram.y

2022-11-03 Thread Alvaro Herrera
Pushed this. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

Re: Speed up transaction completion faster after many relations are accessed in a transaction

2022-11-03 Thread Ankit Kumar Pandey
Hi David, This is review of speed up releasing of locks patch. Contents & Purpose: Subject is missing in patch. It would have been easier to understand purpose had it been included. Included in the patch are change in README, but no new tests are included.. Initial Run: The patch applies cleanl

Re: Privileges on PUBLICATION

2022-11-03 Thread Peter Eisentraut
On 03.11.22 01:43, Antonin Houska wrote: Peter Eisentraut wrote: The CF entry is about privileges on publications. Please rebase that patch and repost it so that the CF app and the CF bot are up to date. The rebased patch (with regression tests added) is attached here. Some preliminary di

Re: Add the ability to limit the amount of memory that can be allocated to backends.

2022-11-03 Thread Reid Thompson
On Tue, 2022-10-25 at 11:49 -0400, Reid Thompson wrote: > Hi Arne, > > On Mon, 2022-10-24 at 15:27 +, Arne Roland wrote: > > Hello Reid, > > > > could you rebase the patch again? It doesn't apply currently > > (http://cfbot.cputube.org/patch_40_3867.log). Thanks! > > rebased patches attached

new option to allow pg_rewind to run without full_page_writes

2022-11-03 Thread Jérémie Grauer
Hello, Currently pg_rewind refuses to run if full_page_writes is off. This is to prevent it to run into a torn page during operation. This is usually a good call, but some file systems like ZFS are naturally immune to torn page (maybe btrfs too, but I don't know for sure for this one). Hav

remove unnecessary assignment to tmask in DecodeDateTime

2022-11-03 Thread Zhihong Yu
Hi, I was looking at the code in DecodeDateTime() around line 1382: tmask = DTK_M(type); In case type is UNKNOWN_FIELD, the above macro would shift 1 left 31 bits which cannot be represented in type 'int'. Looking down in the same function, we can see that tmask is assigned for ev

Re: remap the .text segment into huge pages at run time

2022-11-03 Thread Andres Freund
Hi, On 2022-11-02 13:32:37 +0700, John Naylor wrote: > It's been known for a while that Postgres spends a lot of time translating > instruction addresses, and using huge pages in the text segment yields a > substantial performance boost in OLTP workloads [1][2]. Indeed. Some of that we eventually

Re: security_context_t marked as deprecated in libselinux 3.1

2022-11-03 Thread Alvaro Herrera
On 2020-Aug-14, Michael Paquier wrote: > On Thu, Aug 13, 2020 at 08:47:28PM -0400, Tom Lane wrote: > > Should we back-patch that? Usually I figure that people might want > > to build back PG branches on newer platforms at some point, so that > > it's useful to apply portability fixes across-the-b

Re: Fix proposal for comparaison bugs in PostgreSQL::Version

2022-11-03 Thread Justin Pryzby
On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote: > Nice catch, but this looks like massive overkill. I think we can very > simply fix the test in just a few lines of code, instead of a 190 line > fix and a 130 line TAP test. > > It was never intended to be able to compare markers li

Re: ssl tests aren't concurrency safe due to get_free_port()

2022-11-03 Thread Andrew Dunstan
On 2022-11-02 We 15:09, Andrew Dunstan wrote: > On 2022-10-17 Mo 10:59, Andrew Dunstan wrote: >> On 2022-10-04 Tu 01:39, Andrew Dunstan wrote: >>> On 2022-10-02 Su 12:49, Andres Freund wrote: 2) Use a lockfile containing a pid to protect the choice of a port within a build directory.

Re: heavily contended lwlocks with long wait queues scale badly

2022-11-03 Thread Jonathan S. Katz
On 11/1/22 1:41 PM, Andres Freund wrote: Andres: when you suggested backpatching, were you thinking of the Nov 2022 release or the Feb 2023 release? I wasn't thinking that concretely. Even if we decide to backpatch, I'd be very hesitant to do it in a few days. Yeah this was my thinking (and

Re: [BUG] parenting a PK constraint to a self-FK one (Was: Self FK oddity when attaching a partition)

2022-11-03 Thread Alvaro Herrera
On 2022-Oct-05, Alvaro Herrera wrote: > I've been giving the patches a look and it caused me to notice two > additional bugs in the same area: > > - FKs in partitions are sometimes marked NOT VALID. This is because of > missing initialization when faking up a Constraint node in > CloneFkRefe

Re: On login trigger: take three

2022-11-03 Thread Daniel Gustafsson
> On 20 Sep 2022, at 16:10, Daniel Gustafsson wrote: > Since the original authors seems to have retired from the patch > (I've only rebased it to try and help) I am inclined to mark it as returned > with feedback. Doing so now since no updates have been posted for quite some time and holes have

Re: Tracking last scan time

2022-11-03 Thread Dave Page
On Mon, 31 Oct 2022 at 07:36, Dave Page wrote: > FYI, this is not intentional, and I do plan to look into it, however I've > been somewhat busy with pgconfeu, and am travelling for the rest of this > week as well. > Here's a patch to fix this issue. Many thanks to Peter Eisentraut who figured it

GUC for temporarily disabling event triggers

2022-11-03 Thread Daniel Gustafsson
In the thread discussing the login event trigger patch it was argued that we want to avoid recommending single-user mode for troubleshooting tasks, and a GUC for temporarily disabling event triggers was proposed. Since the login event trigger patch lost momentum, I've broken out the GUC part into

Re: proposal: possibility to read dumped table's name from file

2022-11-03 Thread Pavel Stehule
čt 3. 11. 2022 v 5:09 odesílatel Julien Rouhaud napsal: > Hi, > > On Wed, Oct 26, 2022 at 06:26:26AM +0200, Pavel Stehule wrote: > > > > út 18. 10. 2022 v 11:33 odesílatel Julien Rouhaud > > napsal: > > > > > > > > I'm wondering if psql's parse_identifier() could be exported and reused > > > her

Re: Use array as object (src/fe_utils/parallel_slot.c)

2022-11-03 Thread Tom Lane
Michael Paquier writes: > Based on the way the code is written on HEAD, this would be the > correct assumption. Now, calling PQgetCancel() would return NULL for > a connection that we actually ignore in the code a couple of lines > above when it has PGINVALID_SOCKET. So it seems to me that the >

Re: Incorrect include file order in guc-file.l

2022-11-03 Thread Michael Paquier
On Thu, Nov 03, 2022 at 07:19:07PM +0700, John Naylor wrote: > Because it wouldn't compile otherwise, obviously. :-) > > I must have been working on it before bfb9dfd93720 Hehe, my fault then ;p The CI is able to complete without it. Would you mind if it is removed? If you don't want us to pok

Re: security_context_t marked as deprecated in libselinux 3.1

2022-11-03 Thread Tom Lane
Alvaro Herrera writes: > On 2020-Aug-14, Michael Paquier wrote: >> On Thu, Aug 13, 2020 at 08:47:28PM -0400, Tom Lane wrote: >>> Should we back-patch that? Usually I figure that people might want >>> to build back PG branches on newer platforms at some point, so that >>> it's useful to apply port

Re: Add semi-join pushdown to postgres_fdw

2022-11-03 Thread Ian Lawrence Barwick
2022年8月30日(火) 15:58 Alexander Pyhalov : > > Ashutosh Bapat писал 2022-08-29 17:12: > > Hi Alexander, > > Thanks for working on this. It's great to see FDW join pushdown scope > > being expanded to more complex cases. > > > > I am still figuring out the implementation. It's been a while I have > > l

Re: [PATCH] Completed unaccent dictionary with many missing characters

2022-11-03 Thread Ian Lawrence Barwick
2022年7月13日(水) 19:13 Przemysław Sztoch : > > Dear Michael P., > > 3. The matter is not that simple. When I change priorities (ie > Latin-ASCII.xml is less important than Unicode decomposition), > then "U + 33D7" changes not to pH but to PH. > In the end, I left it like it was before ... > > If you

Re: Data is copied twice when specifying both child and parent table in publication

2022-11-03 Thread Ian Lawrence Barwick
2022年10月17日(月) 14:49 wangw.f...@fujitsu.com : > > On Wed, Oct 5, 2022 at 11:08 AM Peter Smith wrote: > > Hi Wang-san. Here are my review comments for HEAD_v12-0001 patch. > > Thanks for your comments. > > > == > > > > 1. Missing documentation. > > > > In [1] you wrote: > > > I think the behavi

Re: [PATCH] Expand character set for ltree labels

2022-11-03 Thread Ian Lawrence Barwick
2022年10月6日(木) 7:05 Garen Torikian : > > After digging into it, you are completely correct. I had to do a bit more > reading to understand the relationships between UTF-8 and wchar, but > ultimately the existing locale support works for my use case. > > Therefore I have updated the patch with thre

Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert

2022-11-03 Thread Jacob Champion
On Tue, Nov 1, 2022 at 10:55 AM Jacob Champion wrote: > On Tue, Nov 1, 2022 at 10:03 AM Jacob Champion > wrote: > > I'm not familiar with "unregistered scheme" in this context and will > > need to dig in. > > Unfortunately I can't reproduce with 3.0.0 on Ubuntu :( Sorry, when rereading my own e

Re: ExecRTCheckPerms() and many prunable partitions

2022-11-03 Thread Ian Lawrence Barwick
2022年10月15日(土) 15:01 Amit Langote : > > On Fri, Oct 7, 2022 at 4:31 PM Amit Langote wrote: > > On Fri, Oct 7, 2022 at 3:49 PM Amit Langote wrote: > > > On Fri, Oct 7, 2022 at 1:25 PM Amit Langote > > > wrote: > > > > On Fri, Oct 7, 2022 at 10:04 AM Amit Langote > > > > wrote: > > > > > On Thu

Re: security_context_t marked as deprecated in libselinux 3.1

2022-11-03 Thread Michael Paquier
On Thu, Nov 03, 2022 at 07:01:20PM -0400, Tom Lane wrote: > Alvaro Herrera writes: >> FWIW I just had a CI job fail the "warnings" test because of lacking >> this patch in the back branches :-) What do you think about >> back-patching this to at least 11? > > No objection to back-patching from m

Re: In-placre persistance change of a relation

2022-11-03 Thread Ian Lawrence Barwick
2022年9月28日(水) 17:21 Kyotaro Horiguchi : > > Just rebased. Hi cfbot reports the patch no longer applies. As CommitFest 2022-11 is currently underway, this would be an excellent time to update the patch. Thanks Ian Barwick

Re: Commit fest 2022-11

2022-11-03 Thread Justin Pryzby
On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote: > 2022年11月2日(水) 19:10 Greg Stark : > > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > > > Two people showing up to help is really great, thanks! I'll be around > > > as well this month, so I'll do my share of pat

Re: SLRUs in the main buffer pool - Page Header definitions

2022-11-03 Thread Ian Lawrence Barwick
2022年9月28日(水) 10:57 Bagga, Rishu : > > Hi, > > We have been working on adding page headers to the SLRU pages, as part of the > migration for SLRU to buffer cache. We’ve incorporated Thomas Munro’s patch > and Heikki’s Storage manager changes[1] and have a patch for early feedback. > > As part of

Re: [PATCH] New [relation] option engine

2022-11-03 Thread Ian Lawrence Barwick
2022年7月12日(火) 13:47 Nikolay Shaplov : > > В письме от вторник, 12 июля 2022 г. 07:30:40 MSK пользователь Nikolay Shaplov > написал: > > > What about table access methods? There have been a couple attempts to > > > allow custom reloptions for table AMs. Does this patch help that use > > > case? > >

Re: Non-replayable WAL records through overflows and >MaxAllocSize lengths

2022-11-03 Thread Ian Lawrence Barwick
2022年10月5日(水) 16:46 Michael Paquier : > > Hi Matthias, > > On Wed, Jul 27, 2022 at 02:07:05PM +0200, Matthias van de Meent wrote: > > My apologies for the time it took me to come back to this thread. > > > + * To accommodate some overhead, hhis MaxXLogRecordSize value allows for > > > s/hhis/this/.

Re: Incorrect include file order in guc-file.l

2022-11-03 Thread John Naylor
On Fri, Nov 4, 2022 at 5:42 AM Michael Paquier wrote: > > The CI is able to complete without it. Would you mind if it is > removed? If you don't want us to poke more at the bear, that's a nit > so leaving things as they are is also fine by me. I've removed it. -- John Naylor EDB: http://www.en

Re: On login trigger: take three

2022-11-03 Thread Ian Lawrence Barwick
2022年11月4日(金) 5:23 Daniel Gustafsson : > > > On 20 Sep 2022, at 16:10, Daniel Gustafsson wrote: > > > Since the original authors seems to have retired from the patch > > (I've only rebased it to try and help) I am inclined to mark it as returned > > with feedback. > > Doing so now since no updates

Re: Commit fest 2022-11

2022-11-03 Thread Ian Lawrence Barwick
2022年11月4日(金) 9:43 Justin Pryzby : > > On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote: > > 2022年11月2日(水) 19:10 Greg Stark : > > > > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > > > > > Two people showing up to help is really great, thanks! I'll be around > >

Re: [Proposal] Page Compression for OLTP

2022-11-03 Thread Ian Lawrence Barwick
2022年7月27日(水) 2:47 chenhj : > > Hi hackers, > > I have rebase this patch and made some improvements. > > > 1. A header is added to each chunk in the pcd file, which records the chunk > of which block the chunk belongs to, and the checksum of the chunk. > > Accordingly, all pages in a compressed

Re: Proposal to provide the facility to set binary format output for specific OID's per session

2022-11-03 Thread Ian Lawrence Barwick
2022年9月6日(火) 21:32 Dave Cramer : > > > > > On Tue, 6 Sept 2022 at 02:30, Ibrar Ahmed wrote: >> >> >> >> On Fri, Aug 12, 2022 at 5:48 PM Dave Cramer wrote: >>> >>> >>> >>> On Fri, 5 Aug 2022 at 17:51, Justin Pryzby wrote: On Tue, Jul 26, 2022 at 08:11:04AM -0400, Dave Cramer wrote:

Re: Reducing power consumption on idle servers

2022-11-03 Thread Ian Lawrence Barwick
2022年3月25日(金) 1:03 Simon Riggs : > > On Thu, 24 Mar 2022 at 15:39, Robert Haas wrote: > > > > On Thu, Mar 24, 2022 at 6:59 AM Simon Riggs > > wrote: > > > The proposals of this patch are the following, each of which can be > > > independently accepted/rejected: > > > 1. fix the sleep pattern of b

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

2022-11-03 Thread Ian Lawrence Barwick
2022年8月5日(金) 22:55 Melih Mutlu : > > Hi Amit, > >> >> Why after step 4, do you need to drop the replication slot? Won't just >> >> clearing the required info from the catalog be sufficient? >> > >> > >> > The replication slots that we read from the catalog will not be used for >> > anything else a

Re: Skipping schema changes in publication

2022-11-03 Thread Ian Lawrence Barwick
2022年8月19日(金) 2:41 vignesh C : > > On Mon, Aug 8, 2022 at 2:53 PM vignesh C wrote: > > > > On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote: > > > > > > On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote: > > > > > > > > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com > > > > wrote: > >

Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

2022-11-03 Thread Ian Lawrence Barwick
2022年5月3日(火) 8:45 David Christensen : > > ...and pushing a couple fixups pointed out by cfbot, so here's v4. Hi cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is currently underway, this would be an excellent time to update the patch. [1] http://cfbot.cputube.org/patch_40_3

Re: Condition pushdown: why (=) is pushed down into join, but BETWEEN or >= is not?

2022-11-03 Thread Ian Lawrence Barwick
2022年7月7日(木) 20:11 Andrey Lepikhov : > > On 17/5/2022 05:00, Andy Fan wrote: > > Thanks. But I will wait to see if anyone will show interest with this. > > Or else > > Moving alone is not a great experience. > To move forward I've rebased your patchset onto new master, removed > annoying tailing b

Re: archive modules

2022-11-03 Thread Ian Lawrence Barwick
2022年10月16日(日) 16:36 Bharath Rupireddy : > > On Sat, Oct 15, 2022 at 3:13 AM Nathan Bossart > wrote: > > > > On Fri, Oct 14, 2022 at 11:51:30AM -0700, Nathan Bossart wrote: > > > On Fri, Oct 14, 2022 at 12:10:18PM +0530, Bharath Rupireddy wrote: > > >> 2) I think we have a problem - set archive_m

Re: Privileges on PUBLICATION

2022-11-03 Thread Amit Kapila
On Thu, Nov 3, 2022 at 11:12 AM Antonin Houska wrote: > > Peter Eisentraut wrote: > > > The CF entry is about privileges on publications. Please rebase that patch > > and repost it so that the CF app and the CF bot are up to date. > > The rebased patch (with regression tests added) is attached h

Re: Privileges on PUBLICATION

2022-11-03 Thread Amit Kapila
On Thu, Nov 3, 2022 at 9:19 PM Peter Eisentraut wrote: > > On 03.11.22 01:43, Antonin Houska wrote: > > Peter Eisentraut wrote: > > > >> The CF entry is about privileges on publications. Please rebase that patch > >> and repost it so that the CF app and the CF bot are up to date. > > > > The reb

Re: [PATCH] pgbench: add multiconnect option

2022-11-03 Thread Ian Lawrence Barwick
2022年4月2日(土) 22:35 Fabien COELHO : > > > > According to the cfbot this patch needs a rebase > > Indeed. v4 attached. Hi cfbot reports the patch no longer applies. As CommitFest 2022-11 is currently underway, this would be an excellent time to update the patch. Thanks Ian Barwick

Re: Allow single table VACUUM in transaction block

2022-11-03 Thread Rahila Syed
Hi Simon, On Thu, Nov 3, 2022 at 3:53 PM Simon Riggs wrote: > On Tue, 1 Nov 2022 at 23:56, Simon Riggs > wrote: > > > > I haven't checked the rest of the patch, but +1 for allowing VACUUM > FULL > > > within a user txn. > > > > My intention was to prevent that. I am certainly quite uneasy about

Re: Commit fest 2022-11

2022-11-03 Thread Ian Lawrence Barwick
2022年11月4日(金) 10:23 Ian Lawrence Barwick : > > 2022年11月4日(金) 9:43 Justin Pryzby : > > > > On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote: > > > 2022年11月2日(水) 19:10 Greg Stark : > > > > > > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > > > > > > > Two people sh

Re: Fix comments atop ReorderBufferAddInvalidations

2022-11-03 Thread Masahiko Sawada
Hi On Thu, Nov 3, 2022 at 7:53 PM Amit Kapila wrote: > > The comments atop seem to indicate that we always accumulate > invalidation messages in top-level transactions which is neither > required nor match with the code. This is introduced in the commit > c55040ccd0 and I have observed it while w