On Wed, Sep 7, 2022 at 3:36 PM Alvaro Herrera wrote:
>
> On 2022-Sep-06, John Naylor wrote:
>
> > Note that the indentation hasn't changed. My thought there: perltidy
> > will be run again next year, at which time it will be part of a listed
> > whitespace-only commit. Any objections, since that c
Hi,
On Tue, Sep 06, 2022 at 06:23:12PM +0800, Julien Rouhaud wrote:
> On Tue, Sep 06, 2022 at 08:43:59AM +0200, Pavel Stehule wrote:
> > Hi
> >
> > After talking with Julian I removed "debug" fields name and nsname from
> > SVariable structure. When it is possible it is better to read these fields
Hi,
On Tue, Sep 6, 2022 at 9:48 PM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> On 02.09.22 19:16, samay sharma wrote:
> > Another thing I'd like input on. A common question I've heard from
> > people who've tried out the docs is How do we do the equivalent of X in
> > make with
Hi there,
I believe this very small bug and its fix are really trivial and could be push
out of the way quite quickly. It's just about a bad constraint name fixed by
moving one assignation after the next one. This could easily be fixed for next
round of releases.
Well, I hope I'm not wrong :)
Re
On 2022-09-06 20:57, Aleksander Alekseev wrote:
Hi Shinya,
A minor modification has been made so that the composite type is also
completed after "ALTER TABLE OF".
LGTM. Here is v3 created with `git format-path`. Unlike v2 it also
includes the commit message.
Thanks! I marked it as ready fo
On 2022-Sep-06, Simon Riggs wrote:
> On Tue, 6 Sept 2022 at 17:19, Erik Rijkers wrote:
> >
> > Op 06-09-2022 om 17:16 schreef Simon Riggs:
> > > New chapter on transaction management, plus a few related changes.
> > >
> > > Markup and links are not polished yet, so please comment initially on
> >
On 2022-Sep-07, Peter Eisentraut wrote:
> A possible drawback is that the intermediate postgres-full.xml file is
> >10MB, but I guess we're past the point where we are worrying about that
> kind of thing.
I think we are, but maybe mark it .PRECIOUS? IIUC that would prevent it
from being removed
On Wed, Sep 07, 2022 at 01:10:11PM -0400, Tom Lane wrote:
> After looking at the text more carefully, I thought it could use
> a deal more help than Robert has given it. I propose the attached.
It looks good to me.
- for example ~/.psqlrc-9.2 or
- ~/.psqlrc-9.2.5. The most specific
+
On 9/7/22 22:51, Vitaly Burovoy wrote:
Hello hackers!
Reading docs for the MERGE statement I've found a little error: a
semicolon in middle of a statement and absence of a semicolon in the end
of it.
Key words in subqueries are written in uppercase everywhere in the docs
but not in an examp
Hello!
Added a TAP test for this case.
On 30.08.2022 10:09, Anton A. Melnikov wrote:
Hello!
The patch was rebased on current master.
And here is a simplified crash reproduction:
1) On primary with 'wal_level = logical' execute:
CREATE TABLE public.test (id int NOT NULL, val integer);
CREAT
On Tue, Aug 30, 2022 at 01:29:24PM +1200, Thomas Munro wrote:
> This reminds me of 24c3ce8f1, which replaced a dlopen()-ish thing with
> a direct function call. Can you just call all these functions
> directly these days?
Hmm. Some tests in the CI show that attempting to call directly
MiniDumpWr
Hi Peter,
> > 3. Go with your patch and just fix up the warnings about uninitialized
> > variables. But that seems the least principled to me.
>
> IMO the 3rd option is the lesser evil. Initializing four bools/ints in
> order to make Clang 11 happy doesn't strike me as such a big deal. At
> least
Op 07-09-2022 om 21:45 schreef Daniel Gustafsson:
One thing this patchversion currently lacks is refined error messaging, but if
we feel that this approach is a viable path then that can be tweaked. The
function which starts the parser can also be refactored to be shared across
pg_dump, pg_dump
On 2022-05-16 17:02, torikoshia wrote:
On 2022-03-09 19:04, torikoshia wrote:
On 2022-02-08 01:13, Fujii Masao wrote:
AbortSubTransaction() should reset ActiveQueryDesc to
save_ActiveQueryDesc that ExecutorRun() set, instead of NULL?
Otherwise ActiveQueryDesc of top-level statement will be unav
On Tue, Sep 6, 2022 at 11:07 PM Robert Haas wrote:
> On Tue, Sep 6, 2022 at 4:40 AM Dilip Kumar wrote:
> > I have explored this area more and also tried to come up with a
> > working prototype, so while working on this I realized that we would
> > have almost to execute all the code which is get
Hi All,
The logically decoded data are sent to the logical subscriber at the time
of transaction commit, assuming that the data is small. However, before the
transaction commit is performed, the LSN representing the data that is yet
to be received by the logical subscriber appears in the confirmed
Hi,
In Neon, we've had to modify the GIN fast insertion path as attached,
due to an unexpected XLOG insertion and buffer locking ordering issue.
The xlog readme [0] mentions that the common order of operations is 1)
pin and lock any buffers you need for the log record, then 2) start a
critical se
On Thu, Sep 8, 2022 at 12:21 PM Amit Kapila wrote:
>
> On Mon, Sep 5, 2022 at 6:34 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Attach the correct patch set this time.
> >
>
> Few comments on v28-0001*:
> ===
>
Some suggestions for comments in v28-0001*
1.
+/*
+ * Entry for a h
On 2022-Sep-08, Jehan-Guillaume de Rorthais wrote:
> Hi there,
>
> I believe this very small bug and its fix are really trivial and could be push
> out of the way quite quickly. It's just about a bad constraint name fixed by
> moving one assignation after the next one. This could easily be fixed
Hi,
On Thu, Sep 08, 2022 at 11:06:51AM +0200, Drouvot, Bertrand wrote:
> Hi,
>
> On 9/8/22 8:50 AM, Julien Rouhaud wrote:
>
> Thanks for looking at it!
>
> > On Thu, Sep 08, 2022 at 02:23:19PM +0900, Michael Paquier wrote:
> > > On Wed, Sep 07, 2022 at 06:19:42PM -0700, Jeremy Schneider wrote:
Apparently, you can't add a table to a publication if its schema is
already part of the publication (and vice versa), e.g.,
=# alter publication p1 add table s1.t1;
ERROR: 22023: cannot add relation "s1.t1" to publication
DETAIL: Table's schema "s1" is already part of the publication or part
> On 8 Sep 2022, at 12:00, Erik Rijkers wrote:
>
> Op 07-09-2022 om 21:45 schreef Daniel Gustafsson:
>> One thing this patchversion currently lacks is refined error messaging, but
>> if
>> we feel that this approach is a viable path then that can be tweaked. The
>> function which starts the par
Hi,
On Thu, Sep 08, 2022 at 01:38:42PM +0200, Daniel Gustafsson wrote:
> > On 8 Sep 2022, at 12:00, Erik Rijkers wrote:
> >
> > Op 07-09-2022 om 21:45 schreef Daniel Gustafsson:
> >> One thing this patchversion currently lacks is refined error messaging,
> >> but if
> >> we feel that this appro
On Wed, Sep 7, 2022 at 3:27 AM Nathan Bossart wrote:
>
> +
> + wal_source_switch_interval configuration
> parameter
> +
>
> I don't want to bikeshed on the name too much, but I do think we need
> something more descriptive. I'm thinking of something like
> streaming_replication
The pg_walinspect function pg_get_wal_stats() has output arguments
declared as float4 (count_percentage, record_size_percentage, etc.), but
the internal computations are all done in type double. Is there a
reason why this is then converted to float4 for output? It probably
doesn't matter in p
While testing Alvaro's "cataloguing NOT NULL constraints" patch [1], I
noticed a behavior of inherited column merging during ALTER TABLE that
I thought might be a bug (though see at the bottom).
Note how CREATE TABLE merges the inherited properties of parent foo's
a's NOT NULL into a child bar's o
On Thu, 8 Sep 2022 13:25:15 +0200
Alvaro Herrera wrote:
> On 2022-Sep-08, Jehan-Guillaume de Rorthais wrote:
>
> > Hi there,
> >
> > I believe this very small bug and its fix are really trivial and could be
> > push out of the way quite quickly. It's just about a bad constraint name
> > fixed b
Attached is the plain-text list of acknowledgments for the PG15 release
notes, current through REL_15_BETA4. Please check for problems such as
wrong sorting, duplicate names in different variants, or names in the
wrong order etc. (Note that the current standard is given name followed
by sur
On Thu, Sep 08, 2022 at 02:35:24PM +0300, Dmitry Koval wrote:
> Thanks a lot Justin!
>
> After compilation PostgreSQL+patch with macros
> RELCACHE_FORCE_RELEASE,
> RANDOMIZE_ALLOCATED_MEMORY,
> I saw a problem on Windows 10, MSVC2019.
Yes, it passes tests on my CI improvements branch.
https://git
> On 8 Sep 2022, at 13:44, Julien Rouhaud wrote:
> On Thu, Sep 08, 2022 at 01:38:42PM +0200, Daniel Gustafsson wrote:
>>> On 8 Sep 2022, at 12:00, Erik Rijkers wrote:
>>> I did notice one peculiarity (in your patch) where for each table a few
>>> spaces are omitted by pg_dump.
>>
>> Right, I h
On Thu, Sep 8, 2022 at 4:14 PM Ashutosh Sharma wrote:
>
> Hi All,
>
> The logically decoded data are sent to the logical subscriber at the time of
> transaction commit, assuming that the data is small. However, before the
> transaction commit is performed, the LSN representing the data that is y
> On 3 Sep 2022, at 10:27, Dong Wook Lee wrote:
> I write a tiny patch about vacuumlo to improve test coverage.
If we are paying for setting up a cluster we might as well test more scenarios
than just the one. Perhaps some other low-hanging fruit like calling vacuumlo
on a non-existing databsas
On Wed, Sep 7, 2022 at 5:51 PM Stephen Frost wrote:
> > To be more precise, I propose that in order for alice to create
> > objects owned by bob or to change one of her objects to be owned by
> > bob, she must not only be a member of role bob, but also inherit bob's
> > privileges. If she has the
I'm wondering about making the list of things you can specify in
require_auth less confusing and future proof.
For example, before long someone is going to try putting "ldap" into
require_auth. The fact that the methods in pg_hba.conf are not what
libpq sees is not something that was really e
On Thu, Sep 08, 2022 at 05:55:40PM +0900, Michael Paquier wrote:
> On Tue, Aug 30, 2022 at 01:29:24PM +1200, Thomas Munro wrote:
> > This reminds me of 24c3ce8f1, which replaced a dlopen()-ish thing with
> > a direct function call. Can you just call all these functions
> > directly these days?
>
Hi,
I also would like to suggest a cosmetic change.
In v15 a new field checkunique is added after heapallindexed and before
no_btree_expansion fields in struct definition, but in initialisation it is
added after no_btree_expansion:
--- a/src/bin/pg_amcheck/pg_amcheck.c
+++ b/src/bin/pg_amcheck/pg
On Wed, Sep 7, 2022 at 7:09 PM Stephen Frost wrote:
> Calling this a redesign is over-stating things, imv … and I’d much rather
> have the per-relation granularity than predefined roles for this, so there is
> that to consider too, perhaps.
I also prefer the finer granularity.
On the question
On 2022-Sep-08, Justin Pryzby wrote:
> If the patch were split into separate parts for MERGE and SPLIT, would
> the first patch be significantly smaller than the existing patch
> (hopefully half as big) ? That would help to review it, even if both
> halves were ultimately squished together. (An
Thanks for your advice, Justin and Alvaro!
I'll try to reduce the size of this patch and split it into separate
parts (for MERGE and SPLIT).
--
With best regards,
Dmitry Koval
Postgres Professional: http://postgrespro.com
On Thu, Sep 8, 2022 at 6:23 PM Ashutosh Bapat
wrote:
>
> On Thu, Sep 8, 2022 at 4:14 PM Ashutosh Sharma wrote:
> >
> > Hi All,
> >
> > The logically decoded data are sent to the logical subscriber at the time
> > of transaction commit, assuming that the data is small. However, before the
> > tr
Julien Rouhaud writes:
> On Wed, Sep 07, 2022 at 01:10:11PM -0400, Tom Lane wrote:
> - for example ~/.psqlrc-9.2 or
> - ~/.psqlrc-9.2.5. The most specific
> + for example ~/.psqlrc-15 or
> + ~/.psqlrc-15.2. The most specific
> This bit is a bit saddening. It's probably good to
Hi
st 7. 9. 2022 v 21:46 odesílatel Daniel Gustafsson napsal:
> As noted upthread at some point, I'm not overly excited about the parser in
> filter.c, for maintainability and readability reasons. So, I've
> reimplemented
> the parser in Flex/Bison in the attached patch, which IMHO provides a
On Thu, 08 Sep 2022 at 20:13, Peter Eisentraut
wrote:
> Attached is the plain-text list of acknowledgments for the PG15 release
> notes, current through REL_15_BETA4. Please check for problems such as
> wrong sorting, duplicate names in different variants, or names in the
> wrong order etc.
Robert Haas:
Fairly obviously, my thinking here is biased by having written the
patch to allow restricting SET ROLE. If alice can neither inherit
bob's privileges nor SET ROLE bob, she had better not be able to
create objects owned by bob, because otherwise she can make a table,
add an expression
On Thu, Sep 08, 2022 at 11:39:43PM +0800, Japin Li wrote:
>
> On Thu, 08 Sep 2022 at 20:13, Peter Eisentraut
> wrote:
> > Attached is the plain-text list of acknowledgments for the PG15 release
> > notes, current through REL_15_BETA4. Please check for problems such as
> > wrong sorting, dupli
On Thu, Sep 8, 2022 at 11:45 AM Wolfgang Walther
wrote:
> I think to change the owner of an object from role A to role B, you just
> need a different "privilege" on that role B to "use" the role that way,
> which is distinct from INHERIT or SET ROLE "privileges".
It's not distinct, though, becaus
Robert Haas:
I think to change the owner of an object from role A to role B, you just
need a different "privilege" on that role B to "use" the role that way,
which is distinct from INHERIT or SET ROLE "privileges".
It's not distinct, though, because if you can transfer ownership of a
table to a
Hi,
On 2022-09-07 11:08:27 -0400, Tom Lane wrote:
> > I'll need to think about how best to fix this. In the meantime, I
> > think the other 32-bit animals are probably not going to like this
> > either :-(
>
> Yeah. The basic problem here is that we've greatly reduced the amount
> of redundancy i
On 2022-09-08 14:10:45 +0700, John Naylor wrote:
> Okay, done that way.
Thanks!
Robert Haas:
Fairly obviously, my thinking here is biased by having written the
patch to allow restricting SET ROLE. If alice can neither inherit
bob's privileges nor SET ROLE bob, she had better not be able to
create objects owned by bob, because otherwise she can make a table,
add an expression
Hi,
On 2022-09-06 13:32:32 +0700, John Naylor wrote:
> Here are autoconf-only patches to that effect.
Looks like you did actually include src/tools/msvc as well :)
> Subject: [PATCH v2 2/2] Bump minimum version of Flex to 2.5.35
LGTM.
> From b7f35ae5e0fd55f8dceb2a4a546be3b50065a09c Mon Sep 1
Hi hackers,
I tried to understand some implementation details of ProcArray and
discovered that this is a bit challenging to do due to a missing
comment for PGPROC.pgprocno. E.g. it's hard to understand why
ProcArrayAdd() preserves procArray->pgprocnos[] sorted by (PGPROC *)
if actually the sorting
Hi,
On 2022-09-08 13:25:15 +0200, Alvaro Herrera wrote:
> I think you're right, so pushed, and backpatched to 12. I added the
> test case to regression also.
Something here doesn't look to be quite right. Starting with this commit CI
[1] started to fail on freebsd (stack trace [2]), and in the m
On Mon, Sep 5, 2022 at 12:43 PM Peter Geoghegan wrote:
> Barring any objections I will commit this patch within the next few days.
Pushed this just now.
Thanks
--
Peter Geoghegan
On Wed, Sep 7, 2022 at 6:17 PM Michael Paquier wrote:
> >> + /* Initialize SystemUser now that MyClientConnectionInfo is
> >> restored. */
> >> + InitializeSystemUser(MyClientConnectionInfo.authn_id,
> >> +
> >> hba_authname(MyClientConn
On Thu, Sep 08, 2022 at 05:16:53PM +0530, Bharath Rupireddy wrote:
> On Wed, Sep 7, 2022 at 3:27 AM Nathan Bossart
> wrote:
>> It's not clear to me how this is expected to interact with the pg_wal phase
>> of standby recovery. As the docs note [0], standby servers loop through
>> archive recover
Andres Freund writes:
> If there is a finalfunc, they're typically going to return data from within
> the current memory context, but could legitimately also return part of the
> data from curaggcontext. Perhaps we could forbid that?
No, I don't think we can get away with that. See int8inc() for
On Thu, Sep 8, 2022 at 6:25 AM Peter Eisentraut
wrote:
> For example, before long someone is going to try putting "ldap" into
> require_auth. The fact that the methods in pg_hba.conf are not what
> libpq sees is not something that was really exposed to users until now.
> "none" vs. "trust" takes
Jeff Janes writes:
> When costing a btree index scan, num_sa_scans gets computed twice, once in
> btcostestmeate and once in genericcostestimate. But the computations are
> different. It looks like the generic one includes all =ANY in any column
> in the index, while the bt one includes only =AN
Jeff Janes writes:
> Why does having the =ANY in the "Index Cond:" rather than the "Filter:"
> inhibit it from understanding that the rows will still be delivered in
> order by "thousand"?
They won't be. The =ANY in index conditions results in multiple
index scans, that is we effectively do a sc
Andres Freund writes:
> Something here doesn't look to be quite right. Starting with this commit CI
> [1] started to fail on freebsd (stack trace [2]), and in the meson branch I've
> also seen the crash on windows (CI run[3], stack trace [4]).
The crash seems 100% reproducible if I remove the ear
Hi,
The current WAL records generated by the Heap tableAM do not contain
the command ID of the query that inserted/updated/deleted the records.
The CID is not included in XLog because it is useful only to
visibility checks in an active read/write transaction, which currently
only appear in a prima
Matthias van de Meent writes:
> Please find attached a patch that adds the CommandId of the inserting
> transaction to heap (batch)insert, update and delete records. It is
> based on the changes we made in the fork we maintain for Neon.
This seems like a very significant cost increment with retur
On Tue, Aug 23, 2022 at 9:27 AM Jacob Champion wrote:
> I have updated the CFM checklist through the "2 days before CF"
> section. Let me know if you have questions/suggestions.
I've additionally removed references to "shame emails" for
non-reviewers; I don't think CFMs are doing that anymore and
Ronan Dunklau writes:
> Following the bug report at [1], I sent the attached patch to pgsql-bugs
> mailing list. I'm starting a thread here to add it to the next commitfest.
That link didn't work easily for me (possibly because it got split across
lines). Here's another one for anybody having s
Hi,
On 2022-09-08 14:10:36 -0400, Tom Lane wrote:
> Andres Freund writes:
> > If there is a finalfunc, they're typically going to return data from within
> > the current memory context, but could legitimately also return part of the
> > data from curaggcontext. Perhaps we could forbid that?
>
>
On Tue, Sep 6, 2022 at 9:46 PM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> On 02.09.22 01:12, samay sharma wrote:
> > So, I was thinking of the following structure:
> > - Supported Platforms
> > - Getting the Source
> > - Building with make and autoconf
> >-- Short version
>
On Thu, Jul 28, 2022 at 9:19 AM Jacob Champion wrote:
> On Thu, Jul 21, 2022 at 4:29 PM Jacob Champion
> wrote:
> > v4 attempts to fix this by letting the check hooks pass
> > MCXT_ALLOC_NO_OOM to pg_clean_ascii(). (It's ignored in the frontend,
> > which just mallocs.)
>
> Ping -- should I add
Ronan Dunklau writes:
> The problem I'm trying to solve is that, contrary to btree, gist and sp-gist
> indexes, gin indexes do not charge any cpu-cost for descending the entry tree.
I looked this over briefly. I think you are correct to charge an
initial-search cost per searchEntries count, but
Andres Freund writes:
> On 2022-09-08 14:10:36 -0400, Tom Lane wrote:
>> No, I don't think we can get away with that. See int8inc() for a
>> counterexample.
> What I was suggesting a bit below the bit quoted above, was that we'd copy
> whenever there's no finalfunc or if the finalfunc doesn't ta
On Wed, Sep 07, 2022 at 02:42:05PM -0700, Jacob Champion wrote:
> Just to clarify, was Justin's statement upthread (that the XID problem
> is fixed) correct? And is this patch just trying to improve the
> remaining memory and lock usage problems?
I think "fixed" might not be totally accurate, but
On Thu, Sep 8, 2022 at 4:18 PM Nathan Bossart wrote:
> IIUC the main benefit of this approach is that it isn't dependent on
> binary-upgrade mode, which seems to be a goal based on the discussion
> upthread [0].
To clarify, I agree that pg_dump should contain the core fix. What I'm
questioning is
On Fri, 9 Sept 2022 at 10:53, Tom Lane wrote:
> I hate to give up MemoryContextContains altogether. The assertions
> that David nuked in b76fb6c2a had some value I think,
Those can be put back if we decide to keep MemoryContextContains.
Those newly added Asserts just temporarily had to go due to
On Thu, Sep 08, 2022 at 04:29:10PM -0700, Jacob Champion wrote:
> On Thu, Sep 8, 2022 at 4:18 PM Nathan Bossart
> wrote:
>> IIUC the main benefit of this approach is that it isn't dependent on
>> binary-upgrade mode, which seems to be a goal based on the discussion
>> upthread [0].
>
> To clarif
On Fri, Aug 19, 2022 at 1:13 AM Drouvot, Bertrand wrote:
> This is why I think username filtering with regular expressions would
> provide its own advantages.
>
> Thoughts? Looking forward to your feedback,
I think your motivation for the feature is solid. It is killing me a
bit that this is maki
Jacob Champion writes:
> On Fri, Aug 19, 2022 at 1:13 AM Drouvot, Bertrand wrote:
>> This is why I think username filtering with regular expressions would
>> provide its own advantages.
> I think your motivation for the feature is solid.
Yeah. I'm not sure that I buy the argument that this is
On Tue, Aug 23, 2022 at 11:53 AM Kyotaro Horiguchi
wrote:
>
> At Mon, 15 Aug 2022 11:16:56 +0900, Masahiko Sawada
> wrote in
> > Sorry for the late reply.
>
> No worries. Anyway I was in a long (as a Japanese:) vacation.
>
> > On Thu, Jul 28, 2022 at 4:29 PM Kyotaro Horiguchi
> > wrote:
> > > r
On Wed, Sep 07, 2022 at 07:02:07PM +0900, Michael Paquier wrote:
> Before posting my previous patch, I have considered a few options:
> - Extend errormsg_buf with an error code, but the frontend does not
> care about that.
> - Make RestoreBlockImage() a backend-only routine and provide a better
> e
On Thu, Sep 08, 2022 at 08:29:20AM -0500, Justin Pryzby wrote:
> It seems silly to do it at runtime if it's possible to do it at link time.
Thanks. This set of simplifications is too good to let go, and I have
a window to look after the buildfarm today and tomorrow, which should
be enough to take
Hi!
I created a patch for improving MARGE tab completion.
Currently there is a problem with "MERGE INTO dst as d Using src as s ON
d.key = s.key WHEN " is typed, "MATCHED" and "NOT MATCHED" is not
completed.
There is also a problem that typing "MERGE INTO a AS " completes
"USING".
This patch
On Thu, Sep 8, 2022 at 5:23 PM Peter Eisentraut
wrote:
>
> The pg_walinspect function pg_get_wal_stats() has output arguments
> declared as float4 (count_percentage, record_size_percentage, etc.), but
> the internal computations are all done in type double. Is there a
> reason why this is then co
On Wed, Sep 7, 2022 at 1:56 AM Jonathan S. Katz wrote:
> To close this loop, I added a section for "fixed before RC1" to Open
> Items since this is presumably the next release. We can include it there
> once committed.
Done yesterday.
To tie up a couple of loose ends from this thread:
On Thu, S
Hi,
When implementing the feature to perform streaming logical transactions by
background workers[1], we plan to extend the LOGICAL_REP_MSG_STREAM_ABORT
message
to send the additional "abort_lsn" and "abort_time" so that we can advance the
origin lsn in subscriber and can restart streaming from c
Being late for the party.
It seems to me that the function is getting too long. I think we
might want to move the core part of the patch into another function.
I think it might be better if intentionalSourceSwitch doesn't need
lastSourceFailed set. It would look like this:
> if (lastSourceFail
On Wed, Sep 7, 2022 at 4:27 PM Peter Eisentraut
wrote:
>
> On 04.09.22 20:17, Andres Freund wrote:
> > I think, as a followup improvement, we should move gramparse.h to
> > src/backend/parser, and stop installing gram.h, gramparse.h. gramparse.h
> > already had this note:
> >
> > * NOTE: this fi
At Thu, 8 Sep 2022 10:53:56 -0700, Nathan Bossart
wrote in
> On Thu, Sep 08, 2022 at 05:16:53PM +0530, Bharath Rupireddy wrote:
> > I'm attaching the v3 patch with the review comments addressed, please
> > review it further.
>
> My general point is that we should probably offer some basic preve
Hi!
is_superuser function checks whether a user is a superuser or not, and
is commonly used. However, is_superuser is not documented and is set to
UNGROUPED in guc.c. I think is_superuser should be added to the
documentation and set to PRESET OPTIONS.What are you thought on this?
Regards,
Ko
On Thu, Sep 8, 2022 at 9:32 AM vignesh C wrote:
>
>
> The attached patch has the changes to handle the same.
>
Pushed. I am not completely sure whether we want the remaining
documentation patch in this thread in its current form or by modifying
it. Johnathan has shown some interest in it. I feel
On Thu, Sep 8, 2022 at 5:06 PM Peter Eisentraut
wrote:
>
> Apparently, you can't add a table to a publication if its schema is
> already part of the publication (and vice versa), e.g.,
>
> =# alter publication p1 add table s1.t1;
> ERROR: 22023: cannot add relation "s1.t1" to publication
> DETAIL
On Fri, Sep 9, 2022 at 12:07 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-09-06 13:32:32 +0700, John Naylor wrote:
> > Here are autoconf-only patches to that effect.
>
> Looks like you did actually include src/tools/msvc as well :)
Ah, in my head I meant "no patches for the Meson branch". :-)
CI
On Thu, Sep 8, 2022 at 9:03 PM Amit Langote wrote:
> While testing Alvaro's "cataloguing NOT NULL constraints" patch [1], I
> noticed a behavior of inherited column merging during ALTER TABLE that
> I thought might be a bug (though see at the bottom).
>
> I feel like we may have discussed this bef
Amit Kapila writes:
> To avoid these confusions, we have disallowed adding a table if its
> schema is already part of the publication and vice-versa.
Really?
Is there logic in ALTER TABLE SET SCHEMA that rejects the command
dependent on the contents of the publication tables? If so, are
there l
On Fri, Sep 9, 2022 at 10:57 AM Kyotaro Horiguchi
wrote:
>
> At Thu, 8 Sep 2022 10:53:56 -0700, Nathan Bossart
> wrote in
> > On Thu, Sep 08, 2022 at 05:16:53PM +0530, Bharath Rupireddy wrote:
> > > I'm attaching the v3 patch with the review comments addressed, please
> > > review it further.
>
93 matches
Mail list logo
