Re: Handle infinite recursion in logical replication setup

On Tue, Jul 26, 2022 at 10:23 AM Peter Smith wrote: > > On Tue, Jul 26, 2022 at 2:09 PM Amit Kapila wrote: > > > > > > I am not really sure how much we gain by maintaining consistency with > > slot_name because if due to this we have to change the error messages > > as well then it can create an

Re: generic plans and "initial" pruning

On Wed, Jul 13, 2022 at 4:03 PM Amit Langote wrote: > On Wed, Jul 13, 2022 at 3:40 PM Amit Langote wrote: > > Rebased over 964d01ae90c. > > Sorry, left some pointless hunks in there while rebasing. Fixed in > the attached. Needed to be rebased again, over 2d04277121f this time. -- Thanks, Ami

Re: Add proper planner support for ORDER BY / DISTINCT aggregates

On Wed, Jul 27, 2022 at 6:46 AM David Rowley wrote: > On Tue, 26 Jul 2022 at 19:39, Richard Guo wrote: > > Also I'm wondering if it's possible to take into consideration the > > ordering indicated by existing indexes when determining the pathkeys. So > > that for the query below we can avoid the

Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.

On Mon, Jul 25, 2022 at 8:34 AM Peter Smith wrote: > > On Mon, Jul 25, 2022 at 11:08 AM Michael Paquier wrote: > > > > On Sun, Jul 24, 2022 at 09:52:16PM +0530, vignesh C wrote: > > > Thanks for the comments, i have modified it by changing it to a > > > boolean parameter. The attached v4 patch h

Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.

On Mon, Jul 25, 2022 at 10:22 AM Amit Kapila wrote: > > On Mon, Jul 25, 2022 at 8:34 AM Peter Smith wrote: > > > > On Mon, Jul 25, 2022 at 11:08 AM Michael Paquier > > wrote: > > > > > > On Sun, Jul 24, 2022 at 09:52:16PM +0530, vignesh C wrote: > > > > Thanks for the comments, i have modified

Re: [PoC] Reducing planning time when tables have many partitions

On Mon, 4 Jul 2022 at 09:28, Tom Lane wrote: > For the bms_equal class of lookups, I wonder if we could get anywhere > by adding an additional List field to every RelOptInfo that chains > all EquivalenceMembers that match that RelOptInfo's relids. > The trick here would be to figure out when to bu

Re: Perform streaming logical transactions by background workers and parallel apply

Here are some review comments for patch v19-0003: == 3.1 doc/src/sgml/ref/create_subscription.sgml @@ -240,6 +240,10 @@ CREATE SUBSCRIPTION subscription_nameparallel mode has two requirements: 1) the unique + column in the relation on the subscriber-side should also be the +

Re: Perform streaming logical transactions by background workers and parallel apply

On Tue, Jul 26, 2022 at 2:30 PM Dilip Kumar wrote: > > On Fri, Jul 22, 2022 at 8:27 AM wangw.f...@fujitsu.com > wrote: > > > > On Tues, Jul 19, 2022 at 10:29 AM I wrote: > > > Attach the news patches. > > > > Not able to apply patches cleanly because the change in HEAD (366283961a). > > Therefore

Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO

At Wed, 27 Jul 2022 00:16:33 +0800, Zhang Mingli wrote in > FORCE_NOT_NULL and FORCE_NULL are only used when COPY FROM. > > And copyto.c and copyfrom.c are split in this commit > https://github.com/postgres/postgres//commit/c532d15dddff14b01fe9ef1d465013cb8ef186df > >

Re: predefined role(s) for VACUUM and ANALYZE

At Tue, 26 Jul 2022 13:54:38 -0400, Robert Haas wrote in > On Tue, Jul 26, 2022 at 1:50 PM David G. Johnston > wrote: > >> Still, it seems somewhat appealing to give > >> people fine-grained control over this, rather than just "on" or "off". > > Appealing enough to consume a couple of permissio

Re: Perform streaming logical transactions by background workers and parallel apply

On Wed, Jul 27, 2022 at 10:06 AM Amit Kapila wrote: > > On Tue, Jul 26, 2022 at 2:30 PM Dilip Kumar wrote: > > > > On Fri, Jul 22, 2022 at 8:27 AM wangw.f...@fujitsu.com > > wrote: > > > > > > On Tues, Jul 19, 2022 at 10:29 AM I wrote: > > > > Attach the news patches. > > > > > > Not able to app

Re: Refactoring postgres_fdw/connection.c

On Tue, Jul 26, 2022 at 7:46 PM Fujii Masao wrote: > On 2022/07/26 19:26, Etsuro Fujita wrote: > > Could you add this to the next CF? > > Yes. > https://commitfest.postgresql.org/39/3782/ Thanks! Best regards, Etsuro Fujita

Re: Custom tuplesorts for extensions

On Mon, Jul 25, 2022 at 4:01 PM Pavel Borisov wrote: >> Thank you for caching this. Fixed in the revision attached. >> >> Testing subsets of patchsets in cfbot looks like a good idea to me. >> However, I'm not sure if we always require subsets to be consistent. > > > Hi, hackers! > > I've looked

Re: Fast COPY FROM based on batch insert

On 7/22/22 13:14, Etsuro Fujita wrote: On Fri, Jul 22, 2022 at 3:39 PM Andrey Lepikhov wrote: Analyzing multi-level heterogeneous partitioned configurations I realized, that single write into a partition with a trigger will flush buffers for all other partitions of the parent table even if the

Re: standby recovery fails (tablespace related) (tentative patch and discussion)

On 2022-Jul-22, Kyotaro Horiguchi wrote: > At Fri, 22 Jul 2022 10:18:58 +0200, Alvaro Herrera > wrote in > > Which commits would we consider? > > > > 7170f2159fb2Allow "in place" tablespaces. > > f6f0db4d6240Fix pg_tablespace_location() with in-place tablespaces > > The second on

Re: [PoC] Reducing planning time when tables have many partitions

Dear David, Thank you for sharing your new idea. I agree that introducing a Bitmapset field may solve this problem. I will try this approach in addition to previous ones. Thank you again for helping me. -- Best regards, Yuya Watari

Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO

On Wed, Jul 27, 2022 at 12:55 PM Kyotaro Horiguchi wrote: > ProcessCopyOptions previously rejects force_quote_all for COPY FROM > and copyfrom.c is not even conscious of the option (that is, even no > assertion on it). The two options are rejected for COPY TO by the same > function so it seems li

Re: Cygwin cleanup

On Tue, Jul 26, 2022 at 04:24:25PM +1200, Thomas Munro wrote: > 3. You can't really run PostgreSQL on Cygwin for real, because its > implementation of signals does not have reliable signal masking, so > unsubtle and probably also subtle breakage occurs. That was reported > upstream by Noah years

<    1   2